headers
chad brown | 13 Jan 2001 06:57
Picon
Favicon

21.0.95 stomping DEL binding in mh-e

The DEL/<delete>/<backspace> change in 21.0.95 has caused this code in
mh-e.el to stop working as intended:

  (define-key mh-folder-mode-map "\177" 'mh-previous-page)

It should be either replaced (or perhaps augmented) with:

  (define-key mh-folder-mode-map [(delete)] 'mh-previous-page)
  (define-key mh-folder-mode-map [(backspace)] 'mh-previous-page)

to get proper behavior for mh-e.

chad
Permalink | Reply | 24 comments |
headers
Bill Wohler | 15 Jan 2001 20:05
Picon
Picon
Gravatar

Re: 21.0.95 stomping DEL binding in mh-e

  Thanks. I added that to the bug list at SourceForge
  (https://sourceforge.net/bugs/?group_id=13357).

--

-- 
Bill Wohler <wohler <at> newt.com>  http://www.newt.com/wohler/
Maintainer of comp.mail.mh FAQ. Vote Libertarian!
If you're passed on the right, you're in the wrong lane.
Permalink | Reply | 15 comments |
headers
Eli Zaretskii | 16 Jan 2001 13:45
Picon

Re: 21.0.95 stomping DEL binding in mh-e

On 15 Jan 2001, Bill Wohler wrote:

>   Thanks. I added that to the bug list at SourceForge
>   (https://sourceforge.net/bugs/?group_id=13357).

Why is it a good idea to include on that site bugs in the pretest 
versions?  I can hardly believe that this problem won't be fixed
in the final release.

I think it is better that people who try the pretest report problems here 
instead of thinking that the problem is a known bug.
Permalink | Reply | 10 comments |
headers
Peter S Galbraith | 16 Jan 2001 15:27
Picon
Favicon

Re: 21.0.95 stomping DEL binding in mh-e

Eli Zaretskii wrote:

> On 15 Jan 2001, Bill Wohler wrote:
> 
> >   Thanks. I added that to the bug list at SourceForge
> >   (https://sourceforge.net/bugs/?group_id=13357).
> 
> Why is it a good idea to include on that site bugs in the pretest 
> versions?  

If it's an mh-e bug, then it should be on that site.

>            I can hardly believe that this problem won't be fixed
> in the final release.

Of Emacs-21 ?
Then it's an Emacs-21 bug and not an mh-e bug?

> I think it is better that people who try the pretest report problems here 

I'm sorry, `here' refers to what?   
emacs-pretest-bug <at> gnu.org or mh-e-devel <at> lists.sourceforge.net? 

> instead of thinking that the problem is a known bug.

If it gets listed as an mh-e bug on sourceforge, it'll presumably
get fixed and not just listed as a known bug.  mh-e development
is slowly ramping up again.  Please give us time to settle in
(for myself, my father died a month ago so my open source efforts
have taken a hit recently.)
(Continue reading)

Permalink | Reply | 9 comments |
headers
chad | 16 Jan 2001 17:38
Picon
Favicon

Re: 21.0.95 stomping DEL binding in mh-e

Sorry about the delay; I've been out of touch recently.

> Then it's an Emacs-21 bug and not an mh-e bug?

For the emacs people: Do you believe that define-key for "\177" should
continue to work in Emacs 21, after the changes for Delete/Backspace?
If so, then this is a bug in emacs-21.0.95.

For the mh-e people: emacs-21 will have a new way to deal with DEL, to
differentiate Delete and Backspace.  Because of this, the following
patch should be applied:

*** mh-e.el    Tue Jan 16 11:33:38 2001
--- mh-e.el-orig    Thu Nov  2 07:37:54 2000
***************
*** 1345,1352 ****
  (define-key mh-folder-mode-map "\e<" 'mh-first-msg)
  (define-key mh-folder-mode-map "\e>" 'mh-last-msg)
  (define-key mh-folder-mode-map "\177" 'mh-previous-page)
- (define-key mh-folder-mode-map [(delete)] 'mh-previous-page)
- (define-key mh-folder-mode-map [(backspace)] 'mh-previous-page)
  (define-key mh-folder-mode-map " " 'mh-page-msg)
  (define-key mh-folder-mode-map "\r" 'mh-show)
  (define-key mh-folder-mode-map "." 'mh-show)

I believe that the patch should be applied even if the emacs people
determine that "\177" should work.  Some simple testing indicates that
the additional lines cause no problems for Emacs 20.7.

chad
(Continue reading)

Permalink | Reply | 7 comments |
headers
Peter S Galbraith | 16 Jan 2001 17:43
Picon
Favicon

Re: 21.0.95 stomping DEL binding in mh-e

Thanks.  I'll note this for mh-e.

chad wrote:

> Sorry about the delay; I've been out of touch recently.
> 
> > Then it's an Emacs-21 bug and not an mh-e bug?
> 
> For the mh-e people: emacs-21 will have a new way to deal with DEL, to
> differentiate Delete and Backspace.  Because of this, the following
> patch should be applied:
> 
> *** mh-e.el    Tue Jan 16 11:33:38 2001
> --- mh-e.el-orig    Thu Nov  2 07:37:54 2000
> ***************
> *** 1345,1352 ****
>   (define-key mh-folder-mode-map "\e<" 'mh-first-msg)
>   (define-key mh-folder-mode-map "\e>" 'mh-last-msg)
>   (define-key mh-folder-mode-map "\177" 'mh-previous-page)
> - (define-key mh-folder-mode-map [(delete)] 'mh-previous-page)
> - (define-key mh-folder-mode-map [(backspace)] 'mh-previous-page)
>   (define-key mh-folder-mode-map " " 'mh-page-msg)
>   (define-key mh-folder-mode-map "\r" 'mh-show)
>   (define-key mh-folder-mode-map "." 'mh-show)
> 
> 
> I believe that the patch should be applied even if the emacs people
> determine that "\177" should work.  Some simple testing indicates that
> the additional lines cause no problems for Emacs 20.7.
(Continue reading)

Permalink | Reply | 1 comment |
headers
chad | 16 Jan 2001 17:53
Picon
Favicon

Re: 21.0.95 stomping DEL binding in mh-e

Blah.  Looking at the patch, it's obviously backwards.  those two new
lines should be added.  Mea Culpa.

chad
Permalink | Reply | 0 comments |
headers
Jeffrey C Honig | 16 Jan 2001 17:56

Re: 21.0.95 stomping DEL binding in mh-e

How far back does this work?  I've verified that it works on 20.4.1
and am trying to get access to a system with a version of emacs 19
installed.

How many version of emacs do we want mh-e to be compatible with?

Thanks.

Jeff

> For the mh-e people: emacs-21 will have a new way to deal with DEL, to
> differentiate Delete and Backspace.  Because of this, the following
> patch should be applied:
> 
> *** mh-e.el    Tue Jan 16 11:33:38 2001
> --- mh-e.el-orig    Thu Nov  2 07:37:54 2000
> ***************
> *** 1345,1352 ****
>   (define-key mh-folder-mode-map "\e<" 'mh-first-msg)
>   (define-key mh-folder-mode-map "\e>" 'mh-last-msg)
>   (define-key mh-folder-mode-map "\177" 'mh-previous-page)
> - (define-key mh-folder-mode-map [(delete)] 'mh-previous-page)
> - (define-key mh-folder-mode-map [(backspace)] 'mh-previous-page)
>   (define-key mh-folder-mode-map " " 'mh-page-msg)
>   (define-key mh-folder-mode-map "\r" 'mh-show)
>   (define-key mh-folder-mode-map "." 'mh-show)
> 
> 
> I believe that the patch should be applied even if the emacs people
> determine that "\177" should work.  Some simple testing indicates that
(Continue reading)

Permalink | Reply | 4 comments |
headers
Peter S Galbraith | 16 Jan 2001 18:04
Picon
Favicon

Re: 21.0.95 stomping DEL binding in mh-e

Jeffrey C Honig wrote:

> How many version of emacs do we want mh-e to be compatible with?

Good question.  I was going to start a thread concerning this
point.

Personally, I think we should support Emacs-20, Emacs-21,
XEmacs-21 and possibly XEmacs-20 if people still use it.

I think we should drop Emacs-19 support for future versions
because: 

 - It'll be a pain to test.
 - It'll be a pain to conditionally test for the existence of
   functions everywhere in stuff we add (font-lock, customize,
   MIME, etc)
 - We'll want to use new features available only in more recent
   versions of Emacs.

(I still have Emacs-19 installed, but no longer really use it.)

My two cents only...

Peter
Permalink | Reply | 2 comments |
headers
Eli Zaretskii | 16 Jan 2001 18:24
Picon

Re: 21.0.95 stomping DEL binding in mh-e

> Date: Tue, 16 Jan 2001 09:27:20 -0500
> From: Peter S Galbraith <GalbraithP <at> dfo-mpo.gc.ca>
> > 
> > Why is it a good idea to include on that site bugs in the pretest 
> > versions?  
> 
> If it's an mh-e bug, then it should be on that site.

I don't think it's an mh-bug; see below.

> >            I can hardly believe that this problem won't be fixed
> > in the final release.
> 
> Of Emacs-21 ?

Yes.

> Then it's an Emacs-21 bug and not an mh-e bug?

It's not a bug at all.  It's an unintended consequence of making Emacs
know about a <backspace> key if the keyboard has it.  Previously,
Emacs would treat that key as DEL.

> > I think it is better that people who try the pretest report problems here 
> 
> I'm sorry, `here' refers to what?   
> emacs-pretest-bug <at> gnu.org or mh-e-devel <at> lists.sourceforge.net? 

I meant emacs-pretest-bug.  Sorry for being unclear about that.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane