Mart Raudsepp | 1 Dec 2004 05:01

Re: Re[6]: [wx-dev] GTK2 wxTextCtrl patches outstanding

> I'll look into wxTextCtrl::WriteText (that gets called by AppendText
> right after the insertion point is moved to the end) as soon as I have a
> chance.

Ok.
I'm done with tracking.
It's right inside gtk_text_buffer_insert
Postponing the investigation of this due to it's level of difficulty
compared to other matters at hand.
I am 95% sure it's gtk+ problem. What makes me wonder is that google
doesn't seem to know anything about it.
It does all sorts of things inside _gtk_text_btree_insert for some
reason.

Meanwhile Mahogany can be made usable with the text viewer by:

* Making it not process the text twice in some occasions
* Calling wxTextCtrl::AppendText as less as possibly, that is it
shouldn't be called once for each line if lines have the same style
really, but only once per _real_ style change.
With the sample message I was sent should then render at least 50 times
quicker, most probably more.
Without the Quotes and URL filter the message is written with just some
AppendText's. With the filter turned on, at least once per line.
* Alternatively even better instead of the previous point is to write
all and then style it with SetStyle. See below.

Each AppendText call costs some time in milliseconds, starting from zero
and raising gradually when called on a larger buffer. In case of the
sample message I was sent, maxing out at around 90 milliseconds. The
(Continue reading)

Vadim Zeitlin | 2 Dec 2004 09:04
Favicon

Re[2]: crash when exiting program

On Thu, 25 Nov 2004 04:57:22 +0200 (EET) Nerijus Baliunas <nerijus <at> users.sourceforge.net> wrote:

NB> On Wed, 24 Nov 2004 23:20:58 +0200 (EET) Nerijus Baliunas <nerijus <at> users.sourceforge.net> wrote:
NB> 
NB> NB> The following crash I get only when M is compiled with gcc 3.4, but not
NB> NB> with 2.96:
NB> 
NB> Oops, sorry, I get a crash with dynamic modules, but not static.

 This should be fixed now, please let me know if it is not.

 Thanks,
VZ

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Vadim Zeitlin | 2 Dec 2004 09:11
Favicon

Re[2]: Re[6]: [wx-dev] GTK2 wxTextCtrl patches outstanding

On Wed, 01 Dec 2004 06:01:45 +0200 Mart Raudsepp <leio <at> dustbite.net> wrote:

MR> Ok.
MR> I'm done with tracking.

 Hello,

 thanks a lot for taking time to look into this, and really sorry for
having no time at all to do anything myself right now...

MR> Meanwhile Mahogany can be made usable with the text viewer by:
MR> 
MR> * Making it not process the text twice in some occasions

 I'll look into this but it seems that even when it processes it only once
it is still way too slow (50s to show the message!?).

MR> * Calling wxTextCtrl::AppendText as less as possibly, that is it
MR> shouldn't be called once for each line if lines have the same style
MR> really, but only once per real style change.

 This makes a lot of sense and should be easy to do... I'll do it, Nerijus,
could you please test if this improves things enough to become usable?

MR> * Alternatively even better instead of the previous point is to write
MR> all and then style it with SetStyle. See below.

 This will unfortunately require some heavy changes.

 Thanks again,
(Continue reading)

Nerijus Baliunas | 2 Dec 2004 13:46
Picon

Re[3]: crash when exiting program

On Thu, 2 Dec 2004 09:04:04 +0100 (Romance Standard Time) Vadim Zeitlin <vadim <at> wxwindows.org> wrote:

VZ> NB> Oops, sorry, I get a crash with dynamic modules, but not static.
VZ> 
VZ>  This should be fixed now, please let me know if it is not.

Yes, thanks, but now for almost all modules there is
Error: /usr/local/lib/mahogany/modules/TextViewer.so: undefined symbol: CleanupMModule

Regards,
Nerijus

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Nerijus Baliunas | 2 Dec 2004 14:02
Picon

Re[3]: Re[6]: [wx-dev] GTK2 wxTextCtrl patches outstanding

On Thu, 2 Dec 2004 09:11:17 +0100 (Romance Standard Time) Vadim Zeitlin <vadim <at> wxwindows.org> wrote:

VZ> MR> * Calling wxTextCtrl::AppendText as less as possibly, that is it
VZ> MR> shouldn't be called once for each line if lines have the same style
VZ> MR> really, but only once per real style change.
VZ> 
VZ>  This makes a lot of sense and should be easy to do... I'll do it, Nerijus,
VZ> could you please test if this improves things enough to become usable?

Yes, now 15 seconds, thanks! But still much slower than gtk1 of course.

Regards,
Nerijus

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Vadim Zeitlin | 2 Dec 2004 14:19
Favicon

Re[4]: crash when exiting program

On Thu, 2 Dec 2004 14:46:33 +0200 (EET) Nerijus Baliunas <nerijus <at> users.sourceforge.net> wrote:

NB> On Thu, 2 Dec 2004 09:04:04 +0100 (Romance Standard Time) Vadim Zeitlin <vadim <at> wxwindows.org> wrote:
NB> 
NB> VZ> NB> Oops, sorry, I get a crash with dynamic modules, but not static.
NB> VZ> 
NB> VZ>  This should be fixed now, please let me know if it is not.
NB> 
NB> Yes, thanks, but now for almost all modules there is
NB> Error: /usr/local/lib/mahogany/modules/TextViewer.so: undefined symbol: CleanupMModule

 Should be fixed, thanks,
VZ

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Mart Raudsepp | 11 Dec 2004 19:07

Re: Re[3]: Re[6]: [wx-dev] GTK2 wxTextCtrl patches outstanding

On Thu, 2004-12-02 at 15:02 +0200, Nerijus Baliunas wrote:
> On Thu, 2 Dec 2004 09:11:17 +0100 (Romance Standard Time) Vadim Zeitlin <vadim <at> wxwindows.org> wrote:
> 
> VZ> MR> * Calling wxTextCtrl::AppendText as less as possibly, that is it
> VZ> MR> shouldn't be called once for each line if lines have the same style
> VZ> MR> really, but only once per real style change.
> VZ> 
> VZ>  This makes a lot of sense and should be easy to do... I'll do it, Nerijus,
> VZ> could you please test if this improves things enough to become usable?
> 
> Yes, now 15 seconds, thanks! But still much slower than gtk1 of course.

Whoops, meant to post list.

How does 

https://sourceforge.net/tracker/?func=detail&aid=1081243&group_id=9863&atid=309863

help? :)

--

-- 
With regards,
Mart Raudsepp

Project manager of wxMUD
E-mail: leio <at> dustbite.net
http://wxmud.sourceforge.net/

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
(Continue reading)

Nerijus Baliunas | 16 Dec 2004 16:24
Picon

precompiled headers

Hello,

M uses a lot of USE_PCH and only a few WX_PRECOMP. Why?
Wouldn't using only WX_PRECOMP be enough?

Regards,
Nerijus

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
Mark A Framness | 19 Dec 2004 21:28
Picon

repeated function make error.

Greetings,

I have worked through a problem or two already and am faced by a situation 
arising from multiple definitions of the same function in two different 
source files.

As you can see from the output this is happening with ParseColourString and 
GetColourByName. I looked in the files with the GetColourByName definitions 
and and one appears to be a file that came with the source and the other 
appears to be a file generated at runtime by the make procedure. I am 
guessing I need to comment out the make generated definition, correct?

BTW I am running on Slackware 9.0 and have the latest successful build 
snapshot for the Mahogany source.

==================================
util/miscutil.o(.text+0x0): In function `ParseColourString(wxString const&, 
wxCo                    lour*)':
: multiple definition of `ParseColourString(wxString const&, wxColour*)'
util/ColourNames.o(.text+0x0): first defined here
util/miscutil.o(.text+0x158): In function `GetColourName(wxColour const&)':
: multiple definition of `GetColourName(wxColour const&)'
util/ColourNames.o(.text+0x158): first defined here
util/miscutil.o(.text+0x1f8): In function `GetColourByName(wxColour*, wxString 
c                    onst&, wxString const&)':
: multiple definition of `GetColourByName(wxColour*, wxString const&, wxString 
c                    onst&)'
util/ColourNames.o(.text+0x1f8): first defined here
/usr/lib/gcc-lib/i386-slackware-linux/3.2.2/../../../../i386-slackware-linux/bin                    
/ld: Warning: size of symbol `GetColourByName(wxColour*, wxString const&, 
(Continue reading)

Vadim Zeitlin | 19 Dec 2004 21:28
Favicon

Re: repeated function make error.

On Sun, 19 Dec 2004 14:28:43 -0600 Mark A Framness <farmer <at> netnet.net> wrote:

MAF> As you can see from the output this is happening with ParseColourString and 
MAF> GetColourByName. I looked in the files with the GetColourByName definitions 
MAF> and and one appears to be a file that came with the source and the other 
MAF> appears to be a file generated at runtime by the make procedure. I am 
MAF> guessing I need to comment out the make generated definition, correct?

 Hello,

 which file is generated by make? Normally miscutil.cpp shouldn't exist at
all any longer -- the few functions from it were moved to other files (in
particular ColourNames.cpp). If you have this file in the source tree, it
must be a [mix of newer and] older version, please remove it. If it's
somehow generated during make, I'd like to know how does it happen...

 Thanks,
VZ

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Gmane