headers
Marc Perkel | 4 Mar 2009 18:56

[Bug 819] New: Passing New Headers to Spamassassin

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=819
           Summary: Passing New Headers to Spamassassin
           Product: Exim
           Version: 4.69
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: wishlist
          Priority: medium
         Component: Content Scanning
        AssignedTo: tom <at> duncanthrax.net
        ReportedBy: marc <at> perkel.com
                CC: exim-dev <at> exim.org

Not sure how hard it would be but I'd like to see new headers added in ACLs be
passed to Spam Assassin.

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
Permalink | Reply | 1 comment |
headers
Ted Cooper | 5 Mar 2009 13:20
Favicon

[Bug 819] Passing New Headers to Spamassassin

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=819

Ted Cooper <eximX0902w <at> linuxwan.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eximX0902w <at> linuxwan.net
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Ted Cooper <eximX0902w <at> linuxwan.net>  2009-03-05 12:20:51 ---
They are. I have confirmed it works 2 years ago with a 5 minute experiment.

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
Permalink | Reply | 0 comments |
headers
Simon Arlott | 8 Mar 2009 12:55

[Bug 486] Monthly datestamped log files

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=486

--- Comment #2 from Simon Arlott <bugzilla.exim.simon <at> arlott.org>  2009-03-08 11:55:13 ---
Created an attachment (id=302)
 --> (http://bugs.exim.org/attachment.cgi?id=302)
Patch implementing an option for monthly datestamped log files

This patch based on 4.69 adds a %M equivalent to %D. It still only allows one
of these to be specified, although without changes to panic filename handling
it wouldn't be possible to use "%M/%D" anyway. (But there appears to be no
request for this feature).

For removal from the panic filename, as well as the offset, the length is now
also stored. The type is stored to allow the change in datestamp value to be
detected for mainlog/rejectlog.

Tested with %D, %M, %D%M, normal (queue run) and panic log entries.

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
Permalink | Reply | 0 comments |
headers
Ted Cooper | 8 Mar 2009 13:55
Favicon

[Bug 486] Monthly datestamped log files

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=486

--- Comment #3 from Ted Cooper <eximX0902w <at> linuxwan.net>  2009-03-08 12:55:58 ---
Should only allow for %M or %D, not both.

tod_stamp(int type) function in tod.c needs to be updated to include a monthly
todstamp as calling a monthly log file yyyymmDD is questionable. The DD part is
irrelevant. line 1543 in src/expand.c - case vtype_todlf needs to be duplicated
with a new type to correctly deal with tod_stamp calls.

Documentation needs updating.

Perhaps instead it should allow for the full strftime so log files can be named
whatever people want them to be rather than limiting to only 2 of the formats.

To quote the docs on panic "The location of the panic log is also determined by
log_file_path, but it is not datestamped, because rotation of the panic log
does not make sense".

As a side - most systems now come with logrotated or something similar. Is log
file management really something that should still be in exim?

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ted Cooper | 8 Mar 2009 14:10
Favicon

[Bug 391] please consider allowing multiple log_selector statements

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=391

--- Comment #2 from Ted Cooper <eximX0902w <at> linuxwan.net>  2009-03-08 13:10:16 ---
log_selector is a global setting.

This hasn't been touched in a long time and no one else has piped up for it.
Does anyone else see any benefit at all in being able to adjust a global
logging setting based on ACL decisions? log_message allows logging of pretty
much any extra data you could ever want.

In my mind, you either always the log the things you want, or kick yourself for
not logging them when you need them. Hard drive room is cheap - if someone
really doesn't want all the XX log entires regarding TLS from YY host, filter
them out at the end of the day before rotating the logs.

I hereby vote to resolve this bug as WONTFIX.

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
Permalink | Reply | 0 comments |
headers
Simon Arlott | 8 Mar 2009 14:28

[Bug 486] Monthly datestamped log files

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=486

Simon Arlott <bugzilla.exim.simon <at> arlott.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla.exim.simon <at> arlott.o
                   |                            |rg

--- Comment #4 from Simon Arlott <bugzilla.exim.simon <at> arlott.org>  2009-03-08 13:28:15 ---
(In reply to comment #3)
> Should only allow for %M or %D, not both.

It doesn't allow both; I tested it with both to see what would happen.

> tod_stamp(int type) function in tod.c needs to be updated to include a monthly
> todstamp as calling a monthly log file yyyymmDD is questionable. The DD part is

That's what my patch does...

> irrelevant. line 1543 in src/expand.c - case vtype_todlf needs to be duplicated
> with a new type to correctly deal with tod_stamp calls.

The documentation explicitly states that this uses %D, I don't think there's a
need to add a %M version.

> Documentation needs updating.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Simon Arlott | 8 Mar 2009 14:32

[Bug 391] please consider allowing multiple log_selector statements

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=391

Simon Arlott <bugzilla.exim.simon <at> arlott.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla.exim.simon <at> arlott.o
                   |                            |rg

--- Comment #3 from Simon Arlott <bugzilla.exim.simon <at> arlott.org>  2009-03-08 13:32:32 ---
(In reply to comment #2)
> log_selector is a global setting.

I don't think this request intends to change that. It's currently not possible
to specify log_selector multiple times; you must always specify the full set of
options. It's not possible to .include a common list of log_selector options
and then modify them, or split them up within different sections of the main
part of the configuration file.

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
(Continue reading)

Permalink | Reply | 0 comments |
headers
Simon Arlott | 8 Mar 2009 14:48

[Bug 486] Monthly datestamped log files

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=486

--- Comment #5 from Simon Arlott <bugzilla.exim.simon <at> arlott.org>  2009-03-08 13:48:44 ---
Created an attachment (id=303)
 --> (http://bugs.exim.org/attachment.cgi?id=303)
Documentation updates for addition of %M to log_file_path

This patch is against 4.69

-- 
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email

--

-- 
## List details at http://lists.exim.org/mailman/listinfo/exim-dev Exim details at
http://www.exim.org/ ##
Permalink | Reply | 0 comments |
headers
Ted Cooper | 8 Mar 2009 23:23
Favicon

[Bug 486] Monthly datestamped log files

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=486

--- Comment #6 from Ted Cooper <eximX0902w <at> linuxwan.net>  2009-03-08 22:23:39 ---
Docs look good.

>> tod_stamp(int type) function in tod.c needs to be updated to include a monthly
>> todstamp as calling a monthly log file yyyymmDD is questionable. The DD part is
>
>That's what my patch does...

So it does sorry. Got confused up the top with the expand.c only returning one
of the types rathar than both. Completely missed the 2 different types with
different length towards the end. Still, does the variable expansion section
need to be expanded to include the new %M type return? currently the
$tod_logfile variable returns the yyyymmdd version, perhaps
$tod_logfile_monthly should return yyyymm to match.

>> As a side - most systems now come with logrotated or something similar. Is
>> log file management really something that should still be in exim?
>
>Log file name management is not something that should be in logrotated. It's
>flawed because it requires moving files that could be actively in use. Writing
>to the current file works much better, but the per-day option creates too many
>files for me. These are then easily compressed after the end of the month.

You can move/rename an open file without incident on most *nix. Open files are
based off the file inode, not the name of the file. So if you move rename (into
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ted Cooper | 8 Mar 2009 23:38
Favicon

[Bug 391] please consider allowing multiple log_selector statements

------- You are receiving this mail because: -------
You are the QA contact for the bug.

http://bugs.exim.org/show_bug.cgi?id=391

--- Comment #4 from Ted Cooper <eximX0902w <at> linuxwan.net>  2009-03-08 22:38:23 ---
Since it's global, it means that it's read all at once by the time the file is
read - there can't be different modes of log selectors based on what part of
the file it's referenced as stated in the original WL item.

The log selectors can already be split up with with .ifdef, and can even be
.included in -

log_selector = +smtp_connection \
               +smtp_confirmation \
.ifdef GREYLISTD
               +smtp_no_mail \
               +smtp_protocol_error \
               +smtp_syntax_error \
.endif
.ifdef TLS_ENABLED
               +tls_cipher +tls_peerdn \
.endif
               +smtp_incomplete_transaction \
               +incoming_interface \
.include /etc/exim/other_file

They can't be modified as the file is parsed since all of that is done well
before that process starts accepting emails. An entirely new infrastructure
would have to be build to incorporate this which creates an enormous amount of
(Continue reading)

Permalink | Reply | 0 comments |

Gmane