Re: Bug#345998: enemies-of-carlotta: Use standard exit codes in --incoming mode
Lars Wirzenius <liw@...
2006-01-06 22:20:11 GMT
Erich filed a wishlist bug, with a patch, to make EoC use different exit
codes than before for certain situations. This has been mentioned
before, and I like the idea. My only worry is whether it is too big a
behavioral change to do for a 1.2 release.
EoC list: do you think anything depends on the current exit codes of the
EoC command? Tommi especially, you have a habit of writing stuff on top
ke, 2006-01-04 kello 19:59 +0100, Erich Schubert kirjoitti:
> Attached patch will use a "short" error reporting in --incoming mode,
> and use appropriate exit codes (from the os module) for common errors.
> When used as a postfix pipe transport, EoC used to report exceptions
> wrapped into a single line; thus causing a really ugly error message.
> by using appropriate exit codes in sys.exit(), postfix (as does
> procmail) understands what the type of error is, and will produce a
> nicer error message; by printing just a tiny bit of additional information
> this hopefully makes much more sense to the user:
> <something@...>: user unknown. Command output: Unknown list
> instead of
> <irgendwas@...>: Command died with status 1:
> "/usr/bin/enemies-of-carlotta". Command output: Traceback (most recent call
> last): File "/usr/bin/enemies-of-carlotta", line 16, in ?
> eoc.main(sys.argv[1:]) File "/usr/share/enemies-of-carlotta/eoc.py", line
> 1645, in main mlm.incoming_message(skip_prefix, domain, moderate, post)
> File "/usr/share/enemies-of-carlotta/eoc.py", line 375, in incoming_message
> domain) File "/usr/share/enemies-of-carlotta/eoc.py", line 313, in
> parse_recipient_address listname, parts = ap.parse(address) File
> "/usr/share/enemies-of-carlotta/eoc.py", line 181, in parse raise