Matthias Andree | 1 Apr 2005 09:08
Picon
Picon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

David Relson <relson <at> users.sourceforge.net> writes:

> Update of /cvsroot/bogofilter/bogofilter/src/tests
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv1160/src/tests
>
> Modified Files:
> 	Makefile.am 
> Log Message:
> Update for 0.94.3
>

[...]

> -ENVIRON_TESTS = t.abort t.env t.ctype t.bogodir t.leakfind t.u_fpe
> +ENVIRON_TESTX = t.abort
> +ENVIRON_TESTS = t.env t.ctype t.bogodir t.leakfind t.u_fpe
>  
>  PARSING_TESTS = \
>  	t.longoptions \

Was this intentional?

--

-- 
Matthias Andree
_______________________________________________
Bogofilter-dev mailing list
Bogofilter-dev <at> bogofilter.org
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev

(Continue reading)

David Relson | 3 Apr 2005 02:35
Favicon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

On Fri, 01 Apr 2005 09:08:39 +0200
Matthias Andree wrote:

> David Relson <relson <at> users.sourceforge.net> writes:
> 
> > Update of /cvsroot/bogofilter/bogofilter/src/tests
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv1160/src/tests
> >
> > Modified Files:
> > 	Makefile.am 
> > Log Message:
> > Update for 0.94.3
> >
> 
> [...]
> 
> > -ENVIRON_TESTS = t.abort t.env t.ctype t.bogodir t.leakfind t.u_fpe
> > +ENVIRON_TESTX = t.abort
> > +ENVIRON_TESTS = t.env t.ctype t.bogodir t.leakfind t.u_fpe
> >  
> >  PARSING_TESTS = \
> >  	t.longoptions \
> 
> Was this intentional?

No.  I'll fix it for the next release.  As a related matter, you may
notice that t.bogoutil is _not_ included in the 0.94.3 tarball.  That's
deliberate because t.bogoutil failures affect "make rpm".

_______________________________________________
(Continue reading)

Matthias Andree | 4 Apr 2005 09:51
Picon
Picon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

David Relson <relson <at> osagesoftware.com> writes:

> No.  I'll fix it for the next release.  As a related matter, you may
> notice that t.bogoutil is _not_ included in the 0.94.3 tarball.  That's
> deliberate because t.bogoutil failures affect "make rpm".

I am not aware of t.bogoutil failures.

BTW, "make rpm" fails building the static RPM for me for two reasons:

1. SuSE's db package requires linking against libpthread which
   apparently is not provided for statically linked programs

2. getpwnam() - with glibc and probably other systems with name service
   switch - causes warnings because it needs dynamic name service
   libraries...

Other than that, the current CVS fails horribly in a lot of tests, this
sample from t.bogodir running bogofilter -x d -vv -D -C (I don't have
redirections handy):

<<< SIMPLE BACKTRACE <<<
#0  0x0805c47b in mxcat (first=0x0) at mxcat.c:16
#1  0x08057947 in init_wordlist (name=0x0, path=0x805cb40 "wordlist.db", override=0,
type=WL_REGULAR) at wordlists_base.c:65
#2  0x0804a37d in process_parameters (argc=6, argv=0xbfffea24, warn_on_error=true) at bogoconfig.c:205
#3  0x0804bbb6 in bogomain (argc=6, argv=0xbfffea24) at bogomain.c:48
#4  0x0804a12b in main (argc=0, argv=0x0) at main.c:30

--

-- 
(Continue reading)

David Relson | 4 Apr 2005 13:22
Favicon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

On Mon, 04 Apr 2005 09:51:18 +0200
Matthias Andree wrote:

> David Relson <relson <at> osagesoftware.com> writes:
> 
> > No.  I'll fix it for the next release.  As a related matter, you may
> > notice that t.bogoutil is _not_ included in the 0.94.3 tarball.  That's
> > deliberate because t.bogoutil failures affect "make rpm".
> 
> I am not aware of t.bogoutil failures.
> 
> 
> BTW, "make rpm" fails building the static RPM for me for two reasons:
> 
> 1. SuSE's db package requires linking against libpthread which
>    apparently is not provided for statically linked programs
> 
> 2. getpwnam() - with glibc and probably other systems with name service
>    switch - causes warnings because it needs dynamic name service
>    libraries...

I noticed those warnings not too long ago.  Since 'ldd' indicated the
executables didn't need any shared libraries, I've ignore the warnings.

> Other than that, the current CVS fails horribly in a lot of tests, this
> sample from t.bogodir running bogofilter -x d -vv -D -C (I don't have
> redirections handy):
> 
> <<< SIMPLE BACKTRACE <<<
> #0  0x0805c47b in mxcat (first=0x0) at mxcat.c:16
(Continue reading)

Matthias Andree | 5 Apr 2005 00:48
Picon
Picon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

David Relson <relson <at> osagesoftware.com> writes:

> I noticed those warnings not too long ago.  Since 'ldd' indicated the
> executables didn't need any shared libraries, I've ignore the
> warnings.

You can link libdl itself (for dlopen() and company) statically, but the
libraries opened by dlopen() are still .so libraries required at
run-time.

>> Other than that, the current CVS fails horribly in a lot of tests, this
>> sample from t.bogodir running bogofilter -x d -vv -D -C (I don't have
>> redirections handy):
>> 
>> <<< SIMPLE BACKTRACE <<<
>> #0  0x0805c47b in mxcat (first=0x0) at mxcat.c:16
>> #1  0x08057947 in init_wordlist (name=0x0, path=0x805cb40 "wordlist.db", override=0,
type=WL_REGULAR) at wordlists_base.c:65
>> #2  0x0804a37d in process_parameters (argc=6, argv=0xbfffea24, warn_on_error=true) at bogoconfig.c:205
>> #3  0x0804bbb6 in bogomain (argc=6, argv=0xbfffea24) at bogomain.c:48
>> #4  0x0804a12b in main (argc=0, argv=0x0) at main.c:30
>
> My current 'bfpath' code passes "make check" for db4.x (TXN and NON-
> TXN), tdb, qdbm, and sqlite.  I've just committed the code so you can
> test it.

Yup. Appears to work much better. Thank you :-)

--

-- 
Matthias Andree
(Continue reading)

David Relson | 5 Apr 2005 01:08
Favicon

Re: [cvs] bogofilter/src/tests Makefile.am,1.46,1.47

On Tue, 05 Apr 2005 00:48:31 +0200
Matthias Andree wrote:

> David Relson <relson <at> osagesoftware.com> writes:
> 
> > I noticed those warnings not too long ago.  Since 'ldd' indicated the
> > executables didn't need any shared libraries, I've ignore the
> > warnings.
> 
> You can link libdl itself (for dlopen() and company) statically, but the
> libraries opened by dlopen() are still .so libraries required at
> run-time.
> 
> >> Other than that, the current CVS fails horribly in a lot of tests, this
> >> sample from t.bogodir running bogofilter -x d -vv -D -C (I don't have
> >> redirections handy):
> >> 
> >> <<< SIMPLE BACKTRACE <<<
> >> #0  0x0805c47b in mxcat (first=0x0) at mxcat.c:16
> >> #1  0x08057947 in init_wordlist (name=0x0, path=0x805cb40 "wordlist.db", override=0,
type=WL_REGULAR) at wordlists_base.c:65
> >> #2  0x0804a37d in process_parameters (argc=6, argv=0xbfffea24, warn_on_error=true) at bogoconfig.c:205
> >> #3  0x0804bbb6 in bogomain (argc=6, argv=0xbfffea24) at bogomain.c:48
> >> #4  0x0804a12b in main (argc=0, argv=0x0) at main.c:30
> >
> > My current 'bfpath' code passes "make check" for db4.x (TXN and NON-
> > TXN), tdb, qdbm, and sqlite.  I've just committed the code so you can
> > test it.
> 
> Yup. Appears to work much better. Thank you :-)
(Continue reading)

Matthias Andree | 6 Apr 2005 00:31
Picon
Picon

Re: [cvs] bogofilter/src token.c,1.118,1.119

David Relson <relson <at> users.sourceforge.net> writes:

> +    uint p = (prefix == NULL) ? 0 : prefix->leng;
> +    uint l = leng + p;
> +
> +    if (l >= token_size)
> +	l = token_size - p;
> +
> +    token->leng = l;
> +
> +    /* copy prefix, if there is one */
> +    if (prefix != NULL)
> +	memcpy(token->text, prefix->text, p);
> +
> +    memcpy(token->text + p, text, l-p);		/* include nul terminator */
> +    token->text[token->leng] = '\0';		/* ensure nul termination */

What is the upper limit here?

IOW, against what limit does the actual prefix length count?

Do we limit against MAXTOKENLEN or something a lot larger?

--

-- 
Matthias Andree
_______________________________________________
Bogofilter-dev mailing list
Bogofilter-dev <at> bogofilter.org
http://www.bogofilter.org/mailman/listinfo/bogofilter-dev

(Continue reading)

David Relson | 6 Apr 2005 01:05
Favicon

limits [was: [cvs] ... token.c]

On Wed, 06 Apr 2005 00:31:31 +0200
Matthias Andree wrote:

> David Relson <relson <at> users.sourceforge.net> writes:
> 
> > +    uint p = (prefix == NULL) ? 0 : prefix->leng;
> > +    uint l = leng + p;
> > +
> > +    if (l >= token_size)
> > +	l = token_size - p;
> > +
> > +    token->leng = l;
> > +
> > +    /* copy prefix, if there is one */
> > +    if (prefix != NULL)
> > +	memcpy(token->text, prefix->text, p);
> > +
> > +    memcpy(token->text + p, text, l-p);		/* include nul terminator */
> > +    token->text[token->leng] = '\0';		/* ensure nul termination */
> 
> What is the upper limit here?
> 
> IOW, against what limit does the actual prefix length count?
> 
> Do we limit against MAXTOKENLEN or something a lot larger?

prefix->leng is the length of the current prefix.  At present the
prefixes are:

"to:", "from:", "rtrn:", "subj:", "rcvd:", "head:", and "mime:"
(Continue reading)

David Relson | 8 Apr 2005 02:38
Favicon

bogofilter-0.94.4 - new current release

Greetings,

Bogofilter-0.94.4 reformats the RELEASE.NOTES, fixes a parser problem
with long VERPs, and cleans up the filename and directory handling code.

########################################################################

Files are available at http://sourceforge.net/projects/bogofilter for
download.

Here are the md5sums for the release:

d86e2e29d8f3f69a3032d43de079e3e3  bogofilter-0.94.4-1.i586.rpm
368041463e7d5744d7a6e8e3aa723d62  bogofilter-0.94.4-1.src.rpm
74e84907f2ca9e0226a8d3931aa0635f  bogofilter-0.94.4.tar.bz2
fbc7eaa60b31623151101a5ffd44e491  bogofilter-0.94.4.tar.gz
1762377c48995740a67a30b572ff9434  bogofilter-static-0.94.4-1.i586.rpm

################################################################

			       =================
				BOGOFILTER NEWS
			       =================

	!!!!!!!! READ THE RELEASE.NOTES !!!!!!!!

	The sections

        INCOMPATIBLE CHANGES IN BOGOFILTER (version)
and     MAJOR CHANGES IN BOGOFILTER (version)
(Continue reading)

Matthias Andree | 10 Apr 2005 14:58
Picon
Picon

Re: [cvs] bogofilter/src/tests t.valgrind,1.16,1.17

David Relson <relson <at> users.sourceforge.net> writes:

> Update of /cvsroot/bogofilter/bogofilter/src/tests
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv3831
>
> Modified Files:
> 	t.valgrind 
> Log Message:
> Suppress errors in glibc::strchr.
>
> +# suppress valgrind complaints about glibc::strchr.S
> +
> +VG_SUPP=${TMPDIR}/vg.supp
> +
> +cat <<EOF > ${VG_SUPP}
> +{
> +   ignore strchr problem
> +   Memcheck:Cond
> +   fun:strchr
> +}
> +EOF
> +
>  #V="-v"	# verbosity level
>  

This is too aggressive and will also quiet complaints that are real bugs.

--

-- 
Matthias Andree
_______________________________________________
(Continue reading)


Gmane