Hi,

I’m currently trying to learn and evaluate ucw for future projects and I was wondering if there is any support for form validation. I would be very thankful for suggestions on how to do this efficiently in ucw.

Hi.

This is a minor issue, actually.  In yaclml/src/tal/xmls.lisp, we read:

  (defun make-node (&key name ns attrs child children)
    (cons #<Datum for name, ns and attrs> #<Datum for child or children>))

and, correspondingly,

  (defun (setf node-children) (children elem)
    (setf (CDR elem) children)
    (node-children elem))

but, at the same time,

  (defun node-children (elem)
    (CDDR elem))

which results in the first child being lost.

Attached is a patch to fix this issue.

Sincerely,
 - B. Smilga.

Hi,

serve-file method doesn't expose content-disposition parameter. Is
that intentional?.

I was looking at how to serve static content with ucw and found
serve-file.  Unfortunately it assumes that content disposition is
"attachment" and doesn't provide a way for one to specify an
alternative.

It was easy to change it, so that it could be used as:

(serve-file (make-pathname ...)
            :content-disposition "inline"
            :content-type "text/html; charset=\"...\"")

but I'm wondering whether there is a reason or it's only a matter of
unintentional omission.

Is "attachment" really the preferred way to serve static content,
especially for html files? I tried using
static-roots-application-mixin and was surprised to see download
dialog opening.

Regards,
Anton

Hi,

Before anything else I have a "management" question. As I'll be doing
(mostly trivial for now) changes so it would be useful to know about the
policy here. What do you prefer to ask/discuss on this list before
changing anything or directly send patches?

This time I'll ask:

* Is there any reason in-application is not exported?

  In protocol.lisp there is a macro in-application but it is not
  exported. IMHO it could be useful in client code as it will
  eliminate the need to specify :application argument in
  defentry-point.

  Any objections about exporting it?

* Is *ucw-applications-directory* in vars.lisp needed?

  I don't think this variable is actually used. Any reason to keep it?

* Is *ucw-systems* in vars.lisp needed?
 
  Same as *ucw-applications-directory*

* How about changing default value fo create-server :application argument?

- (applications *ucw-applications*)
+ (applications (or *ucw-applications* '(*default-application*))

  So than one could write:

  (in-application (make-instance 'demo-application))

  (create-server)

  rather than
 
  (create-server :applications '(*default-application*))

  Or maybe changing in-application
  (pushnew *default-application* *ucw-applications*)

Kind regards,
Anton