Faré | 2 Sep 2011 21:19
Picon
Gravatar

Issues with script.test.sh

I tried to run script.test.sh (that tests the --script functionality)
on Linux to a pipe (to tee). It failed miserably at the "--script exit
status from QUIT when stdout closed" test, because closing the stdout
fd causes the pipe to close which causes the process to abort. Ouch. I
tried to redirect to a file instead; this works on Linux. Now it fails
on MacOS X because the unix realpath function (from Apple's libc?)
loses as it returns /dev/fd/$(basename file) instead of the full path
to the file:

CL-USER> (sb-posix:open "/tmp/foo" #o10660)
6
CL-USER> (truename "/dev/fd/6")
#P"/dev/fd/foo"
CL-USER> (sb-posix:readlink "/dev/fd/6")
; Evaluation aborted on #<SB-POSIX:SYSCALL-ERROR {1004B507B1}>.
CL-USER> (describe (sb-posix:lstat "/dev/fd/6"))
#<SB-POSIX:STAT {1004CBC571}>
  [standard-object]

Slots with :INSTANCE allocation:
  MODE   = 33188
  INO    = 11613310
  DEV    = 120128676
  NLINK  = 1
  UID    = 132098
  GID    = 0
  SIZE   = 0
  RDEV   = 0
  ATIME  = 1314985242
  MTIME  = 1314985242
(Continue reading)

David Lichteblau | 2 Sep 2011 21:48
Gravatar

Re: Issues with script.test.sh

Quoting Far? (fahree <at> gmail.com):
> I tried to run script.test.sh (that tests the --script functionality)
> on Linux to a pipe (to tee). It failed miserably at the "--script exit
> status from QUIT when stdout closed" test, because closing the stdout
> fd causes the pipe to close which causes the process to abort. Ouch. I
> tried to redirect to a file instead; this works on Linux.
[...]

Thanks for the report.  Since "run-tests.sh | tee" is an important use
case to support, I have pushed a test fix for Linux.

d.

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
Faré | 2 Sep 2011 23:07
Picon
Gravatar

Re: Issues with script.test.sh

On Fri, Sep 2, 2011 at 15:48, David Lichteblau <david <at> lichteblau.com> wrote:
> Quoting Far? (fahree <at> gmail.com):
>> I tried to run script.test.sh (that tests the --script functionality)
>> on Linux to a pipe (to tee). It failed miserably at the "--script exit
>> status from QUIT when stdout closed" test, because closing the stdout
>> fd causes the pipe to close which causes the process to abort. Ouch. I
>> tried to redirect to a file instead; this works on Linux.
> [...]
>
> Thanks for the report.  Since "run-tests.sh | tee" is an important use
> case to support, I have pushed a test fix for Linux.
>
Your "fix" might work on Linux, but it breaks on MacOS X, because
realpath is broken on said platform. :-/
What about we disable the test on MacOS X or mark it as expected to fail?
What's the right way to do that?

—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Sbcl-devel mailing list
Sbcl-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel
(Continue reading)

Faré | 3 Sep 2011 00:00
Picon
Gravatar

Re: Simple testing patch

Here's a new version of my test fixes, as a formatted patch. Can a
committer review and/or apply?

Additionally, it allows one to test an SBCL installation (rather than
a SBCL being compiled in the source directory) by overriding
$SBCL_HOME, $SBCL_CORE and $SBCL_RUNTIME.

—♯ƒ • François-René ÐVB Rideau •Reflection&Cybernethics• http://fare.tunes.org
Attachment (0001-Minor-cleanups-of-some-tests.patch): application/octet-stream, 6633 bytes
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Sbcl-devel mailing list
Sbcl-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel
David Lichteblau | 3 Sep 2011 12:56
Gravatar

Re: Issues with script.test.sh

Hi Fare,

yes, my change made things fail more aggressively on MacOS.  I still
think it's the right change, because it makes the test less dependent on
the environment.  I also think that we need to add even more similar
tests, which would currently fail reliably on both Linux and MacOS.

After more testing:

Quoting Far? (fahree <at> gmail.com):
> Your "fix" might work on Linux, but it breaks on MacOS X, because
> realpath is broken on said platform. :-/

realpath does not work on Linux either -- not in the way SBCL needs it
to work, at least -- and not if we want to support use of files in /dev.

Conceptually, realpath does the right thing: Among other things, it
resolves symlinks.  In reality, that is not the right thing to do,
because there are symlinks in /dev which the kernel can open even though
their target is not a file name. 

On the SBCL side, the big issue is that OPEN does not call open(2).
Instead it non-atomically probes around in the file system.  Let's for
the moment assume that the CL spec requires such scary behaviour...
Among other things, it uses PROBE-FILE, which tries to return a
truename.  PROBE-FILE calls realpath and fails with NIL, even though
open(2) would have succeeded.  Consequently, OPEN errors out -- rather
pointlessly, since it had already used stat() to confirm that the file
exist.

(Continue reading)

Lutz Euler | 3 Sep 2011 19:56
Picon
Favicon

Patch: Handle prefix instructions in the disassembler

Hi,

since this mail is not short, first the motivation:
Nicer disassembler output, shorter source code, smaller core.

There is a FIXME in "src/compiler/x86[-64]/insts.lisp" at the
instruction definition of LOCK: "It would be better to make the
disassembler understand the prefix as part of the instructions...".

This is addressed herewith, but I didn't want to do it in the same way
as REX etc. are currently treated, as that would have meant to double
the number of printer clauses of all relevant instructions again (making
that eight for CMPXCHG on x86-64, for example). So instead I changed the
prefix implementation which allows both to make the disassembly of LOCK
and other prefixes look nicer, but also to treat REX and #x66 better
so that the already existing combinatorial explosion in the number of
printer clauses can be imploded back.

This removes much redundancy from the source code, cutting some 300
lines from "x86-64/insts.lisp", and reduces the core size by nearly
200 KB on x86-64 (and a little bit on x86, too).

Here are examples of the disassembler output changes:

Old (x86):

  ;      156:       64               FS-SEGMENT-PREFIX
  ;      157:       892D5C000000     MOV [#x5C], EBP

New:
(Continue reading)

Max Mikhanosha | 3 Sep 2011 20:43

[PATCH] Fix (run-program) to cleanup fd handlers

RUN-PROGRAM fails to clean-up the handler that it added with
ADD-FD-HANDLER if it exits due to error rather then EOF.

So when user does RUN-PROGRAM with a stream that encounters any
encoding errors or such, any subsequent RUN-PROGRAM's are hosed
because of a stale FD handler left in the *descriptor-handlers*

Attached patch fixes it, and adds a test case. This fixes the bug that
user dsp_ was describing on #lisp with pdfinfo output on a barf.pdf
file.


------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Sbcl-devel mailing list
Sbcl-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel
Elliott Slaughter | 5 Sep 2011 00:16
Picon
Gravatar

Re: freeze for 1.0.51

Windows binary is finally up; loads and runs lispbuilder-sdl fine.


As usual, please commit the following to sbcl-page (or give me access so I can do it myself):

diff --git a/platform-support-platforms.lisp b/platform-support-platforms.lisp
old mode 100644
new mode 100755
index a38abc7..a568a38
--- a/platform-support-platforms.lisp
+++ b/platform-support-platforms.lisp
<at> <at> -48,5 +48,5 <at> <at>
 (define-port :x86-64 :openbsd :available "1.0.50" :os-version 49)
 (define-port :powerpc :openbsd :available "1.0.50" :os-version 49)

-(define-port :x86 :windows :in-progress "1.0.50" :file-type "msi")
+(define-port :x86 :windows :in-progress "1.0.51" :file-type "msi")
 (define-port :x86-64 :windows :in-progress)


On Sun, Aug 28, 2011 at 1:59 PM, Gabriel Dos Reis <gdr <at> integrable-solutions.net> wrote:
On Sun, Aug 28, 2011 at 3:18 PM, Aleksej Saushev <asau <at> inbox.ru> wrote:
> In fact, I wish tests weren't run unless explicitly asked.

Seconded.  (That used to be the case.)

------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Sbcl-devel mailing list
Sbcl-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel



--
Elliott Slaughter

"Don't worry about what anybody else is going to do. The best way to predict the future is to invent it." - Alan Kay
------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Sbcl-devel mailing list
Sbcl-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sbcl-devel
Josh Elsasser | 5 Sep 2011 03:16
Favicon
Gravatar

Re: freeze for 1.0.51

Page updated, thanks.

On Sun, Sep 04, 2011 at 03:16:49PM -0700, Elliott Slaughter wrote:
> Windows binary is finally up; loads and runs lispbuilder-sdl fine.
> 
> As usual, please commit the following to sbcl-page (or give me access so I
> can do it myself):
> 
> diff --git a/platform-support-platforms.lisp
> b/platform-support-platforms.lisp
> old mode 100644
> new mode 100755
> index a38abc7..a568a38
> --- a/platform-support-platforms.lisp
> +++ b/platform-support-platforms.lisp
>  <at>  <at>  -48,5 +48,5  <at>  <at> 
>  (define-port :x86-64 :openbsd :available "1.0.50" :os-version 49)
>  (define-port :powerpc :openbsd :available "1.0.50" :os-version 49)
> 
> -(define-port :x86 :windows :in-progress "1.0.50" :file-type "msi")
> +(define-port :x86 :windows :in-progress "1.0.51" :file-type "msi")
>  (define-port :x86-64 :windows :in-progress)
> 
> 
> On Sun, Aug 28, 2011 at 1:59 PM, Gabriel Dos Reis <
> gdr <at> integrable-solutions.net> wrote:
> 
> > On Sun, Aug 28, 2011 at 3:18 PM, Aleksej Saushev <asau <at> inbox.ru> wrote:
> > > In fact, I wish tests weren't run unless explicitly asked.
> >
> > Seconded.  (That used to be the case.)
> >
> >
> > ------------------------------------------------------------------------------
> > EMC VNX: the world's simplest storage, starting under $10K
> > The only unified storage solution that offers unified management
> > Up to 160% more powerful than alternatives and 25% more efficient.
> > Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
> > _______________________________________________
> > Sbcl-devel mailing list
> > Sbcl-devel <at> lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/sbcl-devel
> >
> 
> 
> 
> -- 
> Elliott Slaughter
> 
> "Don't worry about what anybody else is going to do. The best way to predict
> the future is to invent it." - Alan Kay

> ------------------------------------------------------------------------------
> Special Offer -- Download ArcSight Logger for FREE!
> Finally, a world-class log management solution at an even better 
> price-free! And you'll get a free "Love Thy Logs" t-shirt when you
> download Logger. Secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsisghtdev2dev

> _______________________________________________
> Sbcl-devel mailing list
> Sbcl-devel <at> lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/sbcl-devel

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
Josh Elsasser | 5 Sep 2011 04:21
Favicon
Gravatar

RSS feed for sbcl.org

Someone mentioned in #sbcl how it would be nice if the website had an
RSS feed for news updates. I hacked something together quickly in
sbcl-page to do it, but I don't use RSS so I don't really know how
this looks to someone who does.

Anyone have any criticisms or objections? Would anyone actually find
this useful? Diff for sbcl-page is attached, and a test copy of the
site is up at http://www.elsasser.org/misc/sbcl-page-rss

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev

Gmane