bug in scheme_connect in network1.c

Since `s48_extract_unsigned_integer' may cause a garbage collection,
because it calls back to Scheme, the extraction of the host and port
in the internet address case must be GC-protected, around line 110.  A
patch to fix this is attached.

*** network1.c	17 Feb 2003 11:05:26 -0500	1.33
--- network1.c	01 Dec 2006 00:08:22 -0500	
***************
*** 353,361 ****
--- 353,367 ----
      case AF_INET:
        {
  	struct sockaddr_in name;
+ 
+         S48_DECLARE_GC_PROTECT (1);
+         S48_GC_PROTECT_1 (scheme_name);
+ 
  	u_long  addr = htonl (s48_extract_unsigned_integer (S48_CAR (scheme_name)));
  	u_short port = htons(s48_extract_fixnum (S48_CDR (scheme_name)));

+         S48_GC_UNPROTECT ();
+ 
  	memset(&name, 0, sizeof(name));

  	name.sin_family=AF_INET;

Orion WM -- Error: wrong number of arguments

[SourceForge.net Team] SUBJECT: SourceForge.net: CVS service offering changes

Dear scsh hackers,

as you can learn from the attached e-mail the name of the CVS server
for scsh has changed to scsh.cvs.sourceforge.net. Please update your
working copies accordingly.

From: SourceForge.net Team <noreply <at> sourceforge.net>
Subject: SUBJECT: SourceForge.net: CVS service offering changes
Date: 2006-05-11 23:16:38 GMT

Greetings,

You are receiving this mail because you are a project admin for
a SourceForge.net-hosted project. One of our primary services,
CVS, suffered a series of interrelated, critical hardware failures
in recent weeks. We understand how frustrating this CVS outage
must be to you and your users; however, our top priority remains
preservation of the integrity of your data.

The series of CVS hardware failures prompted us to expedite the
deployment of planed improvements to our CVS infrastructure,
drawing upon much of the knowledge that we gained from our
Subversion deployment. Our improved CVS service architecture,
which we plan to deploy tomorrow afternoon (2006-05-12), will
offer greater performance and stability and will eliminate several
single points of failure.

The Site Status page (https://www.sf.net/docs/A04) will be
updated as soon as the new infrastructure is rolled out. In the
interim, please read the important information provided below
to learn about how these changes will affect your project.

Summary of changes, effective 2006-05-12:

1. Hostname for CVS service

Old: cvs.sourceforge.net

New: PROJECT_UNIX_NAME.cvs.sourceforge.net

This change will require new working copies to be checked out of all
repositories (so control files in the working copy will point to the
right place). We will be updating the instructions we supply, but
instructions that your team has written within documentation, etc. will
need to be updated.

cvs -d:pserver:anonymous <at> cvs.sourceforge.net:/cvsroot/gaim co gaim

would be changed to

cvs -d:pserver:anonymous <at> gaim.cvs.sourceforge.net:/cvsroot/gaim co gaim

2. ViewCVS

We are moving from ViewCVS to its successor, ViewVC. ViewVC is
currently in use for our Subversion service.

3. Sync delay

Old: CVS pserver, tarballs and ViewCVS provided against a separate
server which is a minimum of three hours behind developer CVS.

New: ViewVC will be provided against developer CVS (it will be current).
CVS pserver will be provided against a secondary server (not developer
server) with a maximum expected delay of two hours.

Follow-up work is planned (this infrastructure takes us 80% of the way)
to essentially eliminate the sync delay.

4. Read-only rsync service

As a new service offering, we are now providing read-only rsync access
against developer CVS. This allows projects to efficiently make
on-demand backups of their entire CVS repository.

All projects should be making regular backups of their CVS repository
contents using this service.

5. Nightly tarball service

Nightly tarball service is being dropped in lieu of read-only rsync
service. Projects which currently depend on nightly tarballs for
repository backups will need to begin using rsync to make a backup copy
of their repository contents.

We see this as a major functional improvement. For a number of reasons,
tarballs have fallen out of sync with the data in the repository at
times in the past few years. Tarballs required a substantial amount of
additional disk, and I/O to generate. The move to read-only rsync
allows backups to be produced on-demand, with an update frequency chosen
by the project.

6. Points of failure

In the past, developer CVS service for all projects was provided from a
single host. CVS pserver service was provided from individual backend
heads based on a split of the data.

Under our new design, developer CVS and most of our CVS-related services
are provided from one of ten CVS hosts (count subject to increase with
growth). Each host is independent, and makes a backup copy of the
repository data of another host (which is used to provide the pserver
CVS service).

Failure of a single host will impact only the availability of data on
that host. Since the data is split among a larger number of hosts, the
size of data impacted by an individual host outage is substantially
smaller, and the time required for us to restore service will be
substantially shorter.

This rapid architecture change has been made possible specifically using
the research we performed for our recent launch of Subversion service.
We've applied our best practices, produced a substantial amount of
internal documentation, and kept an eye toward maintainability.
This effort has allowed us to deploy this new architecture quickly
once hardware was received, and will permit us to quickly scale
this service horizontally as growth and demand requires. 

Many other minor improvements have also been made to improve the service
offering and make it less trouble-prone. The most important of which are
listed above. For a full description of the new service offering, and
for information on how to use the services described above, please refer
to the site documentation for the CVS service after the service has been
launched: https://www.sf.net/docs/E04

Thank you,

The SourceForge.net Team 

.

--

-- 
Martin

scsh 0.6.7 RC 2

I've created a new release candidate for scsh 0.6.7 available at

ftp://ftp.scsh.net/pub/scsh/0.6/scsh-0.6.7-rc2.tar.gz

I haven't been able to fix the behavior of the regular expression
facility reported on some NetBSD and Cygwin installations and the
problem of FILE-INFO reported by Matthew Swank. I hope to have fixed
FORK-PTY-SESSION for Solaris and RUN/COLLECTING, and included new
versions of config.guess/sub.

It would be great if you could test the new RC using the test suite
and your own scripts.

--

-- 
Martin

scsh 0.6.7 RC 1

Dear scsh hackers,

I've created a first release candidate for scsh 0.6.7. It's available from 

<ftp://ftp.scsh.net/pub/scsh/0.6/scsh-0.6.7.tar.gz>

The new release comes with an extended test suite which you can run in
the source tree as

./go -lm scsh/test/test-packages.scm -o test-all -c "(test-all)"

Please test the RC and tell me about your experiences!

--

-- 
Martin

Minor bug with match:substring

I think this is a bug in match:substring.  I revised my code to work
around
it, so this is just for your information, I am not looking for a fix.

scsh manual says
   match:substring returns the substring matched regexp's submatch. If
   there was no match for the indexed submatch, it returns false.

But this code
   (match:substring
     (string-match
        (posix-string-≥regexp "Job <(.*)> is submitted")
        ""
         )
     1)

Returns this error
   Error: exception
          (record-ref #f 0)

Regards, John

[ scsh-Bugs-1063781 ] rx-choice doesn't create char-sets

Bugs item #1063781, was opened at 11/10/04 04:51
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1063781&group_id=10493

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: run-time
Group: None
>Status: Closed
Resolution: Duplicate
Priority: 5
Submitted By: Martin Gasbichler (mainzelm)
Assigned to: Mike Sperber (sperber)
Summary: rx-choice doesn't create char-sets

Initial Comment:

 (rx (| numeric alphabetic)) yields a char-set: but 
(rx (| ,(rx numeric) ,(rx alphabetic))) doesn't:, even
though the "type-checking rules" for char-sets says
that it should:

> (rx (| numeric alphabetic))
'#{re-char-set}
> (rx (| ,(rx numeric) ,(rx alphabetic))) 
'#{Re-choice}

The following patch fixes this but I'm not sure if
make-re-choice is the right place to tackle this problem:

Index: re.scm
===================================================================
RCS file: /cvsroot/scsh/scsh/scsh/rx/re.scm,v
retrieving revision 1.8
diff -u -c -r1.8 re.scm
*** re.scm	30 Oct 2002 12:33:51 -0000	1.8
--- re.scm	10 Nov 2004 12:48:25 -0000
***************
*** 133,146 ****
    (really-make-re-choice elts tsm (new-cre posix-str
tvec)))

  (define (make-re-choice res)
!   (make-re-choice/tsm res
! 		      (fold (lambda (re sm-count)
! 			   (let ((maybe-tsm (re-tsm re)))
! 			     (if (and (number? maybe-tsm)
! 				      (number? sm-count))
! 				 (+ maybe-tsm sm-count)
! 				 (unspecific))))
! 			    0 res)))

  ;;; Slightly smart choice constructor:
  ;;; - Flattens nested choices
--- 133,148 ----
    (really-make-re-choice elts tsm (new-cre posix-str
tvec)))

  (define (make-re-choice res)
!   (if (every re-char-set? res)
!       (make-re-char-set (apply char-set-union (map
re-char-set:cset res)))
!       (make-re-choice/tsm res
!                           (fold (lambda (re sm-count)
!                                   (let ((maybe-tsm
(re-tsm re)))
!                                     (if (and (number?
maybe-tsm)
!                                              (number?
sm-count))
!                                         (+ maybe-tsm
sm-count)
!                                         (unspecific))))
!                                 0 res))))

  ;;; Slightly smart choice constructor:
  ;;; - Flattens nested choices

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 11/01/05 19:20

Message:
Logged In: YES 
user_id=1312539

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Martin Gasbichler (mainzelm)
Date: 10/18/05 07:05

Message:
Logged In: YES 
user_id=17553

I've committed the above patch to CVS. It will be in 0.6.7.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1063781&group_id=10493

[ scsh-Bugs-1194281 ] scsh cannot be build with gcc 4.0

Bugs item #1194281, was opened at 2005-05-03 10:04
Message generated for change (Comment added) made by mainzelm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1194281&group_id=10493

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: build
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Christoph Bauer (fridolin)
>Assigned to: Martin Gasbichler (mainzelm)
Summary: scsh cannot be build with gcc 4.0

Initial Comment:
here is the error message:

c/unix/io.c: In function 'ps_write_integer':
c/unix/io.c:154: error: invalid storage class for 
function 'write_integer'
c/unix/io.c: At top level:
c/unix/io.c:171: error: conflicting types for 'write_integer'
c/unix/io.c:160: error: previous implicit declaration 
of 'write_integer' was here

OS: IRIX64

----------------------------------------------------------------------

>Comment By: Martin Gasbichler (mainzelm)
Date: 2005-10-27 09:56

Message:
Logged In: YES 
user_id=17553

Fixed as suggested by  schoinobates.

--
Martin

----------------------------------------------------------------------

Comment By: Schoinobates Volans (schoinobates)
Date: 2005-08-23 17:29

Message:
Logged In: YES 
user_id=41822

Bug as been reproduced under Debian GNU/Linux i386 and
sparc. Here's a patch. It is also available as a download in
a file from http://bugs.debian.org/324576

diff -rN -u old-scsh-0.6-0.6.6/c/unix/io.c
new-scsh-0.6-0.6.6/c/unix/io.c
--- old-scsh-0.6-0.6.6/c/unix/io.c	2005-08-23
14:38:58.000000000 +0200
+++ new-scsh-0.6-0.6.6/c/unix/io.c	2005-08-23
14:14:49.000000000 +0200
@@ -146,13 +146,27 @@
       return 0; }
 }

+static long
+write_integer(unsigned long n, FILE *port)
+{
+  char ch;
+  long status;
+
+  if (n == 0)
+    status = 0;
+  else {
+    status = write_integer(n / 10, port);
+    if (status == 0) {
+      ch = (n % 10) + '0';
+      WRITE_CHAR(ch, port,status); } }
+  return status;
+}
+
 long
 ps_write_integer(long n, FILE *port)
 {
   int status;

-  static long write_integer(unsigned long n, FILE *port);
-
   if (n == 0) {
     WRITE_CHAR('0', port, status);
     return status; }
@@ -166,22 +180,6 @@
       return status; }
 }

-static long
-write_integer(unsigned long n, FILE *port)
-{
-  char ch;
-  long status;
-
-  if (n == 0)
-    status = 0;
-  else {
-    status = write_integer(n / 10, port);
-    if (status == 0) {
-      ch = (n % 10) + '0';
-      WRITE_CHAR(ch, port,status); } }
-  return status;
-}
-
 long
 ps_write_string(char *string, FILE *port)
 {

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1194281&group_id=10493

[ scsh-Bugs-1017609 ] read-delimited with character predicate

Bugs item #1017609, was opened at 2004-08-27 16:12
Message generated for change (Settings changed) made by mainzelm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1017609&group_id=10493

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: hetz (chetz)
Assigned to: Martin Gasbichler (mainzelm)
Summary: read-delimited with character predicate

Initial Comment:
In section 7 of the manual it says,
that the char-set argument from

(read-delimited char-set [port handle-delim])

could be a character predicate, but:

13> (read-delimited char-digit?)

Error: ->char-set: Not a charset, string or char.
       #{Procedure 14381 (char-digit? in char-predicates-
lib)}
14> 

----------------------------------------------------------------------

>Comment By: Martin Gasbichler (mainzelm)
Date: 2005-10-18 17:07

Message:
Logged In: YES 
user_id=17553

I fixed the manual because SRFI-14's x->char-set does not
accept char predicates either.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1017609&group_id=10493

[ scsh-Bugs-1017625 ] read-delimited! -> heap overflow

Bugs item #1017625, was opened at 2004-08-27 16:26
Message generated for change (Settings changed) made by mainzelm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1017625&group_id=10493

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: run-time
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: hetz (chetz)
Assigned to: Martin Gasbichler (mainzelm)
Summary: read-delimited! -> heap overflow

Initial Comment:
The read-delimited! function from  section 7 of the 
manual has the following strange behavior:

calling it as follows

14> (define buffer "abcdefghi")
14> (read-delimited! "abc" buffer)

it returns, iff the first sign written is an 'a' a 'b', or a 'c'.
if the first sign is not a sign from the char-set argument
("abc") it won't return at all, but exits the scsh after a 
few seconds by  a heap overflow.

14> (define buffer "abcdefghi")
14> (read-delimited! "abc" buffer)
x
Scheme48 heap overflow

Process scheme exited abnormally with code 255

----------------------------------------------------------------------

>Comment By: Martin Gasbichler (mainzelm)
Date: 2005-10-18 16:58

Message:
Logged In: YES 
user_id=17553

The buffer in the example is immutable but
(%)read-delimited! failed to reject it in the first place.

Fixed

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110493&aid=1017625&group_id=10493

(usagi-users 03517) Porting SUnet to s48; network API convergance

Hi!

Since I'd like to be able to run SUnet on Scheme48, I have wondered
what the best way would be to achive this; here are excerpts of my
exchange with Michael Sperber:

,----
| Andreas Rottmann <ar <at> visotech.at> writes:
|
| > [...] These ideas and patches are all somewhat related to the effort
| > of porting scsh to Scheme48. I'm also interested in details on that,
| > since I want to have SUnet available for Scheme48 and that would
| > mean porting some scsh libraries/infrastructure. Could you please
| > point me to information on the porting process, so I can get
| > involved?
| 
| That's a handful of questions.  I'm not sure I can answer all of them
| well:
| 
| The general plan with scsh and Scheme 48 is to clean up the scsh APIs
| one by one.  The network API is high on that list, and indeed running
| SUnet on Scheme 48 is among our plans.  For that to happen, what we
| need to do is overhaul the scsh networking API---to clean it up, and
| to fit better with Scheme 48 conventions.  First and foremost, that
| means turning the enumerations into finite types, I think.  The best
| way to do it is probably to make the changes on the scsh trunk, and,
| when the code is ready there, merge it over.  (We also have plans to
| coordinate the network API with the PLT people, but that's probably a
| bit further off.)  So, if you want to help, submitting patches to scsh
| (coordinating with the scsh-hackers list) would probably be the
| appropriate first step.
`----

So, as a first step, I'm posting this here as a heads-up, and to ask
wether any efforts in that direction have already been undertaken or
are planned. FWIW, I've created an GNU Arch archive corresponding to
the scsh CVS trunk, and will branch from that, since CVS
branching/merging is mostly unusable. As Michael Sperber already
indicated, a first change will be converting the network constants
(e.g. protocol-family/*) to finite types. Since currently these
constants are hardcoded to match the constants used in the
corresponding C API, my idea was to have a platform-specific mapping
procedure, e.g. PROTOCOL-FAMILY-≥OS-INTEGER, that maps the finite type
instances to their C constant counterparts.

Of course these changes will break backwards compatibility, hence code
using the network API must be adapted or the old interface
retained. I'd like to know the stance of the scsh hackers on that one,
as well as how to coordinate with the SUnet hackers to get SUnet moved
to the new API.

Also, I would be grateful if I could get more details wrt. the
coordination with the PLT people.

Cheers, Rotty
--

-- 
Andreas Rottmann         | Rotty <at> ICQ      | 118634484 <at> ICQ | a.rottmann <at> gmx.at
http://yi.org/rotty      | GnuPG Key: http://yi.org/rotty/gpg.asc
Fingerprint              | DFB4 4EB4 78A4 5EEE 6219  F228 F92F CFC5 01FD 5B62
v2sw7MYChw5pr5OFma7u7Lw2m5g/l7Di6e6t5BSb7en6g3/5HZa2Xs6MSr1/2p7 hackerkey.com

Python is executable pseudocode, Perl is executable line-noise.