Win32/MinGW port

Hi,

compiling guile-core-1.8-20061001 under MinGW fails with the following
error message:
---
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -g -O2 -Wall
-Wmissing-prototypes -W
error -MT libguile_la-scmsigs.lo -MD -MP -MF
.deps/libguile_la-scmsigs.Tpo -c sc
msigs.c  -DDLL_EXPORT -DPIC -o .libs/libguile_la-scmsigs.o
scmsigs.c: In function `signal_delivery_thread':
scmsigs.c:156: warning: implicit declaration of function `sigfillset'
scmsigs.c:157: warning: implicit declaration of function `pthread_sigmask'
scmsigs.c: In function `start_signal_delivery_thread':
scmsigs.c:182: warning: implicit declaration of function `pipe'
make[3]: *** [libguile_la-scmsigs.lo] Error 1
make[3]: Leaving directory `/home/guile-core-1.8-20061001/libguile'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/guile-core-1.8-20061001/libguile'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/guile-core-1.8-20061001'
make: *** [all] Error 2
---

After removing do_read_without_guile(), read_without_guile,
signal_delivery_thread() and the content of
start_signal_delivery_thread() from scmsigs.c, the build process fails
at threads.c:
---
 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -g -O2 -Wall

guile-1.8.0 configure error

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: guile-1.8.0 configure error

"Weinstein, Jay P" <jay.p.weinstein <at> intel.com> writes:
>
> It can't find pthread libs in /usr/lib. See config.log

Looks like "-pthread" succeeded.  Did something not work?

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Win32/MinGW port

Nils Durner <ndurner <at> web.de> writes:
>
> scmsigs.c:157: warning: implicit declaration of function `pthread_sigmask'

Does it have pthreads?  Did you ask for them, or did configure wrongly
decide to use them?

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Copyright years on the Guile Web page

Yoni Rabkin Katzenell <yoni-r <at> actcom.com> writes:
>
> The years 2003, 2004 and 2006 are missing from the list.

Thanks, I added 2006 to changed pages.  (A year only gets added when
there's an actual change.)

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: (apply make-vector '(1 2 3))

The case of no args was also not caught (passed through to the 2o
func).  I made this change,

        * eval.c (SCM_APPLY): For scm_tc7_subr_2o, throw wrong-num-args on 0
        arguments or 3 or more arguments.  Previously 0 called proc with
        SCM_UNDEFINED, and 3 or more silently used just the first 2.

--- eval.c.~1.405.2.5.~	2006-07-21 10:22:22.000000000 +1000
+++ eval.c	2006-10-02 12:18:26.000000000 +1000
 <at>  <at>  -4849,7 +4849,16  <at>  <at> 
   switch (SCM_TYP7 (proc))
     {
     case scm_tc7_subr_2o:
-      args = scm_is_null (args) ? SCM_UNDEFINED : SCM_CAR (args);
+      if (SCM_UNBNDP (arg1))
+	scm_wrong_num_args (proc);
+      if (scm_is_null (args))
+        args = SCM_UNDEFINED;
+      else
+        {
+          if (! scm_is_null (SCM_CDR (args)))
+            scm_wrong_num_args (proc);
+          args = SCM_CAR (args);
+        }
       RETURN (SCM_SUBRF (proc) (arg1, args));
     case scm_tc7_subr_2:
       if (scm_is_null (args) || !scm_is_null (SCM_CDR (args)))

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Win32/MinGW port

>> scmsigs.c:157: warning: implicit declaration of function
>> `pthread_sigmask'
>
> Does it have pthreads?
Yes, but some functions are not supported by pthreads-w32.

> Did you ask for them, or did configure wrongly
> decide to use them?
No, I didn't ask.

    Nils

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Win32/MinGW port

Nils Durner <ndurner <at> web.de> writes:
>
> Yes, but some functions are not supported by pthreads-w32.

How bad are the missing bits?  Should configure reject it because
there's no pthread_sigmask, or is there something the code can do to
cope?

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Win32/MinGW port

> How bad are the missing bits?
It's not too bad. pthreads-win32 is fairly complete and working.
The mentioned functions are missing because Windows lacks the concept of
signals altogether.

> Should configure reject it because
> there's no pthread_sigmask, or is there something the code can do to
> cope?
As there are no signals on Win32, I *think* it is okay to just "ifndef
MINGW" the code.

Regarding the undefined "pipe()":
the easiest thing to do would be to define pipe() in the following way:

    #include <fcntl.h>
    #define pipe(f) _pipe(f, 1000, _O_BINARY)

_pipe() takes two additional parameters: size in bytes and file mode.
Note that these pipes are blocking.

Nils

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile

Re: Win32/MinGW port

Nils Durner <ndurner <at> web.de> writes:
>
> As there are no signals on Win32, I *think* it is okay to just "ifndef
> MINGW" the code.

That might be worth trying.  (But not with ifdef mingw, rather a test
for missing funcs or features.  There's already been mingw-specific
conditionals that became bogus because missing bits have since been
added to the system.)

>     #include <fcntl.h>
>     #define pipe(f) _pipe(f, 1000, _O_BINARY)

Yep, we've got that in another file.  It might be worth sticking in
_scm.h to get it everywhere.

_______________________________________________
Bug-guile mailing list
Bug-guile <at> gnu.org
http://lists.gnu.org/mailman/listinfo/bug-guile