New Drakma release 1.2.2

There's a new release of Drakma out at weitz.de.  This is a bugfix release.

ChangeLog: http://weitz.de/drakma/CHANGELOG.txt

Patch: Unclosed <code> node in doc/index.html

Patch attached.

An unclosed <code> node in doc/index.html causes all text after the 
documentation for *allow-dotless-cookie-domains-p* to render in a 
monospaced font.

This is my first patch ever, so let me know if I did it wrong.

Thanks,

Walter

--

-- 
The Online Slang Dictionary - Now a wiki!
http://onlineslangdictionary.com/

_______________________________________________
drakma-devel mailing list
drakma-devel <at> common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel

Re: Patch: Unclosed <code> node in doc/index.html

Thanks for the patch, I've fixed this in the repository and on the
website.  Will be in the next release.

(It seems, Firefox doesn't have a problem with this glitch, though.)

On Mon, Jul 12, 2010 at 1:29 AM, Walter GR <waltergr <at> aol.com> wrote:
> Patch attached.
>
> An unclosed <code> node in doc/index.html causes all text after the
> documentation for *allow-dotless-cookie-domains-p* to render in a monospaced
> font.
>
> This is my first patch ever, so let me know if I did it wrong.
>
> Thanks,
>
> Walter
>
>
> --
> The Online Slang Dictionary - Now a wiki!
> http://onlineslangdictionary.com/
>
> _______________________________________________
> drakma-devel mailing list
> drakma-devel <at> common-lisp.net
> http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
>
>

Re: Patch: Unclosed <code> node in doc/index.html

 > (It seems, Firefox doesn't have a problem with this glitch, though.)

I was remiss in not mentioning: I'm using Chrome 5 on XP.  Apple Safari 
uses the same rendering engine, but I don't have an installation handy 
to test on.

Walter

On 7/12/2010 1:46 PM, Edi Weitz wrote:
> Thanks for the patch, I've fixed this in the repository and on the
> website.  Will be in the next release.
>
> (It seems, Firefox doesn't have a problem with this glitch, though.)
>
> On Mon, Jul 12, 2010 at 1:29 AM, Walter GR<waltergr <at> aol.com>  wrote:
>>  Patch attached.
>>
>>  An unclosed<code>  node in doc/index.html causes all text after the
>>  documentation for *allow-dotless-cookie-domains-p* to render in a monospaced
>>  font.
>>
>>  This is my first patch ever, so let me know if I did it wrong.
>>
>>  Thanks,
>>
>>  Walter
>>
>>
>>  --
>>  The Online Slang Dictionary - Now a wiki!

Regarding URL encoding...

Although I understand why it's not done by default, it seems slightly
odd to me that Drakma doesn't provide a URL-ENCODE function whereas
Hunchentoot does. I would've thought the need was considerably more
immediate in Drakma...

With greetings,
  Herbert Snorrason

Re: Regarding URL encoding...

On 21 July 2010 13:28, Herbert Snorrason <methanal <at> gmail.com> wrote:
> [...] Drakma doesn't provide a URL-ENCODE function [...]
And after thinking about it, turns out it _does_, just doesn't expose
it. The thinking is, I presume, that all URL-encoded data should pass
through another interface that handles the cleaning?

In any case, the attached patch updates url-encode to RFC3986 (or at
least only passes that standard's "unreserved characters" through) and
exposes it.

With greetings,
  Herbert Snorrason

_______________________________________________
drakma-devel mailing list
drakma-devel <at> common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel

Re: Regarding URL encoding...

On Wed, Jul 21, 2010 at 11:46 AM, Herbert Snorrason <methanal <at> gmail.com> wrote:
> In any case, the attached patch updates url-encode to RFC3986 (or at
> least only passes that standard's "unreserved characters" through) and
> exposes it.

I suspect that the original portions of

-                        (find char "$-_.!*'()," :test #'char=))
+                        (find char "-_.~" :test #'char=))
                      (write-char char out))
-                   ((char= char #\Space)
-                     (write-char #\+ out))

are based on RFC 1738's more restricted list of characters:

   Thus, only alphanumerics, the special characters "$-_.+!*'(),", and
   reserved characters used for their reserved purposes may be used
   unencoded within a URL. [1]

Since request parameters (which could include URIs) might appear in
the HTTP request's URL, the parameters need to be URL encoded, not
just composed of valid URI characters.

[1] http://www.rfc-editor.org/rfc/rfc1738.txt

//JT

--

-- 
Joshua Taylor, http://www.cs.rpi.edu/~tayloj/

Re: duplicate cookies problem with proposed patch

_______________________________________________
drakma-devel mailing list
drakma-devel <at> common-lisp.net
http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel