11 Apr 2013 10:49
3 Apr 2013 23:55
REMOVE CACHES: r14460 changes FASL entry point name
Hi all,
Commits between r14456 and r14460 change the FASL entry point name. Everybody tracking trunk will need to blow their caches away.
Bye,
Erik.
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
3 Apr 2013 23:50
Patch for ASDF2.26.32 to support concatenated fasls for ABCL
Hi!
In order for these commands to generate a fasl per ASDF system, I had to apply the patch below to ASDF.
$ ./abcl
CL-USER(1): :ld c:/users/erik/quicklisp/setup
CL-USER(2): (ql:quickload :bordeaux-threads)
CL-USER(3): (asdf:oos 'asdf:binary-op :bordeax-threads)
The commands above work with current trunk (r14460) and produces 2 concatenated fasls in my cache directory: 1 for alexandria and 1 for bordeaux-threads.
This patch is required (also attached, to prevent line wrapping):
diff --git a/bundle.lisp b/bundle.lisp
index 568f894..24fbf90 100644
--- a/bundle.lisp
+++ b/bundle.lisp
<at> <at> -185,7 +185,7 <at> <at>
(or #+ecl (or (equalp type (compile-file-type :type :object))
(equalp type (compile-file-type :type :static-library)))
#+mkcl (equalp type (compile-file-type :fasl-p nil))
- #+(or allegro clisp clozure cmu lispworks sbcl scl xcl) (equalp type (compile-file-type)))))
+ #+(or abcl allegro clisp clozure cmu lispworks sbcl scl xcl) (equalp type (compile-file-type)))))
(defgeneric* (trivial-system-p) (component))
diff --git a/uiop/lisp-build.lisp b/uiop/lisp-build.lisp
index e2e376d..4b7e819 100644
--- a/uiop/lisp-build.lisp
+++ b/uiop/lisp-build.lisp
<at> <at> -669,11 +669,12 <at> <at> it will filter them appropriately."
;;; Links FASLs together
(with-upgradability ()
(defun combine-fasls (inputs output)
- #-(or allegro clisp clozure cmu lispworks sbcl scl xcl)
+ #-(or abcl allegro clisp clozure cmu lispworks sbcl scl xcl)
(error "~A does not support ~S~%inputs ~S~%output ~S"
(implementation-type) 'combine-fasls inputs output)
#+clozure (ccl:fasl-concatenate output inputs :if-exists :supersede)
#+(or allegro clisp cmu sbcl scl xcl) (concatenate-files inputs output)
+ #+abcl (sys:concatenate-fasls inputs output)
#+lispworks
(let (fasls)
(unwind-protect
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
3 Apr 2013 22:39
Support for concatenated fasls
Hi!
As we discussed, I'd write FASL concatenation support for ABCL. I'm nearly done, however I'm running into a snag caused by ASDF:
Normally, a file "package.lisp" is compiled into a fasl "package.abcl" which is basically a zip with at least one entry: "package._". The "._" file contains instructions for loading the fasl and may contain references to other files in the same zip.
My FASL concatenation code currently uses the assumption that the "._" file has exactly the same name as the enclosing package. However, FASLs generated using ASDF violate that assumption: the ._ file in the fasl isn't called "package._" but it's called "package-ASDF_TMP._".
How does ABCL know about the suffix when ASDF is loading the FASL "package.abcl" with the suffixed file in it in the regular situation?
Bye,
Erik.
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
2 Apr 2013 21:40
Other findings (was Re: Questions about r14452 (Fix cl-cont))
Well, to some extent I can see your problem. Indeed there seem to be no slots in the 'MOP:FUNCALLABLE-STANDARD-OBJECT class. The layoutFuncallableStandardClass is what confused me, but that's indeed the layout of the metaclass.So, you're correct that the fix works by accident. The solution should be to add a slot by the name 'MOP::NAME to the FUNCALLABLE-STANDARD-OBJECT. That slot can contain the name of the object (ie function) for which the item is defined. In that case, we should probably remove the direct slot MOP::NAME on the standard generic function, since it's already defined on the superclass if we decide to do that.
While studying this problem using DESCRIBE, it seems our current implementation dispatches (DESCRIBE (MAKE-INSTANCE 'CL-CONT::FUNCALLABLE/CC)) the wrong way: to the T way instead of the STANDARD-OBJECT way...
Yet more to investigate...
Bye,
Erik.
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
2 Apr 2013 20:08
Re: Questions about r14452 (Fix cl-cont)
What makes me suspicious is the output of
(describe (make-instance 'funcallable-standard-object))
vs
(describe (make-instance 'standard-generic-function))
.
There's a layout called layoutFuncallableStandardClass, defined in StandardClass.java, which has NAME as first slot, but that's for class objects with metaclass funcallable-standard-class, not for instances of these classes. I'll think a bit in the next days and try to either resolve my doubts or come up with another fix for the problem. Maybe I'm simply confused; wouldn't be the first time. :)
Rudi
On Apr 2, 2013, at 19:52, Erik Huelsmann <ehuels-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
Hi Rudi,
Basically the expectation we violated was the fact that %set-lambda-name didn't want to take a funcallable instance as its function argument. The commit changed that and used the first slot of the funcallable instance class layout (called NAME) to store the name. I guess we forget to finalize the class somewhere, so the spots don't appear?
Bye,
Erik.
sent from my phoneOn Apr 2, 2013 7:32 PM, "Rudolf Schlatte" <rudi-4eUIStHq6WvhYHbOoDrFzw@public.gmane.org> wrote:Hi,
I suspect that the changes in commit r14452 only work by accident.
The definions of SLOT_INDEX_NAME in FuncallableStandardClass vs FuncallableStandardObject are no problem, since the latter simply isn't used anywhere. But the new methods getName() and setName() assume that a) the FuncallableStandardObject instance has at least one slot, and b) that slot holds a name. Since
(class-slots (find-class 'funcallable-standard-object))
returns NIL, these assumptions hold only when the objects are in fact generic functions.
Amusingly,
(function-lambda-expression (make-instance 'funcallable-standard-object))
runs into the type error on line 2666 of Primitives.lisp ("The value #<FUNCALLABLE-STANDARD-OBJECT {665C5A83}> is not of type FUNCTION.") even though
(typep (make-instance 'funcallable-standard-object) 'function) => T
so I can't trigger the array-out-of-bounds error right now.
Could I have a recipe for triggering the bug? I'd like to see how cl-cont uses funcallable-standard-objects, and what expectations we violate. I believe I can fix this properly.
Cheers,
Rudi
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
2 Apr 2013 19:55
Re: Questions about r14452 (Fix cl-cont)
Forgot to mention: Pre 14452 it was enough to just quickload cl-cont to trigger the bug.
Bye, Erik
sent from my phone
On Apr 2, 2013 7:52 PM, "Erik Huelsmann" <ehuels-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
Hi Rudi,
Basically the expectation we violated was the fact that %set-lambda-name didn't want to take a funcallable instance as its function argument. The commit changed that and used the first slot of the funcallable instance class layout (called NAME) to store the name. I guess we forget to finalize the class somewhere, so the spots don't appear?
Bye,
Erik.
sent from my phoneOn Apr 2, 2013 7:32 PM, "Rudolf Schlatte" <rudi <at> constantly.at> wrote:Hi,
I suspect that the changes in commit r14452 only work by accident.
The definions of SLOT_INDEX_NAME in FuncallableStandardClass vs FuncallableStandardObject are no problem, since the latter simply isn't used anywhere. But the new methods getName() and setName() assume that a) the FuncallableStandardObject instance has at least one slot, and b) that slot holds a name. Since
(class-slots (find-class 'funcallable-standard-object))
returns NIL, these assumptions hold only when the objects are in fact generic functions.
Amusingly,
(function-lambda-expression (make-instance 'funcallable-standard-object))
runs into the type error on line 2666 of Primitives.lisp ("The value #<FUNCALLABLE-STANDARD-OBJECT {665C5A83}> is not of type FUNCTION.") even though
(typep (make-instance 'funcallable-standard-object) 'function) => T
so I can't trigger the array-out-of-bounds error right now.
Could I have a recipe for triggering the bug? I'd like to see how cl-cont uses funcallable-standard-objects, and what expectations we violate. I believe I can fix this properly.
Cheers,
Rudi
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
2 Apr 2013 19:52
Fwd: Re: Questions about r14452 (Fix cl-cont)
sent from my phone
---------- Forwarded message ----------
From: ehuels-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Date: Apr 2, 2013 7:51 PM
Subject: Re: Questions about r14452 (Fix cl-cont)
To: Rudolf Schlatte <rudi-4eUIStHq6WvhYHbOoDrFzw@public.gmane.org>
Cc:
From: ehuels-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Date: Apr 2, 2013 7:51 PM
Subject: Re: Questions about r14452 (Fix cl-cont)
To: Rudolf Schlatte <rudi-4eUIStHq6WvhYHbOoDrFzw@public.gmane.org>
Cc:
Hi Rudi,
Basically the expectation we violated was the fact that %set-lambda-name didn't want to take a funcallable instance as its function argument. The commit changed that and used the first slot of the funcallable instance class layout (called NAME) to store the name. I guess we forget to finalize the class somewhere, so the spots don't appear?
Bye,
Erik.
sent from my phoneOn Apr 2, 2013 7:32 PM, "Rudolf Schlatte" <rudi-4eUIStHq6WvhYHbOoDrFzw@public.gmane.org> wrote:Hi,
I suspect that the changes in commit r14452 only work by accident.
The definions of SLOT_INDEX_NAME in FuncallableStandardClass vs FuncallableStandardObject are no problem, since the latter simply isn't used anywhere. But the new methods getName() and setName() assume that a) the FuncallableStandardObject instance has at least one slot, and b) that slot holds a name. Since
(class-slots (find-class 'funcallable-standard-object))
returns NIL, these assumptions hold only when the objects are in fact generic functions.
Amusingly,
(function-lambda-expression (make-instance 'funcallable-standard-object))
runs into the type error on line 2666 of Primitives.lisp ("The value #<FUNCALLABLE-STANDARD-OBJECT {665C5A83}> is not of type FUNCTION.") even though
(typep (make-instance 'funcallable-standard-object) 'function) => T
so I can't trigger the array-out-of-bounds error right now.
Could I have a recipe for triggering the bug? I'd like to see how cl-cont uses funcallable-standard-objects, and what expectations we violate. I believe I can fix this properly.
Cheers,
Rudi
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
2 Apr 2013 19:32
Questions about r14452 (Fix cl-cont)
Hi,
I suspect that the changes in commit r14452 only work by accident.
The definions of SLOT_INDEX_NAME in FuncallableStandardClass vs FuncallableStandardObject are no
problem, since the latter simply isn't used anywhere. But the new methods getName() and setName() assume
that a) the FuncallableStandardObject instance has at least one slot, and b) that slot holds a name. Since
(class-slots (find-class 'funcallable-standard-object))
returns NIL, these assumptions hold only when the objects are in fact generic functions.
Amusingly,
(function-lambda-expression (make-instance 'funcallable-standard-object))
runs into the type error on line 2666 of Primitives.lisp ("The value #<FUNCALLABLE-STANDARD-OBJECT
{665C5A83}> is not of type FUNCTION.") even though
(typep (make-instance 'funcallable-standard-object) 'function) => T
so I can't trigger the array-out-of-bounds error right now.
Could I have a recipe for triggering the bug? I'd like to see how cl-cont uses
funcallable-standard-objects, and what expectations we violate. I believe I can fix this properly.
Cheers,
Rudi
1 Apr 2013 14:15
ASDF-JAR vs ASDF3 deployment support
Hi all,
Some years ago, Mark wrote ASDF-JAR; a solution to package ASDF systems and their dependencies in JARs.
As it turns out, the solution chosen has some problems with correctly packaging ASDs for systems which use the #. reader macro. As an example: bordeaux-threads uses a version.lisp-sexp file to canonically define the version number and the system definition reads that file in a #. form. However, this file isn't packaged because it's not part of the file listing in the system definition. This means asdf can't load the definition after deployment.
With the advent of ASDF3, its developers have created infrastructure to combine fasls of a single system and even fasls of a system and all its dependencies into a single large combined FASL. Among others, this new infrastructure does not run into the issue ASDF-JAR is running into. While not completely equivalent to the JAR solution, using this infrastructure would help us a huge step along that way of getting better deployment. My current thinking is that if the single-packed-FASL needs to end up as a jar, we can work on that as a next step.
The first step to take would be to create "concatenate fasls" functionality, which would do the following:
* Detect all the file entries in all the passed-in fasls
* Create a new output zip file with directories for each fasl being packed, populated with the files and directories of that fasl
* create a toplevel ._ file which loads the sub-fasls' ._ files
Comments?
Bye,
Erik.
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
31 Mar 2013 21:39
Using ASDF/BUNDLE for ABCL
Hi,
Bye,
Some time ago Mark Evenson created ASDF-JAR on ABCL. It has some issues packaging ASD files which uses #. syntax to read e.g. version files (version.lisp-sexp) such as bordeaux-threads does.
We know ECL started hooking into the ASDF/BUNDLE machinery for ASDF to overcome problems like these. Could you help me/us out and explain how we can plug ABCL into the same machinery? From what I've seen, it's most efficient if the resulting code be committed to ASDF. That's fine by me. At this point, I'd just be happy with an explanation on how to do the hooking up: the new ASDF/BUNDLE functionality doesn't seem to be documented in the manual yet.
Thanks for any help you may be able to provide!
Bye,
Erik.
_______________________________________________ armedbear-devel mailing list armedbear-devel@... http://lists.common-lisp.net/cgi-bin/mailman/listinfo/armedbear-devel
RSS Feed