Re: ATi Remote key repeat
Oliver Endriss <o.endriss <at> gmx.de>
2006-07-02 19:07:55 GMT
Chris Jones wrote:
> Hi
>
> On Wed, 2006-06-28 at 01:28 +0200, Oliver Endriss wrote:
> > Please try the evtest tool from the dvb-apps package and
> > post its output for a short key press and for a long one.
>
> Here is the output. I pressed the play button in both cases:
>
> cmsj <at> tenshu:~$ evtest /dev/input/event4
> Input driver version is 1.0.0
> Input device ID: bus 0x3 vendor 0xbc7 product 0x4 version 0x100
> Input device name: "X10 Wireless Technology Inc USB Receiver"
> Supported events:
> Event type 0 (Reset)
> Event code 0 (Reset)
> Event code 1 (Key)
> Event code 2 (Relative)
> ...
> Testing ... (interrupt to exit)
> Event: time 1151653959.792243, type 1 (Key), code 207 (?), value 1
> Event: time 1151653959.792246, type 1 (Key), code 207 (?), value 0
> Event: time 1151653959.792248, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653959.880230, type 1 (Key), code 207 (?), value 1
> Event: time 1151653959.880233, type 1 (Key), code 207 (?), value 0
> Event: time 1151653959.880235, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653959.928229, type 1 (Key), code 207 (?), value 1
> Event: time 1151653959.928232, type 1 (Key), code 207 (?), value 0
> Event: time 1151653959.928234, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653959.976214, type 1 (Key), code 207 (?), value 1
> Event: time 1151653959.976218, type 1 (Key), code 207 (?), value 0
> Event: time 1151653959.976220, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653964.559472, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.559476, type 1 (Key), code 207 (?), value 0
> Event: time 1151653964.559478, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653964.607473, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.607477, type 1 (Key), code 207 (?), value 0
> Event: time 1151653964.607479, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653964.743449, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.743453, type 1 (Key), code 207 (?), value 0
> Event: time 1151653964.743455, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653964.791438, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.791443, type 1 (Key), code 207 (?), value 0
> Event: time 1151653964.791445, type 0 (Reset), code 0 (Reset), value 0
> ...
> Event: time 1151653965.991242, type 1 (Key), code 207 (?), value 1
> Event: time 1151653965.991246, type 1 (Key), code 207 (?), value 0
> Event: time 1151653965.991248, type 0 (Reset), code 0 (Reset), value 0
> Event: time 1151653966.039234, type 1 (Key), code 207 (?), value 1
> Event: time 1151653966.039237, type 1 (Key), code 207 (?), value 0
> Event: time 1151653966.039239, type 0 (Reset), code 0 (Reset), value 0
This driver is terribly broken! Key repeat does not work correctly.
A correct driver would send for a single short press:
> Event: time 1151653964.791438, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.791443, type 1 (Key), code 207 (?), value 0
For a long press:
> Event: time 1151653964.559472, type 1 (Key), code 207 (?), value 1
> Event: time 1151653964.607473, type 1 (Key), code 207 (?), value 2
> ...
> Event: time 1151653964.743449, type 1 (Key), code 207 (?), value 2
> Event: time 1151653964.743453, type 1 (Key), code 207 (?), value 0
I omitted Reset events, as I don't know what they are used for.
Reset events seem to be ok. The keyboard driver generates them, too.
There is a bug in the remote plugin. It misinterprets Reset as a key
release. Reset should be ignored. Please try the attached patch.
Oliver
--
--
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------
_______________________________________________
vdr mailing list
vdr <at> linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr