Greg KH | 26 Mar 13:31 2014

Re: move ZTE CDMA device pid from zte_ev back to option.c

On Wed, Mar 26, 2014 at 05:05:07PM +0800, liu.lei78@... wrote:
> 
> dear linuxfoundation:
>     There have two question in the patch.

Plese don't send html email, the mailing list drops your emails :(

> Qestion 1: Move ZTE CDMA device pid fffe from zte_ev.c to option.c
> ZTE device pid of fffe can't connection when drops ppp connection every minute.
> There is normal when we move the pid to option。
> 
> Qestion 2: Modify the parameter from 0x0003 to 0x0000.
> the problem may cause the device can not be closed, when we send 0x22 0x21
> 0x0003 in close serial ports.
> It must send 0x22 0x21 0x0000, We have checked Qualcomm document.

So, which one do you want to do?  You are modifying both in your patch
below, should I take both of these?

> 
> 
> 
> Signed-off-by:lei liu<liu.lei78@...>
> diff -u -r drivers-old/usb/serial/option.c drivers/usb/serial/option.c
> --- drivers-old/usb/serial/option.c        2014-03-24 12:45:42.000000000 +0800
> +++ drivers/usb/serial/option.c        2014-03-26 15:13:02.232956251 +0800
>  <at>  <at>  -1462,6 +1462,7  <at>  <at> 
>          { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff92, 0xff, 0xff,
> 0xff) },
>          { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0xff93, 0xff, 0xff,
(Continue reading)

Roger Quadros | 26 Mar 10:28 2014
Picon

[PATCH] usb: gadget: zero: Fix SuperSpeed enumeration for alternate setting 1

It was impossible to enumerate on a SuperSpeed (XHCI) host
with alternate setting = 1 due to the wrongly set 'bMaxBurst'
field in the SuperSpeed Endpoint Companion descriptor.

Testcase:
<host> modprobe -r usbtest; modprobe usbtest alt=1
<device> modprobe g_zero
plug device to SuperSpeed port on the host.

Without this patch the host always complains like so
"usb 12-2: Not enough bandwidth for new device state.
 usb 12-2: Not enough bandwidth for altsetting 1"

Bug was introduced by commit cf9a08ae in v3.9

Cc: 3.9+ <stable@...> # 3.9+
Cc: Sebastian Andrzej Siewior <bigeasy@...>
Reviewed-by: Felipe Balbi <balbi@...>
Signed-off-by: Roger Quadros <rogerq@...>
---
 drivers/usb/gadget/zero.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/zero.c b/drivers/usb/gadget/zero.c
index 9f170c5..134f354 100644
--- a/drivers/usb/gadget/zero.c
+++ b/drivers/usb/gadget/zero.c
 <at>  <at>  -300,7 +300,7  <at>  <at>  static int __init zero_bind(struct usb_composite_dev *cdev)
 	ss_opts->isoc_interval = gzero_options.isoc_interval;
 	ss_opts->isoc_maxpacket = gzero_options.isoc_maxpacket;
(Continue reading)

Jack Pham | 25 Mar 22:11 2014

[PATCH] usb: dwc3: gadget: Iterate only over valid endpoints

Make dwc3_gadget_resize_tx_fifos() iterate only over IN
endpoints that are actually present, based on the
num_in_eps parameter. This terminates the loop so as to
prevent dereferencing a potential NULL dwc->eps[i] where
i >= (num_in_eps + num_out_eps).

Change-Id: I07f711bfd380dce212e86b59cf417f84ca7eb006
Signed-off-by: Jack Pham <jackp@...>
---
Hi Felipe,

This was found when testing on a virtual simulation platform in
which the DWC3 IP was configured with only a handful of endpoints
as opposed to 32. Do you think this is worthy of cc:stable?

Thanks,
Jack

 drivers/usb/dwc3/gadget.c |   11 +++--------
 1 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index a740eac..258eee6 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
 <at>  <at>  -187,15 +187,11  <at>  <at>  int dwc3_gadget_resize_tx_fifos(struct dwc3 *dwc)
 	 * improve this algorithm so that we better use the internal
 	 * FIFO space
 	 */
-	for (num = 0; num < DWC3_ENDPOINTS_NUM; num++) {
(Continue reading)

Alexander Stein | 25 Mar 10:34 2014

[PATCH] cdc-acm: Remove Motorola/Telit H24 serial interfaces from ACM driver

From: Michael Ulbricht <michael.ulbricht@...>

By specifying NO_UNION_NORMAL the ACM driver does only use the first two
USB interfaces (modem data & control). The AT Port, Diagnostic and NMEA
interfaces are left to the USB serial driver.

Signed-off-by: Michael Ulbricht <michael.ulbricht@...>
Signed-off-by: Alexander Stein <alexander.stein@...>
---
 drivers/usb/class/cdc-acm.c | 28 +++++++++++++++++++++-------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 900f7ff..7783aca 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
 <at>  <at>  -1652,13 +1652,27  <at>  <at>  static const struct usb_device_id acm_ids[] = {
 	},
 	/* Motorola H24 HSPA module: */
 	{ USB_DEVICE(0x22b8, 0x2d91) }, /* modem                                */
-	{ USB_DEVICE(0x22b8, 0x2d92) }, /* modem           + diagnostics        */
-	{ USB_DEVICE(0x22b8, 0x2d93) }, /* modem + AT port                      */
-	{ USB_DEVICE(0x22b8, 0x2d95) }, /* modem + AT port + diagnostics        */
-	{ USB_DEVICE(0x22b8, 0x2d96) }, /* modem                         + NMEA */
-	{ USB_DEVICE(0x22b8, 0x2d97) }, /* modem           + diagnostics + NMEA */
-	{ USB_DEVICE(0x22b8, 0x2d99) }, /* modem + AT port               + NMEA */
-	{ USB_DEVICE(0x22b8, 0x2d9a) }, /* modem + AT port + diagnostics + NMEA */
+	{ USB_DEVICE(0x22b8, 0x2d92),   /* modem           + diagnostics        */
+	.driver_info = NO_UNION_NORMAL, /* handle only modem interface          */
+	},
(Continue reading)

Alexander Stein | 25 Mar 10:34 2014

[PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

As the module does not use the standard USB mechanism, the appropriate
product and vendor IDs have to be added.

Signed-off-by: Michael Ulbricht <michael.ulbricht@...>
Signed-off-by: Alexander Stein <alexander.stein@...>
---
 drivers/usb/serial/usb-serial-simple.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
index fb79775..b25e552 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
 <at>  <at>  -61,7 +61,17  <at>  <at>  DEVICE(vivopay, VIVOPAY_IDS);
 	{ USB_DEVICE(0x0c44, 0x0022) },	/* unknown Mororola phone */	\
 	{ USB_DEVICE(0x22b8, 0x2a64) },	/* Motorola KRZR K1m */		\
 	{ USB_DEVICE(0x22b8, 0x2c84) },	/* Motorola VE240 phone */	\
-	{ USB_DEVICE(0x22b8, 0x2c64) }	/* Motorola V950 phone */
+	{ USB_DEVICE(0x22b8, 0x2c64) },	/* Motorola V950 phone */	\
+	{ USB_DEVICE(0x22b8, 0x2d94) },	/* Motorola H24 HSPA module (                  Diagnostic       ) */	\
+	{ USB_DEVICE(0x22b8, 0x2d9B) },	/* Motorola H24 HSPA module (                               NMEA) */	\
+	{ USB_DEVICE(0x22b8, 0x2d93) },	/* Motorola H24 HSPA module (Modem + AT Port                    ) */	\
+	{ USB_DEVICE(0x22b8, 0x2d92) },	/* Motorola H24 HSPA module (Modem           + Diagnostic       ) */	\
+	{ USB_DEVICE(0x22b8, 0x2d96) },	/* Motorola H24 HSPA module (Modem                        + NMEA) */	\
+	{ USB_DEVICE(0x22b8, 0x2d98) },	/* Motorola H24 HSPA module (                  Diagnostic + NMEA) */	\
+	{ USB_DEVICE(0x22b8, 0x2d95) },	/* Motorola H24 HSPA module (Modem + AT Port + Diagnostic       ) */	\
+	{ USB_DEVICE(0x22b8, 0x2d99) },	/* Motorola H24 HSPA module (Modem + AT Port              + NMEA) */	\
+	{ USB_DEVICE(0x22b8, 0x2d97) },	/* Motorola H24 HSPA module (Modem           + Diagnostic + NMEA) */	\
+	{ USB_DEVICE(0x22b8, 0x2d9A) }	/* Motorola H24 HSPA module (Modem + AT Port + Diagnostic + NMEA) */
 DEVICE(moto_modem, MOTO_IDS);
(Continue reading)

Fabio Estevam | 25 Mar 03:55 2014
Picon

[PATCH v2] chipidea: usbmisc_imx: Allow USB OTG to work on mx51

From: Fabio Estevam <fabio.estevam@...>

The field PLLDIVVALUE of register PHY_CTRL_1 selects the reference clock source
for the PHY:
00 = sysclock uses 19.2 MHz
01 = sysclock uses 24 MHz
10 = sysclock uses 26 MHz
11 = sysclock uses 27 MHz

The reset value for this field is 10 according to the reference manual, and
even though this reset value works for mx53, it does not work for mx51.

So instead of relying on the reset value for the PLLDIVVALUE field, explicitly
set it to 01 so that a 24MHz clock can be selected for the PHY and allowing both
mx51 and mx53 to have USB OTG port functional.

Succesfully tested 'g_ether' on a imx51-babbage and on a imx53-qsb boards.

Signed-off-by: Fabio Estevam <fabio.estevam@...>
---
Changes since v1:
- The reset value for PLLDIVVALUE is 10, not 01.

 drivers/usb/chipidea/usbmisc_imx.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index cd061ab..f6c4f3c 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
(Continue reading)

Fabio Estevam | 25 Mar 03:44 2014
Picon

[PATCH] chipidea: usbmisc_imx: Allow USB OTG to work on mx51

From: Fabio Estevam <fabio.estevam@...>

The field PLLDIVVALUE of register PHY_CTRL_1 selects the reference clock source
for the PHY:
00 = sysclock uses 19.2 MHz
01 = sysclock uses 24 MHz
10 = sysclock uses 26 MHz
11 = sysclock uses 27 MHz

The reset value for this field is 01 according to the reference manual, but
inspecting the register on mx51 showed that this does not happen.

So instead of relying on the reset value for the PLLDIVVALUE field, explicitly
set it to 01, so that both mx51 and mx53 can have USB OTG functional.

Succesfully tested 'g_ether' on a imx51-babbage and on a imx53-qsb boards.

Signed-off-by: Fabio Estevam <fabio.estevam@...>
---
 drivers/usb/chipidea/usbmisc_imx.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
index cd061ab..f6c4f3c 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
 <at>  <at>  -26,11 +26,14  <at>  <at> 
 #define MX27_OTG_PM_BIT			BIT(24)

 #define MX53_USB_OTG_PHY_CTRL_0_OFFSET	0x08
(Continue reading)

Sarah Sharp | 25 Mar 00:14 2014
Picon

Re: USB3.0 is not getting detected sometimes

On Mon, Mar 24, 2014 at 02:17:37PM -0700, Abhay kumar wrote:
> Thanks Sarah..
> 
> I did further investigation on this figured out that When the host tries to
> disable the LPM U1 and U2 state of USB 3 device by sending
> command "usb_control_msg" it is getting timed out as the device is not
> responding and after that we get timeout error --110 and then followed by
> usb 2-1: Disable of device-initiated U1 failed.
> 
> I am trying now to plug an external powered USB hard disk to see if this is
> power/signal problem. Any suggestion?

Please send the output of `sudo lspci -vvv` and `sudo lspci -vvv -n`.
I'm seeing a disturbing pattern where specific Ivy Bridge systems (C210
systems) have Link PM failures.  Not sure if that's because we aren't
programming the U1/U2 timeouts correctly, or if those systems simply
don't support Link PM at all.

Can you blacklist the usb-storage driver, and then send the output of
`sudo lsusb -v` with the USB 3.0 device plugged in?

Sarah Sharp

> 
> Regards,
> Abhay Kumar
> 
> 
> 
> On Sun, Mar 23, 2014 at 9:48 AM, Sarah Sharp
(Continue reading)

lornaderek | 24 Mar 16:51 2014
Picon

Vantec NST-280S3 (external HDD enclosure on JMicron JMS539) various troubles

https://bugzilla.kernel.org/show_bug.cgi?id=72761

This enclosure (with Hitachi 1Tb HDD inside in my case) have troubles with Gigabyte GA-H81M-HD3 USB3.0 ports.
This MB has additional USB3.0 controller:
---------
Chipset:
     2 USB 3.0/2.0 ports (available through the internal USB header)
     6 USB 2.0/1.1 ports (2 ports on the back panel, 4 ports available through the internal USB headers)

VIA® VL805 chip:
     4 USB 3.0/2.0 ports on the back panel
--------

With kernel 3.11:
1.When I'm connecting Vantec to USB (chipset) it works but very unstable. It hangs and then disconnects
while copying files.
2.When I'm connecting it to VIA chip ports it seems to work fine.

With kernel 3.13.6 and 3.14-rc7
1.Same unstable behavior as in kernel 3.11 (with chipset USBs)
2.Do not works at all with VIA chip USBs.

Enclosure and HDD is healthy (SMART is ok and it works flawlessly on another PC). Other USB3.0 flash disk
(Silicon Power 32GB) works flawlessly on all ports.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Mike Sampson | 24 Mar 10:04 2014

[PATCH] next-20140324 drivers/staging/media/sn9c102/sn9c102_hv7131r.c fix style warnings flagged by checkpatch.pl.

Signed-off-by: Mike Sampson <mike@...>

---
 drivers/staging/media/sn9c102/sn9c102_hv7131r.c |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/media/sn9c102/sn9c102_hv7131r.c b/drivers/staging/media/sn9c102/sn9c102_hv7131r.c
index 26a9111..51b24e0 100644
--- a/drivers/staging/media/sn9c102/sn9c102_hv7131r.c
+++ b/drivers/staging/media/sn9c102/sn9c102_hv7131r.c
 <at>  <at>  -23,7 +23,7  <at>  <at> 
 #include "sn9c102_devtable.h"

 
-static int hv7131r_init(struct sn9c102_device* cam)
+static int hv7131r_init(struct sn9c102_device *cam)
 {
 	int err = 0;

 <at>  <at>  -137,8 +137,8  <at>  <at>  static int hv7131r_init(struct sn9c102_device* cam)
 }

 
-static int hv7131r_get_ctrl(struct sn9c102_device* cam,
-			    struct v4l2_control* ctrl)
+static int hv7131r_get_ctrl(struct sn9c102_device *cam,
+			    struct v4l2_control *ctrl)
 {
 	switch (ctrl->id) {
 	case V4L2_CID_GAIN:
(Continue reading)

Chris Cheng | 24 Mar 02:35 2014

Kernel trace when remove usb storage without umount

system kernel is 3.13.6, the origin issue is mount usb storage(3.0) on
usb3.0 port not smooth, i found the solve method is revert xhci.c
patch, here is the link :
https://lkml.org/lkml/2014/3/7/295

After i revert the patch, mount usb storage is fine.
But it takes some issue, here is test case :

Here is test case :
usb storage 2.0 remove from usb 3.0 port => kernel trace
usb storage 2.0 remove from usb 2.0 port => kernel trace
usb storage 3.0 remove from usb 3.0 port => kernel trace

Kernel trace message:

[224189.786719] usb 2-1: USB disconnect, device number 4
[224189.820934] ------------[ cut here ]------------
[224189.820949] WARNING: CPU: 3 PID: 14554 at fs/sysfs/group.c:214
sysfs_remove_group+0x37/0x69()
[224189.820953] sysfs group c1851c34 not found for kobject 'target7:0:0'
[224189.820956] Modules linked in: snd_hda_intel(F)
snd_hda_codec_via(F) snd_hda_codec(F) snd_hwdep(F) snd_pcm_oss(F)
snd_mixer_oss(F) snd_pcm(F) snd_seq_dummy(F) snd_page_alloc(F)
snd_seq_oss(F) snd_seq_midi_event(F) snd_seq(F) snd_timer(F)
snd_seq_device(F) snd(F) parport_pc(F) fan(F) ppdev(F) lp(F)
parport(F)
[224189.820985] CPU: 3 PID: 14554 Comm: umount Tainted: GF       W    3.13.6 #1
[224189.820988] Hardware name: LG CNS t180/t180, BIOS 1.11 03/21/2014
[224189.820991]  00000000 00000000 da877d98 c154fb31 c175e60a da877db0
c102e9f5 c112446b
(Continue reading)


Gmane