David Binderman | 10 Jul 16:45 2014
Picon

host/ohci-tmio.c:104: possible novice coding error ?

Hello there,

[linux-3.16-rc4/drivers/usb/host/ohci-tmio.c:104]: (warning) Redundant bitwise operation on 'pm'
in 'switch' statement. 'break;' missing?

    switch (ohci->num_ports) {
        default:
            dev_err(&dev->dev, "Unsupported amount of ports: %d\n", ohci->num_ports);
        case 3:
            pm |= CCR_PM_USBPW3;
        case 2:
            pm |= CCR_PM_USBPW2;
        case 1:
            pm |= CCR_PM_USBPW1;
    }

Suggest add missing breaks.

Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

David Binderman | 10 Jul 16:42 2014
Picon

gadget/net2272.c:2075: possible bad test ?

Hello there,

[linux-3.16-rc4/drivers/usb/gadget/net2272.c:2075]: (style) Boolean result is used in bitwise
operation. Clarify expression with parentheses.

    if (!intcsr & (1 << NET2272_PCI_IRQ)) {

Maybe the programmer intended

    if (!(intcsr & (1 << NET2272_PCI_IRQ))) {

Regards

David Binderman

 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hans de Goede | 10 Jul 13:17 2014
Picon

xhci error: Transfer event TRB DMA ptr not part of current TD

Hi Sarah, Matthias, et al,

I've been running a full Linux distro from an uas enclosure with a ssd
for testing purposes (mostly for testing the distro on different
hardware but also for uas testing).

While testing this on a Thinkpad T440s I noticed the error
from $subject happening exactly once in the log. This always happens
when initializing the uas disk enclosure with the ssd. This happens
with both 3.15 and 3.16-rc4.

I've run a battery of tests to try and pin this down, here is the
test matrix:

                         T440s (Ivy Bridge)   E6430 (Sandy Bridge)  Desktop (NEC)
Renesas uPD720231 + ssd:  FAIL (*)             OK                    OK (**)
ASM1053E + hdd         :  OK                   OK                    OK (**)
ASM1053E + ssd         :  OK                   OK                    OK (**)

*) Putting an USB-3 hub in between makes no difference
**) Tested with an USB-3 hub in between

Where FAIL means that the error shows up.

The 2 enclosures tested with are:
Renesas uPD720231: http://www.amazon.com/SEDNA-SE-EH-322-U-External-Enclosure-Support/dp/B00E0MLIVE
ASM1053E: http://plugable.com/products/usb3-sata-uasp1

The 3 xhci controllers tested with are:

(Continue reading)

Andrzej Pietrasiewicz | 10 Jul 12:30 2014

[PATCHv2] usb: gadget: composite: Provide a list of available functions

When gadgets are composed with configfs the user must know what are the
available function names. The names are parts of usb_f_*.ko
modules' aliases. If a function is compiled as a module, the information
can be found in modules.alias file. But if a function is compiled-in,
there is no way to know the function's name.

This patch adds a sysfs attribute in libcomposite's sys directory to
show functions which are already registered. Functions which are
compiled-in will be in this list as well.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...>
---
This time there should be no obvious mistakes: potential
buffer overrun is checked and THIS_MODULE is not dereferenced at all.
Tested with libcomposite compiled-in and modular.

v1..v2:
- changed the location in sysfs: usb_gadget class is added

 drivers/usb/gadget/configfs.c  | 25 +++++++++++++++++++++++++
 drivers/usb/gadget/functions.c | 25 +++++++++++++++++++++++++
 drivers/usb/gadget/u_f.h       |  2 ++
 3 files changed, 52 insertions(+)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index bcc2a62..358242a 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
 <at>  <at>  -1553,13 +1553,37  <at>  <at>  void unregister_gadget_item(struct config_item *item)
 }
(Continue reading)

Ulrich Hecht | 10 Jul 09:53 2014
Picon

[PATCH v2 0/2] ARM: shmobile: lager: USBHS callback elimination

Changes in v2:
- move phy handle to struct usbhs_priv
- add new default pipe type to driver
- remove pipe type from Lager board code

Ulrich Hecht (2):
  usb: renesas_usbhs: add R-Car Gen. 2 init and power control
  ARM: shmobile: lager: remove USBHS callbacks

 arch/arm/mach-shmobile/board-lager.c | 126 ++++-------------------------------
 drivers/usb/renesas_usbhs/Makefile   |   2 +-
 drivers/usb/renesas_usbhs/common.c   |  66 ++++++++++++++++--
 drivers/usb/renesas_usbhs/common.h   |   2 +
 drivers/usb/renesas_usbhs/rcar2.c    |  76 +++++++++++++++++++++
 drivers/usb/renesas_usbhs/rcar2.h    |   4 ++
 include/linux/usb/renesas_usbhs.h    |   6 ++
 7 files changed, 163 insertions(+), 119 deletions(-)
 create mode 100644 drivers/usb/renesas_usbhs/rcar2.c
 create mode 100644 drivers/usb/renesas_usbhs/rcar2.h

--

-- 
1.8.4.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Joonyoung Shim | 10 Jul 07:22 2014

[PATCH 1/2] usb: usb3503: add PM functions

The usb3503 needs to switch to standby mode while suspending and should
switch to hub mode when resumed. Also we can control clock on PM
function.

Signed-off-by: Joonyoung Shim <jy0922.shim@...>
---
 drivers/usb/misc/usb3503.c | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
index 652855b..47cb143 100644
--- a/drivers/usb/misc/usb3503.c
+++ b/drivers/usb/misc/usb3503.c
 <at>  <at>  -149,8 +149,6  <at>  <at>  static int usb3503_switch_mode(struct usb3503 *hub, enum usb3503_mode mode)

 	case USB3503_MODE_STANDBY:
 		usb3503_reset(hub, 0);
-
-		hub->mode = mode;
 		dev_info(dev, "switched to STANDBY mode\n");
 		break;

 <at>  <at>  -347,6 +345,37  <at>  <at>  static int usb3503_platform_probe(struct platform_device *pdev)
 	return usb3503_probe(hub);
 }

+#ifdef CONFIG_PM_SLEEP
+static int usb3503_i2c_suspend(struct device *dev)
+{
+	struct i2c_client *client = to_i2c_client(dev);
(Continue reading)

Tobias Klauser | 9 Jul 18:09 2014
Picon

[PATCH 0/2] usb: gadget: Introduce and use helper macro for usb_composite_driver boilerplate

Patch 1/2 introduces the module_usb_composite_driver helper macro (similar to
module_usb_driver and friends) which can be used to reduce
module_init/module_exit boilerplate for USB gadget composite drivers.

Patch 2/2 converts gadget drivers to use module_usb_composite_driver where
applicable.

Patches are against linux-next 20140709.

Tobias Klauser (2):
  usb: gadget: Add helper macro for usb_composite_driver boilerplate
  usb: gadget: Convert drivers to use module_usb_composite_driver()

 drivers/usb/gadget/acm_ms.c   | 14 ++------------
 drivers/usb/gadget/audio.c    | 12 +-----------
 drivers/usb/gadget/cdc2.c     | 14 ++------------
 drivers/usb/gadget/ether.c    | 14 ++------------
 drivers/usb/gadget/gmidi.c    | 13 +------------
 drivers/usb/gadget/multi.c    | 13 +------------
 drivers/usb/gadget/ncm.c      | 14 ++------------
 drivers/usb/gadget/nokia.c    | 12 +-----------
 drivers/usb/gadget/webcam.c   | 15 +--------------
 drivers/usb/gadget/zero.c     | 14 ++------------
 include/linux/usb/composite.h | 15 +++++++++++++++
 11 files changed, 30 insertions(+), 120 deletions(-)

--

-- 
2.0.1

--
(Continue reading)

Sven Geggus | 9 Jul 16:01 2014
Picon

pl2303: usb_serial_generic_read_bulk_callback - nonzero urb status: -71

Hello,

I have been using this particular device (on another machine with an older
kernel) for years without problems.

Unfortunately I ran into problems on my new machine with a 3.15.3 kernel now.

The device suddenly stopped working yesterday rendering the machine mostly
unusable and producing 18009814 messages/hour like this:

Jul  8 01:00:02 solar kernel: [126413.116875] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback
- nonzero urb status: -71
Jul  8 01:00:02 solar kernel: [126413.117068] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback
- nonzero urb status: -71
Jul  8 01:00:02 solar kernel: [126413.117294] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback
- nonzero urb status: -71

I was only able to re-vitalise the machine by re-plugging the device and it
started working again afterwards.

Any idea?

Regards

Sven

--

-- 
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety (Benjamin Franklin)

(Continue reading)

Johan Hovold | 9 Jul 15:14 2014

[GIT PULL] USB-serial fixes for v3.16-rc5

The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1:

  Linux 3.16-rc4 (2014-07-06 12:37:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-3.16-rc5

for you to fetch changes up to 3d28bd840b2d3981cd28caf5fe1df38f1344dd60:

  usb: option: Add ID for Telewell TW-LTE 4G v2 (2014-07-07 10:31:14 +0200)

----------------------------------------------------------------
USB-serial fixes for v3.16-rc5

Here are some USB-serial updates for v3.16-rc5 that add two new device IDs.

Signed-off-by: Johan Hovold <johan@...>

----------------------------------------------------------------
Andras Kovacs (1):
      USB: cp210x: add support for Corsair usb dongle

Bernd Wachter (1):
      usb: option: Add ID for Telewell TW-LTE 4G v2

 drivers/usb/serial/cp210x.c | 1 +
 drivers/usb/serial/option.c | 2 ++
 2 files changed, 3 insertions(+)

(Continue reading)

Andrzej Pietrasiewicz | 9 Jul 12:24 2014

[PATCH] usb: gadget: composite: Provide a list of available functions

When gadgets are composed with configfs the user must know what are the
available function names. The names are parts of usb_f_*.ko
modules' aliases. If a function is compiled as a module, the information
can be found in modules.alias file. But if a function is compiled-in,
there is no way to know the function's name.

This patch adds a sysfs attribute in libcomposite's sys directory to
show functions which are already registered. Functions which are
compiled-in will be in this list as well.

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@...>
---
 drivers/usb/gadget/configfs.c  | 24 ++++++++++++++++++++++++
 drivers/usb/gadget/functions.c | 19 +++++++++++++++++++
 drivers/usb/gadget/u_f.h       |  2 ++
 3 files changed, 45 insertions(+)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index bcc2a62..352571b 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
 <at>  <at>  -1553,13 +1553,36  <at>  <at>  void unregister_gadget_item(struct config_item *item)
 }
 EXPORT_SYMBOL_GPL(unregister_gadget_item);

+static ssize_t sysfs_func_list_show(struct module_attribute *ma,
+				    struct module_kobject *ko, char *buf)
+{
+	return usb_function_list_functions(buf, PAGE_SIZE);
+}
(Continue reading)

Andrzej Pietrasiewicz | 9 Jul 12:20 2014

[PATCHv4 0/3] OS descriptors in FunctionFS

OS String descriptor can be provided by using FunctionFS with configfs.
In order for FunctionFS to support Feature Descriptors, corresponding
Extended Compatibility and Extended Properties descriptors must be
passed to ep0. This series adds parsing the said descriptors and
setting up appropriate internal data structures.

Rebased onto Felipe's testing/next.

This is meant for 3.17.

v1..v2:
- changed confused naming of two existing functions
- OS descriptors proper implementation with fixes suggested by Michal;
thanks, Michal!

v2..v3:
- introduced helper functions for accessing particular locations within
a buffer holding extended properties
- fixes after Michal's second review; thanks Michal!

v3..v4:
- minor corrections pointed by Michal

Andrzej Pietrasiewicz (3):
  usb: gadget: f_fs: rename descriptor parsing functions
  usb: gadget: u_os_desc: helper functions for accessing ext prop buffer
  usb: gadget: f_fs: OS descriptors support

 drivers/usb/gadget/function/f_fs.c  | 348 ++++++++++++++++++++++++++++++++++--
 drivers/usb/gadget/function/u_fs.h  |   7 +
(Continue reading)


Gmane