Thomas Meyer | 14 Jul 13:45 2015
Picon

[PATCH v2] um: Switch clocksource to hrtimers

Switch the UML clocksource from interval timers to posix interval timers and
move to a monotonic timer.

This fixes suspend&resume related timer issues and improves network
performance
as TCP state machines are now fed with the correct time; also correct
QoS and
traffic shaping.

v2:
Fixed a hang in copy_context_skas0() by disabling signals.

Signed-off-by: Thomas Meyer <thomas <at> m3y3r.de>
---
 arch/um/Makefile                        |   2 +-
 arch/um/include/shared/os.h             |  15 +-
 arch/um/include/shared/skas/stub-data.h |   5 +-
 arch/um/include/shared/timer-internal.h |  13 ++
 arch/um/kernel/process.c                |   6 +-
 arch/um/kernel/skas/clone.c             |   5 -
 arch/um/kernel/skas/mmu.c               |   2 +
 arch/um/kernel/time.c                   |  80 +++++++----
 arch/um/os-Linux/internal.h             |   1 -
 arch/um/os-Linux/main.c                 |   6 +-
 arch/um/os-Linux/process.c              |   5 +
 arch/um/os-Linux/signal.c               |  35 +++--
 arch/um/os-Linux/skas/process.c         |  44 ++----
 arch/um/os-Linux/time.c                 | 248 ++++++++++++++++--------
--------
 14 files changed, 234 insertions(+), 233 deletions(-)
(Continue reading)

Toralf Förster | 13 Jul 17:56 2015
Picon
Picon

Re: linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

On 07/13/2015 05:46 PM, Geert Uytterhoeven wrote:
> For hotmail, port 465?
Ick - right, I use GMX, where tls works flawlessly (BTW I didn't specify the port in .gitconfig)

--

-- 
Toralf, pgp key: 872AE508 0076E94E

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
Thomas Meyer | 13 Jul 15:41 2015
Picon

uml_net zombie processes

Hi,

The uml_net network setup "fails" on my computer with:

[   15.930000] helper_wait : waitpid process 11673 failed, errno = 10
[   15.930000] * modprobe tun
               * ifconfig tap0 192.168.10.1 netmask 255.255.255.255 up
               * bash -c echo 1 > /proc/sys/net/ipv4/ip_forward
[   20.480000] helper_wait : waitpid process 11780 failed, errno = 10
[   20.480000] * route add -host 192.168.10.2 dev tap0
               * bash -c echo 1 >
/proc/sys/net/ipv4/conf/tap0/proxy_arp

because I run uml linux as a normal user and I guess these commands
fail, because of insufficient rights:
bash -c echo 1 > /proc/sys/net/ipv4/ip_forward
bash -c echo 1 > /proc/sys/net/ipv4/conf/tap0/proxy_arp

But this failure is okay for me, as firewalld, sets above options
correctly on my host computer.

The problem I see is that UML list two zombie processes:
  11780 root       20   0     0     0     0 Z  0.0  0.0  0:00.00 15:34 │  │     ├─ uml_net
  11673 root       20   0     0     0     0 Z  0.0  0.0  0:00.00 15:34 │  │     ├─ uml_net

UML seems to never reap those two processes, likely because of errno=10 exit code.

any idea how to fix this?

with kind regards
(Continue reading)

David Binderman | 13 Jul 11:08 2015
Picon

linux-4.2-rc2/arch/um/drivers/net_user.c:258: possible missing call to va_end ?

Hello there,

[linux-4.2-rc2/arch/um/drivers/net_user.c:258]: (error) va_list 'ap' was opened but not closed by va_end().

Source code is

    va_start(ap, str);
    while ((arg = va_arg(ap, char **)) != NULL) {
        if (*str == '\0')
            return NULL;
        end = strchr(str, ',');
        if (end != str)
            *arg = str;
        if (end == NULL)
            return NULL;
        *end++ = '\0';
        str = end;
    }
    va_end(ap);
    return str;

If va_end needs to be called for successful return, it probably also
needs to be called for NULL return (twice).

Regards

David Binderman

 		 	   		  
------------------------------------------------------------------------------
(Continue reading)

Hans-Werner Hilse | 26 Jun 10:36 2015
Picon

[PATCH] missed musl compatibility patch

I'm sorry but one patch that is necessary for compilation against
musl libc was still missing in the series I sent earlier.
(Thank you very much for applying!)

This is a bit awkward: It looked so nice and clean to just call
"modify_ldt()" before. The external declaration is a hint that not
all was well. Looking at modify_ldt(2), making the syscall via
syscall() ourselves is actually the recommended way, so I hope
it isn't too troublesome a patch.

Hans-Werner Hilse (1):
  um: Do not rely on libc to provide modify_ldt()

 arch/x86/um/ldt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--

-- 
2.4.3

------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors 
network devices and physical & virtual servers, alerts via email & sms 
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
Hans-Werner Hilse | 11 Jun 11:29 2015
Picon

[PATCH v2 0/3] musl compatibility patches

This set of patches facilitate compilation with the musl libc,
either linked to shared libraries or static.

Hans-Werner Hilse (3):
  um: Do not use __ptr_t type for stack_t's .ss pointer
  um: Do not use stdin and stdout identifiers for struct members
  um: Include sys/types.h for makedev(), major(), minor()

 arch/um/drivers/harddog_user.c         | 18 +++++++++---------
 arch/um/drivers/net_user.c             |  6 +++---
 arch/um/drivers/slip_user.c            | 14 +++++++-------
 arch/um/drivers/slirp_user.c           | 16 ++++++++--------
 arch/um/os-Linux/drivers/tuntap_user.c |  6 +++---
 arch/um/os-Linux/file.c                |  1 +
 arch/um/os-Linux/signal.c              |  8 +++++---
 7 files changed, 36 insertions(+), 33 deletions(-)

--

-- 
2.4.2

------------------------------------------------------------------------------
Richard Weinberger | 10 Jun 23:38 2015
Picon

Re: [PATCH 3/3] um: Include sys/types.h for makedev(), major(), minor()

On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse <hwhilse <at> gmail.com> wrote:
> The functions in question are not part of the POSIX standard,
> documentation however hints that the corresponding header shall
> be sys/types.h. C libraries other than glibc, namely musl, did
> not include that header via other ways and complained.

Makes sense. :-)

--

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Richard Weinberger | 10 Jun 23:37 2015
Picon

Re: [PATCH 2/3] um: Do not use stdin and stdout names for variables

On Wed, Jun 10, 2015 at 11:21 PM, Hans-Werner Hilse <hwhilse <at> gmail.com> wrote:
> Naming local variables "stdin" and "stdout" is fine with glibc,
> other C libraries, namely musl, will however complain.

Wait, what?!
These are not local variables, they are struct members.

What exactly is the issue with musl? Sounds very odd.

--

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Richard Weinberger | 10 Jun 23:35 2015
Picon

Re: [PATCH 1/3] um: Fallback when C library does not provide __ptr_t

On Wed, Jun 10, 2015 at 11:20 PM, Hans-Werner Hilse <hwhilse <at> gmail.com> wrote:
> Glibc provides __ptr_t for the pointer in the stack_t struct,
> but other C libraries - namely musl - do not necessarily do so.
> In that case, fall back to a void* pointer.

Please just kill __ptr_t in UML.

--

-- 
Thanks,
//richard

------------------------------------------------------------------------------
Hans-Werner Hilse | 10 Jun 23:23 2015
Picon

Re: [PATCH 1/3] um: Fallback when C library does not provide __ptr_t

Hi,

Am 2015-06-10 23:20, schrieb Hans-Werner Hilse:
[...]

This three-part patch series will allow to compile UML against the musl 
libc implementation - even statically.

Take it as a suggestion, but I think most things are quite sensible. The 
__ptr_t stuff is admittedly a bit ugly.

-hwh

------------------------------------------------------------------------------
Hans-Werner Hilse | 10 Jun 23:21 2015
Picon

[PATCH 3/3] um: Include sys/types.h for makedev(), major(), minor()

The functions in question are not part of the POSIX standard,
documentation however hints that the corresponding header shall
be sys/types.h. C libraries other than glibc, namely musl, did
not include that header via other ways and complained.

Signed-off-by: Hans-Werner Hilse <hwhilse <at> gmail.com>
---
  arch/um/os-Linux/file.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/um/os-Linux/file.c b/arch/um/os-Linux/file.c
index 08d90fb..26e0164 100644
--- a/arch/um/os-Linux/file.c
+++ b/arch/um/os-Linux/file.c
 <at>  <at>  -13,6 +13,7  <at>  <at> 
  #include <sys/socket.h>
  #include <sys/stat.h>
  #include <sys/un.h>
+#include <sys/types.h>
  #include <os.h>

  static void copy_stat(struct uml_stat *dst, const struct stat64 *src)
--

-- 
2.4.2

------------------------------------------------------------------------------

Gmane