[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

Kip <kip <at> thevertigo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andi.fischer <at> hispeed.ch

--

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

--- Comment #2 from Oliver Kellogg <okellogg users sourceforge net>  2011-07-01 17:13:47 ---
As a workaround, have you looked at
http://sourceforge.net/mailarchive/message.php?msg_id=25627567
?

--

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

KDE/kdesdk/umbrello/umbrello

SVN commit 1239070 by fischer:

Some tabs with spaces replaced.
Zoom-Fit enabled and implemented.
Zoom-Label added.

 M  +31 -1     uml.cpp  
 M  +2 -0      uml.h  
 M  +5 -3      umlview.cpp  
 M  +11 -6     widgets/statusbartoolbutton.cpp  
 M  +2 -2      widgets/statusbartoolbutton.h  

--- trunk/KDE/kdesdk/umbrello/umbrello/uml.cpp #1239069:1239070
 <at>  <at>  -91,6 +91,8  <at>  <at> 
 #include <QtGui/QPushButton>
 #include <QtGui/QLabel>

+#include <cmath>
+
 /** Static pointer, holding the last created instance. */
 UMLApp* UMLApp::s_instance;

 <at>  <at>  -541,6 +543,29  <at>  <at> 
 }

 /**
+ * Set zoom to fit the view.
+ */
+void UMLApp::slotZoomFit()
+{

Re: KDE/kdesdk/umbrello/umbrello

On Sat, 2011-07-02 at 11:58 +0200, Andi Fischer wrote:
> 
> Some tabs with spaces replaced.
> Zoom-Fit enabled and implemented.
> Zoom-Label added. 

Hey Andi,

I just tried your commit and it looks like the zooming is still done
wrong. I think the problem is somewhere in the calculation for
generating the bounding rectangle of all diagram widgets.

It looks like there is a problem possibly somewhere in
kdesdk/umbrello/umbrello/umlview.cpp in QRect
UMLView::getDiagramRect(). The bounding rectangle of the exported
diagram image is much larger than the actual diagram objects on the
right and bottom sides.

There is a sample Umbrello project here that I was using. Just export
any of the diagrams to SVG, and possibly any other image format to see.

https://bugs.kde.org/attachment.cgi?id=60548

--

-- 
Kip Warner -- Software Engineer
OpenPGP encrypted/signed mail preferred
http://www.thevertigo.com

------------------------------------------------------------------------------

[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

--- Comment #3 from Kip <kip thevertigo com>  2011-07-02 22:47:31 ---
Hey Oliver, yes, I've seen and tried that. That managed remove the bulk of it.
I don't know how that binary junk got in there, but thankfully it's gone.

I seem to have identified another problem massively contributing to bloated
save files. A friend of mine sent me a project file that I already had, but he
had made some minor changes, saved, and then emailed the project file to me. I
noticed his was only 1 MB, whereas mine was 3.4 MB. When I opened his and
resaved it, it then bloated to 7.4 MB. It stayed at 7.4 MB if I kept resaving.

I took a look at a diff between his project and mine, since we hadn't really
changed much, and I saw the following...

The end of his project file contained:
  (...)
  </listview>
  <codegeneration>
   <codegenerator language="C++"/>
  </codegeneration>
 </XMI.extensions>
</XMI>

In mine on the other hand, sandwiched between the codegeneration tags is 47007
lines of code generator elements...

(...)
  </listview>
  <codegeneration>

Re: Diagram exporting with wrong bounding rectangle

Am 29.06.2011 02:25, schrieb Kip Warner:
> I've been doing some debugging in Umbrello and it looks like there is a
> problem possibly somewhere in kdesdk/umbrello/umbrello/umlview.cpp in
> QRect UMLView::getDiagramRect(). The bounding rectangle of the exported
> diagram image is much larger than the actual diagram objects on the
> right and bottom sides. You can see this in the attached image.
>
Hey Kip,

What exactly are you doing? Do you export your diagram as a picture? In 
what format - svg, png?

I did a test with exporting to png and the picture has just the size of 
the diagram elements.
When I export to svg, then there is a larger margin at the bottom and on 
the right.

Therefore I suspect the code that generates the svg picture.

Regards,

Andi

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

Re: Diagram exporting with wrong bounding rectangle

On Sun, 2011-07-03 at 11:30 +0200, Andi Fischer wrote:
> Hey Kip,
> 
> What exactly are you doing? Do you export your diagram as a picture? In 
> what format - svg, png?
> 
> I did a test with exporting to png and the picture has just the size of 
> the diagram elements.
> When I export to svg, then there is a larger margin at the bottom and on 
> the right.
> 
> Therefore I suspect the code that generates the svg picture.
> 
> Regards,
> 
> Andi

Hey Andi,

I think you are right. I just tested with png and they came out
perfectly fitted. So yes, the code must be somewhere where the svg
pictures are generated. Maybe somewhere where the bounding rectangle is
calculated? Or perhaps the bounding rectangle is calculated properly
initially, but then scaled uniformly to be a little bigger.

--

-- 
Kip Warner -- Software Engineer
OpenPGP encrypted/signed mail preferred
http://www.thevertigo.com

[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

--- Comment #4 from Andi Fischer <andi fischer hispeed ch>  2011-07-04 19:42:12 ---
I guess that the different sizes of the xmi-files is because of the different
set checkbox "Use new C++/Java/Ruby generators" in the general settings dialog.
If the checkbox is selected, code documents are written to the xmi-file.

--

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

--- Comment #5 from Kip <kip thevertigo com>  2011-07-04 21:28:33 ---
Hey Andi. I can confirm that you seem to have found the culprit. A couple
observations:

(1) The new code generator does not appear to scale well for a large project,
like the one I showed you.

(2) If it needs to generate what it did when the feature is enabled, then
perhaps we should consider automatic transparent gzip'ing of project files.

--

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2

[Bug 274718] Huge Save File

https://bugs.kde.org/show_bug.cgi?id=274718

--- Comment #6 from Kip <kip thevertigo com>  2011-07-05 04:06:51 ---
Something else I noticed with that project file when trying to export diagram
images from the console was the file appears to still have a great deal of
garbage in it:

$ umbrello --export svg Engine.xmi
umbrello(644)/kdeui (kdelibs): Attempt to use QAction "edit_undo" with
KXMLGUIFactory! 
umbrello(644)/kdeui (kdelibs): Attempt to use QAction "edit_redo" with
KXMLGUIFactory! 
umbrello(644) KXMLGUI::ActionList::plug: Index  18  is not within range (0 - 
11 
umbrello(644): Guess is Uml::ModelType::N_MODELTYPES - package not set
correctly for  ""  / base type  116 
...
< repeats a gazillion times >
...
umbrello(644): Guess is Uml::ModelType::N_MODELTYPES - package not set
correctly for  ""  / base type  116 
umbrello(644): loadFromXMI(UMLRole): id  "eGBqqwbL28pg"  is already in use!!!
Please fix your XMI file. 
...
< repeats a gazillion times with different id >
...
umbrello(644): loadFromXMI(UMLRole): id  "8rcMzyH06JU6"  is already in use!!!
Please fix your XMI file. 
umbrello(644) UMLListView::findView: returning 0 at UMLListView::findView 
...