headers
Surbhi Palande | 1 Apr 2010 10:30
Favicon

[PATCH] ext4: correctly calculate number of blocks for fiemap

The following cherry-picked patch fixes the calculation of extents in fiemap.
The commit id in the upstream code is: aca92ff6f57c000d1b4523e383c8bd6b8269b8b1
This patch fixes bug 474597 on LP. Do consider merging this in Lucid.

From dfaa33f0502a8bf9dff0e596783a40ce330c7a9b Mon Sep 17 00:00:00 2001
From: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
Date: Thu, 4 Mar 2010 17:07:28 -0500
Subject: [PATCH] ext4: correctly calculate number of blocks for fiemap

http://launchpad.net/bugs/474597

ext4_fiemap() rounds the length of the requested range down to
blocksize, which is is not the true number of blocks that cover the
requested region.  This problem is especially impressive if the user
requests only the first byte of a file: not a single extent will be
reported.

We fix this by calculating the last block of the region and then
subtract to find the number of blocks in the extents.

Signed-off-by: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso <at> mit.edu>
(cherry picked from commit aca92ff6f57c000d1b4523e383c8bd6b8269b8b1)

Signed-off-by: Surbhi Palande <surbhi.palande <at> canonical.com>
---
 fs/ext4/extents.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
(Continue reading)

Permalink | Reply | 9 comments |
headers
Stefan Bader | 1 Apr 2010 10:55
Favicon

Re: [PATCH] ext4: correctly calculate number of blocks for fiemap

Surbhi Palande wrote:
> The following cherry-picked patch fixes the calculation of extents in fiemap.
> The commit id in the upstream code is: aca92ff6f57c000d1b4523e383c8bd6b8269b8b1
> This patch fixes bug 474597 on LP. Do consider merging this in Lucid.

Surbhi,

it would be better to give a quick summary about what the symptom of it is and
how the fix affects it here. Saves us going to LP and read through it. ;-)

> From dfaa33f0502a8bf9dff0e596783a40ce330c7a9b Mon Sep 17 00:00:00 2001
> From: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
> Date: Thu, 4 Mar 2010 17:07:28 -0500
> Subject: [PATCH] ext4: correctly calculate number of blocks for fiemap
> 
> http://launchpad.net/bugs/474597
BugLink: ...
> 
> ext4_fiemap() rounds the length of the requested range down to
> blocksize, which is is not the true number of blocks that cover the
> requested region.  This problem is especially impressive if the user
> requests only the first byte of a file: not a single extent will be
> reported.
> 
> We fix this by calculating the last block of the region and then
> subtract to find the number of blocks in the extents.
> 
> Signed-off-by: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
> Signed-off-by: "Theodore Ts'o" <tytso <at> mit.edu>
> (cherry picked from commit aca92ff6f57c000d1b4523e383c8bd6b8269b8b1)
(Continue reading)

Permalink | Reply | 7 comments |
headers
Stefan Bader | 1 Apr 2010 11:20
Favicon

Re: [PATCH] psmouse: touchpad doesn't reconnect after resume: Synaptics ps2 Bug: 551234

Peter M. Petrakis wrote:
> Stefan,
> 
> I think we tried that, but I retested again just to be sure
> with a live image and it still fails with that option. Also,
> removing and reinserting the psmouse mod doesn't make a
> difference.
> 
> Peter
> 
> On 03/30/2010 05:46 AM, Stefan Bader wrote:
>> Peter M. Petrakis wrote:
>>> Hi All,
>>>
>>> This is my first stab at correcting some PS/2 misbehavior when returning
>>> from S3. Fire away :). Thanks.
>>>
>>> Peter
>>>
>>> P.S. Collaborated with Colin King on this one.
>>>
>> Hm, just a question. Have you tried using "i8042.reset=1" in the boot command
>> line while getting it to work(without your patch applied)? Knowing Coling likely
>> yes. But to be sure here...
>>
>> Stefan
> 

Ok, sorry for the delayed response. First off, I assume this is requested for
Lucid, right?
(Continue reading)

Permalink | Reply | 1 comment |
headers
Surbhi Palande | 1 Apr 2010 11:21
Favicon

[PATCH] ext4: correctly calculate number of blocks for fiemap

The following cherry-picked patch fixes the calculation of extents in fiemap.
Without this patch a user of fiemap could be misled into thinking that there
are no extents in a file when actually there are. This patch is necessary for
code such as ureadahead which uses fiemap to find out if the file extents have
increased.

The commit id in the upstream code is: aca92ff6f57c000d1b4523e383c8bd6b8269b8b1
This patch fixes bug 474597 on LP. Do consider merging this in Lucid.

From dfaa33f0502a8bf9dff0e596783a40ce330c7a9b Mon Sep 17 00:00:00 2001
From: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
Date: Thu, 4 Mar 2010 17:07:28 -0500
Subject: [PATCH] ext4: correctly calculate number of blocks for fiemap

ext4_fiemap() rounds the length of the requested range down to
blocksize, which is is not the true number of blocks that cover the
requested region.  This problem is especially impressive if the user
requests only the first byte of a file: not a single extent will be
reported.

We fix this by calculating the last block of the region and then
subtract to find the number of blocks in the extents.

Signed-off-by: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso <at> mit.edu>
(cherry picked from commit aca92ff6f57c000d1b4523e383c8bd6b8269b8b1 upstream)

BugLink: http://launchpad.net/bugs/474597
Signed-off-by: Surbhi Palande <surbhi.palande <at> canonical.com>
---
(Continue reading)

Permalink | Reply | 6 comments |
headers
Andy Whitcroft | 1 Apr 2010 11:24
Favicon

Re: [PATCH] psmouse: touchpad doesn't reconnect after resume: Synaptics ps2 Bug: 551234

On Mon, Mar 29, 2010 at 05:18:35PM -0400, Peter M. Petrakis wrote:
> Hi All,
> 
> This is my first stab at correcting some PS/2 misbehavior when returning
> from S3. Fire away :). Thanks.
> 
> Peter
> 
> P.S. Collaborated with Colin King on this one.

> From 006e55bacfe64f5fe6b8c12af071f7b2bf528c3a Mon Sep 17 00:00:00 2001
> From: Peter M. Petrakis <peter.petrakis <at> canonical.com>
> Date: Fri, 26 Mar 2010 17:23:43 -0400
> Subject: [PATCH] Perform a reset should psmouse_probe fail for any reason. This is necessary for some
PS/2 devices who can't even be identified when returning from sleep (S3).
> 
> ---
>  psmouse-base.c |   28 +++++++++++++++++++++++++---
>  1 files changed, 25 insertions(+), 3 deletions(-)
> 
> diff --git a/psmouse-base.c b/psmouse-base.c
> index b407b35..3b8e63c 100644
> --- a/psmouse-base.c
> +++ b/psmouse-base.c
>  <at>  <at>  -856,12 +856,12  <at>  <at>  static const struct psmouse_protocol *psmouse_protocol_by_name(const char *name,
>  	return NULL;
>  }
>  
> -
>  /*
(Continue reading)

Permalink | Reply | 5 comments |
headers
Stefan Bader | 1 Apr 2010 11:37
Favicon

Re: [PATCH] ext4: correctly calculate number of blocks for fiemap

Ok, looks good to me now.

Surbhi Palande wrote:
> The following cherry-picked patch fixes the calculation of extents in fiemap.
> Without this patch a user of fiemap could be misled into thinking that there
> are no extents in a file when actually there are. This patch is necessary for
> code such as ureadahead which uses fiemap to find out if the file extents have
> increased.
> 
> The commit id in the upstream code is: aca92ff6f57c000d1b4523e383c8bd6b8269b8b1
> This patch fixes bug 474597 on LP. Do consider merging this in Lucid.
> 
> From dfaa33f0502a8bf9dff0e596783a40ce330c7a9b Mon Sep 17 00:00:00 2001
> From: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
> Date: Thu, 4 Mar 2010 17:07:28 -0500
> Subject: [PATCH] ext4: correctly calculate number of blocks for fiemap
> 
> ext4_fiemap() rounds the length of the requested range down to
> blocksize, which is is not the true number of blocks that cover the
> requested region.  This problem is especially impressive if the user
> requests only the first byte of a file: not a single extent will be
> reported.
> 
> We fix this by calculating the last block of the region and then
> subtract to find the number of blocks in the extents.
> 
> Signed-off-by: Leonard Michlmayr <leonard.michlmayr <at> gmail.com>
> Signed-off-by: "Theodore Ts'o" <tytso <at> mit.edu>
> (cherry picked from commit aca92ff6f57c000d1b4523e383c8bd6b8269b8b1 upstream)
>
(Continue reading)

Permalink | Reply | 4 comments |
headers
Stefan Bader | 1 Apr 2010 11:59
Favicon

[Lucid] SRU: Add xen netboot support

This patch adds the two modules to the d-i/modules files to be included
in the udeb files.

NOTE: Contrary to the propoal I got throught IRC, I have added the
xen-blkfront modules to block-modules and not scsi-modules. This
seemed more appropriate as it is built in drivers/block and not
drivers/scsi and virtio_blk lands in the same file.

cjwatson: Please let us/me know if that is not ok. Thanks.

-Stefan

From 7d5eb60bada3a3f428f2938b635e8ed6fb43982b Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader <at> canonical.com>
Date: Thu, 1 Apr 2010 11:53:00 +0200
Subject: [PATCH] UBUNTU: [Config] Add xen netboot support

BugLink: http://bugs.launchpad.net/bugs/160366

This adds xen-netfront and xen-blkfront to the debian installer modules
list.

Signed-off-by: Stefan Bader <stefan.bader <at> canonical.com>
---
 debian.master/d-i/modules/block-modules |    1 +
 debian.master/d-i/modules/nic-modules   |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/debian.master/d-i/modules/block-modules b/debian.master/d-i/modules/block-modules
index be8a07b..ada17c5 100644
(Continue reading)

Permalink | Reply | 4 comments |
headers
Andy Whitcroft | 1 Apr 2010 12:52
Favicon

linux-ec2 kernel 2.6.32-304.8 uploaded (ABI bump)

We have just uploaded a new Lucid linux-ec2 kernel.  It is based on the
Ubuntu-2.6.32-19.28 kernel.  Note the ABI bump:

    https://www.launchpad.net/ubuntu/+source/linux-ec2/2.6.32-304.8

-apw
Permalink | Reply | 0 comments |
headers
Bryan Wu | 1 Apr 2010 12:56
Favicon

[PATCH 0/2] Karmic/Lucid: fec.c driver fixing in fsl-imx51

According to the feedback from upstream review of my fec.c phylib patch,
phy_speed caculation in the new driver should be fixed up since the one in the
old driver was wrong from beginning. So this first patch fix this issue.

Karmic fec.c driver users got lots of timeout error message when transfer large
files. Actually, that is not an error, just a warning. The 2nd patch changed
the printk level to warning from error.

Both these 2 patches are ready for Karmic and Lucid, please consider to apply
them to both kernel repo.

Bryan Wu (2):
  netdev/fec: fix phy_speed caculating
  netdev/fec.c: fix timeout warning message

 drivers/net/fec.c |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)
Permalink | Reply | 3 comments |
headers
Bryan Wu | 1 Apr 2010 12:56
Favicon

[PATCH 1/2] netdev/fec: fix phy_speed caculating

BugLink: http://bugs.launchpad.net/bugs/546649
BugLink: http://bugs.launchpad.net/bugs/457878

 - remove duplicated phy_speed caculation
 - fix the phy_speed caculation according to the DataSheet

Signed-off-by: Bryan Wu <bryan.wu <at> canonical.com>
---
 drivers/net/fec.c |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/net/fec.c b/drivers/net/fec.c
index 9d99359..53240d3 100644
--- a/drivers/net/fec.c
+++ b/drivers/net/fec.c
 <at>  <at>  -737,10 +737,9  <at>  <at>  static int fec_enet_mii_init(struct platform_device *pdev)
 	fep->mii_timeout = 0;

 	/*
-	 * Set MII speed to 2.5 MHz
+	 * Set MII speed to 2.5 MHz (= clk_get_rate() / 2 * phy_speed)
 	 */
-	fep->phy_speed = ((((clk_get_rate(fep->clk) / 2 + 4999999)
-					/ 2500000) / 2) & 0x3F) << 1;
+	fep->phy_speed = DIV_ROUND_UP(clk_get_rate(fep->clk), 5000000) << 1;
 	writel(fep->phy_speed, fep->hwp + FEC_MII_SPEED);

 	fep->mii_bus = mdiobus_alloc();
 <at>  <at>  -1121,10 +1120,6  <at>  <at>  int __init fec_enet_init(struct net_device *dev, int index)
 	dev->netdev_ops = &fec_netdev_ops;
(Continue reading)

Permalink | Reply | 0 comments |

Gmane