Hi guys, I am now running sysfsutils
test suites under sles10. However, I got a test case failure message, look
at following:
test_sysfs_get_classdev_driver: FAILED
with flag = 0 errno = 2
Definition are like the following in
libsysfs.conf.
VALID_CLASS=net
VALID_CLASS_DEVICE=eth0
VALID_CLASS_DEVICE_PATH=/sys/class/net/eth0
VALID_CLASS_DEV_ATTR=type
After adding some printfs in lib/sysfs_class.c
sysfs_get_classdev_driver():
369
safestrcpy(drvpath, clsdev->path);
370
safestrcat(drvpath, "/driver");
371
printf("cj: drvpath=%s\n", drvpath);
372
if ((sysfs_path_is_link(drvpath)) != 0) {
373
if (clsdev->driver
!= NULL) {
374
sysfs_close_driver(clsdev->driver);
375
clsdev->driver = NULL;
376
}
377
printf("cj: out from
%s\n", "sysfs_path_is_link");
378
return NULL;
379
}
I got the following output:
cj: drvpath=/sys/class/net/eth0/driver
cj: out from sysfs_path_is_link
But /sys/class/net/eth0/driver does
not exist in sysfs.
[root <at> localhost sysfsutils-1.3.0]# ls
/sys/class/net/eth0/
addr_len broadcast device
features ifindex link_mode operstate tx_queue_len
uevent
address carrier dormant
flags iflink mtu statistics
type weight
This case is planning to get net/eth0's
driver object; but just as above, it returned NULL because it found that
/sys/class/net/eth0/driver is not a link and is not created in sysfs. However,
I does notice that /sys/class/net/eth0/device/driver is a link and exists.
So here is my question:
Is driver expected to be created under
/sys/class/net/eth0 or /sys/class/net/eth0/device?
If former case, then network drivers
did not follow this spec. I notice that no driver is created under other
devices like /sys/class/usb_device/usbdev2.1/ etc.
If latter case, why sysfs_get_classdev_driver()
use safestrcat(drvpath, "/driver") instead of safestrcat(drvpath,
"device/driver")? I do not think the case should set VALID_CLASS_DEVICE_PATH=/sys/class/net/eth0/device.
Is it a bug sysfsutils?
Best Regards!
Chen Jian(陈剑)
MCP Test, Linux Technology Center, China Systems & Technology Lab
China Development Labs, Beijing Email: chenjian <at> cn.ibm.com
Tel: 8610-82782244-3578 T/L: 915-2244,ext:3578 Fax:
8610-82782244-3251
RSS Feed