[Bug translator/7053] automatic global printing of statistic needs to check <at> count>0


------- Additional Comments From wenji dot huang at oracle dot com  2008-12-02 03:35 -------
Created an attachment (id=3085)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3085&action=view)
patch for checking empty aggregate and adding default print

Add checking empty aggregate and default print where  <at> count==0. It's not
necessary to check empty aggregate in Array case. The generated foreach 
can eliminate the possibly of printing empty aggregate.

Sample script:
$ sudo stap -ve 'global var; probe never{ var<<<2}' -p2
Pass 1: parsed user script and 47 library script(s) in 540usr/60sys/603real ms.

# globals
var:stats
# probes
never /* <- never */
(var) <<< (2)
end /* <- end */
{
if (( <at> count(var)) > (0)) printf("var  <at> count=%#x  <at> min=%#x  <at> max=%#x  <at> sum=%#x
 <at> avg=%#x\\n",  <at> count(var),  <at> min(var),  <at> max(var),  <at> sum(var),  <at> avg(var))
else printf("var  <at> count=0x0\\n")

}
Pass 2: analyzed script: 2 probe(s), 0 function(s), 0 embed(s), 1 global(s) in
10usr/20sys/26real ms.

--

-- 
(Continue reading)

[Bug runtime/7051] printf %n directive broken


------- Additional Comments From prerna at linux dot vnet dot ibm dot com  2008-12-02 09:45 -------
Waiting for feedback on whether %n directive should be continued with...

--

-- 

http://sourceware.org/bugzilla/show_bug.cgi?id=7051

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug runtime/7051] printf %n directive broken


------- Additional Comments From prerna at linux dot vnet dot ibm dot com  2008-12-02 09:41 -------
I'm not too sure if %n is useful enough to be retained..

--

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

http://sourceware.org/bugzilla/show_bug.cgi?id=7051

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Dmitry Malichenko | 2 Dec 11:50 2008
Picon

Re: error inserting module while running sleeptime.stp on maemo platform

Hi,

On Fri, Nov 28, 2008 at 1:15 AM, Frank Ch. Eigler <fche <at> redhat.com> wrote:
>
> CONFIG_RELAY=y should have made this available.
> Does /proc/kallsyms contain relay_open?
>

CONFIG_RELAY was enabled. I checked it one more time. But /proc/kallsyms doesn't
contain relay_open

>
> While the kernel.org kernel appears to lack arm kprobes support
> altogether, the linux-omap-2.6 git tree does appear to have support
> for it as of 2007-06-11, tagged beyond v2.6.24.
>
>> Kernel version: diablo kernel 2.6.21
>                                ^^^^^^
> That could be your problem there.
>

I patched and configured kernel using this systemtap wiki page:
http://sourceware.org/systemtap/wiki/SystemtapMaemoBenchmark
There is a patch which adds Kprobes to ARM kernel.

Thanks,
   Dmitry Malichenko

gowrishankar | 2 Dec 13:00 2008
Picon

Request to add git url in building systemtap guide

Hi,
Can you please add git url for systemtap source,  in "Building Systemtap 
Mainline"
section of link 
"http://sources.redhat.com/systemtap/wiki/SystemtapOnUbuntu".
Currently shown steps are :

sudo apt-get install git-core dejagnu
sudo apt-get build-dep systemtap
cd path/to/systemtap
./configure --disable-pie
make && sudo make install

Thanks in advance.
Gowri

Dmitry Malichenko | 2 Dec 13:30 2008
Picon

Re: error inserting module while running sleeptime.stp on maemo platform

Hi,

On Fri, Nov 28, 2008 at 10:03 AM, Ananth N Mavinakayanahalli
<ananth <at> in.ibm.com> wrote:
>
> - Does your kernel have CONFIG_RELAY set?
> - Doesn't maemo use an ARM processor? If so, I am not sure if kprobes are
> available for 2.6.21 for ARM. You may need to use a newer kernel.
> - And make sure to build with DEBUG_INFO set.
>

I enabled CONFIG_RELAY, CONFIG_DEBUG_FS, CONFIG_DEBUG_INFO,
CONFIG_KPROBES options.

I used systemtap wiki page
http://sourceware.org/systemtap/wiki/SystemtapMaemoBenchmark
there is a patch there which adds kprobes to the kernel.

I also successfully ran some tests from systemtap testsuite.

Thanks,
  Dmitry Malichenko

Ananth N Mavinakayanahalli | 2 Dec 15:15 2008
Picon

Re: Request to add git url in building systemtap guide

On Tue, Dec 02, 2008 at 05:30:44PM +0530, gowrishankar wrote:
> Hi,
> Can you please add git url for systemtap source,  in "Building Systemtap 
> Mainline"
> section of link 
> "http://sources.redhat.com/systemtap/wiki/SystemtapOnUbuntu".
> Currently shown steps are :
>
> sudo apt-get install git-core dejagnu
> sudo apt-get build-dep systemtap
> cd path/to/systemtap
> ./configure --disable-pie
> make && sudo make install

Added now.

BTW, feel free to create an account for yourself on the wiki and add
such details. We'd like for more volunteers to help update and improve
documentation on the wiki.

Ananth

Frank Ch. Eigler | 2 Dec 15:37 2008
Picon

Re: Request to add git url in building systemtap guide

gowrishankar <gomuthuk <at> linux.vnet.ibm.com> writes:

> [...]  Can you please add git url for systemtap source, in "Building
> Systemtap Mainline" section of link
> "http://sources.redhat.com/systemtap/wiki/SystemtapOnUbuntu".  [...]

The wiki is a community resource.  You can create yourself a login account
and edit the page to your liking.

- FChE

fche at redhat dot com | 2 Dec 19:03 2008

[Bug runtime/7051] remove broken printf %n directive support


------- Additional Comments From fche at redhat dot com  2008-12-02 18:03 -------
If there is no dissent, let's get rid of it.

--

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
   Last reconfirmed|0000-00-00 00:00:00         |2008-12-02 18:03:43
               date|                            |
            Summary|printf %n directive broken  |remove broken printf %n
                   |                            |directive support

http://sourceware.org/bugzilla/show_bug.cgi?id=7051

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

fche at redhat dot com | 2 Dec 20:17 2008

[Bug translator/7053] automatic global printing of statistic needs to check <at> count>0


------- Additional Comments From fche at redhat dot com  2008-12-02 19:17 -------
Nice work, plase commit with a test case.

--

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|systemtap at sources dot    |wenji dot huang at oracle
                   |redhat dot com              |dot com
             Status|NEW                         |ASSIGNED

http://sourceware.org/bugzilla/show_bug.cgi?id=7053

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Gmane