Using serial devices under linux

Tobias Klauser | 1 Mar 2011 09:10

Picon

Re: [smatch stuff] altera_uart: inconsistent checks for null

On 2011-02-19 at 15:02:05 +0100, Dan Carpenter <error27 <at> gmail.com> wrote:
> On Sat, Feb 19, 2011 at 02:22:17PM +0100, Tobias Klauser wrote:
> > On 2011-02-19 at 10:31:07 +0100, Dan Carpenter <error27 <at> gmail.com> wrote:
> > > Patch 2780ad42f5fe67 "tty: serial: altera_uart: Use port->regshift to
> > > store bus shift" added a NULL check for platp in altera_uart_probe() but
> > > not consistently through out the function.
> > > 
> > > drivers/tty/serial/altera_uart.c +553 altera_uart_probe(43)
> > > 	error: we previously assumed 'platp' could be null.
> > > 
> > >    545          if (platp)
> > >                    ^^^^^^^
> > > checked here.
> > > 
> > >    546                  port->regshift = platp->bus_shift;
> > >    547          else
> > >    548                  port->regshift = 0;
> > >    549
> > >    550          port->line = i;
> > >    551          port->type = PORT_ALTERA_UART;
> > >    552          port->iotype = SERIAL_IO_MEM;
> > >    553          port->uartclk = platp->uartclk;
> > >                                 ^^^^^^^
> > > potential NULL dereference?
> > 
> > Not at the moment, because everybody is using platform data at the
> > momenti, so platp should never be NULL. Still this is inconsistent and
> > shouldn't be there like this. The dereference on line 553 will go away
> > with the patch introducing device tree support to altera_uart [1].
> >

(Continue reading)

@@@ | 2 Mar 2011 00:48

Picon

(unknown)

Van szüksége a hitel bármilyen célra? Van egy pénzügyi probléma? Nem
szükség van a pénzügyi megoldás? Mr. Henrik
 hitelek a megoldás toall a pénzügyi problémákat, mi hitelek könnyen,
olcsó, és gyors. Írjon nekünk ma, hogy a kölcsönt, amire vágytok, akkor
intézkedik minden olyan kölcsön, hogy megfeleljen a költségvetés mindössze
3%-os kamat. Ha
érdekli, lépjen velünk kapcsolatba immediately.Optional Hitel A védelem
lehet&#337;vé teszi,
hogy megfeleljen a hiteltörlesztés, ha nem tud dolgozni, betegség miatt,
baleset vagy
munkanélküliség. Csak akkor vegye ki az értékes biztosítást, ha alkalmazni
az Ön kölcsönt,
emlékszem, hogy elmondja nekünk, ha azt szeretné, hogy
henmoralendingfirm <at> gmail.com

* HITEL JELENTKEZÉSI LAP *

* Teljes név ............*

* Otthoni cím ....................... ..*

* Születési dátum ......................*

* Telefonszám ...................*

* MOBIL szám, ha ..............*

* HITEL szükséges mennyiség .................*

* FAX .................*

(Continue reading)

Mr. henry | 2 Mar 2011 00:47

Picon

(unknown)

Van szüksége a hitel bármilyen célra? Van egy pénzügyi probléma? Nem
szükség van a pénzügyi megoldás? Mr. Henrik
 hitelek a megoldás toall a pénzügyi problémákat, mi hitelek könnyen,
olcsó, és gyors. Írjon nekünk ma, hogy a kölcsönt, amire vágytok, akkor
intézkedik minden olyan kölcsön, hogy megfeleljen a költségvetés mindössze
3%-os kamat. Ha
érdekli, lépjen velünk kapcsolatba immediately.Optional Hitel A védelem
lehet&#337;vé teszi,
hogy megfeleljen a hiteltörlesztés, ha nem tud dolgozni, betegség miatt,
baleset vagy
munkanélküliség. Csak akkor vegye ki az értékes biztosítást, ha alkalmazni
az Ön kölcsönt,
emlékszem, hogy elmondja nekünk, ha azt szeretné, hogy
henmoralendingfirm <at> gmail.com

* HITEL JELENTKEZÉSI LAP *

* Teljes név ............*

* Otthoni cím ....................... ..*

* Születési dátum ......................*

* Telefonszám ...................*

* MOBIL szám, ha ..............*

* HITEL szükséges mennyiség .................*

* FAX .................*

(Continue reading)

Govindraj | 2 Mar 2011 08:40

Picon

Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be configured from board file

On Wed, Mar 2, 2011 at 12:46 AM, Sricharan R <r.sricharan <at> ti.com> wrote:
> Hi,
>>diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
>>index 755f4aa..530e9e3 100644
>>--- a/arch/arm/mach-omap2/serial.c
>>+++ b/arch/arm/mach-omap2/serial.c
>> <at>  <at>  -44,6 +44,15  <at>  <at> 
>>
>> static int omap_uart_con_id __initdata = -1;
>>
>>+static struct omap_uart_port_info omap_serial_default_info[] = {
>>+      {
>>+              .dma_enabled    = 0,
>>+              .dma_rx_buf_size = DEFAULT_RXDMA_BUFSIZE,
>>+              .dma_rx_timeout = DEFAULT_RXDMA_TIMEOUT,
>>+              .idle_timeout   = DEFAULT_IDLE_TIMEOUT,
>>+      },
>>+};
>>+
>> static int uart_idle_hwmod(struct omap_device *od)
>> {
>>       omap_hwmod_idle(od->hwmods[0]);
>> <at>  <at>  -66,6 +75,54  <at>  <at>  static struct omap_device_pm_latency
> omap_uart_latency[]
>>= {
>>       },
>> };
>>
>>+#ifdef CONFIG_OMAP_MUX
>>+static struct omap_device_pad default_serial0_pads[] __initdata = {

(Continue reading)

Sricharan R | 2 Mar 2011 09:19

Picon

RE: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be configured from board file

Hi,
>-----Original Message-----
>From: Govindraj [mailto:govindraj.ti <at> gmail.com]
>Sent: Wednesday, March 02, 2011 1:11 PM
>To: Sricharan R
>Cc: Govindraj.R; linux-omap <at> vger.kernel.org;
linux-serial <at> vger.kernel.org;
>linux-arm-kernel <at> lists.infradead.org; Jon Hunter; Tony Lindgren; Benoit
>Cousson; Kevin Hilman; Paul Walmsley; Rajendra Nayak; Deepak Kattungal
>Subject: Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be
>configured from board file
>
>On Wed, Mar 2, 2011 at 12:46 AM, Sricharan R <r.sricharan <at> ti.com> wrote:
>> Hi,
>>>diff --git a/arch/arm/mach-omap2/serial.c
b/arch/arm/mach-omap2/serial.c
>>>index 755f4aa..530e9e3 100644
>>>--- a/arch/arm/mach-omap2/serial.c
>>>+++ b/arch/arm/mach-omap2/serial.c
>>> <at>  <at>  -44,6 +44,15  <at>  <at> 
>>>
>>> static int omap_uart_con_id __initdata = -1;
>>>
>>>+static struct omap_uart_port_info omap_serial_default_info[] = {
>>>+      {
>>>+              .dma_enabled    = 0,
>>>+              .dma_rx_buf_size = DEFAULT_RXDMA_BUFSIZE,
>>>+              .dma_rx_timeout = DEFAULT_RXDMA_TIMEOUT,
>>>+              .idle_timeout   = DEFAULT_IDLE_TIMEOUT,
>>>+      },

(Continue reading)

Govindraj | 2 Mar 2011 11:07

Picon

Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be configured from board file

On Wed, Mar 2, 2011 at 1:49 PM, Sricharan R <r.sricharan <at> ti.com> wrote:
> Hi,
>>-----Original Message-----
>>From: Govindraj [mailto:govindraj.ti <at> gmail.com]
>>Sent: Wednesday, March 02, 2011 1:11 PM
>>To: Sricharan R
>>Cc: Govindraj.R; linux-omap <at> vger.kernel.org;
> linux-serial <at> vger.kernel.org;
>>linux-arm-kernel <at> lists.infradead.org; Jon Hunter; Tony Lindgren; Benoit
>>Cousson; Kevin Hilman; Paul Walmsley; Rajendra Nayak; Deepak Kattungal
>>Subject: Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be
>>configured from board file
>>
>>On Wed, Mar 2, 2011 at 12:46 AM, Sricharan R <r.sricharan <at> ti.com> wrote:
>>> Hi,
>>>>diff --git a/arch/arm/mach-omap2/serial.c
> b/arch/arm/mach-omap2/serial.c
>>>>index 755f4aa..530e9e3 100644
>>>>--- a/arch/arm/mach-omap2/serial.c
>>>>+++ b/arch/arm/mach-omap2/serial.c
>>>> <at>  <at>  -44,6 +44,15  <at>  <at> 
>>>>
>>>> static int omap_uart_con_id __initdata = -1;
>>>>
>>>>+static struct omap_uart_port_info omap_serial_default_info[] = {
>>>>+      {
>>>>+              .dma_enabled    = 0,
>>>>+              .dma_rx_buf_size = DEFAULT_RXDMA_BUFSIZE,
>>>>+              .dma_rx_timeout = DEFAULT_RXDMA_TIMEOUT,
>>>>+              .idle_timeout   = DEFAULT_IDLE_TIMEOUT,

(Continue reading)

Govindraj | 2 Mar 2011 11:40

Picon

Re: [PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads

On Wed, Mar 2, 2011 at 10:19 AM, Varadarajan, Charulatha <charu <at> ti.com> wrote:
> Govind,
>
> Couple of minor comments.
>
> On Mon, Feb 28, 2011 at 20:09, Govindraj.R <govindraj.raja <at> ti.com> wrote:
>> For device pads which have OMAP_DEVICE_PAD_WAKEUP set (which means they
>> are wakeup capable) enable the IO-daisy wakeup capability.
>> During re-muxing avoid direct write with val as this can disturb if any
>> mux done at bootloader level so read the pad then write back.
>>
>> Also add a api to fetch the wake-up status bit is set for given omap-hwmod
>
> %s/a api/an API/
>
>> device using available mux info which is added during omap_hwmod_mux_init.
>> Wakeup status bit is needed for uart_resume_idle call from sram_idle path
>> based on wake-up event has occurred for given uart we can enable clocks back.
>>
>> Signed-off-by: Rajendra Nayak <rnayak <at> ti.com>
>> Signed-off-by: Govindraj.R <govindraj.raja <at> ti.com>
>> ---
>>  arch/arm/mach-omap2/mux.c                    |   23 +++++++++++++++++++++++
>>  arch/arm/mach-omap2/mux.h                    |   13 +++++++++++++
>>  arch/arm/mach-omap2/omap_hwmod.c             |   13 +++++++++++++
>>  arch/arm/plat-omap/include/plat/omap_hwmod.h |    1 +
>>  4 files changed, 50 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
>> index 98148b6..5338b93 100644

(Continue reading)

Govindraj.R | 2 Mar 2011 12:12

Picon

[PATCH 2/7] OMAP2+: mux: Enable wakeup for wakeup enable requested pads

For device pads which have OMAP_DEVICE_PAD_WAKEUP set (which means they
are wakeup capable) enable the IO-daisy wakeup capability.
During re-muxing avoid direct write with val as this can disturb if any
mux done at bootloader level so read the pad then write back.

Also add an API to fetch the wake-up status bit is set for given omap-hwmod
device using available mux info which is added during omap_hwmod_mux_init.
Wakeup status bit is needed for uart_resume_idle call from sram_idle path
based on wake-up event has occurred for given uart we can enable clocks back.

Signed-off-by: Rajendra Nayak <rnayak <at> ti.com>
Signed-off-by: Govindraj.R <govindraj.raja <at> ti.com>
---
 arch/arm/mach-omap2/mux.c                    |   28 ++++++++++++++++++++++++++
 arch/arm/mach-omap2/mux.h                    |   13 ++++++++++++
 arch/arm/mach-omap2/omap_hwmod.c             |   13 ++++++++++++
 arch/arm/plat-omap/include/plat/omap_hwmod.h |    1 +
 4 files changed, 55 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
index 98148b6..50edcea 100644
--- a/arch/arm/mach-omap2/mux.c
+++ b/arch/arm/mach-omap2/mux.c
 <at>  <at>  -317,6 +317,29  <at>  <at>  err1:
 	return NULL;
 }

+/* Gets the wakeup status of given pad from omap-hwmod */
+int omap_hwmod_mux_wakeup(struct omap_hwmod_mux_info *hmux)
+{

(Continue reading)

Sricharan R | 3 Mar 2011 06:08

Picon

RE: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be configured from board file

Hi,
>-----Original Message-----
>From: Govindraj [mailto:govindraj.ti <at> gmail.com]
>Sent: Wednesday, March 02, 2011 3:37 PM
>To: Sricharan R
>Cc: Govindraj.R; linux-omap <at> vger.kernel.org;
linux-serial <at> vger.kernel.org;
>linux-arm-kernel <at> lists.infradead.org; Jon Hunter; Tony Lindgren; Benoit
>Cousson; Kevin Hilman; Paul Walmsley; Rajendra Nayak; Deepak Kattungal
>Subject: Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be
>configured from board file
>
>On Wed, Mar 2, 2011 at 1:49 PM, Sricharan R <r.sricharan <at> ti.com> wrote:
>> Hi,
>>>-----Original Message-----
>>>From: Govindraj [mailto:govindraj.ti <at> gmail.com]
>>>Sent: Wednesday, March 02, 2011 1:11 PM
>>>To: Sricharan R
>>>Cc: Govindraj.R; linux-omap <at> vger.kernel.org;
>> linux-serial <at> vger.kernel.org;
>>>linux-arm-kernel <at> lists.infradead.org; Jon Hunter; Tony Lindgren; Benoit
>>>Cousson; Kevin Hilman; Paul Walmsley; Rajendra Nayak; Deepak Kattungal
>>>Subject: Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be
>>>configured from board file
>>>
>>>On Wed, Mar 2, 2011 at 12:46 AM, Sricharan R <r.sricharan <at> ti.com>
wrote:
>>>> Hi,
>>>>>diff --git a/arch/arm/mach-omap2/serial.c
>> b/arch/arm/mach-omap2/serial.c

(Continue reading)

Govindraj | 3 Mar 2011 13:14

Picon

Re: [PATCH 6/7] OMAP: Serial: Allow UART parameters to be configured from board file

On Wed, Mar 2, 2011 at 11:54 PM, Tony Lindgren <tony <at> atomide.com> wrote:
> * Govindraj <govindraj.ti <at> gmail.com> [110302 02:05]:
>>
>> >>>>+static struct omap_device_pad default_serial1_pads[] __initdata = {
>> >>>>+      {
>> >>>>+              .name   = "uart2_rx.uart2_rx",
>> >>>>+              .flags  = OMAP_DEVICE_PAD_REMUX |
>> > OMAP_DEVICE_PAD_WAKEUP,
>> >>>>+              .enable = OMAP_MUX_MODE0,
>> >>>>+      },
> ...
>
> AFAIK you should only need the OMAP_DEVICE_PAD_REMUX option for
> omap24xx. And if you use that option, you also need the .idle
> value.
>

Yes correct. I should avoid enabling rx-pad wakeup for omap24xx and
populate rx pad wakeup only for 3xxx onwards as done prior to this patch.

Will correct this in next version.

--
Thanks,
Govindraj.R

> Tony
>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in

(Continue reading)

Group

gmane.linux.serial.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 15

Articles in period: 148

March 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH] serial: 8250_dw: add ACPI ID for Intel BayTrail (21 May 2013)
[PATCH v2] serial: sccnxp: Improve verify_port (14 May 2013)
[PATCH] serial: sccnxp: Improve verify_port (14 May 2013)
[PATCH v2] serial: imx: Add Rx Fifo overrun error message (14 May 2013)
Investment Placement (6 May 2013)
Investment Placement (3 May 2013)
6 (11 May 2013)
[PATCH] serial: pl011: protect attribute read from NULL platform data (9 May 2013)
[PATCH] serial: 8250_dw: set clock rate (9 May 2013)
3 (9 May 2013)
dringender Vorschlag (8 May 2013)
[PATCH] serial: 8250_dw: Add valid clk pointer check (7 May 2013)
[PATCH 15/15] serial: pxa: remove unnecessary platform_set_drvdata() (7 May 2013)
[PATCH 14/15] serial: vt8500: remove unnecessary platform_set_drvdata( (7 May 2013)
[PATCH 13/15] serial: sirfsoc: remove unnecessary platform_set_drvdata (7 May 2013)
[PATCH 12/15] serial: sccnxp: remove unnecessary platform_set_drvdata( (7 May 2013)
[PATCH 11/15] serial: sa1100: remove unnecessary platform_set_drvdata( (7 May 2013)
[PATCH 10/15] serial: pnx8xxx: remove unnecessary platform_set_drvdata (7 May 2013)
[PATCH 09/15] serial: pmac_zilog: remove unnecessary platform_set_drvd (7 May 2013)
[PATCH 08/15] serial: netx: remove unnecessary platform_set_drvdata() (7 May 2013)
[PATCH 07/15] serial: imx: remove unnecessary platform_set_drvdata() (7 May 2013)

Archives

107	May 2013
182	April 2013
261	March 2013
184	February 2013
221	January 2013
139	December 2012
258	November 2012
215	October 2012
289	September 2012
177	August 2012
121	July 2012
131	June 2012
176	May 2012
115	April 2012
181	March 2012
150	February 2012
151	January 2012
115	December 2011
143	November 2011
219	October 2011
98	September 2011
136	August 2011
90	July 2011
147	June 2011
151	May 2011
98	April 2011
148	March 2011
84	February 2011
66	January 2011
53	December 2010
109	November 2010
93	October 2010
124	September 2010
67	August 2010
39	July 2010
26	June 2010
80	May 2010
25	April 2010
133	March 2010
99	February 2010
49	January 2010
10	December 2009
33	November 2009
28	October 2009
65	September 2009
34	August 2009
52	July 2009
47	June 2009
28	May 2009
2	April 2009
67	March 2009
19	February 2009
164	January 2009
45	December 2008
87	November 2008
129	October 2008
60	September 2008
63	August 2008
56	July 2008
33	June 2008
44	May 2008
57	April 2008
31	March 2008
30	February 2008
70	January 2008
18	December 2007
30	November 2007
67	October 2007
26	September 2007
77	August 2007
91	July 2007
14	June 2007
29	May 2007
51	April 2007
54	March 2007
59	February 2007
30	January 2007
30	December 2006
16	November 2006
36	October 2006
18	September 2006
84	August 2006
15	July 2006
48	June 2006
30	May 2006
17	April 2006
39	March 2006
4	February 2006
28	January 2006
15	December 2005
23	November 2005
25	October 2005
4	September 2005
12	August 2005
24	July 2005
24	June 2005
37	May 2005
19	April 2005
32	March 2005
38	February 2005
2	January 2005
1	December 2004
11	November 2004
12	October 2004
13	September 2004
29	August 2004
35	July 2004
5	June 2004
6	May 2004
5	April 2004
22	March 2004
16	February 2004
11	January 2004
50	December 2003
22	November 2003
10	October 2003
8	September 2003
20	August 2003
8	July 2003
1	June 2003
8	May 2003
15	April 2003
53	March 2003
31	February 2003
12	January 2003
4	December 2002
1	November 2002
17	October 2002
16	September 2002
19	August 2002
26	July 2002
15	June 2002
13	May 2002
12	April 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template