Using serial devices under linux

Dominik Brodowski | 1 Aug 2010 14:59

[PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte

Use pcmcia_read_config_byte and pcmcia_write_config_byte instead
of pcmcia_access_configuration_register.

CC: netdev <at> vger.kernel.org
CC: linux-wireless <at> vger.kernel.org
CC: linux-serial <at> vger.kernel.org
CC: Michael Buesch <mb <at> bu3sch.de>
Signed-off-by: Dominik Brodowski <linux <at> dominikbrodowski.net>
---
 drivers/net/pcmcia/axnet_cs.c              |    3 +-
 drivers/net/pcmcia/nmclan_cs.c             |   21 ++-----
 drivers/net/pcmcia/xirc2ps_cs.c            |   16 ++---
 drivers/net/wireless/hostap/hostap_cs.c    |   91 ++++++++--------------------
 drivers/net/wireless/orinoco/spectrum_cs.c |   32 +++-------
 drivers/pcmcia/cistpl.c                    |    7 +-
 drivers/pcmcia/cs_internal.h               |    4 +-
 drivers/pcmcia/pcmcia_resource.c           |   72 +++++++++++++---------
 drivers/serial/serial_cs.c                 |    8 +--
 drivers/ssb/pcmcia.c                       |   14 +----
 include/pcmcia/cs.h                        |   12 ----
 include/pcmcia/ds.h                        |    4 +-
 12 files changed, 105 insertions(+), 179 deletions(-)

diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c
index 467fd4b..ee0a6d0 100644
--- a/drivers/net/pcmcia/axnet_cs.c
+++ b/drivers/net/pcmcia/axnet_cs.c
 <at>  <at>  -378,8 +378,7  <at>  <at>  static int axnet_config(struct pcmcia_device *link)
     /* Maybe PHY is in power down mode. (PPD_SET = 1) 
        Bit 2 of CCSR is active low. */

(Continue reading)

Marcel Holtmann | 1 Aug 2010 20:04

Re: [PATCH 05/11] pcmcia: do not use io_req_t when calling pcmcia_request_io()

Hi Dominik,

> Instead of io_req_t, drivers are now requested to fill out
> struct pcmcia_device *p_dev->resource[0,1] for up to two ioport
> ranges. After a call to pcmcia_request_io(), the ports found there
> are reserved, after calling pcmcia_request_configuration(), they may
> be used.
> 
> CC: netdev <at> vger.kernel.org
> CC: linux-wireless <at> vger.kernel.org
> CC: linux-ide <at> vger.kernel.org
> CC: linux-usb <at> vger.kernel.org
> CC: laforge <at> gnumonks.org
> CC: linux-mtd <at> lists.infradead.org
> CC: linux-bluetooth <at> vger.kernel.org
> CC: alsa-devel <at> alsa-project.org
> CC: linux-serial <at> vger.kernel.org
> CC: Michael Buesch <mb <at> bu3sch.de>
> Signed-off-by: Dominik Brodowski <linux <at> dominikbrodowski.net>

for the drivers/bluetooth/ pieces.

Acked-by: Marcel Holtmann <marcel <at> holtmann.org>

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in

(Continue reading)

Dominik Brodowski | 2 Aug 2010 21:52

Re: [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte

Hey,

On Mon, Aug 02, 2010 at 08:59:26PM +0900, Komuro wrote:
> >--- a/drivers/net/pcmcia/xirc2ps_cs.c
> >+++ b/drivers/net/pcmcia/xirc2ps_cs.c
> 
> 
> >+	if (err)
> > 	    goto config_error;
> >-	reg.Action = CS_WRITE;
> >-	reg.Offset = CISREG_IOBASE_1;
> >-	reg.Value = (link->io.BasePort2 >> 8) & 0xff;
> >-	if ((err = pcmcia_access_configuration_register(link, &reg)))
> >+
> >+	err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
> >+				link->io.BasePort2 & 0xff);
> 
> It should be
> 
> 	err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
> 				(link->io.BasePort2 >> 8) & 0xff);
> 

Fixed, thanks.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org

(Continue reading)

Pavel Machek | 4 Aug 2010 14:49

Driver for kontron PMC-6L interface card

Hi!

Here's driver for PMC-6L interface card. It is against 2.6.27
(sorry). It seems to mostly work. It is quite an interesting card, for
example it timestamps incoming characters.

Problems remaining:

1) Due to ringbuffer design, I don't know how to handle input buffer
overrun.

2) stop_rx is currently a nop. I'm not sure if it is required? I guess
I could set RX buffer size to zero....?

I hope I did get the locking right.

Signed-off-by: Pavel Machek <pavel <at> ucw.cz>

diff -ur clean-27//drivers/serial/Kconfig linux-27//drivers/serial/Kconfig
--- clean-27//drivers/serial/Kconfig	2008-10-10 00:13:53.000000000 +0200
+++ linux-27//drivers/serial/Kconfig	2010-08-04 14:21:53.000000000 +0200
 <at>  <at>  -1343,6 +1343,14  <at>  <at> 
 	  If you have enabled the serial port on the Hilscher NetX SoC
 	  you can make it the console by answering Y to this option.

+config SERIAL_PMC6L
+        tristate "Serial ports on PMC-6L interface board"
+	select SERIAL_CORE
+	depends on PCI
+	help

(Continue reading)

Darius Augulis | 5 Aug 2010 22:10

Picon

[PATCH] serial: samsung: fix device name

Swap device and driver names in serial/samsung.c

Signed-off-by: Darius Augulis <augulis.darius <at> gmail.com>
---
 drivers/serial/samsung.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
index a9d6c56..9d63f24 100644
--- a/drivers/serial/samsung.c
+++ b/drivers/serial/samsung.c
 <at>  <at>  -878,10 +878,10  <at>  <at>  static struct uart_ops s3c24xx_serial_ops = {

 static struct uart_driver s3c24xx_uart_drv = {
 	.owner		= THIS_MODULE,
-	.dev_name	= "s3c2410_serial",
+	.driver_name    = "s3c2410_serial",
 	.nr		= CONFIG_SERIAL_SAMSUNG_UARTS,
 	.cons		= S3C24XX_SERIAL_CONSOLE,
-	.driver_name	= S3C24XX_SERIAL_NAME,
+	.dev_name       = S3C24XX_SERIAL_NAME,
 	.major		= S3C24XX_SERIAL_MAJOR,
 	.minor		= S3C24XX_SERIAL_MINOR,
 };

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Dominik Brodowski | 6 Aug 2010 00:06

[PATCH 07/18] pcmcia: use pcmica_{read,write}_config_byte

Use pcmcia_read_config_byte and pcmcia_write_config_byte instead
of pcmcia_access_configuration_register.

CC: netdev <at> vger.kernel.org
CC: linux-wireless <at> vger.kernel.org
CC: linux-serial <at> vger.kernel.org
CC: Michael Buesch <mb <at> bu3sch.de>
Signed-off-by: Dominik Brodowski <linux <at> dominikbrodowski.net>
---
 drivers/net/pcmcia/axnet_cs.c              |    3 +-
 drivers/net/pcmcia/nmclan_cs.c             |   21 ++-----
 drivers/net/pcmcia/xirc2ps_cs.c            |   16 ++---
 drivers/net/wireless/hostap/hostap_cs.c    |   91 ++++++++--------------------
 drivers/net/wireless/orinoco/spectrum_cs.c |   32 +++-------
 drivers/pcmcia/cistpl.c                    |    7 +-
 drivers/pcmcia/cs_internal.h               |    4 +-
 drivers/pcmcia/pcmcia_resource.c           |   72 +++++++++++++---------
 drivers/serial/serial_cs.c                 |    8 +--
 drivers/ssb/pcmcia.c                       |   14 +----
 include/pcmcia/cs.h                        |   12 ----
 include/pcmcia/ds.h                        |    4 +-
 12 files changed, 105 insertions(+), 179 deletions(-)

diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c
index 467fd4b..ee0a6d0 100644
--- a/drivers/net/pcmcia/axnet_cs.c
+++ b/drivers/net/pcmcia/axnet_cs.c
 <at>  <at>  -378,8 +378,7  <at>  <at>  static int axnet_config(struct pcmcia_device *link)
     /* Maybe PHY is in power down mode. (PPD_SET = 1) 
        Bit 2 of CCSR is active low. */

(Continue reading)

Kyungmin Park | 6 Aug 2010 02:04

Re: [PATCH] serial: samsung: fix device name

Hi,

It's already posted by Mr. Shim
http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2

As discussed with Ben. even though it's right patch, there's some
users to use previous interface.
I also think it will be fixed. but need to coordinate with existing users.

Ben, how to you think?

On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis <augulis.darius <at> gmail.com> wrote:
> Swap device and driver names in serial/samsung.c
>
> Signed-off-by: Darius Augulis <augulis.darius <at> gmail.com>
> ---
>  drivers/serial/samsung.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/samsung.c b/drivers/serial/samsung.c
> index a9d6c56..9d63f24 100644
> --- a/drivers/serial/samsung.c
> +++ b/drivers/serial/samsung.c
>  <at>  <at>  -878,10 +878,10  <at>  <at>  static struct uart_ops s3c24xx_serial_ops = {
>
>  static struct uart_driver s3c24xx_uart_drv = {
>        .owner          = THIS_MODULE,
> -       .dev_name       = "s3c2410_serial",
> +       .driver_name    = "s3c2410_serial",
>        .nr             = CONFIG_SERIAL_SAMSUNG_UARTS,

(Continue reading)

Kyungmin Park | 6 Aug 2010 08:26

Re: [PATCH] serial: samsung: fix device name

On Fri, Aug 6, 2010 at 3:13 PM, Darius Augulis <augulis.darius <at> gmail.com> wrote:
> On 08/06/2010 03:04 AM, Kyungmin Park wrote:
>>
>> Hi,
>>
>> It's already posted by Mr. Shim
>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2
>>
>> As discussed with Ben. even though it's right patch, there's some
>> users to use previous interface.
>> I also think it will be fixed. but need to coordinate with existing users.
>>
>
> IMHO, it must be fixed. It's very annoying bug and I spend few hours trying
> to understand why kernel with devtmpfs auto-mount option doesn't provide
> ttySAC0, because when grep'ing 'grep -R ttySAC0 drivers/serial/*
> it's found in samsung driver and I thought everything should be o.k. Who
> could imagine that it's driver name, not device?...
> Regarding old users, they should not use such strange device name in their
> configs, they have to sync with main line.

Absolutely agree.

>
>> Ben, how to you think?
>>
>> On Fri, Aug 6, 2010 at 5:10 AM, Darius Augulis<augulis.darius <at> gmail.com>
>>  wrote:
>>>
>>> Swap device and driver names in serial/samsung.c

(Continue reading)

Joonyoung Shim | 6 Aug 2010 09:06

Re: [PATCH] serial: samsung: fix device name

On 8/6/2010 3:47 PM, Paulius Zaleckas wrote:
> On 08/06/2010 03:04 AM, Kyungmin Park wrote:
>> Hi,
>>
>> It's already posted by Mr. Shim
>> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2
> 
> Darius patch is a little bit cleaner.
> 

OK, it's better.

Acked-by: Joonyoung Shim <jy0922.shim <at> samsung.com>

>> As discussed with Ben. even though it's right patch, there's some
>> users to use previous interface.
>> I also think it will be fixed. but need to coordinate with existing
>> users.
> 
> IMO this is obvious bug fix.
> 
> Acked-by: Paulius Zaleckas <paulius.zaleckas <at> gmail.com>
> 
>> Ben, how to you think?
>>
>> On Fri, Aug 6, 2010 at 5:10 AM, Darius
>> Augulis<augulis.darius <at> gmail.com>  wrote:
>>> Swap device and driver names in serial/samsung.c
>>>
>>> Signed-off-by: Darius Augulis<augulis.darius <at> gmail.com>

(Continue reading)

Kukjin Kim | 6 Aug 2010 09:23

RE: [PATCH] serial: samsung: fix device name

Joonyoung Shim wrote:
> 
> On 8/6/2010 3:47 PM, Paulius Zaleckas wrote:
> > On 08/06/2010 03:04 AM, Kyungmin Park wrote:
> >> Hi,
> >>
> >> It's already posted by Mr. Shim
> >> http://marc.info/?l=linux-arm-kernel&m=127410047306149&w=2
> >
> > Darius patch is a little bit cleaner.
> >
> 
> OK, it's better.
> 
> Acked-by: Joonyoung Shim <jy0922.shim <at> samsung.com>
> 

Hi all,

I think, this should be handled by Ben Dooks....
As Kyungmin Park said, there was his comment about this.

This is just for your information....

===

On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
> On 5/18/2010 11:48 AM, Ben Dooks wrote:
> > On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
> >> Thd dev_name and driver_name should be switched each other.

(Continue reading)

Group

gmane.linux.serial.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7

Articles in period: 67

August 2010

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH RESEND v2 1/2] serial/mpc52xx_uart: prepare for adding MPC5125 (24 May 2013)
linux-3.9.3 - hit limit of 255 usb->serial devices (24 May 2013)
[PATCH V3 -firmware] rp2: Initial commit of Comtrol RocketPort 2 micro (24 May 2013)
[PATCH v2] driver: serial: omap: fix compilation error (23 May 2013)
[PATCH] driver: serial: omap: fix compilation error (23 May 2013)
[GIT PATCH] TTY/Serial fixes for 3.10-rc3 (23 May 2013)
[PATCH] serial: use platform_{get,set}_drvdata() (23 May 2013)
[PATCH] serial/JSM: change maintainer to myself (22 May 2013)
[PATCH 1/1] serial: vt8500: Remove redundant use of of_match_ptr macro (22 May 2013)
[PATCH] tty: mxser: fix usage of opmode_ioaddr (21 May 2013)
[PATCH] serial: 8250_dw: add ACPI ID for Intel BayTrail (21 May 2013)
[PATCH v2] serial: sccnxp: Improve verify_port (14 May 2013)
[PATCH] serial: sccnxp: Improve verify_port (14 May 2013)
[PATCH v2] serial: imx: Add Rx Fifo overrun error message (14 May 2013)
Investment Placement (6 May 2013)
Investment Placement (3 May 2013)
6 (11 May 2013)
[PATCH] serial: pl011: protect attribute read from NULL platform data (9 May 2013)
[PATCH] serial: 8250_dw: set clock rate (9 May 2013)
3 (9 May 2013)
dringender Vorschlag (8 May 2013)

Archives

135	May 2013
182	April 2013
261	March 2013
184	February 2013
221	January 2013
139	December 2012
258	November 2012
215	October 2012
289	September 2012
177	August 2012
121	July 2012
131	June 2012
176	May 2012
115	April 2012
181	March 2012
150	February 2012
151	January 2012
115	December 2011
143	November 2011
219	October 2011
98	September 2011
136	August 2011
90	July 2011
147	June 2011
151	May 2011
98	April 2011
148	March 2011
84	February 2011
66	January 2011
53	December 2010
109	November 2010
93	October 2010
124	September 2010
67	August 2010
39	July 2010
26	June 2010
80	May 2010
25	April 2010
133	March 2010
99	February 2010
49	January 2010
10	December 2009
33	November 2009
28	October 2009
65	September 2009
34	August 2009
52	July 2009
47	June 2009
28	May 2009
2	April 2009
67	March 2009
19	February 2009
164	January 2009
45	December 2008
87	November 2008
129	October 2008
60	September 2008
63	August 2008
56	July 2008
33	June 2008
44	May 2008
57	April 2008
31	March 2008
30	February 2008
70	January 2008
18	December 2007
30	November 2007
67	October 2007
26	September 2007
77	August 2007
91	July 2007
14	June 2007
29	May 2007
51	April 2007
54	March 2007
59	February 2007
30	January 2007
30	December 2006
16	November 2006
36	October 2006
18	September 2006
84	August 2006
15	July 2006
48	June 2006
30	May 2006
17	April 2006
39	March 2006
4	February 2006
28	January 2006
15	December 2005
23	November 2005
25	October 2005
4	September 2005
12	August 2005
24	July 2005
24	June 2005
37	May 2005
19	April 2005
32	March 2005
38	February 2005
2	January 2005
1	December 2004
11	November 2004
12	October 2004
13	September 2004
29	August 2004
35	July 2004
5	June 2004
6	May 2004
5	April 2004
22	March 2004
16	February 2004
11	January 2004
50	December 2003
22	November 2003
10	October 2003
8	September 2003
20	August 2003
8	July 2003
1	June 2003
8	May 2003
15	April 2003
53	March 2003
31	February 2003
12	January 2003
4	December 2002
1	November 2002
17	October 2002
16	September 2002
19	August 2002
26	July 2002
15	June 2002
13	May 2002
12	April 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template