Matwey V. Kornilov | 21 May 2013 11:57
Picon
Favicon

[PATCH] tty: mxser: fix usage of opmode_ioaddr

From: Matwey V. Kornilov <matwey <at> sai.msu.ru>

mxser_port->opmode_ioaddr is initialized only for MOXA_MUST_MU860_HWID 
chips, but no precautions have been undertaken to prevent reading and 
writing to undefined port number.

Signed-off-by: Matwey V. Kornilov <matwey <at> sai.msu.ru>
---

diff --git a/drivers/tty/mxser.c b/drivers/tty/mxser.c
index 71d6eb2..f97b196 100644
--- a/drivers/tty/mxser.c
+++ b/drivers/tty/mxser.c
 <at>  <at>  -1618,8 +1618,12  <at>  <at>  static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
  				if (ip->type == PORT_16550A)
  					me->fifo[p] = 1;

-				opmode = inb(ip->opmode_ioaddr)>>((p % 4) * 2);
-				opmode &= OP_MODE_MASK;
+				if (ip->board->chip_flag == MOXA_MUST_MU860_HWID) {
+					opmode = inb(ip->opmode_ioaddr)>>((p % 4) * 2);
+					opmode &= OP_MODE_MASK;
+				} else {
+					opmode = RS232_MODE;
+				}
  				me->iftype[p] = opmode;
  				mutex_unlock(&port->mutex);
  			}
 <at>  <at>  -1670,6 +1674,9  <at>  <at>  static int mxser_ioctl(struct tty_struct *tty,
  		return mxser_ioctl_special(cmd, argp);
(Continue reading)

Heikki Krogerus | 21 May 2013 08:34
Picon

[PATCH] serial: 8250_dw: add ACPI ID for Intel BayTrail

This is the same controller as on Intel Lynxpoint but the
ACPI ID is different.

Signed-off-by: Heikki Krogerus <heikki.krogerus <at> linux.intel.com>
---
 drivers/tty/serial/8250/8250_dw.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 0b0eef9..d07b6af 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
 <at>  <at>  -369,6 +369,7  <at>  <at>  MODULE_DEVICE_TABLE(of, dw8250_of_match);
 static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "INT33C4", 0 },
 	{ "INT33C5", 0 },
+	{ "80860F0A", 0 },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);
--

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Alexander Shiyan | 14 May 2013 17:59
Picon

[PATCH v2] serial: sccnxp: Improve verify_port

The patch improves verify_port procedure by comparing the type of
port and IRQ numbers simultaneously. This can be important in the
case of multiple drivers SCCNXP in the system that are different IRQs.

Signed-off-by: Alexander Shiyan <shc_work <at> mail.ru>
---
 drivers/tty/serial/sccnxp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
index c773041..92e6195 100644
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
 <at>  <at>  -713,8 +713,8  <at>  <at>  static void sccnxp_config_port(struct uart_port *port, int flags)

 static int sccnxp_verify_port(struct uart_port *port, struct serial_struct *s)
 {
-	if ((s->type == PORT_UNKNOWN) || (s->type == PORT_SC26XX))
-		return 0;
+	if ((s->type != PORT_UNKNOWN) && (s->type != PORT_SC26XX))
+		return -EINVAL;
 	if (s->irq == port->irq)
 		return 0;

--

-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Alexander Shiyan | 14 May 2013 17:27
Picon

[PATCH] serial: sccnxp: Improve verify_port


Signed-off-by: Alexander Shiyan <shc_work <at> mail.ru>
---
 drivers/tty/serial/sccnxp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
index c773041..92e6195 100644
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
 <at>  <at>  -713,8 +713,8  <at>  <at>  static void sccnxp_config_port(struct uart_port *port, int flags)

 static int sccnxp_verify_port(struct uart_port *port, struct serial_struct *s)
 {
-	if ((s->type == PORT_UNKNOWN) || (s->type == PORT_SC26XX))
-		return 0;
+	if ((s->type != PORT_UNKNOWN) && (s->type != PORT_SC26XX))
+		return -EINVAL;
 	if (s->irq == port->irq)
 		return 0;

--

-- 
1.8.1.5

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Alexander Stein | 14 May 2013 17:06

[PATCH v2] serial: imx: Add Rx Fifo overrun error message

This patch enables the overrun error (ORE) interrupt and increases the
counter in case of overrun.

Signed-off-by: Alexander Stein <alexander.stein <at> systec-electronic.com>
---
Changes in v2:
* Added a patch description what this patch actually does
* Added uart_icount overrun counter increase

 drivers/tty/serial/imx.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 147c9e1..72bc1db 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
 <at>  <at>  -449,6 +449,13  <at>  <at>  static void imx_start_tx(struct uart_port *port)
 		temp &= ~(UCR1_RRDYEN);
 		writel(temp, sport->port.membase + UCR1);
 	}
+	/* Clear any pending ORE flag before enabling interrupt */
+	temp = readl(sport->port.membase + USR2);
+	writel(temp | USR2_ORE, sport->port.membase + USR2);
+
+	temp = readl(sport->port.membase + UCR4);
+	temp |= UCR4_OREN;
+	writel(temp, sport->port.membase + UCR4);

 	temp = readl(sport->port.membase + UCR1);
 	writel(temp | UCR1_TXMPTYEN, sport->port.membase + UCR1);
(Continue reading)

Mr. Wayne Scott | 6 May 2013 21:18
Picon
Favicon

Investment Placement

Greetings,

I am a Civil Lawyer in the United Kingdom. I have a Client that has Interest in investing in Your country. Can
You be of assistance?

I shall give you details when you reply

Wayne
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Mr. Wayne Scott | 3 May 2013 20:14
Picon
Favicon

Investment Placement

Greetings,

I am a Civil Lawyer in the United Kingdom. I have a Client that has Interest in investing in Your country. Can
You be of assistance?

I shall give you details when you reply

Wayne
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

grego rigolo | 11 May 2013 17:09
Picon
Favicon

Re:6


8f739Sat, 11 May 2013 8:09:15 http://domaine-de-montboulon.com/work.at.home.n.php?SID=071
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Lee Jones | 9 May 2013 14:50
Favicon

[PATCH] serial: pl011: protect attribute read from NULL platform data struct

It's completely feasible that platform data will be empty i.e. when
booting with Device Tree with no device AUXDATA. So we must protect
it's use in these use-cases, or risk a kernel Oops.

Cc: Russell King <linux <at> arm.linux.org.uk>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
Cc: Jiri Slaby <jslaby <at> suse.cz>
Cc: linux-serial <at> vger.kernel.org
Cc: Arnd Bergmann <arnd <at> arndb.de>
Signed-off-by: Lee Jones <lee.jones <at> linaro.org>
---
*******                                                        *******
If this issue has not already been fixed, this patch should be applied
during the v3.10 -rc:s, as it fixes a serious bug which was introduced
in the merge-window.
*******                                                        *******

 drivers/tty/serial/amba-pl011.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index 8ab70a6..e2774f9 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
 <at>  <at>  -332,7 +332,7  <at>  <at>  static void pl011_dma_probe_initcall(struct device *dev, struct uart_amba_port *
 		dmaengine_slave_config(chan, &rx_conf);
 		uap->dmarx.chan = chan;

-		if (plat->dma_rx_poll_enable) {
+		if (plat && plat->dma_rx_poll_enable) {
(Continue reading)

James Hogan | 9 May 2013 12:29
James Hogan <james.hogan <at> imgtec.com>

Subject: [PATCH] serial: 8250_dw: set clock rate

[PATCH] serial: 8250_dw: set clock rate

If the uart clock provided to the 8250_dw driver is adjustable it may
not be set to the desired rate. Therefore if both a uart clock and a
clock frequency is specified (e.g. via device tree), try and update the
clock to match the frequency.

Unfortunately if the resulting frequency is rounded down (which is the
default behaviour of the generic clk-divider), the 8250 core won't allow
the highest baud rate to be used, so if an explicit frequency is
specified we always report that to the 8250 core.

The device tree bindings document is also updated accordingly.

Signed-off-by: James Hogan <james.hogan <at> imgtec.com>
Cc: Grant Likely <grant.likely <at> linaro.org>
Cc: Rob Herring <rob.herring <at> calxeda.com>
Cc: Rob Landley <rob <at> landley.net>
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
Cc: Jiri Slaby <jslaby <at> suse.cz>
Cc: Heikki Krogerus <heikki.krogerus <at> linux.intel.com>
Cc: Alan Cox <alan <at> linux.intel.com>
Cc: Jamie Iles <jamie <at> jamieiles.com>
Cc: Bill Pemberton <wfp5p <at> virginia.edu>
---
 .../bindings/tty/serial/snps-dw-apb-uart.txt       |  4 +-
 drivers/tty/serial/8250/8250_dw.c                  | 47 +++++++++++++++++-----
 2 files changed, 39 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/tty/serial/snps-dw-apb-uart.txt b/Documentation/devicetree/bindings/tty/serial/snps-dw-apb-uart.txt
index f13f1c5..e0cfc47 100644
--- a/Documentation/devicetree/bindings/tty/serial/snps-dw-apb-uart.txt
(Continue reading)

grego rigolo | 9 May 2013 04:17
Picon
Favicon

Re:3


8b696Wed, 8 May 2013 19:17:46 http://e-nt.de/facebook.com.weightdropn.php?ID=202
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Gmane