Linux SCSI driver development and usage

James Bottomley | 1 Nov 2011 13:35

Re: Do we need to implement sr START/STOP management

On Tue, 2011-11-01 at 14:35 +0800, JiSheng Zhang wrote:
> 2011/11/1 James Bottomley <James.Bottomley <at> hansenpartnership.com>:
> > On Tue, 2011-11-01 at 13:31 +0800, JiSheng Zhang wrote:
> >> Currently, there's no start/stop management in scsi cdrom driver to
> >> spin up/down the motor do we need to implement it?
> >
> > Say more ... like what you think it buys.  The auto spin down of a CD
> > tends to be the best power control we have and it's not even clear that
> > manufacturers have implemented any other useful power states.
> 
> Does it mean the behavior depends on manufacturers? Some cd will spin
> down automatically?

All CDs spin down when not reading (or burning) since the motor power is
pretty high.  Most also do speed adjustments on the fly as well to try
to match platter speed and read or burn rate.

>  Even so, how about during shutdown just after reading
> something from cdrom?

What's the use case?  For internal CDs, shutdown removes power anyway.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Tomas Henzl | 1 Nov 2011 17:46

Picon

[PATCH] qla4xx: a small loop fix

From: Tomas Henzl <thenzl <at> redhat.com>

When the qla4xxx_get_fwddb_entry returns QLA_ERROR
the nex_idx is not updated, 
      for (idx = 0; idx < max_ddbs; idx = next_idx) {
                ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
                                              &next_idx, &state, &conn_err,
                                                NULL, NULL);
                if (ret == QLA_ERROR)
                        continue;

This means there is a risk that the 'idx < max_ddbs' condition will never
met and the loop will loop forever.
Fix this by explicitly increasing the next_idx in the error condition.

Maybe a break instead of continue is more appropriate, leaving the decision
on the qlogic maintainer.

Signed-off-by: Tomas Henzl <thenzl <at> redhat.com>

diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index 3075fba..17acb17 100644
--- a/drivers/scsi/qla4xxx/ql4_init.c
+++ b/drivers/scsi/qla4xxx/ql4_init.c
 <at>  <at>  -787,8 +787,10  <at>  <at>  static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha)
 		ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
 					      &next_idx, &state, &conn_err,
 						NULL, NULL);
-		if (ret == QLA_ERROR)
+		if (ret == QLA_ERROR) {

(Continue reading)

Moger, Babu | 1 Nov 2011 18:19

Picon

[PATCH 0/4] scsi_dh: Fix for handler attach and code clean up

These series of patches handles following things.
1. Fixes handler attach issue.
2. Introduces match function for all the handlers
3. cleans up the scsi_dh code 

I have noticed the attach issue during our multipath testing. We found that during
the lun discovery there were lots of error messages like below..

Oct 25 08:24:43 kswm-mihosi kernel: sd 0:0:0:7: [sdav]  Result: hostbyte=DID_OK
driverbyte=DRIVER_SENSE
Oct 25 08:24:43 kswm-mihosi kernel: sd 0:0:0:7: [sdav]  Sense Key : Illegal
Request [current]
Oct 25 08:24:43 kswm-mihosi kernel: sd 0:0:0:7: [sdav]  <<vendor>> ASC=0x94
ASCQ=0x1ASC=0x94 ASCQ=0x1
Oct 25 08:24:43 kswm-mihosi kernel: sd 0:0:0:7: [sdav] CDB: Read(10): 28 00 00
00 00 00 00 00 80 00
Oct 25 08:24:43 kswm-mihosi kernel: end_request: I/O error, dev sdav, sector 0

These messages were coming in spite of having scsi_dh_rdac in initrd.  Reason
for these errors are due to device handler not being attached properly. If the
device handler was attached then the I/O's should not go to passive paths.

Investigating further we found that there errors started with the introduction
of these patches below.

http://www.spinics.net/lists/linux-scsi/msg54284.html
or
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6c3633d08acf514e2e89aa95d2346ce9d64d719a

This patch introduces the match function for device handlers. But the match function

(Continue reading)

Moger, Babu | 1 Nov 2011 18:19

Picon

[PATCH 2/4] scsi_dh_hp_sw: Adding the match function for hp_sw device handler

This patch introduces the match fuction for hp_sw device handler.
The match function was introduced by this patch
http://www.spinics.net/lists/linux-scsi/msg54284.html

Signed-off-by: Babu Moger <babu.moger <at> netapp.com>
---

--- linux/drivers/scsi/device_handler/scsi_dh_hp_sw.c.orig	2011-10-31 11:25:07.000000000 -0500
+++ linux/drivers/scsi/device_handler/scsi_dh_hp_sw.c	2011-10-31 12:33:05.000000000 -0500
 <at>  <at>  -319,6 +319,20  <at>  <at>  static const struct scsi_dh_devlist hp_s
 	{NULL, NULL},
 };

+static bool hp_sw_match(struct scsi_device *sdev)
+{
+	int i;
+	for (i = 0; hp_sw_dh_data_list[i].vendor; i++) {
+		if (!strncmp(sdev->vendor, hp_sw_dh_data_list[i].vendor,
+			strlen(hp_sw_dh_data_list[i].vendor)) &&
+		    !strncmp(sdev->model, hp_sw_dh_data_list[i].model,
+			strlen(hp_sw_dh_data_list[i].model))) {
+			return true;
+		}
+	}
+	return false;
+}
+
 static int hp_sw_bus_attach(struct scsi_device *sdev);
 static void hp_sw_bus_detach(struct scsi_device *sdev);

(Continue reading)

Moger, Babu | 1 Nov 2011 18:19

Picon

[PATCH 1/4] scsi_dh_emc: Adding the match function for emc device handler

This patch introduces the match fuction for emc device handler.
The match function was introduced by this patch
http://www.spinics.net/lists/linux-scsi/msg54284.html

Signed-off-by: Babu Moger <babu.moger <at> netapp.com>
---

--- linux/drivers/scsi/device_handler/scsi_dh_emc.c.orig	2011-10-31 11:24:29.000000000 -0500
+++ linux/drivers/scsi/device_handler/scsi_dh_emc.c	2011-10-31 11:27:45.000000000 -0500
 <at>  <at>  -628,6 +628,20  <at>  <at>  static const struct scsi_dh_devlist clar
 	{NULL, NULL},
 };

+static bool clariion_match(struct scsi_device *sdev)
+{
+	int i;
+	for (i = 0; clariion_dev_list[i].vendor; i++) {
+		if (!strncmp(sdev->vendor, clariion_dev_list[i].vendor,
+			strlen(clariion_dev_list[i].vendor)) &&
+		    !strncmp(sdev->model, clariion_dev_list[i].model,
+			strlen(clariion_dev_list[i].model))) {
+			return true;
+		}
+	}
+	return false;
+}
+
 static int clariion_bus_attach(struct scsi_device *sdev);
 static void clariion_bus_detach(struct scsi_device *sdev);

(Continue reading)

Moger, Babu | 1 Nov 2011 18:19

Picon

[PATCH 3/4] scsi_dh_rdac: Adding the match function for rdac device handler

This patch introduces the match function for rdac device handler. Without this,
sometimes handler attach fails during the device_add.  The match function was
introduced by this patch
http://www.spinics.net/lists/linux-scsi/msg54284.html

Signed-off-by: Babu Moger <babu.moger <at> netapp.com>
---

--- linux/drivers/scsi/device_handler/scsi_dh_rdac.c.orig	2011-10-31 11:25:44.000000000 -0500
+++ linux/drivers/scsi/device_handler/scsi_dh_rdac.c	2011-10-31 11:31:34.000000000 -0500
 <at>  <at>  -819,6 +819,21  <at>  <at>  static const struct scsi_dh_devlist rdac
 	{NULL, NULL},
 };

+static bool rdac_match(struct scsi_device *sdev)
+{
+	int i;
+
+	for (i = 0; rdac_dev_list[i].vendor; i++) {
+		if (!strncmp(sdev->vendor, rdac_dev_list[i].vendor,
+			strlen(rdac_dev_list[i].vendor)) &&
+		    !strncmp(sdev->model, rdac_dev_list[i].model,
+			strlen(rdac_dev_list[i].model))) {
+			return true;
+		}
+	}
+	return false;
+}
+
 static int rdac_bus_attach(struct scsi_device *sdev);

(Continue reading)

Moger, Babu | 1 Nov 2011 18:20

Picon

[PATCH 4/4] scsi_dh: code cleanup - remove the references to scsi_dev_info

All the handlers have implemented the match function(look at patch 1, 2, 3).
We don't need to use scsi_dev_info any more for matching purposes.

Cleaning up the scsi_dh code.

FYI..
Match function was originally implemented by this 

http://www.spinics.net/lists/linux-scsi/msg54284.html
or
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=6c3633d08acf514e2e89aa95d2346ce9d64d719a

Signed-off-by: Babu Moger <babu.moger <at> netapp.com>
---

diff -uprN -X linux/Documentation/dontdiff linux//drivers/scsi/device_handler/scsi_dh.c linux-new/linux//drivers/scsi/device_handler/scsi_dh.c
--- linux//drivers/scsi/device_handler/scsi_dh.c	2011-10-31 13:47:37.000000000 -0500
+++ linux-new/linux//drivers/scsi/device_handler/scsi_dh.c	2011-10-31 13:45:46.000000000 -0500
 <at>  <at>  -27,7 +27,6  <at>  <at> 

 static DEFINE_SPINLOCK(list_lock);
 static LIST_HEAD(scsi_dh_list);
-static int scsi_dh_list_idx = 1;

 static struct scsi_device_handler *get_device_handler(const char *name)
 {
 <at>  <at>  -44,21 +43,6  <at>  <at>  static struct scsi_device_handler *get_d
 	return found;
 }

(Continue reading)

Mike Christie | 1 Nov 2011 19:10

Picon

Re: [PATCH] qla4xx: a small loop fix

On 11/01/2011 11:46 AM, Tomas Henzl wrote:
> From: Tomas Henzl <thenzl <at> redhat.com>
> 
> When the qla4xxx_get_fwddb_entry returns QLA_ERROR
> the nex_idx is not updated, 
>       for (idx = 0; idx < max_ddbs; idx = next_idx) {
>                 ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>                                               &next_idx, &state, &conn_err,
>                                                 NULL, NULL);
>                 if (ret == QLA_ERROR)
>                         continue;
>  
> This means there is a risk that the 'idx < max_ddbs' condition will never
> met and the loop will loop forever.
> Fix this by explicitly increasing the next_idx in the error condition.
> 
> Maybe a break instead of continue is more appropriate, leaving the decision
> on the qlogic maintainer.
> 
> Signed-off-by: Tomas Henzl <thenzl <at> redhat.com>
> 
> diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
> index 3075fba..17acb17 100644
> --- a/drivers/scsi/qla4xxx/ql4_init.c
> +++ b/drivers/scsi/qla4xxx/ql4_init.c
>  <at>  <at>  -787,8 +787,10  <at>  <at>  static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha)
>  		ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>  					      &next_idx, &state, &conn_err,
>  						NULL, NULL);
> -		if (ret == QLA_ERROR)

(Continue reading)

Tomas Henzl | 1 Nov 2011 21:22

Picon

Re: [PATCH] qla4xx: a small loop fix

On 11/01/2011 07:10 PM, Mike Christie wrote:
> On 11/01/2011 11:46 AM, Tomas Henzl wrote:
>> From: Tomas Henzl <thenzl <at> redhat.com>
>>
>> When the qla4xxx_get_fwddb_entry returns QLA_ERROR
>> the nex_idx is not updated, 
>>       for (idx = 0; idx < max_ddbs; idx = next_idx) {
>>                 ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>>                                               &next_idx, &state, &conn_err,
>>                                                 NULL, NULL);
>>                 if (ret == QLA_ERROR)
>>                         continue;
>>  
>> This means there is a risk that the 'idx < max_ddbs' condition will never
>> met and the loop will loop forever.
>> Fix this by explicitly increasing the next_idx in the error condition.
>>
>> Maybe a break instead of continue is more appropriate, leaving the decision
>> on the qlogic maintainer.
>>
>> Signed-off-by: Tomas Henzl <thenzl <at> redhat.com>
>>
>> diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
>> index 3075fba..17acb17 100644
>> --- a/drivers/scsi/qla4xxx/ql4_init.c
>> +++ b/drivers/scsi/qla4xxx/ql4_init.c
>>  <at>  <at>  -787,8 +787,10  <at>  <at>  static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha)
>>  		ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>>  					      &next_idx, &state, &conn_err,
>>  						NULL, NULL);

(Continue reading)

Mike Christie | 1 Nov 2011 21:31

Picon

Re: [PATCH] qla4xx: a small loop fix

On 11/01/2011 03:22 PM, Tomas Henzl wrote:
> On 11/01/2011 07:10 PM, Mike Christie wrote:
>> On 11/01/2011 11:46 AM, Tomas Henzl wrote:
>>> From: Tomas Henzl <thenzl <at> redhat.com>
>>>
>>> When the qla4xxx_get_fwddb_entry returns QLA_ERROR
>>> the nex_idx is not updated, 
>>>       for (idx = 0; idx < max_ddbs; idx = next_idx) {
>>>                 ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>>>                                               &next_idx, &state, &conn_err,
>>>                                                 NULL, NULL);
>>>                 if (ret == QLA_ERROR)
>>>                         continue;
>>>  
>>> This means there is a risk that the 'idx < max_ddbs' condition will never
>>> met and the loop will loop forever.
>>> Fix this by explicitly increasing the next_idx in the error condition.
>>>
>>> Maybe a break instead of continue is more appropriate, leaving the decision
>>> on the qlogic maintainer.
>>>
>>> Signed-off-by: Tomas Henzl <thenzl <at> redhat.com>
>>>
>>> diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
>>> index 3075fba..17acb17 100644
>>> --- a/drivers/scsi/qla4xxx/ql4_init.c
>>> +++ b/drivers/scsi/qla4xxx/ql4_init.c
>>>  <at>  <at>  -787,8 +787,10  <at>  <at>  static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha)
>>>  		ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL,
>>>  					      &next_idx, &state, &conn_err,

(Continue reading)

Group

gmane.linux.scsi.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 30

Articles in period: 293

November 2011

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

Pull Request for 3.10-rc (FCoE) (21 May 2013)
[PATCH 0/4] libfc, libfcoe, fcoe updates for 3.10-rc (21 May 2013)
[PATCH 1/3] sd_try_extended_inquiry for SPC-3 targets (21 May 2013)
[PATCH 1/3] sd_try_extended_inquiry for SPC-3 targets (21 May 2013)
[PATCH 1/3] sd_try_extended_inquiry for SPC-3 targets (21 May 2013)
[PATCH 0/0] ipr: possible irq lock inversion dependency detected (20 May 2013)
Contact me (20 May 2013)
CHECK. (20 May 2013)
CHECK. (19 May 2013)
[PATCH v2 0/5] scsi_debug: bug fixes and cleanups for data integrity s (19 May 2013)
[PATCH 0/8] scsi: ufs: query support and other fixes (19 May 2013)
(unknown) (18 May 2013)
[PATCH] csiostor: Retain default adapter configuration in absence of c (17 May 2013)
[PATCH] Hard disk S3 resume time optimization (17 May 2013)
Attention!!! (16 May 2013)
[PATCH V1 0/7] Drivers: hv/scsi: Implement multi-channel support (16 May 2013)
mpt2sas,mpt3sas watchdog device removal (15 May 2013)
[PATCH 1/1] ibmvfc: Fix for offlining devices during error recovery (15 May 2013)
[PATCH] mptfusion: avoid reset loop by setting the result to DID_SOFT_ (15 May 2013)
[PATCH 0/3] UFSHCD updates (14 May 2013)
[PATCH V2 0/9] ufs patch siries (14 May 2013)

Archives

305	May 2013
366	April 2013
352	March 2013
387	February 2013
287	January 2013
323	December 2012
294	November 2012
333	October 2012
445	September 2012
393	August 2012
266	July 2012
340	June 2012
558	May 2012
356	April 2012
505	March 2012
423	February 2012
441	January 2012
347	December 2011
255	November 2011
300	October 2011
262	September 2011
467	August 2011
643	July 2011
392	June 2011
430	May 2011
255	April 2011
578	March 2011
514	February 2011
513	January 2011
479	December 2010
642	November 2010
502	October 2010
600	September 2010
441	August 2010
581	July 2010
480	June 2010
481	May 2010
363	April 2010
530	March 2010
429	February 2010
340	January 2010
400	December 2009
635	November 2009
387	October 2009
848	September 2009
930	August 2009
620	July 2009
769	June 2009
985	May 2009
1000	April 2009
744	March 2009
656	February 2009
824	January 2009
896	December 2008
669	November 2008
757	October 2008
586	September 2008
711	August 2008
874	July 2008
614	June 2008
782	May 2008
802	April 2008
1115	March 2008
1200	February 2008
1057	January 2008
712	December 2007
555	November 2007
1117	October 2007
805	September 2007
562	August 2007
1027	July 2007
445	June 2007
769	May 2007
485	April 2007
507	March 2007
544	February 2007
598	January 2007
419	December 2006
508	November 2006
612	October 2006
490	September 2006
629	August 2006
471	July 2006
727	June 2006
569	May 2006
519	April 2006
812	March 2006
796	February 2006
711	January 2006
539	December 2005
647	November 2005
743	October 2005
1018	September 2005
825	August 2005
484	July 2005
552	June 2005
559	May 2005
593	April 2005
614	March 2005
492	February 2005
499	January 2005
297	December 2004
441	November 2004
729	October 2004
734	September 2004
615	August 2004
294	July 2004
642	June 2004
460	May 2004
552	April 2004
472	March 2004
592	February 2004
653	January 2004
325	December 2003
541	November 2003
426	October 2003
395	September 2003
400	August 2003
304	July 2003
361	June 2003
438	May 2003
349	April 2003
362	March 2003
302	February 2003
403	January 2003
250	December 2002
417	November 2002
465	October 2002
290	September 2002
217	August 2002
226	July 2002
257	June 2002
133	May 2002
142	April 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template