Linux SCSI driver development and usage

Jeff Garzik | 1 Nov 2010 03:34

Re: Full hostlock pushdown available


>> On 10/28/2010 05:05 PM, Andi Kleen wrote:
>>> >> The following changes since commit 39764981e772adc832d8a96e6540be346a830ca2:
>>> >>
>>> >>   Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6
(2010-10-27 20:54:34 +0200)
>>> >>
>>> >> are available in the git repository at:
>>> >>
>>> >>   ssh://master.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6.git hostlock

Missing drivers/ata/libata-scsi.c modification?

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Randy Dunlap | 1 Nov 2010 04:19

Picon

Re: [patch] scsi: netlink: avoid including netlink interface in scsi module

On 10/31/10 11:50, Jan Engelhardt wrote:
> parent 3985c7ce85039adacdf882904ca096f091d39346 (v2.6.36-9871-g3985c7c)
> commit 150bc5749967d77b4d1177744d26bf7065f8ee07
> Author: Jan Engelhardt <jengelh <at> medozas.de>
> Date:   Sat Oct 30 19:51:53 2010 +0200
> 
> scsi: netlink: avoid including netlink interface in scsi module
> 
> Only scsi_transport_fc needs it, so don't include it in scsi_mod
> if fc=m.
> 
> Signed-off-by: Jan Engelhardt <jengelh <at> medozas.de>

Mostly looks good to me, just one warning:

drivers/scsi/scsi_netlink.c:678: warning: initialization from incompatible pointer type

The init() function should return an int (status/error code).

> ---
>  drivers/scsi/Kconfig        |    3 ++-
>  drivers/scsi/Makefile       |    2 +-
>  drivers/scsi/scsi.c         |    3 ---
>  drivers/scsi/scsi_netlink.c |   11 ++++++-----
>  drivers/scsi/scsi_priv.h    |    7 +------
>  5 files changed, 10 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8616496..b4e1e2d 100644
> --- a/drivers/scsi/Kconfig

(Continue reading)

KaGeN101 | 1 Nov 2010 08:01

Picon

(unknown)

unsubscribe

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andi Kleen | 1 Nov 2010 12:45

Picon

Re: [ANNOUNCE] Status of unlocked_qcmds=1 operation for .37

> + XXX_queue_command(...
> + {
> + 	return SCSI_LOCKED_QUEUECOMMAND(XXX_queue_command_unlocked, ...);
> + }
> > -Andi
> 
> But since I'm only blabing, the one that "do", gets to decide  .
> Perhaps next time.

With semantics patches "do"ing is actually not that much effort ...

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

FUJITA Tomonori | 1 Nov 2010 13:56

Picon

Re: tcm IBMVSCSIS driver

On Sat, 30 Oct 2010 16:05:43 -0700
"Nicholas A. Bellinger" <nab <at> linux-iscsi.org> wrote:

> One final question in that regard is in your ibmvscsis_queuecommand()
> code, only INQUIRY, REPORT_LUNS, and MODE_SENSE need to be handled
> specially for other non Linux VIO SRP Initiator guests on the other
> end..

INQUIRY and REPORT_LUNS need the special responses. Otherwise the
initiators can't see the logical units.

> I would like to break this out (if possible) into individual
> specialized CDB fields / bits if possible so these special cases so we
> can drop excess emulation code in ibmvscsis.c.  This means we could
> (eventually) allow TCM/IBMVSCSIS to utilize the SPC-3+ emulation bits in
> INQUIRY for high level PR/ALUA emulation using SCSI_PROTOCOL_SRP for the
> EVPD=0x83 case.
> 
> So then perhaps this is more a question for brking and the POWER IBM
> folks.  Of the three CDBs in IBMVSCSIS (INQUIRY, REPORT_LUNS, and
> MODE_SENSE) that we are expecting to be done internally to fabric module
> code, are there any other specific bits you need set..?  Are there in
> any bits/fields in the code below that can not *not* be set..?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hillf Danton | 1 Nov 2010 14:02

Picon

[PATCH] fix scsi cmnd retries in error handling

There are two instances of increment and test of retries of scsi cmnd
in functions scsi_decide_disposition() and scsi_eh_flush_done_q()
respectively.

One of the increments is overwork when the corresponding cmnds are same.
The overwork is fixed in scsi_decide_disposition().

Signed-off-by: Hillf Danton <dhillf <at> gmail.com>
---

--- a/drivers/scsi/scsi_error.c	2010-09-13 07:07:38.000000000 +0800
+++ b/drivers/scsi/scsi_error.c	2010-11-01 20:39:38.000000000 +0800
 <at>  <at>  -1541,7 +1541,7  <at>  <at>  int scsi_decide_disposition(struct scsi_
 	 * the request was not marked fast fail.  Note that above,
 	 * even if the request is marked fast fail, we still requeue
 	 * for queue congestion conditions (QUEUE_FULL or BUSY) */
-	if ((++scmd->retries) <= scmd->allowed
+	if (scmd->retries < scmd->allowed
 	    && !scsi_noretry_cmd(scmd)) {
 		return NEEDS_RETRY;
 	} else {
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hillf Danton | 1 Nov 2010 14:13

Picon

[PATCH] fix queue full in scsi error handling

Upon event that queue is full there seems the relevant time mark
should be updated.

Tedious check for sane depth of queue is also added before issuing the
callback of LLDD.

Signed-off-by: Hillf Danton <dhillf <at> gmail.com>
---

--- a/drivers/scsi/scsi_error.c	2010-09-13 07:07:38.000000000 +0800
+++ b/drivers/scsi/scsi_error.c	2010-11-01 20:48:26.000000000 +0800
 <at>  <at>  -405,6 +405,7  <at>  <at>  static void scsi_handle_queue_full(struc

 	if (!sht->change_queue_depth)
 		return;
+	sdev->last_queue_full_time = jiffies;

 	shost_for_each_device(tmp_sdev, sdev->host) {
 		if (tmp_sdev->channel != sdev->channel ||
 <at>  <at>  -415,8 +416,10  <at>  <at>  static void scsi_handle_queue_full(struc
 		 * the device when we got the queue full so we start
 		 * from the highest possible value and work our way down.
 		 */
-		sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth - 1,
-					SCSI_QDEPTH_QFULL);
+		if (tmp_sdev->queue_depth > 1)
+			sht->change_queue_depth(tmp_sdev,
+						tmp_sdev->queue_depth - 1,
+						SCSI_QDEPTH_QFULL);
 	}

(Continue reading)

Hillf Danton | 1 Nov 2010 14:25

Picon

[PATCH] fix typo in scsi_handle_queue_ramp_up()

There seems cleanup of typo needed.

If only sdev is concerned its time mark could be updated after scanning devices.

Signed-off-by: Hillf Danton <dhillf <at> gmail.com>
---

--- a/drivers/scsi/scsi_error.c	2010-09-13 07:07:38.000000000 +0800
+++ b/drivers/scsi/scsi_error.c	2010-11-01 20:50:32.000000000 +0800
 <at>  <at>  -394,7 +394,7  <at>  <at>  static void scsi_handle_queue_ramp_up(st
 		 */
 		sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1,
 					SCSI_QDEPTH_RAMP_UP);
-		sdev->last_queue_ramp_up = jiffies;
+		tmp_sdev->last_queue_ramp_up = jiffies;
 	}
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

James Bottomley | 1 Nov 2010 14:38

Picon

Re: [PATCH] fix scsi cmnd retries in error handling

On Mon, 2010-11-01 at 21:02 +0800, Hillf Danton wrote:
> There are two instances of increment and test of retries of scsi cmnd
> in functions scsi_decide_disposition() and scsi_eh_flush_done_q()
> respectively.

This analysis is incomplete.  Those two functions are called in
completely separate paths, so you can't remove the increment from one
and expect the other to compensate.

James

> One of the increments is overwork when the corresponding cmnds are same.
> The overwork is fixed in scsi_decide_disposition().
> 
> Signed-off-by: Hillf Danton <dhillf <at> gmail.com>
> ---
> 
> --- a/drivers/scsi/scsi_error.c	2010-09-13 07:07:38.000000000 +0800
> +++ b/drivers/scsi/scsi_error.c	2010-11-01 20:39:38.000000000 +0800
>  <at>  <at>  -1541,7 +1541,7  <at>  <at>  int scsi_decide_disposition(struct scsi_
>  	 * the request was not marked fast fail.  Note that above,
>  	 * even if the request is marked fast fail, we still requeue
>  	 * for queue congestion conditions (QUEUE_FULL or BUSY) */
> -	if ((++scmd->retries) <= scmd->allowed
> +	if (scmd->retries < scmd->allowed
>  	    && !scsi_noretry_cmd(scmd)) {
>  		return NEEDS_RETRY;
>  	} else {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

(Continue reading)

Hillf Danton | 1 Nov 2010 14:41

Picon

[PATCH] add yielding cpu in scsi_error_handler()

In cases that it is not ready to unjam host, the operation could be
deferred by yielding cpu since busy testing earns little help.

Signed-off-by: Hillf Danton <dhillf <at> gmail.com>
---

--- a/drivers/scsi/scsi_error.c	2010-09-13 07:07:38.000000000 +0800
+++ b/drivers/scsi/scsi_error.c	2010-11-01 20:56:36.000000000 +0800
 <at>  <at>  -1765,6 +1765,7  <at>  <at>  int scsi_error_handler(void *data)
 			SCSI_LOG_ERROR_RECOVERY(1,
 				printk("Error handler scsi_eh_%d sleeping\n",
 					shost->host_no));
+	yield:
 			schedule();
 			set_current_state(TASK_INTERRUPTIBLE);
 			continue;
 <at>  <at>  -1785,7 +1786,8  <at>  <at>  int scsi_error_handler(void *data)
 				printk(KERN_ERR "Error handler scsi_eh_%d "
 						"unable to autoresume\n",
 						shost->host_no));
-			continue;
+			set_current_state(TASK_INTERRUPTIBLE);
+			goto yield;
 		}

 		if (shost->transportt->eh_strategy_handler)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Group

gmane.linux.scsi.

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 68

Articles in period: 678

November 2010

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity s (26 May 2013)
[PATCH 0/1] ipr: possible irq lock inversion dependency detected (24 May 2013)
Question: eh_abort_handler() and terminate commands (24 May 2013)
[PATCH 0/4] New FC timeout handler (24 May 2013)
re :SCSI error handling -- one error blocks the whole SCSI host (23 May 2013)
SCSI error handling -- one error blocks the whole SCSI host (23 May 2013)
[PATCH] scsi: use platform_{get,set}_drvdata() (23 May 2013)
Hello (23 May 2013)
[PATCH 12/12] megaraid_sas : Changelog and driver version update (22 May 2013)
[PATCH 11/12] megaraid_sas : Add support to differentiate between iMR (22 May 2013)
[PATCH 10/12] megaraid_sas : Add support for Uneven Span PRL11 (22 May 2013)
[PATCH 09/12] megaraid_sas : Add support for Extended MSI-x vectors fo (22 May 2013)
[PATCH 08/12] megaraid_sas : Set IoFlags to enable Fast Path for JBODs (22 May 2013)
[PATCH 07/12] megaraid_sas : Add support to display Customer branding (22 May 2013)
[PATCH 06/12] megaraid_sas : Add support for MegaRAID Fury (device ID- (22 May 2013)
[PATCH 05/12] megaraid_sas : Set IO request timeout value provided by (22 May 2013)
[PATCH 04/12] megaraid_sas : Free event detail memory without device I (22 May 2013)
[PATCH 03/12] megaraid_sas : Update balance count in driver to be in s (22 May 2013)
[PATCH 02/12] megaraid_sas : Fix the interrupt mask for Gen2 controlle (22 May 2013)
[PATCH 01/12] megaraid_sas : Return DID_ERROR for SCSI IO, when contro (22 May 2013)
[PATCH 00/12] megaraid_sas : Updates for scsi for-next (22 May 2013)

Archives

377	May 2013
366	April 2013
352	March 2013
387	February 2013
287	January 2013
323	December 2012
294	November 2012
333	October 2012
445	September 2012
393	August 2012
266	July 2012
340	June 2012
558	May 2012
356	April 2012
505	March 2012
423	February 2012
441	January 2012
347	December 2011
255	November 2011
300	October 2011
262	September 2011
467	August 2011
643	July 2011
392	June 2011
430	May 2011
255	April 2011
578	March 2011
514	February 2011
513	January 2011
479	December 2010
642	November 2010
502	October 2010
600	September 2010
441	August 2010
581	July 2010
480	June 2010
481	May 2010
363	April 2010
530	March 2010
429	February 2010
340	January 2010
400	December 2009
635	November 2009
387	October 2009
848	September 2009
930	August 2009
620	July 2009
769	June 2009
985	May 2009
1000	April 2009
744	March 2009
656	February 2009
824	January 2009
896	December 2008
669	November 2008
757	October 2008
586	September 2008
711	August 2008
874	July 2008
614	June 2008
782	May 2008
802	April 2008
1115	March 2008
1200	February 2008
1057	January 2008
712	December 2007
555	November 2007
1117	October 2007
805	September 2007
562	August 2007
1027	July 2007
445	June 2007
769	May 2007
485	April 2007
507	March 2007
544	February 2007
598	January 2007
419	December 2006
508	November 2006
612	October 2006
490	September 2006
629	August 2006
471	July 2006
727	June 2006
569	May 2006
519	April 2006
812	March 2006
796	February 2006
711	January 2006
539	December 2005
647	November 2005
743	October 2005
1018	September 2005
825	August 2005
484	July 2005
552	June 2005
559	May 2005
593	April 2005
614	March 2005
492	February 2005
499	January 2005
297	December 2004
441	November 2004
729	October 2004
734	September 2004
615	August 2004
294	July 2004
642	June 2004
460	May 2004
552	April 2004
472	March 2004
592	February 2004
653	January 2004
325	December 2003
541	November 2003
426	October 2003
395	September 2003
400	August 2003
304	July 2003
361	June 2003
438	May 2003
349	April 2003
362	March 2003
302	February 2003
403	January 2003
250	December 2002
417	November 2002
465	October 2002
290	September 2002
217	August 2002
226	July 2002
257	June 2002
133	May 2002
142	April 2002

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template