Noriyuki Fujii | 1 Dec 02:15 2009

Re: [PATCH 2nd try] PCI legacy I/O port free driver - Making MegaRAID SAS driver

James,

 > I need a Signed-off-by for this (see Documentation/SubmittingPatches).

 > This is taking away a tab and substituting spaces ... our style is to
 > use tabs.  You can run the patch through scripts/checkpatch.pl and it
 > will advise on problems like this.

I've already posted the patch obeying the community rules.
Could you see the following URL?

http://marc.info/?l=linux-scsi&m=125870212508167&w=2

Thanks,
Noriyuki Fujii

> On Wed, 2009-10-14 at 10:03 +0900, Noriyuki Fujii wrote:
>> Hi,
>>
>> Here's my 2nd try of the following post.
>>
>> http://marc.info/?l=linux-scsi&m=124962265606425&w=2
>>
>> I made a patch for MegaRAID sas driver to make PCI legacy I/O port free.
>>
>> The way to make PCI legacy I/O port free is the same as Fusion-MPT
>> driver's and it has been merged into 2.6.30.4.
>>
>> This has already been fixed in e1000 and lpfc.
>>
(Continue reading)

Ryousei Takano | 1 Dec 02:30 2009
Picon

Re: OCZ Z-drive p84 read performance

Hi Matthew and Kashyap,

Thanks for your comments!

On Tue, Dec 1, 2009 at 1:11 AM, Matthew Wilcox <matthew <at> wil.cx> wrote:
> On Mon, Nov 30, 2009 at 08:07:58PM +0530, Desai, Kashyap wrote:
>> > for i in 1 4 16 64 256 512 1024 2048 4096 8192 16384 32768 65536; do
>> >         bs=$((BS * i))
>> >         count=$((COUNT / i))
>> >
>> >         echo bs=$bs count=$count
>> >         sudo mount /dev/sdb1 /media/test
>> >         dd if=/dev/zero of=/media/test/foo bs=$bs count=$count
>> >         sudo umount /media/test
>> >         sleep 1
>> >         sudo mount /dev/sdb1 /media/test
>> >         dd if=/media/test/foo of=/dev/null bs=$bs count=$count
>> Replace /media/test/foo with /dev/sdb1, you will see raw read
>> >         rm /media/test/foo
>> >         sudo umount /media/test
>> > done
>> >
>> This test is not purely RAW read/write test. In you test File system performance is also included. While
read operation, (sequential read) File system buffering will give huge advantage to data transfer.
>
> Both filesystem and block access will use the page cache.  You should
> use iflag=direct (or oflag=direct as appropriate) in order to bypass
> the page cache.
>
> --
(Continue reading)

Joe Jin | 1 Dec 02:37 2009
Picon

[patch] qla2xxx: use F/W calculated residual length.

Hi,

When comp_status is CS_DATA_OVERRUN, residual length calculated by F/W,
but when comp_status is CS_COMMPLETE, residual length just set to residual
count, at here calculated residual length may via F/W?

Please review.

Signed-off-by: Joe Jin <joe.jin <at> oracle.com>
CC: Andrew Vasquez <andrew.vasquez <at> qlogic.com>

---
 qla_isr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index b20a716..4d1d410 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
 <at>  <at>  -1398,7 +1398,7  <at>  <at>  qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt)
 			break;
 		}
 		if (scsi_status & (SS_RESIDUAL_UNDER | SS_RESIDUAL_OVER)) {
-			resid = resid_len;
+			resid = IS_FWI2_CAPABLE(ha) ? fw_resid_len : resid_len;
 			scsi_set_resid(cp, resid);

 			if (!lscsi_status &&

--
(Continue reading)

Ryousei Takano | 1 Dec 04:25 2009
Picon

Re: OCZ Z-drive p84 read performance

Hi,

On Tue, Dec 1, 2009 at 10:30 AM, Ryousei Takano <ryousei <at> gmail.com> wrote:
> Hi Matthew and Kashyap,
>
> Thanks for your comments!
>
> On Tue, Dec 1, 2009 at 1:11 AM, Matthew Wilcox <matthew <at> wil.cx> wrote:
>> On Mon, Nov 30, 2009 at 08:07:58PM +0530, Desai, Kashyap wrote:
>>> > for i in 1 4 16 64 256 512 1024 2048 4096 8192 16384 32768 65536; do
>>> >         bs=$((BS * i))
>>> >         count=$((COUNT / i))
>>> >
>>> >         echo bs=$bs count=$count
>>> >         sudo mount /dev/sdb1 /media/test
>>> >         dd if=/dev/zero of=/media/test/foo bs=$bs count=$count
>>> >         sudo umount /media/test
>>> >         sleep 1
>>> >         sudo mount /dev/sdb1 /media/test
>>> >         dd if=/media/test/foo of=/dev/null bs=$bs count=$count
>>> Replace /media/test/foo with /dev/sdb1, you will see raw read
>>> >         rm /media/test/foo
>>> >         sudo umount /media/test
>>> > done
>>> >
>>> This test is not purely RAW read/write test. In you test File system performance is also included. While
read operation, (sequential read) File system buffering will give huge advantage to data transfer.
>>
>> Both filesystem and block access will use the page cache.  You should
>> use iflag=direct (or oflag=direct as appropriate) in order to bypass
(Continue reading)

Davidlohr Bueso | 1 Dec 13:43 2009
Picon

Re: [PATCH 00/20] SCSI: No longer use Scsi_Cmd typedef

> Thanks for doing this. What a grate relief.

Just following up on the status of the patch.

Thanks,
Davidlohr
James Bottomley | 1 Dec 15:06 2009
Picon

Re: [GIT PATCH] SCSI fixes for 2.6.32-rc8

On Tue, 2009-12-01 at 08:03 +0900, FUJITA Tomonori wrote:
> On Mon, 30 Nov 2009 17:29:54 -0500
> James Bottomley <James.Bottomley <at> suse.de> wrote:
> 
> > This is a set of miscellaneous (but small) fixes for SCSI.
> > 
> > The patch is available here:
> > 
> > master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
> > 
> > The short changelog is:
> > 
> > Alexey Kuznetsov (1):
> >       fix crash when disconnecting usb storage
> > 
> > James Bottomley (1):
> >       fix async scan add/remove race resulting in an oops
> > 
> > Martin K. Petersen (1):
> >       sd: Return correct error code for DIF
> > 
> > The diffstat is:
> > 
> >  drivers/scsi/hosts.c       |    2 -
> >  drivers/scsi/scsi_scan.c   |   18 ++----------
> >  drivers/scsi/scsi_sysfs.c  |   63 +++++++++++++++++++--------------------------
> >  drivers/scsi/sd_dif.c      |    2 -
> >  include/scsi/scsi_device.h |    1 
> >  5 files changed, 34 insertions(+), 52 deletions(-)
> 
(Continue reading)

Boaz Harrosh | 1 Dec 16:30 2009

[PATCH 0/1] libosd bug fixing


James hi.

Users have found an annoying bug in latest osd/exofs code. Actually this
deficiency exists for a long time, but only most recent exofs code has
exposed it.

Please include the fix to the patches queued for 2.6.33. No need for it
to go into stable as current users will not hit it.

[PATCH 1/1] libosd: Fix blk_put_request locking again

Vineet Please test this new patch, the previous fix was crap

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Boaz Harrosh | 1 Dec 16:36 2009

[PATCH 1/1] libosd: Fix blk_put_request locking again


So libosd has decided to sacrifice some code simplicity for the sake of
a clean API. One of these things is the possibility for users to call
osd_end_request, in any condition at any state. This opens up some
problems with calling blk_put_request when out-side of the completion
callback but calling __blk_put_request when detecting a from-completion
state.

The current hack was working just fine until exofs decided to operate on
all devices in parallel and wait for the sum of the requests, before
deallocating all osd-requests at once. There are two new possible cases
1. All request in a group are deallocated as part of the last request's
   async-done, request_queue is locked.
2. All request in a group where executed asynchronously, but
   de-allocation was delayed to after the async-done, in the context of
   another thread. Async execution but request_queue is not locked.

The solution I chose was to separate the deallocation of the osd_request
which has the information users need, from the deallocation of the
internal(2) requests which impose the locking problem. The internal
block-requests are freed unconditionally inside the async-done-callback,
when we know the queue is always locked. If at osd_end_request time we
still have a bock-request, then we know it did not come from within an
async-done-callback and we can call the regular blk_put_request.

The internal requests were used for carrying error information after
execution. This information is now copied to osd_request members for
later analysis by user code.

The external API and behaviour was unchanged, except now it really
(Continue reading)

Kleber Sacilotto de Souza | 1 Dec 17:54 2009
Picon

Re: [GIT PATCH] SCSI fixes for 2.6.32-rc8

On Mon, 2009-11-30 at 17:29 -0500, James Bottomley wrote:
> This is a set of miscellaneous (but small) fixes for SCSI.
> 
> The patch is available here:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git
> 
> The short changelog is:
> 
> Alexey Kuznetsov (1):
>       fix crash when disconnecting usb storage
> 
> James Bottomley (1):
>       fix async scan add/remove race resulting in an oops
> 
> Martin K. Petersen (1):
>       sd: Return correct error code for DIF
> 
> The diffstat is:
> 
>  drivers/scsi/hosts.c       |    2 -
>  drivers/scsi/scsi_scan.c   |   18 ++----------
>  drivers/scsi/scsi_sysfs.c  |   63 +++++++++++++++++++--------------------------
>  drivers/scsi/sd_dif.c      |    2 -
>  include/scsi/scsi_device.h |    1 
>  5 files changed, 34 insertions(+), 52 deletions(-)

Can you please add the patch from "[PATCH] ipr: fix EEH recovery" sent
to this list?

(Continue reading)

James Bottomley | 1 Dec 18:13 2009
Picon

Re: [GIT PATCH] SCSI fixes for 2.6.32-rc8

On Tue, 2009-12-01 at 14:54 -0200, Kleber Sacilotto de Souza wrote:
> Can you please add the patch from "[PATCH] ipr: fix EEH recovery" sent
> to this list?

Adding linux-pci because this hack actually tampers with internal PCI
device state, which looks wrong.

The thread is here:

http://marc.info/?l=linux-scsi&m=125918723218627

and the proposed full patch and explanation below.

PCI people, is this correct, or is there a better way to do it?

James

---

Hi,

After commits c82f63e411f1b58427c103bd95af2863b1c96dd1 (PCI: check saved
state before restore) and 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff (PCI:
Clear saved_state after the state has been restored) PCI drivers are
prevented from restoring the device standard configuration registers
twice in a row. These changes introduced a regression on ipr EEH
recovery.

The ipr device driver saves the PCI state only during the device probe
and restores it on ipr_reset_restore_cfg_space() during IOA resets. This
(Continue reading)


Gmane