headers
Neil Brown | 1 Jul 2009 02:29
X-Face
Picon
Gravatar

Re: [dm-devel] REQUEST for new 'topology' metrics to be moved out of the 'queue' sysfs directory.

On Tuesday June 30, adilger <at> sun.com wrote:
> On Jun 29, 2009  13:41 +0200, Jens Axboe wrote:
> > ... externally it just makes the API worse since tools then have to know
> > which device type they are talking to.
> > 
> > So I still see absolutely zero point in making such a change, quite the
> > opposite.
> 
> Exactly correct.  Changing these tunables just for the sake of giving
> them a slightly different name is madness.  Making all block devices
> appear more uniform to userspace (even if they don't strictly need all
> of the semantics) is very sensible.  The whole point of the kernel is
> to abstract away the underlying details so that userspace doesn't need
> to understand it all again.

Uniformity is certainly desirable.  But we shouldn't take it so far
as to make apples look like oranges.

We wouldn't want a SATA disk drive to have 'chunk_size' and 'raid_disks'.
Nor would we want a software RAID array to have a 'scheduler' or
'iosched' attributes.

> 
> In order to get good throughput on RAID arrays we need to tune the
> queue/max_* values to ensure the IO requests don't get split.
> 
> It would be great if the MD queue/max_* values would pass these tunings
> down to the underlying disk devices as well.  As it stands now, we have
> to follow the /sys/block/*/slaves tree to set all of these ourselves,
> and before "slaves/" was introduced it was nigh impossible to automatically
(Continue reading)

Permalink | Reply | 0 comments |
headers
Joe Jin | 1 Jul 2009 02:54
Picon
Favicon

kexec kernel failed to restart aacraid device

Hi,

When try to kdump via sysrq-trigger, found kernel hung when 
try to restart aacraid device, kernel print below messages:

  Loading aacraid.ko
  AAC0:  adapter kernel faile to start, init status = 0.

Normally startup, got following message what related the devices:

  Adaptec aacraid driver 1.1-5[2461]
  AAC0: kernel 4.2-0[8208] Jul  6 2006
  AAC0: monitor 4.2-0[8208]
  AAC0: bios 4.2-0[8208]
  AAC0: serial C36FA5
  AAC0: Non-DASD support enabled.

Device info from lspci:

02:03.0 0104: 9005:0285 (rev 01)                                                            
        Subsystem: 9005:0286
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B- 
        Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=slow >TAbort- <TAbort- <MAbort- >SERR- <PERR- 
        Latency: 64 (250ns min, 250ns max), Cache Line Size: 64 bytes                       
        Interrupt: pin A routed to IRQ 177                                                  
        Region 0: Memory at f8000000 (32-bit, prefetchable) [size=64M]
        Expansion ROM at fc9f0000 [disabled] [size=32K]                                     
        Capabilities: [80] Power Management version 2
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)  
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tomasz Torcz | 1 Jul 2009 08:10
Picon

Re: can't access LUN >2TB with aic7xxx, Infortrend EonStor and 2.6.31-rc1

On Tue, Jun 30, 2009 at 03:48:19PM +0000, James Bottomley wrote:
> On Tue, 2009-06-30 at 11:40 +0200, Tomasz Torcz wrote:
> >   I did a rebuild and driver is not happy with above changes. Take a look
> > (I have one RAID5 LUN exported which consist 8x500GB, so about 3.5 TB big):
> 
> Actually, looks like a simple thinko in the aic7xxx core code ... it
> should be indexing of the saved tag not the original tag.  Can you try
> this as a fresh patch?
> 
> James
> 
> ---
> 
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
> index e6f2bb7..56e431e 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_core.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_core.c
>  <at>  <at>  -593,7 +593,7  <at>  <at>  ahc_swap_with_next_hscb(struct ahc_softc *ahc, struct scb *scb)
>  	memcpy(q_hscb, scb->hscb, sizeof(*scb->hscb));
>  	if ((scb->flags & SCB_CDB32_PTR) != 0) {
>  		q_hscb->shared_data.cdb_ptr =
> -		    ahc_htole32(ahc_hscb_busaddr(ahc, q_hscb->tag)
> +		    ahc_htole32(ahc_hscb_busaddr(ahc, saved_tag)
>  			      + offsetof(struct hardware_scb, cdb32));
>  	}
>  	q_hscb->tag = saved_tag;
> diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c
> index fd2b978..2d069de 100644
> --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c
(Continue reading)

Permalink | Reply | 1 comment |
headers
jack wang | 1 Jul 2009 14:07

[RFC][PATCH 0/5]PMC-Sierra PM8001 PCIE 8x6G SAS/SATA HBA driver

The following series implements a driver for a PMC-Sierra PM8001 PCIE 8x6G
SAS/SATA HBA. This driver is base on libsas modules . In the patch set ,
There are two patches for libsas(patch 3 & 4).

This patch series applies on top of scsi-misc-2.6.git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git

The driver interfaces with scsi and libsas .

Patch 1) Add pm8001 SAS/SATA HBA driver to scsi Makefile

Patch 2) Add pm8001 SAS/SATA HBA driver to scsi Kconfig

Patch 3) reuse the original port when reenable the phy in a port

Patch 4) fix wide port hotplug issues

Patch 5) Add pm8001 SAS/SATA HBA driver

Thanks for any reviews and comments
Jack Wang

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
jack wang | 1 Jul 2009 14:33

[RFC][PATCH 1/5] Add pm8001 SAS/SATA HBA driver to scsi Makefile

From b031ca9e1fc4b1c758bc4afb48fbf06dd251fb23 Mon Sep 17 00:00:00 2001
From: Jack Wang <jack_wang <at> usish.com>
Date: Wed, 1 Jul 2009 18:48:02 +0800
Subject: [PATCH 1/5] Add pm8001 SAS/SATA HBA driver to scsi Makefile

Signed-off-by: Jack Wang <jack_wang <at> usish.com>
Signed-off-by: Lindar Liu <lindar_liu <at> usish.com>
Signed-off-by: Tom Peng <tom_peng <at> usish.com>
---
 drivers/scsi/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 25429ea..5945917 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
 <at>  <at>  -70,6 +70,7  <at>  <at>  obj-$(CONFIG_SCSI_AIC79XX)	+= aic7xxx/
 obj-$(CONFIG_SCSI_AACRAID)	+= aacraid/
 obj-$(CONFIG_SCSI_AIC7XXX_OLD)	+= aic7xxx_old.o
 obj-$(CONFIG_SCSI_AIC94XX)	+= aic94xx/
+obj-$(CONFIG_SCSI_PM8001)	+= pm8001/
 obj-$(CONFIG_SCSI_IPS)		+= ips.o
 obj-$(CONFIG_SCSI_FD_MCS)	+= fd_mcs.o
 obj-$(CONFIG_SCSI_FUTURE_DOMAIN)+= fdomain.o
--

--
Attachment (0001-Add-pm8001-SAS-SATA-HBA-driver-to-scsi-Makefile.patch): application/octet-stream, 938 bytes
Permalink | Reply | 0 comments |
headers
jack wang | 1 Jul 2009 14:35

[RFC][PATCH 2/5] Add pm8001 SAS/SATA HBA driver to scsi Kconfig

From 9bb30481d2f2c0153516e6c9b9396bd8b0c64f1a Mon Sep 17 00:00:00 2001
From: Jack Wang <jack_wang <at> usish.com>
Date: Wed, 1 Jul 2009 18:57:11 +0800
Subject: [PATCH 2/5] Add pm8001 SAS/SATA HBA driver to scsi Kconfig

Signed-off-by: Jack Wang <jack_wang <at> usish.com>
Signed-off-by: Lindar Liu <lindar_liu <at> usish.com>
Signed-off-by: Tom Peng <tom_peng <at> usish.com>
---
 drivers/scsi/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 9c23122..0fd285f 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
 <at>  <at>  -520,7 +520,7  <at>  <at>  config SCSI_AIC7XXX_OLD
 source "drivers/scsi/aic7xxx/Kconfig.aic79xx"
 source "drivers/scsi/aic94xx/Kconfig"
 source "drivers/scsi/mvsas/Kconfig"
-
+source "drivers/scsi/pm8001/Kconfig"
 config SCSI_DPT_I2O
 	tristate "Adaptec I2O RAID support "
 	depends on SCSI && PCI && VIRT_TO_BUS
--

--
Attachment (0002-Add-pm8001-SAS-SATA-HBA-driver-to-scsi-Kconfig.patch): application/octet-stream, 897 bytes
Permalink | Reply | 0 comments |
headers
jack wang | 1 Jul 2009 14:37

[PATCH 3/5] reuse the original port when reenable the phy in a port

From 24abd7f05d2293e03aacbdd9d620d6378ea5e2aa Mon Sep 17 00:00:00 2001
From: Tom Peng <tom_peng <at> usish.com>
Date: Wed, 1 Jul 2009 19:04:01 +0800
Subject: [PATCH 3/5] reuse the original port when reenable the phy in a port

Signed-off-by: Tom Peng <tom_peng <at> usish.com>
Signed-off-by: Jack Wang <jack_wang <at> usish.com>
Signed-off-by: Lindar Liu <lindar_liu <at> usish.com>
---
 drivers/scsi/libsas/sas_port.c |   19 +++++++++++++++----
 1 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c
index e6ac59c..5aad165 100644
--- a/drivers/scsi/libsas/sas_port.c
+++ b/drivers/scsi/libsas/sas_port.c
 <at>  <at>  -69,16 +69,27  <at>  <at>  static void sas_form_port(struct asd_sas_phy *phy)
 			SAS_DPRINTK("phy%d matched wide port%d\n", phy->id,
 				    port->id);
 			break;
-		} else if (*(u64 *) port->sas_addr == 0 &&
port->num_phys==0) {
-			memcpy(port->sas_addr, phy->sas_addr,
SAS_ADDR_SIZE);
-			break;
 		}
 		spin_unlock(&port->phy_list_lock);
 	}
+	/* The phy does not match any port currently existed, create new one
*/
(Continue reading)

Permalink | Reply | 3 comments |
headers
jack wang | 1 Jul 2009 14:41

[RFC][PATCH 4/5] fix wide port hotplug issues

The sas layer does not support wide port hotplug, we modified it. For
plugging out, we un-register the device only when it is the last phy in the
port, for other phys in this port, we just delete it from the port.For
inserting, we do discovery when it is the first phy,for other phys in this
port, we add it to the port to
forming the wide-port.
					Jack
From d683c649d0ed8de69b1ffda1b87383ae13fed164 Mon Sep 17 00:00:00 2001
From: Tom Peng <tom_peng <at> usish.com>
Date: Wed, 1 Jul 2009 19:11:03 +0800
Subject: [PATCH 4/5] fix wide port hotplug issues

Signed-off-by: Tom Peng <tom_peng <at> usish.com>
Signed-off-by: Jack Wang <jack_wang <at> usish.com>
Signed-off-by: Lindar Liu <lindar_liu <at> usish.com>
---
 drivers/scsi/libsas/sas_expander.c |  190
++++++++++++++++++++++++------------
 1 files changed, 126 insertions(+), 64 deletions(-)

diff --git a/drivers/scsi/libsas/sas_expander.c
b/drivers/scsi/libsas/sas_expander.c
index 54fa1e4..20fa5e4 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
 <at>  <at>  -764,8 +764,9  <at>  <at>  static int sas_ex_join_wide_port(struct domain_device
*parent, int phy_id)
 			continue;

 		if (!memcmp(phy->attached_sas_addr, ephy->attached_sas_addr,
(Continue reading)

Permalink | Reply | 3 comments |
headers
James Bottomley | 1 Jul 2009 16:19

Re: can't access LUN >2TB with aic7xxx, Infortrend EonStor and 2.6.31-rc1

On Wed, 2009-07-01 at 08:10 +0200, Tomasz Torcz wrote:
>   Still not good:
> sd 6:0:0:0: Attached scsi generic sg2 type 0
> sd 6:0:0:1: Attached scsi generic sg3 type 0
> sd 6:0:0:0: [sdc] Spinning up disk...
> sd 6:0:0:1: [sdd] Spinning up disk........ready
> sd 6:0:0:0: [sdc] Very big device. Trying to use READ CAPACITY(16).
> (scsi6:A:0:0): No or incomplete CDB sent to device.
> (scsi6:A:0:0): Protocol violation in Message-in phase.  Attempting to abort.
> (scsi6:A:0:0): Abort Tag Message Sent
> (scsi6:A:0:0): SCB 2 - Abort Tag Completed.
> (scsi6:A:0:0): No or incomplete CDB sent to device.
> (scsi6:A:0:0): Protocol violation in Message-in phase.  Attempting to abort.
> (scsi6:A:0:0): Abort Tag Message Sent
> (scsi6:A:0:0): SCB 3 - Abort Tag Completed.
> 
> 
>  ... and so on.
>  Maybe this HBA is too old? Newest BIOS for it is from year 2000. I've checked
> another controller, sym53c8xx driven, it shows 3,5TB briefly before reverting to 2TB,
> so array itself is reporting OK.

OK ... I'll look again.  The only doc I have for this is a 1998 HIM
guide for the u160 chip, so it's possible earlier versions didn't
support the >12 CDBs but I'd expect a field warning in that case and I
don't see one.

Chances are there's simply another issue in the driver that I haven't
seen yet.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andy Whitcroft | 1 Jul 2009 17:58
Favicon

Re: [PATCH 1/1] Reduce AACRAID hardware queue size

On Tue, Jun 23, 2009 at 06:04:08PM +0200, Matthias Urlichs wrote:
> Hi,
> 
> James Bottomley:
> > Firstly, Matthias, can you see if on an unmodified aacraid, this fixes
> > the problem for you:
> > 
> > echo 63 > /sys/block/≤disk>/queue/max_sectors_kb
> > 
> Thank you, I'll do that tonight.

How did this one work out for you?  I don't think I saw a reply either
way?

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |

Gmane