headers
Ed Lin | 1 Apr 2009 03:30

[PATCH 3/5] stex:use config struct for parameters of different controllers

Use config struct (st_card_info) for parameters of different controllers

Signed-off-by: Ed Lin <ed.lin <at> promise.com>
---

 drivers/scsi/stex.c |  201 ++++++++++++++++++++++++++++++++-------------------
 1 files changed, 125 insertions(+), 76 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index c4eb5c1..75f5079 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
 <at>  <at>  -95,19 +95,8  <at>  <at>  enum {
 	TASK_ATTRIBUTE_ORDERED			= 0x2,
 	TASK_ATTRIBUTE_ACA			= 0x4,

-	/* request count, etc. */
-	MU_MAX_REQUEST				= 32,
-
-	/* one message wasted, use MU_MAX_REQUEST+1
-		to handle MU_MAX_REQUEST messages */
-	MU_REQ_COUNT				= (MU_MAX_REQUEST + 1),
-	MU_STATUS_COUNT				= (MU_MAX_REQUEST + 1),
-
 	STEX_CDB_LENGTH				= 16,
-	REQ_VARIABLE_LEN			= 1024,
 	STATUS_VAR_LEN				= 128,
-	ST_CAN_QUEUE				= MU_MAX_REQUEST,
-	ST_CMD_PER_LUN				= MU_MAX_REQUEST,
 	ST_MAX_SG				= 32,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ed Lin | 1 Apr 2009 03:30

[PATCH 4/5] stex:add new controller support

This adds the support of a new SAS 6G controller (st_yel)

Signed-off-by: Ed Lin <ed.lin <at> promise.com>
---

 drivers/scsi/stex.c |  382 ++++++++++++++++++++++++++++++++++++++++++++++----
 1 files changed, 351 insertions(+), 31 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 75f5079..4e2b2af 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
 <at>  <at>  -55,6 +55,13  <at>  <at>  enum {
 	OIS	= 0x30,	/* MU_OUTBOUND_INTERRUPT_STATUS */
 	OIM	= 0x3c,	/* MU_OUTBOUND_INTERRUPT_MASK */

+	YH2I_INT				= 0x20,
+	YINT_EN					= 0x34,
+	YI2H_INT				= 0x9c,
+	YI2H_INT_C				= 0xa0,
+	YH2I_REQ				= 0xc0,
+	YH2I_REQ_HI				= 0xc4,
+
 	/* MU register value */
 	MU_INBOUND_DOORBELL_HANDSHAKE		= 1,
 	MU_INBOUND_DOORBELL_REQHEADCHANGED	= 2,
 <at>  <at>  -95,9 +102,14  <at>  <at>  enum {
 	TASK_ATTRIBUTE_ORDERED			= 0x2,
 	TASK_ATTRIBUTE_ACA			= 0x4,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ed Lin | 1 Apr 2009 03:30

[PATCH 5/5] stex:update version

Update version to 4.6.0000.3

Signed-off-by: Ed Lin <ed.lin <at> promise.com>
---

 drivers/scsi/stex.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 4e2b2af..df7f96c 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
 <at>  <at>  -36,11 +36,11  <at>  <at> 
 #include <scsi/scsi_eh.h>

 #define DRV_NAME "stex"
-#define ST_DRIVER_VERSION "4.6.0000.1"
-#define ST_VER_MAJOR 		4
-#define ST_VER_MINOR 		6
-#define ST_OEM 			0
-#define ST_BUILD_VER 		1
+#define ST_DRIVER_VERSION "4.6.0000.3"
+#define ST_VER_MAJOR		4
+#define ST_VER_MINOR		6
+#define ST_OEM			0
+#define ST_BUILD_VER		3

 enum {
 	/* MU register offset */
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ed Lin | 1 Apr 2009 03:30

[PATCH 1/5] stex:small code fixes and changes

These are some small code fixes and changes, including:
- use 64 bit when possible
- remove some unnecessary code (in interrupt, queuecommand routine etc.)
- code change for reset handler

Signed-off-by: Ed Lin <ed.lin <at> promise.com>
---

 drivers/scsi/stex.c |  125 ++++++++++++++++++++++++--------------------------
 1 files changed, 60 insertions(+), 65 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 47b614e..de6c30e 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
 <at>  <at>  -160,26 +160,22  <at>  <at>  struct st_sgitem {
 	u8 ctrl;	/* SG_CF_xxx */
 	u8 reserved[3];
 	__le32 count;
-	__le32 addr;
-	__le32 addr_hi;
+	__le64 addr;
 };

 struct st_sgtable {
 	__le16 sg_count;
 	__le16 max_sg_count;
 	__le32 sz_in_byte;
-	struct st_sgitem table[ST_MAX_SG];
 };
(Continue reading)

Permalink | Reply | 0 comments |
headers
Ed Lin | 1 Apr 2009 03:30

[PATCH 2/5] stex:add MSI support

This adds the MSI support (default 0=off)

Signed-off-by: Ed Lin <ed.lin <at> promise.com>
---

 drivers/scsi/stex.c |   48 +++++++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 43 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index de6c30e..c4eb5c1 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
 <at>  <at>  -292,11 +292,15  <at>  <at>  struct st_hba {
 	struct st_ccb *wait_ccb;

 	unsigned int mu_status;
-	int out_req_cnt;
-
 	unsigned int cardtype;
+	int msi_enabled;
+	int out_req_cnt;
 };

+static int msi;
+module_param(msi, int, 0);
+MODULE_PARM_DESC(msi, "Enable Message Signaled Interrupts(0=off, 1=on)");
+
 static const char console_inq_page[] =
 {
 	0x03,0x00,0x03,0x03,0xFA,0x00,0x00,0x30,
(Continue reading)

Permalink | Reply | 0 comments |
headers
Giridhar Malavali | 1 Apr 2009 03:06

Proposal to add sysfs attributes for FCoE in FC Transport layer

Hi SCSI mailing list,

	I'd like to propose following additions to sysfs to export statistics  
of FCoE host bus adapters.
The additions can be broadly divided into capabilities of FCoE HBA  
adapter and its statistics.
I am thinking of extending HBA specific informations inside the  
fc_host(/sys/class/fc_host/hostX) and make a seperate
attribute_group(/sys/class/fc_host/hostx/fcoe_statistics/) for fcoe  
statistics.

FCoE HBA specific information

1) enode_mac_address		/* Factory programmed MAC address */
2) vn_port_mac_address;     	/* Current programmed MAC address */
3) fcf_mac_address;			/* FCF mac address */
4) vlan_id:					/* Local VLAN ID */
5) mac_addressing_model	/* Whether SPMA or FPMA */

Current DCBX parameter details:

PGID (Priority group ID)

1) pgid_priority_group_0;       /* Priority group ID of priority group  
0 */
2) pgid_priority_group_1;       /* Priority group ID of priority group  
1 */
3) pgid_priority_group_2;       /* Priority group ID of priority group  
2 */
4) pgid_priority_group_3;       /* Priority group ID of priority group
(Continue reading)

Permalink | Reply | 5 comments |
headers
Bart Van Assche | 1 Apr 2009 08:29
Picon

Re: [Iscsitarget-devel] [Scst-devel] ISCSI-SCST performance (withalso IET and STGT data)

On Tue, Mar 31, 2009 at 8:43 PM, Ross S. W. Walker
<RWalker <at> medallion.com> wrote:
> IET just needs to fix how it does it workload with CFQ which
> somehow SCST has overcome. Of course SCST tweaks the Linux kernel to
> gain some extra speed.

I'm not familiar with the implementation details of CFQ, but I know
that one of the changes between SCST 1.0.0 and SCST 1.0.1 is that the
default number of kernel threads of the scst_vdisk kernel module has
been increased to 5. Could this explain the performance difference
between SCST and IET for FILEIO and BLOCKIO ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Ross Walker | 1 Apr 2009 14:20
Picon

Re: [Iscsitarget-devel] [Scst-devel] ISCSI-SCST performance (withalso IET and STGT data)

On Apr 1, 2009, at 2:29 AM, Bart Van Assche <bart.vanassche <at> gmail.com>  
wrote:

> On Tue, Mar 31, 2009 at 8:43 PM, Ross S. W. Walker
> <RWalker <at> medallion.com> wrote:
>> IET just needs to fix how it does it workload with CFQ which
>> somehow SCST has overcome. Of course SCST tweaks the Linux kernel to
>> gain some extra speed.
>
> I'm not familiar with the implementation details of CFQ, but I know
> that one of the changes between SCST 1.0.0 and SCST 1.0.1 is that the
> default number of kernel threads of the scst_vdisk kernel module has
> been increased to 5. Could this explain the performance difference
> between SCST and IET for FILEIO and BLOCKIO ?

Thank for the update. IET has used 8 threads per target for ages now,  
I don't think it is that.

It may be how the I/O threads are forked in SCST that causes them to  
be in the same I/O context with each other.

I'm pretty sure implementing a version of the patch that was used for  
the dump command (found on the LKML) will fix this.

But thanks goes to Vlad for pointing this dificiency out so we can fix  
it to help make IET even better.

-Ross

--
(Continue reading)

Permalink | Reply | 0 comments |
headers
Alan Cox | 1 Apr 2009 16:00
Picon

[PATCH 0/2] SCSI resends for merge

---

Alan Cox (2):
      mptsas: remove unneeded check
      config: Make need for SCSI_CDROM clearer

 drivers/message/fusion/mptsas.c |    5 ++---
 drivers/scsi/Kconfig            |    9 +++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

--

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 3 comments |
headers
Alan Cox | 1 Apr 2009 16:00
Picon

[PATCH 2/2] mptsas: remove unneeded check

From: Alan Cox <alan <at> redhat.com>

>From coverity checker. Closes #9675

Signed-off-by: Alan Cox <alan <at> redhat.com>
---

 drivers/message/fusion/mptsas.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
index 12b7325..a9019f0 100644
--- a/drivers/message/fusion/mptsas.c
+++ b/drivers/message/fusion/mptsas.c
 <at>  <at>  -2279,9 +2279,8  <at>  <at>  mptsas_delete_expander_phys(MPT_ADAPTER *ioc)
 	mutex_lock(&ioc->sas_topology_mutex);
 	list_for_each_entry_safe(port_info, n, &ioc->sas_topology, list) {

-		if (port_info->phy_info &&
-		    (!(port_info->phy_info[0].identify.device_info &
-		    MPI_SAS_DEVICE_INFO_SMP_TARGET)))
+		if (!(port_info->phy_info[0].identify.device_info &
+		    MPI_SAS_DEVICE_INFO_SMP_TARGET))
 			continue;

 		if (mptsas_sas_expander_pg0(ioc, &buffer,

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Permalink | Reply | 0 comments |

Gmane