Randy Dunlap | 1 Jun 2007 01:56
Picon
Favicon

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote:

> On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote:
> > Hello,
> > 
> > the build with the attached .config failed, make ends with:
> > ...
> >   CC      arch/i386/boot/compresse
> >   HOSTCC  arch/i386/boot/tools/build
> >   BUILD   arch/i386/boot/bzImage
> > Root device is (3, 8)
> > Boot sector 512 bytes.
> > Setup is 7178 bytes.
> > System is 2513 kB
> > Kernel: arch/i386/boot/bzImage is ready  (#1)
> >   Building modules, stage 2.
> >   MODPOST 363 modules
> > ERROR: "spi_dv_device" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_attach_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_populate_ppr_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_populate_width_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_release_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_display_xfer_agreement" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_populate_sync_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > ERROR: "spi_dv_device" [drivers/scsi/53c700.ko] undefined!
> > ERROR: "spi_attach_transport" [drivers/scsi/53c700.ko] undefined!
> > ERROR: "spi_schedule_dv_device" [drivers/scsi/53c700.ko] undefined!
> > ERROR: "spi_release_transport" [drivers/scsi/53c700.ko] undefined!
> > ERROR: "spi_display_xfer_agreement" [drivers/scsi/53c700.ko] undefined!
> > ERROR: "spi_populate_sync_msg" [drivers/scsi/53c700.ko] undefined!
(Continue reading)

Randy Dunlap | 1 Jun 2007 02:00
Picon
Favicon

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

On Thu, 31 May 2007 16:56:31 -0700 Randy Dunlap wrote:

> On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote:
> 
> > On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote:
> > > Hello,
> > > 
> > > the build with the attached .config failed, make ends with:
> > > ...
> > >   CC      arch/i386/boot/compresse
> > >   HOSTCC  arch/i386/boot/tools/build
> > >   BUILD   arch/i386/boot/bzImage
> > > Root device is (3, 8)
> > > Boot sector 512 bytes.
> > > Setup is 7178 bytes.
> > > System is 2513 kB
> > > Kernel: arch/i386/boot/bzImage is ready  (#1)
> > >   Building modules, stage 2.
> > >   MODPOST 363 modules
> > > ERROR: "spi_dv_device" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_attach_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_ppr_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_width_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_release_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_display_xfer_agreement" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_sync_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_attach_transport" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_schedule_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_release_transport" [drivers/scsi/53c700.ko] undefined!
(Continue reading)

Cornelia Huck | 1 Jun 2007 09:09
Picon
Favicon

Re: 2.6.22-rc3-mm1

On Thu, 31 May 2007 15:10:05 -0700,
Andrew Morton <akpm <at> linux-foundation.org> wrote:

> Cornelia, afaict your patch has no actual delendency upon Dan's
> dma-mapping-prevent-dma-dependent-code-from-linking-on.patch, correct?  If
> so, I can merge it via James and then merge Dan's patch once James has
> merged.

AFAICS there's no dependency in that direction.

> diff -puN include/scsi/scsi_cmnd.h~scsi-dont-build-scsi_dma_mapunmap-for-has_dma include/scsi/scsi_cmnd.h
> --- a/include/scsi/scsi_cmnd.h~scsi-dont-build-scsi_dma_mapunmap-for-has_dma
> +++ a/include/scsi/scsi_cmnd.h
>  <at>  <at>  -135,8 +135,10  <at>  <at>  extern void scsi_kunmap_atomic_sg(void *
>  extern struct scatterlist *scsi_alloc_sgtable(struct scsi_cmnd *, gfp_t);
>  extern void scsi_free_sgtable(struct scatterlist *, int);
> 
> +#ifdef CONFIG_SCSI_DMA
>  extern int scsi_dma_map(struct scsi_cmnd *cmd);
>  extern void scsi_dma_unmap(struct scsi_cmnd *cmd);
> +#endif
> 
>  #define scsi_sg_count(cmd) ((cmd)->use_sg)
>  #define scsi_sglist(cmd) ((struct scatterlist *)(cmd)->request_buffer)
> 
> We don't really need the ifdefs here.  If someone incorrectly calls these
> functions then they'll get a link-time failure anyway.  The downside of
> removing these ifdefs is that they won't get a compile-time warning, but I
> tend to think that this small cost is worth it.

(Continue reading)

FUJITA Tomonori | 1 Jun 2007 11:56
Picon
Gravatar

[PATCH 1/2] iscsi_tcp: convert to use the data buffer accessors

iscsi_tcp: convert to use the data buffer accessors

- remove the unnecessary map_single path.

- convert to use the new accessors for the sg lists and the
parameters.

TODO: use scsi_for_each_sg().

Signed-off-by: FUJITA Tomonori <fujita.tomonori <at> lab.ntt.co.jp>
---
 drivers/scsi/iscsi_tcp.c |  117 +++++++++++++++-------------------------------
 drivers/scsi/libiscsi.c  |   20 ++++----
 2 files changed, 48 insertions(+), 89 deletions(-)

diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index d5a6527..aee2b60 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
 <at>  <at>  -237,10 +237,10  <at>  <at>  iscsi_data_rsp(struct iscsi_conn *conn, struct iscsi_cmd_task *ctask)
 	tcp_ctask->exp_datasn++;

 	tcp_ctask->data_offset = be32_to_cpu(rhdr->offset);
-	if (tcp_ctask->data_offset + tcp_conn->in.datalen > sc->request_bufflen) {
+	if (tcp_ctask->data_offset + tcp_conn->in.datalen > scsi_bufflen(sc)) {
 		debug_tcp("%s: data_offset(%d) + data_len(%d) > total_length_in(%d)\n",
 		          __FUNCTION__, tcp_ctask->data_offset,
-		          tcp_conn->in.datalen, sc->request_bufflen);
+		          tcp_conn->in.datalen, scsi_buffle(sc));
 		return ISCSI_ERR_DATA_OFFSET;
(Continue reading)

FUJITA Tomonori | 1 Jun 2007 11:56
Picon
Gravatar

[PATCH 2/2] iscsi_iser: convert to use the data buffer accessors

iscsi_iser: convert to use the data buffer accessors

- remove the unnecessary map_single path.

- convert to use the new accessors for the sg lists and the
parameters.

TODO: use scsi_for_each_sg().

Signed-off-by: FUJITA Tomonori <fujita.tomonori <at> lab.ntt.co.jp>
---
 drivers/infiniband/ulp/iser/iscsi_iser.c     |    4 ++--
 drivers/infiniband/ulp/iser/iser_initiator.c |   14 ++++----------
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index 1bf173d..effdee2 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
 <at>  <at>  -210,10 +210,10  <at>  <at>  iscsi_iser_ctask_xmit(struct iscsi_conn *conn,
 	int error = 0;

 	if (ctask->sc->sc_data_direction == DMA_TO_DEVICE) {
-		BUG_ON(ctask->sc->request_bufflen == 0);
+		BUG_ON(scsi_bufflen(ctask->sc) == 0);

 		debug_scsi("cmd [itt %x total %d imm %d unsol_data %d\n",
-			   ctask->itt, ctask->sc->request_bufflen,
+			   ctask->itt, scsi_bufflen(ctask->sc),
 			   ctask->imm_count, ctask->unsol_count);
(Continue reading)

FUJITA Tomonori | 1 Jun 2007 11:56
Picon
Gravatar

[PATCH 0/2] iscsi: convert to use the data buffer accessors

This patchset converts libiscsi, iscsi_tcp, and iscsi_iser to use the
data buffer accessors.

This is dependent on the patchset that Mike posted the day before
yesterday (which is on the top of the latest scsi-misc-2.6):

http://marc.info/?l=linux-scsi&m=118054788406095&w=2

This can be also cleanly applied to Mike's iscsi git tree.

iscsi_tcp and iscsi_iser needs some modifications to use
scsi_for_each_sg macro so I've not done that. It would be easier to
use the chaining sg macros like next_sg directly when they are ready.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Vivek Goyal | 1 Jun 2007 13:08
Picon

Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts.

On Wed, May 30, 2007 at 11:59:13AM -0400, Salyzyn, Mark wrote:
> Moves quiesce, thread and interrupt shutdown into aacraid drivers'
> .shutdown handler. This fix to the aac_shutdown handler will remove the
> superfluous reset of the adapter during a (clean) kexec.
> 
> This fix may mitigate the active investigation 'kexec and aacraid
> broken' but it is unlikely to affect the root cause (issue likely
> present in both kexec and kdump). This patch reduces the chance the
> problem will occur with a kexec. The fix for root cause is currently
> expected to be the minimum value check to the aacraid.startup_timeout
> driver variable after an adapter reset within aacraid_commit_reset.patch
> submitted on 05/22/2007 and awaiting testing by Yinghai to confirm.
> 
> This attached patch is against current scsi-misc-2.6
> 
> ObligatoryDisclaimer: Please accept my condolences regarding Outlook's
> handling of patch attachments.
> 
> Signed-off-by: Mark Salyzyn <aacraid <at> adaptec.com>
> 

Thanks Mark. This does fix the issue of unnecessary reset of aacraid
adapter over kexec on my machine.

Thanks
Vivek
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Emmanuel Fusté | 1 Jun 2007 13:24
Favicon

Re: [AIC7xxx] tree things to report


> Please try the attached patch and see if it helps.
> 
> James, I know that the aic7xxx has some 'next_queued_hscb' pointer which
> might be utilized for this sort of thing. But I didn't really figure out
> how this thing is supposed to work nor how we could utilize it.
> So I figured that the added complexity is not really worth it.
> 
Did you have time to look at the new logs this the patch applied ? Do you need something else ?

Cheers,
Emmanuel.
---

Créez votre adresse électronique prenom.nom <at> laposte.net 
1 Go d'espace de stockage, anti-spam et anti-virus intégrés.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

James Bottomley | 1 Jun 2007 15:07
Favicon

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

On Thu, 2007-05-31 at 16:56 -0700, Randy Dunlap wrote:
> On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote:
> 
> > On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote:
> > > Hello,
> > > 
> > > the build with the attached .config failed, make ends with:
> > > ...
> > >   CC      arch/i386/boot/compresse
> > >   HOSTCC  arch/i386/boot/tools/build
> > >   BUILD   arch/i386/boot/bzImage
> > > Root device is (3, 8)
> > > Boot sector 512 bytes.
> > > Setup is 7178 bytes.
> > > System is 2513 kB
> > > Kernel: arch/i386/boot/bzImage is ready  (#1)
> > >   Building modules, stage 2.
> > >   MODPOST 363 modules
> > > ERROR: "spi_dv_device" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_attach_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_ppr_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_width_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_release_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_display_xfer_agreement" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_populate_sync_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > ERROR: "spi_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_attach_transport" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_schedule_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_release_transport" [drivers/scsi/53c700.ko] undefined!
> > > ERROR: "spi_display_xfer_agreement" [drivers/scsi/53c700.ko] undefined!
(Continue reading)

James Bottomley | 1 Jun 2007 15:23
Favicon

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

On Fri, 2007-06-01 at 09:07 -0400, James Bottomley wrote:
> On Thu, 2007-05-31 at 16:56 -0700, Randy Dunlap wrote:
> > On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote:
> > 
> > > On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote:
> > > > Hello,
> > > > 
> > > > the build with the attached .config failed, make ends with:
> > > > ...
> > > >   CC      arch/i386/boot/compresse
> > > >   HOSTCC  arch/i386/boot/tools/build
> > > >   BUILD   arch/i386/boot/bzImage
> > > > Root device is (3, 8)
> > > > Boot sector 512 bytes.
> > > > Setup is 7178 bytes.
> > > > System is 2513 kB
> > > > Kernel: arch/i386/boot/bzImage is ready  (#1)
> > > >   Building modules, stage 2.
> > > >   MODPOST 363 modules
> > > > ERROR: "spi_dv_device" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_attach_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_populate_ppr_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_populate_width_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_release_transport" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_display_xfer_agreement" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_populate_sync_msg" [drivers/scsi/aic7xxx/aic7xxx.ko] undefined!
> > > > ERROR: "spi_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > > ERROR: "spi_attach_transport" [drivers/scsi/53c700.ko] undefined!
> > > > ERROR: "spi_schedule_dv_device" [drivers/scsi/53c700.ko] undefined!
> > > > ERROR: "spi_release_transport" [drivers/scsi/53c700.ko] undefined!
(Continue reading)


Gmane