headers
Jeff Garzik | 1 Oct 2006 01:58
Favicon

Re: [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2)

Frederik Deweerdt wrote:
> On Sat, Sep 30, 2006 at 12:43:24AM +0100, Alan Cox wrote:
>> Ar Gwe, 2006-09-29 am 23:50 +0000, ysgrifennodd Frederik Deweerdt:
>>> Does this patch makes sense in that case? If yes, I'll put up a patch
>>> for the remaining cases in the drivers/scsi/aic7xxx/ directory.
>>> Also, aic7xxx's coding style would put parenthesis around the returned
>>> value, should I follow it?
>> Yes - but perhaps with a warning message so users know why ?
>>
>> As to coding style - kernel style is unbracketed so I wouldnt worry
>> about either.
>>
> Thanks for the advices. 
> 
> The following patch checks whenever the irq is valid before issuing a
> request_irq() for AIC7XXX and AIC79XX. An error message is displayed to
> let the user know what went wrong.
> 
> Regards,
> Frederik
> 
> Signed-off-by: Frederik Deweerdt <frederik.deweerdt <at> gmail.com>

Actually, rather than adding this check to every driver, I would rather 
do something like the attached patch:  create a pci_request_irq(), and 
pass a struct pci_device to it.  Then the driver author doesn't have to 
worry about such details.

	Jeff
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jeff Garzik | 1 Oct 2006 03:23
Favicon

[PATCH] scsi: device_reprobe() can fail


[This has been sitting in James Bottomley's scsi-misc for five days.
 With SCSI outputting a warning for almost -every- file, let's go ahead
 and get the patch in.]

From: Andrew Morton <akpm <at> osdl.org>

device_reprobe() should return an error code.  When it does so,
scsi_device_reprobe() should propagate it back.

Acked-by: Jeff Garzik <jeff <at> garzik.org>
Signed-off-by: Andrew Morton <akpm <at> osdl.org>
Signed-off-by: James Bottomley <James.Bottomley <at> SteelEye.com>

---

 include/scsi/scsi_device.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

8350a348e97c2f8aa3e91c025c0e040c90146414
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 895d212..b401c82 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
 <at>  <at>  -298,9 +298,9  <at>  <at>  extern int scsi_execute_async(struct scs
 			      void (*done)(void *, char *, int, int),
 			      gfp_t gfp);

-static inline void scsi_device_reprobe(struct scsi_device *sdev)
+static inline int __must_check scsi_device_reprobe(struct scsi_device *sdev)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Jeff Garzik | 1 Oct 2006 03:25
Favicon

SCSI make all{yes,mod}config build breakage

The block tree merge broke the SCSI build:

   CC [M]  drivers/scsi/libsas/sas_scsi_host.o
In file included from include/scsi/libsas.h:35,
                  from drivers/scsi/libsas/sas_internal.h:32,
                  from drivers/scsi/libsas/sas_scsi_host.c:26:
include/scsi/scsi_device.h: In function ‘scsi_device_reprobe’:
include/scsi/scsi_device.h:303: warning: ignoring return value of 
‘device_reprobe’, declared with attribute warn_unused_result
drivers/scsi/libsas/sas_scsi_host.c: In function ‘sas_scsi_get_task_attr’:
drivers/scsi/libsas/sas_scsi_host.c:129: error: ‘struct request’ has no 
member named ‘flags’

The attached patch (sent in separate email with proper sign-off) fixes 
things.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Jeff Garzik | 1 Oct 2006 03:28
Favicon

[PATCH] SCSI: fix request flag-related build breakage


The ->flags in struct request was split into two variables, in a recent
changeset.  The merge of this change forgot to update SCSI's libsas,
probably because libsas was a very recent merge.

Signed-off-by: Jeff Garzik <jeff <at> garzik.org>

diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
index 7f9e89b..e46e793 100644
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
 <at>  <at>  -126,7 +126,7  <at>  <at>  static enum task_attribute sas_scsi_get_
 	enum task_attribute ta = TASK_ATTR_SIMPLE;
 	if (cmd->request && blk_rq_tagged(cmd->request)) {
 		if (cmd->device->ordered_tags &&
-		    (cmd->request->flags & REQ_HARDBARRIER))
+		    (cmd->request->cmd_flags & REQ_HARDBARRIER))
 			ta = TASK_ATTR_HOQ;
 	}
 	return ta;
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
Eric Rannaud | 1 Oct 2006 03:32
Picon

Oops in megaraid_mbox (git HEAD)

Hi,

The following OOPS on current git HEAD
cfae35804bcb909225d6f4eb5bd29e25971614d8 with the following config,
early on boot:
http://engm.ath.cx/kernel/config-cfae35804bcb909225d6f4eb5bd29e25971614d8
http://engm.ath.cx/kernel/liw64-lspci.txt

Seems related to megaraid_mbox.
It is reproductible (just reboot).
Doesn't happen on vanilla 2.6.18.

(It is to be noted that this box is having some trouble with recent
versions of the kernel, that may or may not be related to this Oops,
see the thread ".BUG-lockdep and freeze (was: Arrr! Linux 2.6.18)".
However the symptoms are different, so maybe this is of interest.)

I can git-bisect it if you think it could be useful.

er.

P.S. The "CI: Cannot allocate resource region 0 of device
0000:08:0a.1" is a new message (from v2.6.18)

----
[  182.870034] PCI: Cannot allocate resource region 0 of device 0000:08:0a.1
[  182.870343] PCI: Cannot allocate resource region 0 of device 0000:08:0b.1
[  256.181299] Unable to handle kernel NULL pointer dereference at
0000000000000000 RIP:
[  256.181361]  [<ffffffff811f1bce>] megaraid_mbox_dpc+0x1ce/0x670
(Continue reading)

Permalink | Reply | 0 comments |
headers
michaelc | 1 Oct 2006 02:42
Picon
Favicon

[PATCH 4/4] scsi_devinfo: scsi2 HP and Hitachi entries

From: Mike Christie <michaelc <at> cs.wisc.edu>

From RHEL4: This is a bulk addition of several HP and Hitachi entries.
When SCSI-2 they can support luns past 7 and sparse luns.
Signed-off-by: Mike Christie <michaelc <at> cs.wisc.edu>
---
 drivers/scsi/scsi_devinfo.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index dc1e1eb..ce63044 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
 <at>  <at>  -162,6 +162,11  <at>  <at>  static struct {
 	{"HITACHI", "DF600", "*", BLIST_SPARSELUN},
 	{"HITACHI", "DISK-SUBSYSTEM", "*", BLIST_ATTACH_PQ3 | BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"HITACHI", "OPEN-E", "*", BLIST_ATTACH_PQ3 | BLIST_SPARSELUN | BLIST_LARGELUN},
+	{"HITACHI", "OP-C-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+	{"HITACHI", "3380-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+	{"HITACHI", "3390-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+	{"HITACHI", "6586-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
+	{"HITACHI", "6588-", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN},	/* HP VA7400 */
 	{"HP", "OPEN-", "*", BLIST_REPORTLUN2}, /* HP XP Arrays */
 	{"HP", "NetRAID-4M", NULL, BLIST_FORCELUN},
 <at>  <at>  -169,6 +174,14  <at>  <at>  static struct {
 	{"HP", "C1557A", NULL, BLIST_FORCELUN},
 	{"HP", "C3323-300", "4269", BLIST_NOTQ},
 	{"HP", "C5713A", NULL, BLIST_NOREPORTLUN},
+	{"HP", "DF400", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
(Continue reading)

Permalink | Reply | 0 comments |
headers
michaelc | 1 Oct 2006 02:42
Picon
Favicon

more devinfo updates

The following patches add devinfo entries we had in RHEL4.
Changes since last time:

- Drop entries that were questionable with the current code and
needed testing or there was conflicting info.
- Add new entries for Hitachi and HP devices that have scsi2 support
and support luns higher than 7 and sparse lu numbering.

Patches were made against scsi-misc.

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 4 comments |
headers
michaelc | 1 Oct 2006 02:42
Picon
Favicon

[PATCH 3/4] scsi_devinfo: add nec istorage

From: Mike Christie <michaelc <at> cs.wisc.edu>

From RHEL4: NEC iStorage devices are SCSI-2 devices but they
support the report luns opcode.
Signed-off-by: Mike Christie <michaelc <at> cs.wisc.edu>
---
 drivers/scsi/scsi_devinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index f6aadbd..dc1e1eb 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
 <at>  <at>  -189,6 +189,7  <at>  <at>  static struct {
 	{"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
 	{"NAKAMICH", "MJ-5.16S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
 	{"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
+	{"NEC", "iStorage", NULL, BLIST_REPORTLUN2},
 	{"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
 	{"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
 	{"PIONEER", "CD-ROM DRM-600", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},
--

-- 
1.4.1

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 1 comment |
headers
michaelc | 1 Oct 2006 02:42
Picon
Favicon

[PATCH 2/4] scsi_devinfo: add Tornado

From: Mike Christie <michaelc <at> cs.wisc.edu>

This is from RHEL4. I do not have any info from our bugzilla. All
I could find was something like this thread
http://lkml.org/lkml/2005/1/7/346

Report lun for linux does not work. It may be our lun format code or
it may be the device. It is probably not worth it to add anything
special for this device, so the patch just adds BLIST_NOREPORTLUN.

This patch can be dropped if you feel BLIST_NOREPORTLUN is just
a hack.

Signed-off-by: Mike Christie <michaelc <at> cs.wisc.edu>
---
 drivers/scsi/scsi_devinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index cbf733b..f6aadbd 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
 <at>  <at>  -211,6 +211,7  <at>  <at>  static struct {
 	{"SUN", "T300", "*", BLIST_SPARSELUN},
 	{"SUN", "T4", "*", BLIST_SPARSELUN},
 	{"TEXEL", "CD-ROM", "1.06", BLIST_BORKEN},
+	{"Tornado-", "F4", "*", BLIST_NOREPORTLUN},
 	{"TOSHIBA", "CDROM", NULL, BLIST_ISROM},
 	{"TOSHIBA", "CD-ROM", NULL, BLIST_ISROM},
 	{"USB2.0", "SMARTMEDIA/XD", NULL, BLIST_FORCELUN | BLIST_INQUIRY_36},
(Continue reading)

Permalink | Reply | 2 comments |
headers
michaelc | 1 Oct 2006 02:42
Picon
Favicon

[PATCH 1/4] scsi_devinfo: add EMC Invista

From: Mike Christie <michaelc <at> cs.wisc.edu>

This is from RHEL4. This box can support
scsi2 and can also support BLIST_SPARSELUN | BLIST_LARGELUN.

Signed-off-by: Mike Christie <michaelc <at> cs.wisc.edu>
---
 drivers/scsi/scsi_devinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 3d0429b..cbf733b 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
 <at>  <at>  -150,6 +150,7  <at>  <at>  static struct {
 	{"DELL", "PERCRAID", NULL, BLIST_FORCELUN},
 	{"DGC", "RAID", NULL, BLIST_SPARSELUN},	/* Dell PV 650F, storage on LUN 0 */
 	{"DGC", "DISK", NULL, BLIST_SPARSELUN},	/* Dell PV 650F, no storage on LUN 0 */
+	{"EMC",  "Invista", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
 	{"EMC", "SYMMETRIX", NULL, BLIST_SPARSELUN | BLIST_LARGELUN | BLIST_FORCELUN},
 	{"EMULEX", "MD21/S2     ESDI", NULL, BLIST_SINGLELUN},
 	{"FSC", "CentricStor", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
--

-- 
1.4.1

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply | 3 comments |

Gmane