RE: [PATCH] mptsas: eliminate ghost devices

On Friday, June 30, 2006 4:59 PM, James Bottomley wrote: 

> 
> Yes, but we want an end device for a remote HBA, which your condition
> would also eliminate.  It shows useful information (like sas 
> address and
> parameters).

Yes good point. My thinking was the data is there on the host system
having
the remote HBA.  

> 
> > If the remote initiator is located beyond the 1st leve expander, or
> > direct
> > connected to each other, this condition will not entered.
> 
> Right ... here we'll see the end device, so if we go with your patch
> we'd see an end device for a remote HBA connected to a second level
> expander but not for a first level one.  Whatever happens, we 
> need to be
> consistent ...
> 

Agreed. Your doing referencing checking with host sas address, so 
the only rphys removed are those pointing back to the host, and not
other initiators.  So other initiators can exist on the 1st level
expanders,
as well as 2nd, 3rd, and so one.  Okay your patch is fine. Apply.

[PATCH] sd/scsi_lib simplify sd_rw_intr and scsi_io_completion

This patch simplifies "good_bytes" computation in sd_rw_intr().
sd: "good_bytes" computation is always done in terms of the resolution
of the device's medium, since after that it is the number of good bytes
we pass around and other layers/contexts (as opposed ot sd) can translate
that to their own resolution (block layer:512).  It also makes
scsi_io_completion() processing more straightforward, eliminating the
3rd argument to the function.

It also fixes a couple of bugs like not checking return value,
using "break" instead of "return;", etc.

Signed-off-by: Luben Tuikov <ltuikov <at> yahoo.com>
---
 drivers/scsi/scsi_lib.c  |  108 ++++++++++++++---------------------
 drivers/scsi/sd.c        |  143 ++++++++++++++++++++--------------------------
 drivers/scsi/sr.c        |    2 -
 include/scsi/scsi_cmnd.h |    2 -
 4 files changed, 106 insertions(+), 149 deletions(-)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 923242a..c985c1a 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
 <at>  <at>  -855,8 +855,7  <at>  <at>  static void scsi_release_buffers(struct 
  *		b) We can just use scsi_requeue_command() here.  This would
  *		   be used if we just wanted to retry, for example.
  */
-void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes,
-			unsigned int block_bytes)
+void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)

[PATCH] [SCSI] st.c: Improve sense output

From this:
st0: Error with sense data: <6>st: Current: sense key: Illegal Request
    Additional sense: Invalid field in cdb

To this:
st0: Current: sense key: Illegal Request
    Additional sense: Invalid field in cdb

Signed-off-by: Luben Tuikov <ltuikov <at> yahoo.com>
---
 drivers/scsi/st.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 29d7319..2a59635 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
 <at>  <at>  -368,7 +368,7  <at>  <at>  static int st_chk_result(struct scsi_tap
 		       SRpnt->cmd[0], SRpnt->cmd[1], SRpnt->cmd[2],
 		       SRpnt->cmd[3], SRpnt->cmd[4], SRpnt->cmd[5]);
 		if (cmdstatp->have_sense)
-			 __scsi_print_sense("st", SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
+			 __scsi_print_sense(name, SRpnt->sense, SCSI_SENSE_BUFFERSIZE);
 	} ) /* end DEB */
 	if (!debugging) { /* Abnormal conditions for tape */
 		if (!cmdstatp->have_sense)
 <at>  <at>  -384,9 +384,8  <at>  <at>  static int st_chk_result(struct scsi_tap
 			 scode != VOLUME_OVERFLOW &&
 			 SRpnt->cmd[0] != MODE_SENSE &&
 			 SRpnt->cmd[0] != TEST_UNIT_READY) {

[GIT PATCH] final SCSI updates for 2.6.17

This is the final 2.6.17 scsi updates.  It contains the port API for SAS
that we held off on; quite a slew of driver updates and some
miscellaneous bug fixes.

The patch is available here:

master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git

The short changelog is:

Adrian Bunk:
  o qla2xxx: make some more functions static

Alan Cox:
  o Bogus disk geometry on large disks

Alan Stern:
  o core: Allow QUIESCE -> CANCEL sdev transition

Andrew Vasquez:
  o qla2xxx: Update version number to 8.01.05-k3
  o qla2xxx: Correctly set the firmware NOS/OLS timeout during initialization
  o qla2xxx: Convert from pci_module_init() to pci_register_driver()
  o qla2xxx: Correct 'loop-down' determination logic in qla2x00_fw_ready()
  o qla2xxx: Add support for extended error logging
  o qla2xxx: Cleanup DEBUG macro usage
  o qla2xxx: Remove no-op IOCTL codes and macros
  o qla2xxx: Create an VPD sysfs entry for supported ISPs only
  o qla2xxx: Add DMI (Diagnostics Monitoring Interface) support
  o qla2xxx: Honour 'skip process-login' option during fabric-login IOCB

Re: [GIT PATCH] final SCSI updates for 2.6.17

On Friday, June 30, 2006 9:09 PM, James Bottomley wrote:

> This is the final 2.6.17 scsi updates.  It contains the port API for SAS
> that we held off on; quite a slew of driver updates and some
> miscellaneous bug fixes.
> 

I noticed you didn't pick up the mptsas patch for zero base port ids.
Is that because your eventually going to have transport do
the port id assignments?

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCH] final SCSI updates for 2.6.17

On Fri, 2006-06-30 at 21:17 -0600, Moore, Eric wrote:
> I noticed you didn't pick up the mptsas patch for zero base port ids.
> Is that because your eventually going to have transport do
> the port id assignments?

Actually, no, it just got lost in the rush to get everything done and
tested before 2.6.17 turns into a pumpkin at midnight tonight.

James

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [GIT PATCH] final SCSI updates for 2.6.17

On Fri, Jun 30, 2006 at 10:23:10PM -0500, James Bottomley wrote:
> On Fri, 2006-06-30 at 21:17 -0600, Moore, Eric wrote:
> > I noticed you didn't pick up the mptsas patch for zero base port ids.
> > Is that because your eventually going to have transport do
> > the port id assignments?
> 
> Actually, no, it just got lost in the rush to get everything done and
> tested before 2.6.17 turns into a pumpkin at midnight tonight.
> 
> James
> 
> 

Here is the patch. Please resider it:

Signed-off-by: Eric Moore <Eric.Moore <at> lsil.com>

diff -uarN b/drivers/message/fusion/mptbase.h a/drivers/message/fusion/mptbase.h
--- b/drivers/message/fusion/mptbase.h	2006-06-27 15:24:01.000000000 -0600
+++ a/drivers/message/fusion/mptbase.h	2006-06-28 16:53:39.000000000 -0600
 <at>  <at>  -644,7 +644,6  <at>  <at> 
 	struct work_struct	 fc_rescan_work;
 	char			 fc_rescan_work_q_name[KOBJ_NAME_LEN];
 	struct workqueue_struct *fc_rescan_work_q;
-	u8		port_serial_number;
 } MPT_ADAPTER;

 /*
diff -uarN b/drivers/message/fusion/mptsas.c a/drivers/message/fusion/mptsas.c
--- b/drivers/message/fusion/mptsas.c	2006-06-27 15:17:03.000000000 -0600

additional sense codes need update

At http://www.t10.org/lists/asc-num.txt is a list
of SCSI additional sense codes and their qualifiers
with the corresponding text messages.

Comparing the latest list at that site (2006/06/10)
with what we have in constants.c in the scsi
subsystem my program came up with the following list
of discrepancies. Probably time for an update.

Doug Gilbert

no entry for 0,1d : ATA PASS THROUGH INFORMATION AVAILABLE
4,2 differ; ref: LOGICAL UNIT NOT READY, INITIALIZING COMMAND REQUIRED, kern: LOGICAL UNIT NOT READY,
INITIALIZING CMD. REQUIRED
no entry for b,3 : WARNING - BACKGROUND SELF-TEST FAILED
no entry for b,4 : WARNING - BACKGROUND PRE-SCAN DETECTED MEDIUM ERROR
no entry for b,5 : WARNING - BACKGROUND MEDIUM SCAN DETECTED MEDIUM ERROR
no entry for c,f : DEFECTS IN ERROR WINDOW
no entry for e,3 : INVALID FIELD IN COMMAND INFORMATION UNIT
10,1 differ; ref: LOGICAL BLOCK GUARD CHECK FAILED, kern: DATA BLOCK GUARD CHECK FAILED
10,2 differ; ref: LOGICAL BLOCK APPLICATION TAG CHECK FAILED, kern: DATA BLOCK APPLICATION TAG CHECK FAILED
10,3 differ; ref: LOGICAL BLOCK REFERENCE TAG CHECK FAILED, kern: DATA BLOCK REFERENCE TAG CHECK FAILED
no entry for 11,14 : READ ERROR - LBA MARKED BAD BY APPLICATION CLIENT
no entry for 21,3 : INVALID WRITE CROSSING LAYER JUMP
no entry for 24,2 : OBSOLETE
no entry for 24,3 : OBSOLETE
26,f differ; ref: INVALID DATA-OUT BUFFER INTEGRITY CHECK VALUE, kern: INVALID DATA-OUT BUFFER INTEGRITY
no entry for 26,10 : DATA DECRYPTION KEY FAIL LIMIT REACHED

Re: [RFC] [PATCH 0/7] requested for qla4xxx!!!

[Sorry for repost: was typo in linux-scsi <at> vger
 email, and open-iscsi <at>  didn't accept email
 either, as it says "i'm not subscribed" (which
 isn't _entirely_ true ;)]

Ravi Anand wrote:
> All,
> 
> Today in the following email thread , Mike Christie outlined the 
> modifications that has been done to qla4xx driver from the last submission: 
> 
>> http://marc.theaimsgroup.com/?l=linux-scsi&m=115151443814051&w=2
[...]
> All the patches has been uploaded at the following URL:
>
> 	ftp://ftp.qlogic.com/outgoing/linux/iSCSI/upstream/5.00.05b6-k/
>
> Complete driver package and the diff from previous submission for review
> has also been uploaded at the above mentioned link.
[...]

Hi.

I'm not of much help in reviewing the code and/or making code
suggestions.  Instead, I'm trying to build the driver as we've
several new servers with ISP4010 adapters, which should work
somehow... ;)

Except of the obvious prob wrt ql4_netlink.h file which you
already fixed by subsequent patch.. well....

Symantec Mail Security detected unscannable content in a message sent from your address (SYM:08101184032116260824)

Subject of the message: Returned mail: see transcript for details
Recipient of the message: Uveshnee Ragavan

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html