Or Gerlitz | 1 Oct 12:45 2014

static checker complaints on isert code

Some static checker complaints on isert code, worth looking


# make CHECK="../tools/smatch/smatch -p=kernel --two-passes" C=2 CC=gcc 
SUBDIRS=drivers/infiniband/ulp/isert -j 12 modules | tee warns.txt
   CHECK   drivers/infiniband/ulp/isert/ib_isert.c

drivers/infiniband/ulp/isert/ib_isert.c:701 isert_connect_request() 
warn: inconsistent returns 'sem:&isert_np->np_sem'.
   Locked on:   line 571
                line 581
                line 701
   Unlocked on: line 683

drivers/infiniband/ulp/isert/ib_isert.c:3155 isert_accept_np() error: 
double lock 'sem:&isert_np->np_sem'

drivers/infiniband/ulp/isert/ib_isert.c:3155 isert_accept_np warn: 
unused return: ret = down_interruptible()

Saurav Kashyap | 25 Sep 12:14 2014

[PATCH RESEND 00/17] qla2xxx: Target bug fixes and enchancements.

Hi Nicholas/Christoph,

Please apply the following patches at your earliest convenience.
This patchset have target related changes to qla2xxx. I will submit
the target (TCM-LIO) patches in different patch set.


Arun Easi (6):
  qla2xxx: Use correct offset to req-q-out for reserve calculation
  qla2xxx: Remove verbose messages in target mode.
  qla2xxx: Enable SLER conditionally in target mode.
  qla2xxx: Add Host reset handling in target mode.
  qla2xxx: Handle chip reset in target mode.
  qla2xxx: Host reset handling in ABTS path.

Himanshu Madhani (6):
  qla2xxx: Fix sparse warnings in tcm_qla2xxx.c
  qla2xxx: fix kernel NULL pointer access
  qla2xxx: Increase room in request queue for sending priority packets
  qla2xxx: fix crash due to task mgmt cmd type
  qla2xxx: Do not send SS_RESIDUAL_UNDER with SAM_STAT_BUSY
  qla2xxx: Add memory barrier before ringing doorbell.

Quinn Tran (2):
  qla2xxx: Add support for QFull throttling and Term Exchange retry
  qla2xxx: Fix hang due to cmd_kref not decrementing

Saurav Kashyap (3):
(Continue reading)

Benjamin Siaka | 22 Sep 03:20 2014


Hello my Dear,

I will greatly appreciate my correspondence meets you in good health condition.

My name is Mr. Benjamin Siaka. I am seeking for your co-operation for investment partnership in your
Country. I shall provide the FUND for the investment. When you acknowledged the receipt of this
correspondence, thereafter I will give you the Full Details of my investment proposal.

I await your response in earliest.

My regards,
Mr. Benjamin Siaka.
Nicholas A. Bellinger | 20 Sep 00:41 2014

[GIT PULL] target fixes for v3.17-rc6

Hi Linus,

Here are the target pending fixes for v3.17-rc6.  Please pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master

Included are Sagi's long overdue fixes related to iser-target shutdown,
along with a couple of fixes from Sebastian related to ALUA Referrals
changes that when in during the v3.14 time-frame.

Also included are a few iscsi-target fixes, most recently of which where
found during Joern's Coverity scanning of target code.



Joern Engel (1):
  iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure

Nicholas Bellinger (2):
  iscsi-target: Ignore ICF_GOT_LAST_DATAOUT during Data-Out ITT lookup
  iscsi-target: Fix memory corruption in

Sagi Grimberg (4):
  Target/iser: Get isert_conn reference once got to connected_handler
  Target/iser: Don't put isert_conn inside disconnected handler
  Target/iser: Avoid calling rdma_disconnect twice
  Target/iser: Fix initiator_depth and responder_resources
(Continue reading)

Nicholas A. Bellinger | 18 Sep 03:05 2014

Re: A Question about setting discovery_auth values

On Wed, 2014-09-17 at 14:01 -0600, Lee Duncan wrote:
> Hi Nicholas: 
> Apologies for the top-post, but my current mail agent sucks. :) 
> No problem on the delay. 
> What about handling "NULL" and "" as meaning "clear the current value?
> I could supply a patch ... 

While writing the earlier response, I was trying to remember why "" was
deemed insufficient in the first place for clearing the current value,
but alas the original reasoning escapes me atm.

It could very well have to do with some early user-space (eg: lio-utils)
during state re-creation had a distinction between an empty value and
explicitly clearing a value, but I still don't recall exactly why this

That said, there was some reasoning behind this, and I'd like to
remember why first before making a change that could negatively effect


(Continue reading)

Joern Engel | 16 Sep 22:23 2014

[PATCH 00/10] target: various cleanups

Came across these while reading code.  Nothing exciting.

Joern Engel (10):
  target: simplify core_tmr_release_req()
  target: remove some smp_mb__after_atomic()s
  target: encapsulate smp_mb__after_atomic()
  target: simplify core_tmr_abort_task
  qla_target: remove unused parameter
  qla_target: make some global functions static
  qla_target: remove misleading comment
  qla_target: simplify qlt_send_term_exchange()
  qla_target: improve qlt_unmap_sg()
  qla_target: rearrange struct qla_tgt_prm

 drivers/scsi/qla2xxx/qla_target.c      | 52 ++++++++------------
 drivers/scsi/qla2xxx/qla_target.h      | 12 +----
 drivers/target/loopback/tcm_loop.c     |  6 +--
 drivers/target/target_core_alua.c      | 33 ++++---------
 drivers/target/target_core_device.c    |  9 ++--
 drivers/target/target_core_pr.c        | 90 ++++++++++++----------------------
 drivers/target/target_core_tmr.c       | 24 ++++-----
 drivers/target/target_core_transport.c | 20 +++-----
 drivers/target/target_core_ua.c        | 15 ++----
 include/target/target_core_base.h      | 14 ++++++
 10 files changed, 100 insertions(+), 175 deletions(-)



(Continue reading)

Robert Wood | 10 Sep 01:12 2014

NPIV FC target fails


We are trying to create an FC target using an NPIV FC alias (as an
attempt to set up high availability without using ALUA based
failover).  There are hints that this is supposed to be supported by
LIO, but we are unable to get it to work.  Could you please provide
any insight into configuring an NPIV alias for a Qlogic QLE2562 NPIV?

Thank you,
Sudip Mukherjee | 9 Sep 09:23 2014

[PATCH] drivers: target: target_core_transport.c: build warning

build is giving : 
warning: passing argument 1 of 'strlen' makes pointer from integer 
without a cast [enabled by default]

the snprintf after the strlen is trying to put the "Unsupported" string
at the end of exising string. so len should give the string length here

Signed-off-by: Sudip Mukherjee <sudip <at> vectorindia.org>
 drivers/target/target_core_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 1dd1181..3ce85ed 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
 <at>  <at>  -953,7 +953,7  <at>  <at>  int transport_dump_vpd_ident_type(
 		strlcat(buf, "SCSI name string\n", sizeof(buf));
-		len = strlen(len);
+		len = strlen(buf);
 		snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
 		ret = -EINVAL;


Robert Wood | 6 Sep 06:19 2014

Dual target node ALUA multipathing for Vmware

Good afternoon,

We are testing a dual node Pacemaker based cluster to deliver Fibre
Channel LUNs to Vmware (ESXi 5.5).  OS is Ubuntu Trusty 14.04, LIO
version is:

Target Engine Core ConfigFS Infrastructure v4.1.0 on Linux/x86_64 on

Each of the two LIO nodes (e1, kio1) has a QLA2462 Fibre Channel
(dual-port) HBAs, and the initiator node also has a QLA2462.   These
are connected via a Brocade 4Gb Silkworm switch.

We are setting TPG ID to be separate on each node, while keeping the
LUN serial number the same, back end storage being a Ceph image
presented equally to both LIO nodes.

One node sets ALUA state to s (Standby), while the other to o
(Active/Optimized).  However,when both nodes are presenting the same
LUN to Vmware, the TPG is only set to one of the nodes' ID for all
paths to storage.  ALUA state is Standby for all LUNs and there are
many errors in Vmware host's vmkernel.log, such as:

2014-09-06T03:38:58.748Z cpu2:45460)WARNING: NMP:
nmpDeviceAttemptFailover:603: Retry world failover device
"naa.6001405afcc298020000000000000000" - issuing command
2014-09-06T03:38:58.748Z cpu2:45460)WARNING: NMP:
nmp_SelectPathAndIssueCommand:3174: PSP selected path
"vmhba2:C0:T0:L1" in a bad state (standby) on device
(Continue reading)

Husam Al Sayed | 3 Sep 20:52 2014

FROM: Husam Al Sayed.

FROM: Husam Al Sayed.

EMAIL:alsayedhusa <at> hotmail.com


I decided to write you this proposal in good faith, believing that you will
not betray me. I am Mr. Husam Al Sayed, a Bank officer here in U.A.E.

One Mr. Peter Adams, a citizen of your country and Crude Oil dealer made a fixed deposit with my bank in 2005
for 108 calendar months, valued at US$30,000,000.00 (Thirty Million United State Dollars) the due date
for this deposit contract was last 22nd of January 2014. Sadly Peter was among the death victims in the May
27 2006 Earthquake disaster in Java, Indonesia that killed over 5,000 people. He was in Indonesia on a
business trip and that was how he met his untimely end. My bank management is yet to know about his death, I
knew about it because he was my friend and I am his Account Officer. Peter did not mention any Next of Kin/
Heir when the account was opened, he was not married and no children. Last week my Bank Management
requested that Peter should give instructions on what to do 
 about his funds, if to renew the contract.

I know this will happen and that is why I have been looking for a means to handle the situation, because if my
Bank Directors happens to know that Peter is dead and do not have any Heir, they will take the funds for their
personal use, so I don't want such to happen. That is why I am seeking your co-operation to present you as the
Next of Kin/ Heir to the account, since you are a foreigner and my bank head quarters will release the
account to you. There is no risk involved; the transaction will be executed under a legitimate
arrangement that will protect us from any breach of law. It is better that we claim the money, than allowing
the Bank Directors to take it, they are rich already. I am not a greedy person, so I am suggesting we share the
funds in this ratio, 50/50%, equal sharing. Let 
 me know your mind on this and please do treat this information highly confidential. We shall go over the
details once I receive your urgent response. Please Urgently get back to me through this email address as
soon as possible:
(Continue reading)

Joern Engel | 2 Sep 23:49 2014

[PATCH 00/16] Target fixes for coverity findings v2

Handled comments from Sagi Grimberg.  Thanks for the review, Sagi!

Joern Engel (16):
  target: remove unused debug code
  target: fix memory corruption
  target: avoid NULL pointer dereference
  target: remove always-true conditions
  target: simplify return statement
  target: fix condition
  target: remove unnecessary check
  target: avoid NULL pointer dereference
  target: avoid buffer overflow
  target: plug memory leak
  target: plug memory leak
  target: simplify target_fabric_make_lun
  target: fix pr_out length parsing
  target: handle match_int errors
  target: fix unused shift
  target: check for vector overflows

 drivers/target/iscsi/iscsi_target.c            | 185 +++++++++----------------
 drivers/target/iscsi/iscsi_target_configfs.c   |  10 +-
 drivers/target/iscsi/iscsi_target_erl0.c       |   6 +-
 drivers/target/iscsi/iscsi_target_login.c      |   8 +-
 drivers/target/iscsi/iscsi_target_parameters.c |   2 +-
 drivers/target/iscsi/iscsi_target_util.c       |   5 +-
 drivers/target/target_core_configfs.c          |  22 ++-
 drivers/target/target_core_fabric_configfs.c   |  11 +-
 drivers/target/target_core_fabric_lib.c        |   6 +-
 drivers/target/target_core_file.c              |   4 +-
(Continue reading)