headers
Robert Love | 25 May 23:29
Picon
Favicon

[Resend PATCH v2] scsi_lib: rate-limit the error message from failing commands

From: Yi Zou <yi.zou <at> intel.com>

When performing a cable pull test w/ active stress I/O using fio over
a dual port Intel 82599 FCoE CNA, w/ 256LUNs on one port and about 32LUNs
on the other, it is observed that the system becomes not usable due to
scsi-ml being busy printing the error messages for all the failing commands.
I don't believe this problem is specific to FCoE and these commands are
anyway failing due to link being down (DID_NO_CONNECT), just rate-limit
the messages here to solve this issue.

v2->v1: use __ratelimit() as Tomas Henzl mentioned as the proper way for
rate-limit per function. However, in this case, the failed i/o gets to
blk_end_request_err() and then blk_update_request(), which also has to
be rate-limited, as added in the v2 of this patch.

Signed-off-by: Yi Zou <yi.zou <at> intel.com>
Acked-by: Tomas Henzl <thenzl <at> redhat.com>
Signed-off-by: Robert Love <robert.w.love <at> intel.com>
---
 block/blk-core.c        |    8 +++++---
 drivers/scsi/scsi_lib.c |    5 ++++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index 1f61b74..c1f1c3a 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -29,6 +29,7 @@
 #include <linux/fault-inject.h>
 #include <linux/list_sort.h>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Vasu Dev | 25 May 19:26
Picon
Favicon

[PATCH 1/4] fc: adds some more FC specific stats to fc_host

The libfc provides more flexibility and with that
we can monitor some more FC specific stats for
FC exches or FCP error cases, this patch add
such new FC stats.

The patch adds *only* FC specific new stats to
existing fc_host attribute container.

Added stats names are self explanatory as
existing FC stats already has, however anyway
still added commentary along their definition
to describe them.

CC: James Smart <james.smart <at> emulex.com>

Signed-off-by: Vasu Dev <vasu.dev <at> intel.com>
Acked-by : Robert Love <robert.w.love <at> intel.com>
Tested-by: Ross Brattain <ross.b.brattain <at> intel.com>
---

 drivers/scsi/scsi_transport_fc.c |   18 ++++++++++++++++++
 include/scsi/scsi_transport_fc.h |   12 ++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 5797604..2fded79 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -1744,6 +1744,15 @@ fc_host_statistic(fcp_output_requests);
 fc_host_statistic(fcp_control_requests);
(Continue reading)

Permalink | Reply | 3 comments |
headers
info | 23 May 15:14

Tercume edilecek metinleriniz hakkinda

Sayin ilgili,

Biz 10 yili askin bir süredir internet üzerinden profesyonel olarak
CEVIRI / TERCUME HIZMETLERI veren bir kurulusuz. Kurulusumuzun 10. yili  
serefine firmalara ozel, sayfasi 12 TL+KDV'lik bir kampanya hazirladik.

Sadece INGILIZCE - TURKCE ve TURKCE - INGILIZCE cevirilerde gecerli olan ve 
kisa bir sure 
devam edecek bu cazip fiyat avantajindan yararlanmak icin
lutfen bizi hemen simdi arayiniz veya bir e-posta gonderiniz. Diger diller 
icin lutfen fiyat sorunuz.

Not: 1 sayfa = 1000 karakter veya 180 kelimelik dunya standardi 
esas alinmistir. Teknik metinlerde %25 fark alinacaktir. Diger diller icin 
lutfen fiyat aliniz.

Saygilarimizla,

Levent Turer,  
Genel Koordinator
Turer Ceviri Hizmetleri

e-posta: info <at> turerceviri.com 
web: www.turerceviri.com 
Tel: 0232 421 13 60
Faks: 0232 421 13 32

Bu e-mail size otomatik olarak, yani bir reklam amaciyla rastgele 
gonderilmemistir.  Eger bizden bu veya benzeri bir konuda 
bir daha e-posta almak istemiyorsaniz, lutfen bize bildiriniz. Size
(Continue reading)

Permalink | Reply | 0 comments |
headers
Dan Williams | 25 May 18:39
Picon
Favicon

[PATCH] scsi: fix async probe regression

Commit a7a20d1 "[SCSI] sd: limit the scope of the async probe domain"
moved sd probe work out of reach of wait_for_device_probe().  Allow it
to be synced via scsi_complete_async_scans().

Cc: David Miller <davem <at> davemloft.net>
Cc: Alan Stern <stern <at> rowland.harvard.edu>
Reported-by: Meelis Roos <mroos <at> linux.ee>
Tested-by: Meelis Roos <mroos <at> linux.ee>
Signed-off-by: Dan Williams <dan.j.williams <at> intel.com>
---

 So this is the stop gap that allows us to keep a7a20d1 as a fix for a
 resume deadlock, and gives us time to figure out how to clarify
 async_synchronize_full() properly in the 3.6 timeframe.

 drivers/scsi/scsi_scan.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 01b0374..41f9192 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -141,13 +141,13 @@ struct async_scan_data {
  * started scanning after this function was called may or may not have
  * finished.
  */
-int scsi_complete_async_scans(void)
+static void __scsi_complete_async_scans(void)
 {
 	struct async_scan_data *data;
(Continue reading)

Permalink | Reply | 1 comment |
headers
Dan Williams | 25 May 09:55
Picon
Favicon

[RFC PATCH] scsi: fix hot unplug vs async scan race

The following crash results from cases where the end_device has been
removed before scsi_sysfs_add_sdev has had a chance to run.

 BUG: unable to handle kernel NULL pointer dereference at 0000000000000098
 IP: [<ffffffff8115e100>] sysfs_create_dir+0x32/0xb6
 ...
 Call Trace:
  [<ffffffff8125e4a8>] kobject_add_internal+0x120/0x1e3
  [<ffffffff81075149>] ? trace_hardirqs_on+0xd/0xf
  [<ffffffff8125e641>] kobject_add_varg+0x41/0x50
  [<ffffffff8125e70b>] kobject_add+0x64/0x66
  [<ffffffff8131122b>] device_add+0x12d/0x63a
  [<ffffffff814b65ea>] ? _raw_spin_unlock_irqrestore+0x47/0x56
  [<ffffffff8107de15>] ? module_refcount+0x89/0xa0
  [<ffffffff8132f348>] scsi_sysfs_add_sdev+0x4e/0x28a
  [<ffffffff8132dcbb>] do_scan_async+0x9c/0x145

...teach scsi_sysfs_add_devices to check for deleted device before
trying to add them.

This teaches scsi_transport_sas to bypass scsi_remove_target() since it
is unable to find the target from the end_device rphy since
device_for_each_child() relies on the target device having gone through
a device_add().

Cc: Mike Christie <michaelc <at> cs.wisc.edu>
Cc: Robert Love <robert.w.love <at> intel.com>
Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama <at> lsi.com>
Cc: Kashyap Desai <kashyap.desai <at> lsi.com>
Cc: Matthew Wilcox <matthew <at> wil.cx>
(Continue reading)

Permalink | Reply | 1 comment |
headers
heinekenprize | 24 May 18:47

HHS5877 {Verify Your Ownership}

Your email just earn 1,000,000GBP in the  HEINEKEN STAR PRIZE Offer. 
Your reference code is: HHS5877. To proceed, please reply to verify 
you are the owner of this E-mail Address.

Info Dept.
Heineken Star prize

**SERVER**
THIS MESSAGE HAS BENN VERIFIED AND IT IS THEREFORE AUTHENTIC. If found 
in Junk/Spam folder please move to inbox before you reply, this is to 
avoid loss of relevant information regarding details of procedures 
from the sender.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
michaelc | 24 May 03:40
Picon
Favicon

[PATCH 1/1] be2iscsi: fix dma free size mismatch regression

From: Mike Christie <michaelc <at> cs.wisc.edu>

This patch should go into 3.5 fixes. The bug was added in the
patches for the 3.5 feature window.

As you can see from the patch I made a mistake. During
development I switched from passing a struct to the size of
the struct, but left the sizeof. This results in us allocating
4 bytes (sizeof(int)) but then calling pci_free_consistent
with the size of the struct.

Signed-off-by: Mike Christie <michaelc <at> cs.wisc.edu>
---
 drivers/scsi/be2iscsi/be_mgmt.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
index 01bb04c..2a09679 100644
--- a/drivers/scsi/be2iscsi/be_mgmt.c
+++ b/drivers/scsi/be2iscsi/be_mgmt.c
@@ -571,13 +571,12 @@ free_cmd:
 static int mgmt_alloc_cmd_data(struct beiscsi_hba *phba, struct be_dma_mem *cmd,
 			       int iscsi_cmd, int size)
 {
-	cmd->va = pci_alloc_consistent(phba->ctrl.pdev, sizeof(size),
-				       &cmd->dma);
+	cmd->va = pci_alloc_consistent(phba->ctrl.pdev, size, &cmd->dma);
 	if (!cmd->va) {
 		SE_DEBUG(DBG_LVL_1, "Failed to allocate memory for if info\n");
 		return -ENOMEM;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mrs Anna Kennedy | 23 May 20:58
Picon

GET BACK TO ME ASAP.

Good day my beloved friend,

How are you and your lovely family doing today,i hope all is well?if so glory 
be to God,i have an urgent purposal for you, if interested kindly contact me on 
this e-mail (anna_kennedy_hood <at> hotmail.co.uk)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
UCCCON | 23 May 09:57

CONTACT DR.RUBEN LEE


KINDLY FIND ATTACHED MESSAGE AND GET BACK TO ME
Attachment (APPROVED COMPENSATION.pdf): application/pdf, 62 KiB
Permalink | Reply | 0 comments |
headers
Robert Love | 23 May 04:06
Picon
Favicon

[PATCH v6 0/4] FCoE Sysfs

v6: Resend, v5 was missing patch 4/4

v5: Resend to apply on current misc branch of scsi.git

* checkpatch.pl complains about patch 3/4. The lack of a final
  argument is a trick I took from scsi_transport_fc.c. I think
  that it is fine.

  ERROR: space prohibited before that close parenthesis ')'
  #369: FILE: drivers/scsi/fcoe/fcoe_sysfs.c:196:
  +     fcoe_fcf_private_show_function(field, format_string, sz, )	\

* checkpatch.pl complains about patch 3/4. I attempted to add
  parenthesis around these macros, but I created more problems
  than I resolved. I am not sure what to do about this. I belive
  these were WARNs when this series was initially submitted.

  ERROR: Macros with complex values should be enclosed in parenthesis
  #378: FILE: drivers/scsi/fcoe/fcoe_sysfs.c:205:
  +#define fcoe_fcf_private_rd_attr_cast(field, format_string, sz, cast)	\
  +	 fcoe_fcf_private_show_function(field, format_string, sz, (cast)) \
  +	 static FCOE_DEVICE_ATTR(fcf, field, S_IRUGO,	      	  	  \
  +	 			      	     show_fcoe_fcf_device_##field, NULL)

* checkpatch.pl complains about patch 4/4. This is just a WARN.
  I would fix this if I knew how to, but I don't think it should
  be a problem.

  WARNING: quoted string split across lines
  #502: FILE: drivers/scsi/fcoe/fcoe_ctlr.c:1021:
(Continue reading)

Permalink | Reply | 4 comments |
headers
Robert Love | 23 May 04:04
Picon
Favicon

[PATCH v5 0/3] FCoE Sysfs

v5: Resend to apply on current misc branch of scsi.git

* checkpatch.pl complains about patch 3/4. The lack of a final
  argument is a trick I took from scsi_transport_fc.c. I think
  that it is fine.

  ERROR: space prohibited before that close parenthesis ')'
  #369: FILE: drivers/scsi/fcoe/fcoe_sysfs.c:196:
  +     fcoe_fcf_private_show_function(field, format_string, sz, )	\

* checkpatch.pl complains about patch 3/4. I attempted to add
  parenthesis around these macros, but I created more problems
  than I resolved. I am not sure what to do about this. I belive
  these were WARNs when this series was initially submitted.

  ERROR: Macros with complex values should be enclosed in parenthesis
  #378: FILE: drivers/scsi/fcoe/fcoe_sysfs.c:205:
  +#define fcoe_fcf_private_rd_attr_cast(field, format_string, sz, cast)	\
  +	 fcoe_fcf_private_show_function(field, format_string, sz, (cast)) \
  +	 static FCOE_DEVICE_ATTR(fcf, field, S_IRUGO,	      	  	  \
  +	 			      	     show_fcoe_fcf_device_##field, NULL)

* checkpatch.pl complains about patch 4/4. This is just a WARN.
  I would fix this if I knew how to, but I don't think it should
  be a problem.

  WARNING: quoted string split across lines
  #502: FILE: drivers/scsi/fcoe/fcoe_ctlr.c:1021:
  +		printk(KERN_ERR "Failed to allocate sysfs instance "
  +					       "for FCF, fab 16.16llx mac pM\n",
(Continue reading)

Permalink | Reply | 4 comments |

Gmane