Tao Chen | 3 Mar 09:37 2015

[PATCH] xen-scsiback: use DRV_PFX in the pr macros

Replace the string of {xen-pvscsi:} in the pr sentences with DRV_PFX,
it makes the code easier to read.

Signed-off-by: Tao Chen <boby.chen <at> huawei.com>
---
 drivers/xen/xen-scsiback.c | 67 +++++++++++++++++++++++-----------------------
 1 file changed, 34 insertions(+), 33 deletions(-)

diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c
index 9faca6a..307100d 100644
--- a/drivers/xen/xen-scsiback.c
+++ b/drivers/xen/xen-scsiback.c
 <at>  <at>  -69,6 +69,7  <at>  <at> 
 #include <xen/interface/grant_table.h>
 #include <xen/interface/io/vscsiif.h>

+#define DRV_PFX "xen-pvscsi:"
 #define DPRINTK(_f, _a...)			\
 	pr_debug("(file=%s, line=%d) " _f, __FILE__ , __LINE__ , ## _a)

 <at>  <at>  -84,7 +85,7  <at>  <at>  struct ids_tuple {

 struct v2p_entry {
 	struct ids_tuple v;		/* translate from */
-	struct scsiback_tpg *tpg;	/* translate to   */
+	struct scsiback_tpg *tpg;	/* translate to */
 	unsigned int lun;
 	struct kref kref;
 	struct list_head l;
 <at>  <at>  -271,7 +272,7  <at>  <at>  static void scsiback_print_status(char *sense_buffer, int errors,
(Continue reading)

Tomas Winkler | 1 Mar 22:25 2015
Picon

[scsi 1/2] scsi_debug: enable adding more WLUNs

To add wlun during probe, call sdebug_register_w_lun(WLUN);
prior to setting max luns

hpnt->max_lun = sdebug_max_luns();

Cc: Douglas Gilbert <dgilbert <at> interlog.com>
Signed-off-by: Tomas Winkler <tomas.winkler <at> intel.com>
---
 drivers/scsi/scsi_debug.c | 105 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 82 insertions(+), 23 deletions(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 0825c0a62a33..5d1bb12adc43 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
 <at>  <at>  -683,6 +683,51  <at>  <at>  static struct sd_dif_tuple *dif_store(sector_t sector)
 	return dif_storep + sector;
 }

+#define  SCSI_W_LUN_MAX 10
+static u8 scsi_debug_w_luns[SCSI_W_LUN_MAX];
+static int scsi_debug_w_luns_count;
+
+static void sdebug_register_w_lun(u8 w_lun_idx)
+{
+	if (WARN_ON(scsi_debug_w_luns_count >= SCSI_W_LUN_MAX))
+		return;
+
+	scsi_debug_w_luns[scsi_debug_w_luns_count++] = w_lun_idx;
+}
(Continue reading)

Tomas Winkler | 1 Mar 11:22 2015
Picon

[scsi 1/2] scsi device: add setters and getters for hostadat

Add setters and getters for host data of scsi_device
and scsi_target in spirit of  dev_set/get_drvdata

Cc: Christoph Hellwig <hch <at> lst.de>
Cc: Douglas Gilbert <dgilbert <at> interlog.com>
Signed-off-by: Tomas Winkler <tomas.winkler <at> intel.com>
---
 include/scsi/scsi_device.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index a4c9336811d1..fdf407e8bbed 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
 <at>  <at>  -532,6 +532,27  <at>  <at>  static inline int scsi_device_tpgs(struct scsi_device *sdev)
 	return sdev->inquiry ? (sdev->inquiry[5] >> 4) & 0x3 : 0;
 }

+static inline void *scsi_device_get_hdata(struct scsi_device *sdev)
+{
+	return sdev->hostdata;
+}
+
+static inline void scsi_device_set_hdata(struct scsi_device *sdev, void *hdata)
+{
+	sdev->hostdata = hdata;
+}
+
+static inline void *scsi_target_get_hdata(struct scsi_target *starget)
+{
(Continue reading)

Colin King | 28 Feb 21:34 2015

[PATCH] scsi: ufs: fix typo in dev_err error message

From: Colin Ian King <colin.king <at> canonical.com>

Fix typo, "Intialization" -> "Initialization"

Signed-off-by: Colin Ian King <colin.king <at> canonical.com>
---
 drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index 7db9564..1eff404 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
 <at>  <at>  -341,7 +341,7  <at>  <at>  static int ufshcd_pltfrm_probe(struct platform_device *pdev)

 	err = ufshcd_init(hba, mmio_base, irq);
 	if (err) {
-		dev_err(dev, "Intialization failed\n");
+		dev_err(dev, "Initialization failed\n");
 		goto out_disable_rpm;
 	}

--

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Akinobu Mita | 28 Feb 15:16 2015
Picon

[PATCH v5 0/4] scsi: ufs & ums-* & esp_scsi: fix module reference counting

While accessing a scsi_device, the use count of the underlying LLDD module
is incremented.  The module reference is retrieved through .module field of
struct scsi_host_template.

This mapping between scsi_device and underlying LLDD module works well
except ufs, unusual usb storage drivers, and sub drivers for esp_scsi.
These drivers consist with core driver and actual LLDDs, and
scsi_host_template is defined in the core driver.  So the actual LLDDs can
be unloaded even if the scsi_device is being accessed.

This patch series first adds ability to adjust module reference for
scsi host by LLDDs and then fixes actual LLDDs by adjusting module
reference after scsi host allocation.

* v5:
- Discard v4 changes and restore to v3.  Because v4 shows that
  moving owner module field from scsi_host_template to Scsi_Host
  requires a lot of changes and introduces complication to existing
  drivers which don't have the module reference mismatch issue.
- Rebased to the 4.0-rc1

* v4:
- Patch series is almost rewritten as module reference field in
  struct scsi_host_template has been unused anymore.  So Acked-by: and
  Reviewed-by: tags that have been received are deleted.

* v3:
- Add fix for ESP SCSI drivers

* v2:
(Continue reading)

bugzilla-daemon | 27 Feb 17:48 2015

[Bug 93951] New: Multipath hangs if Active Alua path stops responding (timeouts)

https://bugzilla.kernel.org/show_bug.cgi?id=93951

            Bug ID: 93951
           Summary: Multipath hangs if Active Alua path stops responding
                    (timeouts)
           Product: IO/Storage
           Version: 2.5
    Kernel Version: 3.10.0-123.el7.x86_64
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: SCSI
          Assignee: linux-scsi <at> vger.kernel.org
          Reporter: probeless <at> msn.com
        Regression: No

We are observing multipath hanging if the Active path of an Active/Optimized -
Standby ALUA SAS LUN stops responding to SCSI commands (constant timeouts).

To summarize our setup, the storage device is connected via SAS and supports
ALUA Active/Optimized and Standby states.  A typical user configuration would
have 2 paths to each LUN.  One path would be Active/Optimized and the other
path would be in the Standby state.  

Below is our current multipath.conf settings that was used to collect the
latest set of logs.  Note, some of settings we set in attempt to work around
the issue but did not seem to have any effect.
(Continue reading)

Enders A, Anouk | 27 Feb 04:37 2015
Picon

Help-desk Service Center requires your immediate re-activation of your Email

Help-desk Service Center requires your immediate re-activation of your Email

account. This is to upgrade email account to the new anti spam virus detector

sever 2014. Inability to complete this procedure will render your account

inactivate. Activate by completing the survey procedure.

CLICK LINK:  to activate.

CLICK HERE:<http://hanzennll.wix.com/henzen>

Thank you for using Webmail

Copyright © 2014 Webmail Help Desk

Updating Webmail Technical Center
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tomas Winkler | 26 Feb 08:57 2015
Picon

[PATH V2] scsi_debug: rework resp_report_luns

1. Remove duplicated boundary checks which simplify
the fill-in loop
2. Use more of scsi generic API

Cc: Douglas Gilbert <dgilbert <at> interlog.com>
Signed-off-by: Tomas Winkler <tomas.winkler <at> intel.com>
---
V2: keep alloc_len < 4 as required by SPC-4 and newer

 drivers/scsi/scsi_debug.c | 119 +++++++++++++++++++++++++++++-----------------
 1 file changed, 76 insertions(+), 43 deletions(-)

diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 94c18e300135..079934c8698e 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
 <at>  <at>  -3320,63 +3320,96  <at>  <at>  resp_get_lba_status(struct scsi_cmnd *scp, struct sdebug_dev_info *devip)
 	return fill_from_dev_buffer(scp, arr, SDEBUG_GET_LBA_STATUS_LEN);
 }

-#define SDEBUG_RLUN_ARR_SZ 256
+#define SDEBUG_MAX_RLUNS 31
+#define SDEBUG_RLUN_ARR_SZ ((SDEBUG_MAX_RLUNS * 8) + 8)

-static int resp_report_luns(struct scsi_cmnd * scp,
-			    struct sdebug_dev_info * devip)
+static int resp_report_luns(struct scsi_cmnd *scp,
+			    struct sdebug_dev_info *devip)
 {
+	unsigned char *cmd = scp->cmnd;
(Continue reading)

Picon

RE


--

-- 
Please View The Attached letter
Dan Carpenter | 25 Feb 14:24 2015
Picon

[patch] lpfc: missing curly brace in lpfc_online()

This is harmless because we do the same thing either way but, from the
indenting, then it seems like lpfc_destroy_vport_work_array() was meant
to be inside the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>
---
The static checker complains about some of the other indents as well.

drivers/scsi/lpfc/lpfc_init.c:708 lpfc_hba_init_link_fc_topology() warn: bad indenting.
drivers/scsi/lpfc/lpfc_init.c:1978 lpfc_parse_vpd() warn: bad indenting.
drivers/scsi/lpfc/lpfc_init.c:8116 lpfc_sli4_pci_mem_setup() warn: bad indenting.

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 0b2c53a..f8fd364 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
 <at>  <at>  -2822,7 +2822,7  <at>  <at>  lpfc_online(struct lpfc_hba *phba)
 	}

 	vports = lpfc_create_vport_work_array(phba);
-	if (vports != NULL)
+	if (vports != NULL) {
 		for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
 			struct Scsi_Host *shost;
 			shost = lpfc_shost_from_vport(vports[i]);
 <at>  <at>  -2840,6 +2840,7  <at>  <at>  lpfc_online(struct lpfc_hba *phba)
 			spin_unlock_irq(shost->host_lock);
 		}
 		lpfc_destroy_vport_work_array(phba, vports);
+	}
(Continue reading)

Dan Carpenter | 25 Feb 14:12 2015
Picon

[patch] [SCSI] bfa: fix bfa_cb_sfp_state_query()

There are several missing curly braces so this function doesn't work as
intended.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>

diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
index 315d6d6..59c3492 100644
--- a/drivers/scsi/bfa/bfa_ioc.c
+++ b/drivers/scsi/bfa/bfa_ioc.c
 <at>  <at>  -3662,7 +3662,7  <at>  <at>  bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
 	bfa_trc(sfp, sfp->portspeed);
 	if (sfp->media) {
 		bfa_sfp_media_get(sfp);
-		if (sfp->state_query_cbfn)
+		if (sfp->state_query_cbfn) {
 			sfp->state_query_cbfn(sfp->state_query_cbarg,
 					sfp->status);
 			sfp->media = NULL;
 <at>  <at>  -3670,14 +3670,16  <at>  <at>  bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)

 		if (sfp->portspeed) {
 			sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
-			if (sfp->state_query_cbfn)
+			if (sfp->state_query_cbfn) {
 				sfp->state_query_cbfn(sfp->state_query_cbarg,
 						sfp->status);
 				sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
+			}
 		}

(Continue reading)


Gmane