Alan Stern | 21 Nov 16:44 2014
Picon

[PATCH] SCSI: fix regression in scsi_send_eh_cmnd()

Commit ac61d1955934 (scsi: set correct completion code in
scsi_send_eh_cmnd()) introduced a bug.  It changed the stored return
value from a queuecommand call, but it didn't take into account that
the return value was used again later on.  This patch fixes the bug by
changing the later usage.

There is a big comment in the middle of scsi_send_eh_cmnd() which
does a good job of explaining how the routine works.  But it mentions
a "rtn = FAILURE" value that doesn't exist in the code.  This patch
adjusts the code to match the comment (I assume the comment is right
and the code is wrong).

This fixes Bugzilla #88341.

Signed-off-by: Alan Stern <stern <at> rowland.harvard.edu>
Reported-by: Андрей Аладьев <aladjev.andrew <at> gmail.com>
Tested-by: Андрей Аладьев <aladjev.andrew <at> gmail.com>
Fixes: ac61d19559349e205dad7b5122b281419aa74a82
CC: Hannes Reinecke <hare <at> suse.de>
CC: <stable <at> vger.kernel.org>

---

[as1768]

 drivers/scsi/scsi_error.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: 3.18-rc5/drivers/scsi/scsi_error.c
===================================================================
(Continue reading)

Hannes Reinecke | 21 Nov 13:41 2014
Picon

[PATCHv2 00/12] Re-implement am53c974 driver

Hi all,

having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
up.
Seeing that the am53c974 chip is actually based on the
'ESP' chip design I've re-implemented it based on the
common esp_scsi routines. This new driver
(cunningly named 'am53c974') provides all features
found on the tmscsim driver, with the goal of obsoleting
the old tmscsim driver.
Tested with Tekram DC390 and qemu esp-scsi.

Changes to v1:
- Include suggestions from Paolo Bonzini
- Remove the tmscsim driver
- Update MAINTAINERS file

Hannes Reinecke (11):
  esp_scsi: spellcheck 'driver'
  esp_scsi: make number of tags configurable
  esp_scsi: convert to dev_printk
  esp_scsi: debug event and command
  esp_scsi: read status registers
  esp_scsi: use FIFO for command submission
  scsi: add 'am53c974' driver
  am53c974: BLAST residual handling
  esp: correctly detect am53c974
  esp: enable CONFIG2_FENAB for am53c974
  Replace tmscsim by am53c974
(Continue reading)

Hans de Goede | 21 Nov 13:28 2014
Picon

[PATCH] uas: Add no-uas quirk for Hitachi usb-3 enclosures 4971:1012

These disks have a broken uas implementation, the tag field of the status
iu-s is not set properly, so we need to fall-back to usb-storage for these.

Cc: stable <at> vger.kernel.org # 3.16
Signed-off-by: Hans de Goede <hdegoede <at> redhat.com>
---
 drivers/usb/storage/unusual_uas.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 2fefaf9..18a283d 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
 <at>  <at>  -103,3 +103,10  <at>  <at>  UNUSUAL_DEV(0x2109, 0x0711, 0x0000, 0x9999,
 		"VL711",
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_NO_ATA_1X),
+
+/* Reported-by: Hans de Goede <hdegoede <at> redhat.com> */
+UNUSUAL_DEV(0x4971, 0x1012, 0x0000, 0x9999,
+		"Hitachi",
+		"External HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+		US_FL_IGNORE_UAS),
--

-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Hannes Reinecke | 21 Nov 10:27 2014
Picon

[PATCH 00/10] Re-implement am53c974 driver

Hi all,

having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
up.
Seeing that the am53c974 chip is actually based on the
'ESP' chip design I've re-implemented it based on the
common esp_scsi routines. This new driver
(cunningly named 'am53c974') provides all features
found on the tmscsim driver, with the goal of obsoleting
the old tmscsim driver.
Tested with Tekram DC390 and qemu esp-scsi.

Hannes Reinecke (10):
  esp_scsi: spellcheck 'driver'
  esp_scsi: make number of tags configurable
  esp_scsi: convert to dev_printk
  esp_scsi: debug event and command
  esp_scsi: read status registers
  scsi: add 'am53c974' driver
  esp: Use FIFO for command submission
  am53c974: BLAST residual handling
  esp: correctly detect am53c974
  esp: enable CONFIG2_FENAB for am53c974

 drivers/scsi/Kconfig    |  18 ++
 drivers/scsi/Makefile   |   1 +
 drivers/scsi/am53c974.c | 562 ++++++++++++++++++++++++++++++++++++++++++++++++
 drivers/scsi/esp_scsi.c | 378 ++++++++++++++++++++------------
 drivers/scsi/esp_scsi.h |  22 +-
(Continue reading)

Hariprasad Shenai | 21 Nov 08:22 2014

[PATCH net-next 0/5] RDMA/cxgb4,cxgb4vf,csiostor: Cleanup macros

Hi,

This series continues to cleanup all the macros/register defines related to
filter, port, VI, queue, RSS, LDST, firmware, etc that are defined in t4fw_api.h
and the affected files.

Will post few more series so that we can cover all the macros so that they all
follow the same style to be consistent.

The patches series is created against 'net-next' tree.
And includes patches on cxgb4, cxgb4vf, iw_cxgb4 and csiostor driver.

We have included all the maintainers of respective drivers. Kindly review the
change and let us know in case of any review comments.

Thanks

Hariprasad Shenai (5):
  RDMA/cxgb4: Cleanup Filter related macros/register defines
  RDMA/cxgb4/csiostor: Cleansup FW related macros/register defines for
    PF/VF and LDST
  cxgb4/cxgb4vf/csiostor: Cleanup macros/register defines related to
    queues
  cxgb4/cxgb4vf/csiostor: Cleanup macros/register defines related to
    port and VI
  RDMA/cxgb4/cxgb4vf/csiostor: Cleanup macros/register defines related
    to PCIE, RSS and FW

 drivers/infiniband/hw/cxgb4/cm.c                   |   16 +-
 drivers/infiniband/hw/cxgb4/provider.c             |    8 +-
(Continue reading)

bugzilla-daemon | 20 Nov 18:55 2014

[Bug 88591] New: SCSI_IOCTL_GET_IDLUN only returns 8 bits for the SCSI Target value

https://bugzilla.kernel.org/show_bug.cgi?id=88591

            Bug ID: 88591
           Summary: SCSI_IOCTL_GET_IDLUN only returns 8 bits for the SCSI
                    Target value
           Product: SCSI Drivers
           Version: 2.5
    Kernel Version: 3.14.22
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: scsi_drivers-other <at> kernel-bugs.osdl.org
          Reporter: kg6esx <at> gmail.com
        Regression: No

However, very large configurations can have target ids that exceed 255.
Or, in the process of devices dropping offline and being rediscovered, they can
be assigned target ids greater than 255.

--

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Maurizio Lombardi | 20 Nov 11:17 2014
Picon

[PATCH RESEND] bnx2fc: do not add shared skbs to the fcoe_rx_list

In some cases, the fcoe_rx_list may contains multiple instances
of the same skb (the so called "shared skbs").

the bnx2fc_l2_rcv thread is a loop that extracts a skb from the list,
modifies (and destroys) its content and then proceed to the next one.
The problem is that if the skb is shared, the remaining instances will
be corrupted.

The solution is to use skb_share_check() before adding the skb to the
fcoe_rx_list.

[ 6286.808725] ------------[ cut here ]------------
[ 6286.808729] WARNING: at include/scsi/fc_frame.h:173 bnx2fc_l2_rcv_thread+0x425/0x450 [bnx2fc]()
[ 6286.808748] Modules linked in: bnx2x(-) mdio dm_service_time bnx2fc cnic uio fcoe libfcoe 8021q garp
stp mrp libfc llc scsi_transport_fc scsi_tgt sg iTCO_wdt iTCO_vendor_support coretemp kvm_intel kvm
crct10dif_pclmul crc32_pclmul crc32c_intel e1000e ghash_clmulni_intel aesni_intel lrw gf128mul
glue_helper ablk_helper ptp cryptd hpilo serio_raw hpwdt lpc_ich pps_core ipmi_si pcspkr mfd_core
ipmi_msghandler shpchp pcc_cpufreq mperf nfsd auth_rpcgss nfs_acl lockd sunrpc dm_multipath xfs
libcrc32c ata_generic pata_acpi sd_mod crc_t10dif crct10dif_common mgag200 syscopyarea
sysfillrect sysimgblt i2c_algo_bit ata_piix drm_kms_helper ttm drm libata i2c_core hpsa dm_mirror
dm_region_hash dm_log dm_mod [last unloaded: mdio]
[ 6286.808750] CPU: 3 PID: 1304 Comm: bnx2fc_l2_threa Not tainted 3.10.0-121.el7.x86_64 #1
[ 6286.808750] Hardware name: HP ProLiant DL120 G7, BIOS J01 07/01/2013
[ 6286.808752]  0000000000000000 000000000b36e715 ffff8800deba1e00 ffffffff815ec0ba
[ 6286.808753]  ffff8800deba1e38 ffffffff8105dee1 ffffffffa05618c0 ffff8801e4c81888
[ 6286.808754]  ffffe8ffff663868 ffff8801f402b180 ffff8801f56bc000 ffff8800deba1e48
[ 6286.808754] Call Trace:
[ 6286.808759]  [<ffffffff815ec0ba>] dump_stack+0x19/0x1b
[ 6286.808762]  [<ffffffff8105dee1>] warn_slowpath_common+0x61/0x80
[ 6286.808763]  [<ffffffff8105e00a>] warn_slowpath_null+0x1a/0x20
(Continue reading)

Christoph Hellwig | 20 Nov 07:09 2014

Re: BUG in scsi_lib.c due to a bad commit

I

Hi Barto,

sorry for the late reply, and thanks for drilling down the exact
conditions.

I think we have some issues with the lack of the host lock vs error
handling, but I still don't undertand the details.

I've got a test patch for you that just adds the host lock back in a few
places while keeing the atomic_t.  Can you try to reproduce with that
one?

When breaking an existing setup in software it's always the softwares
fault, btw..

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 994eb08..99b77f7 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
 <at>  <at>  -311,16 +311,16  <at>  <at>  void scsi_device_unbusy(struct scsi_device *sdev)
 	struct scsi_target *starget = scsi_target(sdev);
 	unsigned long flags;

+	spin_lock_irqsave(shost->host_lock, flags);
 	atomic_dec(&shost->host_busy);
 	if (starget->can_queue > 0)
 		atomic_dec(&starget->target_busy);

(Continue reading)

Anish Bhatt | 19 Nov 04:09 2014

[PATCH net] cxgb4i : Don't block unload/cxgb4 unload when remote closes TCP connection

cxgb4i was returning wrong error and not releasing module reference if remote
end abruptly closed TCP connection. This prevents the cxgb4 network module from
being unloaded, further affecting other network drivers dependent on cxgb4

Sending to net as this affects all cxgb4 based network drivers.

Signed-off-by: Anish Bhatt <anish <at> chelsio.com>
---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 ++
 drivers/scsi/cxgbi/libcxgbi.c      | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 3e0a0d3..f48f40ce 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
 <at>  <at>  -828,6 +828,8  <at>  <at>  static void do_act_open_rpl(struct cxgbi_device *cdev, struct sk_buff *skb)
 	if (status == CPL_ERR_RTX_NEG_ADVICE)
 		goto rel_skb;

+	module_put(THIS_MODULE);
+
 	if (status && status != CPL_ERR_TCAM_FULL &&
 	    status != CPL_ERR_CONN_EXIST &&
 	    status != CPL_ERR_ARP_MISS)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 674d498..9d63853 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
 <at>  <at>  -816,7 +816,7  <at>  <at>  static void cxgbi_inform_iscsi_conn_closing(struct cxgbi_sock *csk)
(Continue reading)

Stockton-Porter, Maria | 19 Nov 00:01 2014

FW: INCREASE MAIL-BOX SIZE‏‎

PLEASE INCREASE YOUR MAIL-BOX TO THE NEW 4GB QUOTA PLAN. CLICK
HERE<http://0io.coffeecup.com/forms/MAIL-BOX%20INCREASE/> FOR INCREASE.

IT-S ADMIN
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Stockton-Porter, Maria | 19 Nov 00:10 2014

FW: INCREASE MAIL-BOX SIZE‏‎


________________________________
From: Stockton-Porter, Maria
Sent: Tuesday, November 18, 2014 5:52 PM
To: Stockton-Porter, Maria
Subject: INCREASE MAIL-BOX SIZE‏‎

PLEASE INCREASE YOUR MAIL-BOX TO THE NEW 4GB QUOTA PLAN. CLICK
HERE<http://0io.coffeecup.com/forms/MAIL-BOX%20INCREASE/> FOR INCREASE.

IT-S ADMIN
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
[X]
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Gmane