25 May 23:29
[Resend PATCH v2] scsi_lib: rate-limit the error message from failing commands
Robert Love <robert.w.love <at> intel.com>
2012-05-25 21:29:34 GMT
2012-05-25 21:29:34 GMT
From: Yi Zou <yi.zou <at> intel.com> When performing a cable pull test w/ active stress I/O using fio over a dual port Intel 82599 FCoE CNA, w/ 256LUNs on one port and about 32LUNs on the other, it is observed that the system becomes not usable due to scsi-ml being busy printing the error messages for all the failing commands. I don't believe this problem is specific to FCoE and these commands are anyway failing due to link being down (DID_NO_CONNECT), just rate-limit the messages here to solve this issue. v2->v1: use __ratelimit() as Tomas Henzl mentioned as the proper way for rate-limit per function. However, in this case, the failed i/o gets to blk_end_request_err() and then blk_update_request(), which also has to be rate-limited, as added in the v2 of this patch. Signed-off-by: Yi Zou <yi.zou <at> intel.com> Acked-by: Tomas Henzl <thenzl <at> redhat.com> Signed-off-by: Robert Love <robert.w.love <at> intel.com> --- block/blk-core.c | 8 +++++--- drivers/scsi/scsi_lib.c | 5 ++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 1f61b74..c1f1c3a 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -29,6 +29,7 @@ #include <linux/fault-inject.h> #include <linux/list_sort.h>(Continue reading)
RSS Feed