Ondrej Zary | 25 Jan 22:23 2015

[PATCH] wd719x: add missing .module to wd719x_template

wd719x_template is missing the .module field, causing module refcount
not to work, allowing to rmmod the driver while in use (mounted filesystem),
causing an oops.

Set .module to THIS_MODULE to fix the problem.

Signed-off-by: Ondrej Zary <linux <at> rainbow-software.org>
---
 drivers/scsi/wd719x.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 7702664..289ad01 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
 <at>  <at>  -870,6 +870,7  <at>  <at>  fail_free_params:
 }

 static struct scsi_host_template wd719x_template = {
+	.module				= THIS_MODULE,
 	.name				= "Western Digital 719x",
 	.queuecommand			= wd719x_queuecommand,
 	.eh_abort_handler		= wd719x_abort,
--

-- 
Ondrej Zary

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Krause Arno | 24 Jan 03:11 2015

Darlehen Angebot


Guten Morgen
Sind Sie in Darlehen interessiert?
Der Preis ist niedrig
Für weitere Informationen und Erklärungen
Meine E-Mail: info.krause.arno <at> gmail.com
Danke

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Don Brace | 23 Jan 23:41 2015

[PATCH v2 00/48] hpsa driver updates

This patch set is based on Linus's tree.

The changes are:
 - correct sparse warnings
 - correct memory leaks
 - correct kdump issues
 - correct queue depth updates
 - cleanup function return values
 - cleanup and enhance messages
 - cleanup and enhance error handling
 - minor code refactoring
 - performance enhancements.
 - removal of command queueing in driver
 - elimination of race conditions around aborts
 - change to internal driver workqueues

---

Don Brace (12):
      hpsa: correct endian sparse warnings
      hpsa: change how SA controllers are reset
      hpsa: correct change_queue_depth
      hpsa: do not queue commands internally in driver
      hpsa: use workqueue to resubmit failed ioaccel commands
      hpsa: honor queue depth of physical devices
      hpsa: count passthru cmds with atomics, not a spin locked int
      hpsa: slightly optimize SA5_performant_completed
      hpsa: return failed from device reset/abort handlers
      hpsa: add in gen9 controller model names
      hpsa: add in P840ar controller model name
(Continue reading)

Tomas Henzl | 23 Jan 17:16 2015
Picon

[PATCH 0/2] hpsa: workqueue + minor fix

I've adapted previously posted changes on top of the latest hpsa series.

Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Bart Van Assche | 23 Jan 13:05 2015

[PATCH 0/17] Clear up bidi command confusion

There is some confusion in the SCSI core and in SCSI LLDs around the
meaning of sc_data_direction and whether or not this member can have the
value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this
series are:

0001-Clear-up-sc_data_direction-documentation.patch
0002-Clean-up-scsi_ioctl_reset.patch
0003-sg-Remove-an-unused-variable.patch
0004-dpt_i2o-Fix-bidi-command-test.patch
0005-aachba-Fix-bidi-command-test.patch
0006-eata-Remove-dead-code.patch
0007-sbp2-Fix-bidi-command-test.patch
0008-ibmvscsi-Fix-bidi-command-test.patch
0009-cciss-Remove-dead-code.patch
0010-hpsa-Remove-dead-code.patch
0011-3w-9xxx-Remove-dead-code.patch
0012-ncr53c8xx-Fix-bidi-command-support.patch
0013-qla1280-Fix-bidi-command-support.patch
0014-53c700-Remove-dead-code.patch
0015-mvumi-Remove-dead-code.patch
0016-sym_glue-Fix-bidi-command-test.patch
0017-IB-srp-Detect-bidi-commands-properly.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Nicholas Mc Guire | 22 Jan 12:42 2015
Picon

[PATCH] scsi: ncr5380: use msecs_to_jiffies for conversions

This is only an API consolidation to make things more readable

Signed-off-by: Nicholas Mc Guire <der.herr <at> hofr.at>
---

Converting milliseconds to jiffies by "val * HZ / 1000" is technically
ok but msecs_to_jiffies(val) is the cleaner solution and handles all 
corner cases correctly. This is a minor API cleanup only.

This patch was only compile tested with i386_defconfig + CONFIG_ISA=y,
CONFIG_SCSI_LOWLEVEL=y, CONFIG_SCSI_GENERIC_NCR5380=m

Patch is against 3.19.0-rc5 -next-20150119

 drivers/scsi/NCR5380.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 36244d6..5008a0e 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
 <at>  <at>  -474,11 +474,11  <at>  <at>  static void NCR5380_print_phase(struct Scsi_Host *instance)
  */
 #ifndef USLEEP_SLEEP
 /* 20 ms (reasonable hard disk speed) */
-#define USLEEP_SLEEP (20*HZ/1000)
+#define USLEEP_SLEEP msecs_to_jiffies(20)
 #endif
 /* 300 RPM (floppy speed) */
 #ifndef USLEEP_POLL
(Continue reading)

Gavin Guo | 21 Jan 23:38 2015

General protection fault in iscsi_rx_thread_pre_handler

Hi all,

The general protection fault screenshot is attached.

Summary:
The kernel is Ubuntu-3.13.0-39.66. I've done basic analysis and found
the fault is in list_del of iscsi_del_ts_from_active_list. And it
looks like deleting the iscsi_thread_set *ts two times. The point to
delete including iscsi_get_ts_from_inactive_list, was also checked but
still can't find the clue. Really appreciate if anyone can provide any
idea on the bug.

static void iscsi_del_ts_from_active_list(struct iscsi_thread_set *ts)
{
<...>
list_del(&ts->ts_list);
<...>
}
static inline void list_del(struct list_head *entry)
{
__list_del(entry->prev, entry->next);
entry->next = LIST_POISON1;
entry->prev = LIST_POISON2;
}

static inline void __list_del(struct list_head * prev, struct list_head * next)
{
next->prev = prev;
prev->next = next;
}
(Continue reading)

bugzilla-daemon | 21 Jan 20:17 2015

[Bug 91711] New: 3w-9xxx: DMA-API: device driver tries to free DMA memory it has not allocated

https://bugzilla.kernel.org/show_bug.cgi?id=91711

            Bug ID: 91711
           Summary: 3w-9xxx: DMA-API: device driver tries to free DMA
                    memory it has not allocated
           Product: IO/Storage
           Version: 2.5
    Kernel Version: 3.18.3
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: SCSI
          Assignee: linux-scsi <at> vger.kernel.org
          Reporter: admin <at> e-blokos.com
        Regression: No

3w-9xxx 0000:03:03.0: DMA-API: device driver tries to free DMA memory it has
not allocated [device address=0x0000000000000000] [size=0 bytes]
can cause randomly a kernel panic...

here is the bug trace

[10205.263190] ------------[ cut here ]------------
[10205.271182] WARNING: CPU: 3 PID: 0 at lib/dma-debug.c:1080
check_unmap+0x8ea/0x9e0()
[10205.273087] 3w-9xxx 0000:03:03.0: DMA-API: device driver tries to free DMA
memory it has not allocated [device address=0x0000000000000000] [size=0 bytes]
(Continue reading)

Bart Van Assche | 21 Jan 17:18 2015

sc_data_direction and bidi commands

Hello,

Although several SCSI LLDs compare sc_data_direction with the value
DMA_BIDIRECTIONAL apparently scsi_setup_cmnd() never sets
sc_data_direction to the value DMA_BIDIRECTIONAL. Is this behavior on
purpose ? I discovered this while debugging bidi support in a SCSI LLD.

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Dave Jiang | 21 Jan 17:13 2015
Picon

[PATCH] MAINTAINERS: Remove self as isci maintainer

Removing myself as a maintainer.

Signed-off-by: Dave Jiang <dave.jiang <at> intel.com>
---
 MAINTAINERS |    1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 93409ad..7e3d97a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
 <at>  <at>  -4946,7 +4946,6  <at>  <at>  K:	\b(ABS|SYN)_MT_
 INTEL C600 SERIES SAS CONTROLLER DRIVER
 M:	Intel SCU Linux support <intel-linux-scu <at> intel.com>
 M:	Artur Paszkiewicz <artur.paszkiewicz <at> intel.com>
-M:	Dave Jiang <dave.jiang <at> intel.com>
 L:	linux-scsi <at> vger.kernel.org
 T:	git git://git.code.sf.net/p/intel-sas/isci
 S:	Supported

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Asaf Vertz | 21 Jan 13:44 2015

[PATCH] scsi: 3w-9xxx: fix format string warnings

Fixed the following warnings (reported by cppcheck):
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 2)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 3)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 4)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 5)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 6)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 7)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 8)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 9)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 10)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 11)
requires 'int' but the argument type is 'unsigned int'.

Signed-off-by: Asaf Vertz <asaf.vertz <at> tandemg.com>
---
 drivers/scsi/3w-9xxx.c |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
index 7600639..123eba5 100644
--- a/drivers/scsi/3w-9xxx.c
(Continue reading)


Gmane