headers
bugzilla | 1 Jun 2009 03:32
Picon
Favicon

[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474787

--- Comment #12 from Denis Arnaud <denis.arnaud_fedora <at> m4x.org>  2009-05-31 21:32:15 EDT ---
[My machine crashed just before I pressed the commit button of the review :( ]

Note that, as I have not the sponsor status, that is not an official review.
However, there are a number of issues (some important, some others less) that I
can point to you (in no particular order).

1. Doxygen, as it is configured, generates .map files (in the doc/html
sub-directory), due to the use of the DOT tool (belonging to the graphviz
package). On some configurations (e.g., my Fedora rawhide/11, with rpmbuild),
some of those files are generated with a zero-length, which rpmlint then
complains of.

There are, at least, two solutions/work-arounds:
  1.a. Just drop the use of DOT in the Doxygen configuration file:
  HAVE_DOT = NO
  as in
http://rmol.svn.sourceforge.net/viewvc/rmol/trunk/rmol/doc/doxygen_html.cfg.in?revision=183&view=markup
  As Doxygen replaces with other, simpler, diagrams, that should not be a so
big issue.
  1.b. Keep the use of DOT, but:
    - Add a 'BuildRequires: graphivz' directive.
    - Remove any zero-length-map files after the Doxygen generation
(http://cvs.fedoraproject.org/viewvc/rpms/asterisk/F-11/asterisk.spec?revision=1.51&view=markup):
      find doc/html -name '*.map' -size 0 -delete
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 03:37
Picon
Favicon

[Bug 474787] Review Requrest: stxxl - C++ STL drop-in replacement for extremely large datasets

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474787

--- Comment #13 from Denis Arnaud <denis.arnaud_fedora <at> m4x.org>  2009-05-31 21:37:09 EDT ---
If it may help, the above comments (plus a few small others) have been
integrated into a new version of the specification file:
Spec URL: http://denisarnaud.fedorapeople.org/stxxl/121/6/stxxl.spec
(as well as the corresponding Source RPM:
http://denisarnaud.fedorapeople.org/stxxl/121/6/stxxl-1.2.1-6.fc10.src.rpm)

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 06:48
Picon
Favicon

[Bug 478930] Review Request: globus-rls-client - Globus Toolkit - Replica Location Service Client

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478930

--- Comment #4 from Mattias Ellert <mattias.ellert <at> fysast.uu.se>  2009-06-01 00:48:16 EDT ---
(In reply to comment #3)
> ! The file CHANGELOG can go to a %doc

The CHANGELOG file's last entry is for version 2.1.3, the current version is
5.1. Since the CHANGELOG file is not maintained it doesn't make much sense to
include it.

> * The source extraction guide is incomplete. The original source tree contains
> a ./java directory, which is missing from your tarball. Is there a reason?

Yes, the java directory is not part of the globus-rls-client source package,
but a separate source package of its own. The build GPT build instructions in
the pkgdata directory does not contain information about how to build the java
package. The java directory contains its own pkgdata directory with build
instructions for the java package. I have added a line to the source extraction
guide that removes the java directory before packaging the source tarball.

> ? There is some html documentation under the ./Doc directory. Currently there
> is a doxygen documentation in the doc package which seemed to me rather
> useless. Shall we replace it with the html documentation from the ./Doc
> directory?

The bug is in the LAC_DOXYGEN call in configure.in - it points to the main
directory instead of the library subdirectory. Fixed.
(Continue reading)

Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 06:53
Picon
Favicon

[Bug 502978] Review Request: python-line_profiler - A Python line-by-line profiler

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=502978

--- Comment #3 from Parag AN(पराग) <panemade <at> gmail.com>  2009-06-01 00:53:46 EDT ---
I think you can even follow suggestion given on that guidelines page
1. Rename scripts in %{_bindir} to not have a .py extension: For instance, from
/usr/bin/orient.py to /usr/bin/orient.
This will clean rpmlint output.

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 06:59
Picon
Favicon

[Bug 503298] Review Request: vim-bash-support - BASH-IDE for VIM

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=503298

--- Comment #1 from Ricky Zhou <rzhou <at> redhat.com>  2009-06-01 00:59:40 EDT ---
Some other package submissions from cga:
vim-c-support (bug 503300)
vim-nerdtree (bug 503301)

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 07:09
Picon
Favicon

[Bug 503189] Review Request: python-gnutls - Python wrapper for the GNUTLS library

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=503189

--- Comment #2 from Parag AN(पराग) <panemade <at> gmail.com>  2009-06-01 01:09:39 EDT ---
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463

missing "BuildRequires: python-setuptools-devel" as per given at
https://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 07:09
Picon
Favicon

[Bug 503189] Review Request: python-gnutls - Python wrapper for the GNUTLS library

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=503189

Parag AN(पराग) <panemade <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade <at> gmail.com
         AssignedTo|nobody <at> fedoraproject.org    |panemade <at> gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade <at> gmail.com>  2009-06-01 01:09:07 EDT ---
build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=1386463

missing "BuildRequires: python-setuptools-devel" as per given at

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 07:14
Picon
Favicon

[Bug 503300] Review Request: vim-c-support - C/C++ IDE for VIM

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=503300

Ricky Zhou <rzhou <at> redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rzhou <at> redhat.com

--- Comment #2 from Ricky Zhou <rzhou <at> redhat.com>  2009-06-01 01:14:42 EDT ---
I don't think the iconv in %prep is necessary in this one, since
README.csupport looks fine in the zip file.

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 07:16
Picon
Favicon

[Bug 469460] review request: gir-repository - GObject Introspection Repository

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=469460

--- Comment #7 from Rakesh Pandit <rpandit <at> redhat.com>  2009-06-01 01:16:18 EDT ---
May you import it as soon as possible, I am looking to package whole
gnome-shell and stack packages and dependencies and this is blocker .. please
update to latest stable release ?

Thanks,

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Permalink | Reply | 0 comments |
headers
bugzilla | 1 Jun 2009 07:27
Picon
Favicon

[Bug 503175] Review Request: perl-Crypt-GPG - Perl Object Oriented Interface to GnuPG

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=503175

Parag AN(पराग) <panemade <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade <at> gmail.com
         AssignedTo|nobody <at> fedoraproject.org    |panemade <at> gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade <at> gmail.com>  2009-06-01 01:27:23 EDT ---
please enable tests. use
%check
make test

Can you resubmit spec that will follow
https://fedoraproject.org/wiki/Packaging/Perl?

Also, you can use 
"cpanspec Crypt-GPG" to create spec file. see
https://fedoraproject.org/wiki/Perl/cpanspec

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane