bugzilla | 1 Feb 2009 01:46
Picon
Favicon

[Bug 225999] Merge Review: libdrm

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225999

Orcan 'oget' Ogetbil <oget.fedora <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody <at> fedoraproject.org    |oget.fedora <at> gmail.com
               Flag|                            |fedora-review?

--- Comment #9 from Orcan 'oget' Ogetbil <oget.fedora <at> gmail.com>  2009-01-31 19:46:12 EDT ---
OK, here's the review, with questions (?), issues (*) and comments (!).

? From what you told, I understand that you are the upstream maintainer too. So
why are the patches? This confuses me. Can't they be integrated into the
source? Also why use autoreconf?

? Why are those header files are getting removed? And if they are irrelevant,
why are being installed by the Makefile? An explanation please, preferably in
the SPEC file as a comment.

* Generally, all the patches need to be explained as comments in the SPEC file
(and they need to be sent upstream but we skip this part). It's best to keep
the SPEC file at a state where a new package maintainer can take it over easily
without spending hours to figure out what's going on.

* Now, the rpmlint complaints:
(Continue reading)

bugzilla | 1 Feb 2009 01:59
Picon
Favicon

[Bug 478759] Review Request: perl-SystemPerl - SystemPerl Perl module

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478759

--- Comment #6 from Chitlesh GOORAH <cgoorah <at> yahoo.com.au>  2009-01-31 19:59:16 EDT ---
(In reply to comment #5)
> Chitlesh notified me of this thread.
> 
> The src/ prefix is because many users have multiple versions of SystemPerl
> installed (generally in a repository) and just point to the one they want.
> 
> Lane has a the right solution for the present version, as makefiles etc
> also have the src/ path hardcoded.  If there's a strong objection to the
> extra src/ in the path, I can add a new envvariable that will set the location.

Hello Wilson,

>From my point of view, in order to ease the installation of multiple version of
SystemPerl, those *.cpp should rather be placed into
-- /usr/include/perl-SystemPerl - for the distribution supported package
-- /usr/include/perl-SystemPerl-$version - for parallel installations

I would welcome an envvariable.

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
(Continue reading)

bugzilla | 1 Feb 2009 02:11
Picon
Favicon

[Bug 481040] Review Request: skyeye - integrated simulation environment for typical Embedded Computer Systems

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481040

--- Comment #4 from Chitlesh GOORAH <cgoorah <at> yahoo.com.au>  2009-01-31 20:11:43 EDT ---
(In reply to comment #2)
> * Source code quality:
> Building on FC10 exposes an "exciting amount" of "not-so-harmless" warnings.
> Some of them definitely are worth going after and be fixed.

Hello Ralf,

can you help to improve those warnings please?

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 02:13
Picon
Favicon

[Bug 476449] Review Request: perl-SystemC-Vregs - Utility routines used by vregs

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=476449

--- Comment #4 from Chitlesh GOORAH <cgoorah <at> yahoo.com.au>  2009-01-31 20:13:08 EDT ---
Ping Brennan

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 02:18
Picon
Favicon

[Bug 474980] Review Request: ovm - Open Verification Methodology : IEEE 1800 SystemVerilog standard

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474980

Chitlesh GOORAH <cgoorah <at> yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |INSUFFICIENT_DATA
               Flag|fedora-cvs?                 |

--- Comment #24 from Chitlesh GOORAH <cgoorah <at> yahoo.com.au>  2009-01-31 20:18:58 EDT ---
I'm closing this bug:
Reason : No simulator currently available under fedora

If the situation changes, I will still be interested to push OVM into fedora
repositories.

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 02:20
Picon
Favicon

[Bug 482880] Review Request: perl-Sane - Access SANE-compatible scanners with perl

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=482880

Bernard Johnson <bjohnson <at> symetrix.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Bernard Johnson <bjohnson <at> symetrix.com>  2009-01-31 20:20:08 EDT ---
Thanks Parag AN(पराग)!

New Package CVS Request
=======================
Package Name: perl-Sane
Short Description: Perl extension for the SANE (Scanner Access Now Easy)
Project
Owners: bjohnson
Branches: F-10
InitialCC: fedora-perl-devel-list <at> redhat.com

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 02:53
Picon
Favicon

[Bug 459892] Review Request: rubygem-mocha - Mocking and stubbing library

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459892

--- Comment #13 from Jeroen van Meeuwen <kanarip <at> kanarip.com>  2009-01-31 20:53:55 EDT ---
Marked these files as %doc

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-mocha.spec
New SRPM:
http://www.kanarip.com/custom/f10/SRPMS/rubygem-mocha-0.9.1-4.fc10.src.rpm

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 03:22
Picon
Favicon

[Bug 468597] Review Request: rubygem-ferret - Full-featured text search engine library

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468597

Jeroen van Meeuwen <kanarip <at> kanarip.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sahartsu <at> xs4all.n
                   |                            |l)

--- Comment #32 from Jeroen van Meeuwen <kanarip <at> kanarip.com>  2009-01-31 21:22:48 EDT ---
Stefan, ping?

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzilla | 1 Feb 2009 03:25
Picon
Favicon

[Bug 474412] Review Request: giver - A simple file sharing desktop application

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474412

manuel wolfshant <wolfy <at> nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|wolfy <at> nobugconsulting.ro    |
         AssignedTo|nobody <at> fedoraproject.org    |wolfy <at> nobugconsulting.ro
               Flag|                            |fedora-review+

--- Comment #6 from manuel wolfshant <wolfy <at> nobugconsulting.ro>  2009-01-31 21:25:02 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one
(Continue reading)

bugzilla | 1 Feb 2009 03:43
Picon
Favicon

[Bug 474012] Review Request: qodem - terminal emulator and communications package.

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=474012

--- Comment #5 from manuel wolfshant <wolfy <at> nobugconsulting.ro>  2009-01-31 21:43:54 EDT ---
Jeff, is there an updated package available for review ? At
http://marlene.zimage.com/packages/ I can only see the first src.rpm

Please do not forget to increment the release tag and add a proper entry in the
changelog each time you make modifications to the spec.

Are you already sponsored? I have not found you in FAS.

--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

Gmane