1 Feb 2009 01:46
[Bug 225999] Merge Review: libdrm
<bugzilla <at> redhat.com>
2009-02-01 00:46:13 GMT
2009-02-01 00:46:13 GMT
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225999 Orcan 'oget' Ogetbil <oget.fedora <at> gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody <at> fedoraproject.org |oget.fedora <at> gmail.com Flag| |fedora-review? --- Comment #9 from Orcan 'oget' Ogetbil <oget.fedora <at> gmail.com> 2009-01-31 19:46:12 EDT --- OK, here's the review, with questions (?), issues (*) and comments (!). ? From what you told, I understand that you are the upstream maintainer too. So why are the patches? This confuses me. Can't they be integrated into the source? Also why use autoreconf? ? Why are those header files are getting removed? And if they are irrelevant, why are being installed by the Makefile? An explanation please, preferably in the SPEC file as a comment. * Generally, all the patches need to be explained as comments in the SPEC file (and they need to be sent upstream but we skip this part). It's best to keep the SPEC file at a state where a new package maintainer can take it over easily without spending hours to figure out what's going on. * Now, the rpmlint complaints:(Continue reading)
RSS Feed