bugzilla | 31 Jul 07:14 2014
Picon

[Bug 1124070] Review Request: pcaro-hermit-fonts - Monospace fonts for programming

https://bugzilla.redhat.com/show_bug.cgi?id=1124070

--- Comment #3 from Parag AN(पराग) <panemade <at> gmail.com> ---
Suggestions:
1) spec file name should not contain any version or release. I suppose its a
typo in the initial comment for Spec URL.

2) If you are not planning to add this package to EPEL6 then remove following
from spec

   a) Group tag is now optional and can be removed.

   b) "rm -rf %{buildroot}" is not needed anymore as its done automatically by
rpmbuild 

   c) similarly %clean section is also not needed anymore

3) %prep should contain only
%setup -q

4) Though there is no compilation or building of binary files happening, you
can include empty %build to let rpmlint happy

5) Don't add extra empty spaces in the spec file like one you have line 59

6) I think you can if wanted keep the priority of fontconfig file to 69.
Generally 60-69 numbers are used for "generic aliases, map generic->family" and
you have the same fontconfig rule.

--

-- 
(Continue reading)

pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchcommits set to Approved

user: maxamillion set for maxamillion acl: watchcommits of package: mozilla-fira-fonts from:  to:
Approved on branch: master

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts commit set to Awaiting Review

user: maxamillion set for maxamillion acl: commit of package: mozilla-fira-fonts from:  to: Awaiting
Review on branch: f20

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchbugzilla set to Approved

user: maxamillion set for maxamillion acl: watchbugzilla of package: mozilla-fira-fonts from:  to:
Approved on branch: master

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchcommits set to Approved

user: maxamillion set for maxamillion acl: watchcommits of package: mozilla-fira-fonts from:  to:
Approved on branch: f20

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchbugzilla set to Approved

user: maxamillion set for maxamillion acl: watchbugzilla of package: mozilla-fira-fonts from:  to:
Approved on branch: f20

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts commit set to Awaiting Review

user: maxamillion set for maxamillion acl: commit of package: mozilla-fira-fonts from:  to: Awaiting
Review on branch: master

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts commit set to Awaiting Review

user: maxamillion set for maxamillion acl: commit of package: mozilla-fira-fonts from:  to: Awaiting
Review on branch: f19

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts commit set to Awaiting Review

user: maxamillion set for maxamillion acl: commit of package: mozilla-fira-fonts from:  to: Awaiting
Review on branch: f21

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchcommits set to Approved

user: maxamillion set for maxamillion acl: watchcommits of package: mozilla-fira-fonts from:  to:
Approved on branch: f19

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/
pkgdb | 31 Jul 02:23 2014

[PkgDB] maxamillion:mozilla-fira-fonts watchbugzilla set to Approved

user: maxamillion set for maxamillion acl: watchbugzilla of package: mozilla-fira-fonts from:  to:
Approved on branch: f21

To make changes to this package see:
https://admin.fedoraproject.org/pkgdb/package/mozilla-fira-fonts
_______________________________________________
fonts-bugs mailing list
fonts-bugs <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/fonts-bugs
http://fonts.fedoraproject.org/

Gmane