Rich Megginson | 25 May 20:41
Picon
Favicon

Please review: fix coverity issues with uninit vals, no return checking


From a2dec53772cc1f5f72e701dddf16430229851485 Mon Sep 17 00:00:00 2001
From: Rich Megginson <rmeggins <at> redhat.com>
Date: Fri, 25 May 2012 12:39:09 -0600
Subject: [PATCH] fix coverity issues with uninit vals, no return checking

12766 Uninitialized pointer read
In _entryrdn_replace_suffix_id(): Reads an uninitialized pointer or its target
12765 Uninitialized pointer read
In txn_test_threadmain(): Reads an uninitialized pointer or its target
12764 Unchecked return value
In txn_test_threadmain(): Value returned from a function is not checked for errors before being used
12763 Unchecked return value
In entrycache_replace(): Value returned from a function is not checked for errors before being used
12762 Unchecked return value
In entrycache_add_int(): Value returned from a function is not checked for errors before being used
---
 ldap/servers/slapd/back-ldbm/cache.c         |    8 ++++++--
 ldap/servers/slapd/back-ldbm/dblayer.c       |    9 ++++-----
 ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c |    1 +
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/ldap/servers/slapd/back-ldbm/cache.c b/ldap/servers/slapd/back-ldbm/cache.c
index 045b1eb..de84700 100644
--- a/ldap/servers/slapd/back-ldbm/cache.c
+++ b/ldap/servers/slapd/back-ldbm/cache.c
@@ -1058,7 +1058,9 @@ static int entrycache_replace(struct cache *cache, struct backentry *olde,
     }
(Continue reading)

Rich Megginson | 24 May 21:58
Picon
Favicon

Please review: Ticket #383 - usn + mmr = deletions are not replicated

https://fedorahosted.org/389/ticket/383

https://fedorahosted.org/389/attachment/ticket/383/0003-Ticket-383-usn-mmr-deletions-are-not-replicated.patch
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Rich Megginson | 23 May 03:27
Picon
Favicon

Please review: Ticket #382 - DS Shuts down intermittently


https://fedorahosted.org/389/ticket/382

https://fedorahosted.org/389/attachment/ticket/382/0001-Ticket-382-DS-Shuts-down-intermittently.patch
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Mark Reynolds | 21 May 23:36
Picon
Favicon

please review ticket #110 - RFE - limiting Directory Manager (nsslapd-rootdn) bind access by source host

https://fedorahosted.org/389/ticket/110

https://fedorahosted.org/389/attachment/ticket/110/0001-Ticket-110-RFE-limiting-root-DN-by-host-IP-time-of-d.patch

Thanks,
Mark
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Rich Megginson | 21 May 19:10
Picon
Favicon

Please review: Ticket #360 - ldapmodify returns Operations error

https://fedorahosted.org/389/ticket/360

https://fedorahosted.org/389/attachment/ticket/360/0001-Ticket-360-ldapmodify-returns-Operations-error.patch
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Rich Megginson | 21 May 17:11
Picon
Favicon

Please review: Ticket #321 - krbExtraData is being null modified and replicated on each ssh login


https://fedorahosted.org/389/ticket/321

https://fedorahosted.org/389/attachment/ticket/321/0001-Ticket-321-krbExtraData-is-being-null-modified-and-r.2.patch
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Rich Megginson | 18 May 23:18
Picon
Favicon

Please review: Trac Ticket #359 - Database RUV could mismatch the one in changelog under the stress

I found a small mem leak
https://fedorahosted.org/389/ticket/359

https://fedorahosted.org/389/attachment/ticket/359/0001-Trac-Ticket-359-Database-RUV-could-mismatch-the-one-.patch
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Mark Reynolds | 17 May 22:34
Picon
Favicon

please review ticket #321 - krbExtraData is being null modified and replicated on each ssh login

https://fedorahosted.org/389/ticket/321

https://fedorahosted.org/389/attachment/ticket/321/0001-Ticket-321-krbExtraData-is-being-null-modified-and-r.patch

Thanks,
Mark
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Mark Reynolds | 16 May 23:57
Picon
Favicon

please review Ticket #365 - password in clear text in audit log

https://fedorahosted.org/389/ticket/365

https://fedorahosted.org/389/attachment/ticket/365/0001-Ticket-365-passwords-in-clear-text-in-the-audit-log.patch

Thanks,
Mark
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Mark Reynolds | 16 May 16:37
Picon
Favicon

please review ticket 368 - Make the CLEANALLRUV task one step

https://fedorahosted.org/389/ticket/368

https://fedorahosted.org/389/attachment/ticket/368/0001-Ticket-368-Make-the-cleanAllRUV-task-one-step.patch

Thanks,
Mark
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel
Mark Reynolds | 11 May 19:07
Picon
Favicon

please review ticket 367 - Invalid chaining config triggers a disk full error and shutdown

https://fedorahosted.org/389/ticket/367

https://fedorahosted.org/389/attachment/ticket/367/0001-Ticket-367-Invalid-chaining-config-triggers-a-disk-f.patch

Note:  I also did some code cleanup with indentation, but the the fix is 
just to return -1, instead of LDAP_LOCAL_ERROR(-2).

Thanks,
Mark
--
389-devel mailing list
389-devel <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Gmane