[PATCH] virt-viewer: remove built files in build dir

Hi,
attached patch removes the files in the build dir instead of trying to
do so in the installed system (fix is similar to what I submitted for
gtk-vnc).
Cheers,
 -- Guido

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Réf. : Re: using virtinstall--devel and bus type option.

-----Cole Robinson <crobinso@...> a écrit : -----

>Pour : Fedora/Linux Management Tools <et-mgmt-tools@...>
>De : Cole Robinson <crobinso@...>
>Date : 31/10/2008 14:36
>cc : fcombernous@...
>Objet : Re: [et-mgmt-tools] using virtinstall--devel and bus type
>option.
>
>FCOMBERNOUS@... wrote:
>> Lo,
>>
>> As indicated i get the source with mercurial :
>> hg clone http://hg.et.redhat.com/virt/applications/virtinst--devel
>
>When did you clone the repo? Just yesterday I committed a
>few more patches from Guido that fixed up some of the code

My clone and your commit are near. Perhaps i cloned before your commit.

>to do with the 'bus' option, so you may be running in to
>issues that have been fixed. Try:
>
>cd virtinst--devel
>hg pull
>hg update
>python setup.py install
>
>Then see if the bus option isn't working. If not, report
>back here.

Re: [PATCH] virt-viewer: remove built files in build dir

On Sun, Nov 02, 2008 at 06:43:38PM +0100, Guido G?nther wrote:
> Hi,
> attached patch removes the files in the build dir instead of trying to
> do so in the installed system (fix is similar to what I submitted for
> gtk-vnc).

Thanks, I've applied this change

> Cheers,
>  -- Guido

> diff --git a/plugin/Makefile.am b/plugin/Makefile.am
> index ff1536e..2ccffe6 100644
> --- a/plugin/Makefile.am
> +++ b/plugin/Makefile.am
> @@ -26,7 +26,7 @@ virt-viewer-plugin.so: virt-viewer-plugin.la
>  
>  # Only leave the .so file in the plugins directory.
>  install-data-hook:
> -	rm -f $(plugindir)/virt-viewer-plugin.a $(plugindir)/virt-viewer-plugin.la
> +	rm -f $(DESTDIR)$(plugindir)/virt-viewer-plugin.a $(plugindir)/virt-viewer-plugin.la

The 2nd filename needed $(DESTDIR) here too.

Daniel
--

-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Error setting up graphics device:list index out of range

[Sorry for multiposting, I send this to the wrong mailing list the first
time...]

When I try to create a new KVM VM x86_64, os variant Ubuntu Hardy, it 
fails at the end with this message:

Error setting up graphics device:list index out of range

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/create.py", line 640, in 
finish
    guest._graphics_dev = virtinst.VirtualGraphics
(type=virtinst.VirtualGraphics.TYPE_VNC)
  File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 207,
in 
__init__
    self.set_keymap(keymap)
  File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 219,
in 
set_keymap
    val = util.default_keymap()
  File "/usr/lib/python2.5/site-packages/virtinst/util.py", line 293, in 
default_keymap
    kt = s.split('"')[1]
IndexError: list index out of range

What could be wrong here? I'm using virt-manager 0.6.0, libvirt 0.4.6, 
python-virtinst 0.400.0 on Mandriva Linux 2009.0 x86_64.

--

-- 

Re: Réf. : Re: [et-mgmt-tools] using virtinstall--devel and bus type option.

FCOMBERNOUS@... wrote:
>> to do with the 'bus' option, so you may be running in to
>> issues that have been fixed. Try:
>>
>> cd virtinst--devel
>> hg pull
>> hg update
>> python setup.py install
>>
>> Then see if the bus option isn't working. If not, report
>> back here.
>>     
>
> Here the report :)
> - The man pages use the new syntax about the -disk option.
> - The virt-install --help is broken. Have a look to details below [1].
> - The -disk option looks to do the job.
>
> In fact, i wanted to use -disk option as described in [2]. With this one,
> it's possible to set the devide type to scsi and not only to ide. But with
> the last update, the virt-install don't know the scsi value :
> ERROR    Error with storage parameters: Unknown device type 'scsi'
>
>   

Hmm, this sounds like you made an error on the command line.
You should use

--disk ...,bus=scsi,...  rather than
--disk ...,device=scsi...

Re: Error setting up graphics device:list index out of range

Frederik Himpe wrote:
> [Sorry for multiposting, I send this to the wrong mailing list the first
> time...]
>
> When I try to create a new KVM VM x86_64, os variant Ubuntu Hardy, it 
> fails at the end with this message:
>
> Error setting up graphics device:list index out of range
>
> Traceback (most recent call last):
>   File "/usr/share/virt-manager/virtManager/create.py", line 640, in 
> finish
>     guest._graphics_dev = virtinst.VirtualGraphics
> (type=virtinst.VirtualGraphics.TYPE_VNC)
>   File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 207,
> in 
> __init__
>     self.set_keymap(keymap)
>   File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 219,
> in 
> set_keymap
>     val = util.default_keymap()
>   File "/usr/lib/python2.5/site-packages/virtinst/util.py", line 293, in 
> default_keymap
>     kt = s.split('"')[1]
> IndexError: list index out of range
>
> What could be wrong here? I'm using virt-manager 0.6.0, libvirt 0.4.6, 
> python-virtinst 0.400.0 on Mandriva Linux 2009.0 x86_64.
>

Re: Réf. : Re: [et-mgmt-tools] using virtinstall--devel and bus type option.

On Mon, Nov 03, 2008 at 10:56:00AM +0100, FCOMBERNOUS@... wrote:
> In fact, i wanted to use -disk option as described in [2]. With this one,
> it's possible to set the devide type to scsi and not only to ide. But with
> the last update, the virt-install don't know the scsi value :
> ERROR    Error with storage parameters: Unknown device type 'scsi'
What command are you using, I'm using e.g.:

 --disk path=/tmp/bla2,device=disk,size=1,bus=virtio

Cheers,
 -- Guido

Re: [PATCH] virt-viewer: remove built files in build dir

On Mon, Nov 03, 2008 at 11:05:14AM +0000, Daniel P. Berrange wrote:
> On Sun, Nov 02, 2008 at 06:43:38PM +0100, Guido G?nther wrote:
> > Hi,
> > attached patch removes the files in the build dir instead of trying to
> > do so in the installed system (fix is similar to what I submitted for
> > gtk-vnc).
> 
> Thanks, I've applied this change
> 
> > Cheers,
> >  -- Guido
> 
> > diff --git a/plugin/Makefile.am b/plugin/Makefile.am
> > index ff1536e..2ccffe6 100644
> > --- a/plugin/Makefile.am
> > +++ b/plugin/Makefile.am
> > @@ -26,7 +26,7 @@ virt-viewer-plugin.so: virt-viewer-plugin.la
> >  
> >  # Only leave the .so file in the plugins directory.
> >  install-data-hook:
> > -	rm -f $(plugindir)/virt-viewer-plugin.a $(plugindir)/virt-viewer-plugin.la
> > +	rm -f $(DESTDIR)$(plugindir)/virt-viewer-plugin.a $(plugindir)/virt-viewer-plugin.la
> 
> The 2nd filename needed $(DESTDIR) here too.
Yes, my bad. The gtk-vnc one was correct, the virt-viewer one lacked it,
sorry.
 -- Guido

Re: Error setting up graphics device:list index out of range

On ma, 2008-11-03 at 11:41 -0500, Cole Robinson wrote:
> Frederik Himpe wrote:
> > [Sorry for multiposting, I send this to the wrong mailing list the first
> > time...]
> >
> > When I try to create a new KVM VM x86_64, os variant Ubuntu Hardy, it 
> > fails at the end with this message:
> >
> > Error setting up graphics device:list index out of range

> Hi, thanks for the report. Definitely a bug on our side.
> We try to determine the host machines keyboard mapping
> so we can set a default guest keymap, but out parsing
> code isn't careful enough.
> 
> Can you post the contents of /etc/sysconfig/keyboard so
> we can try to fix it properly?

Aha, great, thank you for the help.

$ cat /etc/sysconfig/keyboard 
KEYBOARD=be
KEYTABLE=be2-latin1

--

-- 
Frederik Himpe <fhimpe@...>

Re: Error setting up graphics device:list index out of range

Frederik Himpe wrote:
> On ma, 2008-11-03 at 11:41 -0500, Cole Robinson wrote:
>   
>> Frederik Himpe wrote:
>>     
>>> [Sorry for multiposting, I send this to the wrong mailing list the first
>>> time...]
>>>
>>> When I try to create a new KVM VM x86_64, os variant Ubuntu Hardy, it 
>>> fails at the end with this message:
>>>
>>> Error setting up graphics device:list index out of range
>>>       
>
>   
>> Hi, thanks for the report. Definitely a bug on our side.
>> We try to determine the host machines keyboard mapping
>> so we can set a default guest keymap, but out parsing
>> code isn't careful enough.
>>
>> Can you post the contents of /etc/sysconfig/keyboard so
>> we can try to fix it properly?
>>     
>
> Aha, great, thank you for the help.
>
> $ cat /etc/sysconfig/keyboard 
> KEYBOARD=be
> KEYTABLE=be2-latin1
>