headers
Daniel P. Berrange | 1 Oct 11:46
Picon
Favicon

Re: [PATCH]: virt-manager: start network before vm creation

On Mon, Sep 29, 2008 at 11:43:03AM -0400, Cole Robinson wrote:
> Guido Günther wrote:
> > Hi,
> > currently we don't check if a network is already running, when trying to
> > create a new machine in virt-manager. Attached patch starts the network
> > if it's not running instead of throwing an exception at the user,
> > adresses a Debian bug [1].
> > Cheers,
> >  -- Guido
> > 
> > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499867
> > 
> 
> Hmm, I'm not sure if I like this idea. Assumably the network is
> 'off' for a reason, so if the user doesn't know any better, I'd
> rather not just turn it on without their potentially knowing.
> 
> I think the problem here is that it isn't made clear in the
> drop down whether a virtual network is running or not. If we
> listed all the nets, but prevented the inactive ones from
> being selected (kind of like unbridged nics are presented)
> hopefully the user would get the point that they need to
> explicitly enable the network to use it. We could even allow
> selecting the inactive network and then prompt to start
> it.

Yep, as you say, there're two problems here. When creating the
VM we need to make it clear which networks are active, and which
are not - but still allow selection of an inactive network.
(Continue reading)

Permalink | Reply | 5 comments |
headers
S.Sakamoto | 1 Oct 11:48

Re: [RFC]Re: [libvirt] [RFC][PATCH] virt-managercalls migration API

Hi, Daniel

Sorry for delaying response.

Thank you for your suggestions. I understand. 
I will make the prototype patch!

Thanks
Shigeki Sakamoto.

> On Fri, Sep 19, 2008 at 06:43:37PM +0900, S.Sakamoto wrote:
> > > 
> > > > You probably want to send this to et-mgmt-list, which is where virt-manager
> > > > development happens,
> > > 
> > > OK. For this, I tried to hear in et-mgmt-list.
> > > 
> > 
> > I'm sorry to be pressing, but would you give me a comment on this patch for
> > going on the next step to migrate from virt-manager ? 
> > I attached screenshots this patch shows.
> 
> I think rather than having it popup a new window with a list of hosts to
> migrate to, you could just have a sub-menu where you choose the destination
> host directly.
> 
> eg,
> 
>     right-click
>       |
(Continue reading)

Permalink | Reply | 11 comments |
headers
Daniel P. Berrange | 1 Oct 11:50
Picon
Favicon

Re: [PATCH] virt-manager: show serial consoles as tabs in 'details' window

On Tue, Sep 30, 2008 at 12:04:13PM -0400, Cole Robinson wrote:
> The attached patch combines the serial console window
> with the VM details window. Opening the serial console
> now appends a tab to the details view. In addition,
> multiple serial consoles are now supported, not just
> the primary/first defined console, though this still
> only works for 'pty' devices.
> 
> The patch does three things: 
> 
> 1) Remove all the previous plumbing needed to keep track
>    of the separate console window
> 2) Fix the vmmSerialConsole class to extend gtk.HBox, so
>    we can reuse most of the code in a notebook tab.
> 3) Add all the plumbing in details.py to deal with adding
>    and removing tabs on the fly.
> 
> Screenshot of a couple tab examples:
> 
> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab1.png
> 
> Screenshot of selecting which serial console to open
> (unsupported console types will have entries, they will
>  just be disabled as shown):
> 
> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab2.png
> 
> Screenshot of terminal right click menu. Tabs can be
> closed via this menu, or the 'View' menu shown in the
> second screenshot.
(Continue reading)

Permalink | Reply | 3 comments |
headers
Daniel P. Berrange | 1 Oct 11:54
Picon
Favicon

Re: [patch] virt-convert add disk signature into virt-image format export

On Tue, Sep 30, 2008 at 05:39:13PM -0400, Joey Boggs wrote:
> Here's a sample that works, just want to verify it's alright. Is 64MB 
> too much/too little to read at one time?
> 
> 
> f = open("test.raw","r")
> m = sha.new()
> while 1:
>    chunk = f.read(65536)
>    if not chunk:
>        break
>    m.update(chunk)
> print m.hexdigest()

Both md5 and sha1 are becoming obsolete, and indeed forbidden by some
of the more paranoid organizations. I'd recommend we go straight
to using at least sha256. Also the docs recommend using  hashlib module
directly, eg

    import hashlib

    m = hashlib.sha256()
    while 1:
      chunk = f.read(65536)
      if not chunk:
        break
      m.update(chunk)
    print m.hexdigest()

Daniel
(Continue reading)

Permalink | Reply | 11 comments |
headers
Cole Robinson | 1 Oct 15:43
Picon
Favicon

Re: [patch] virt-convert add disk signature into virt-image format export

Daniel P. Berrange wrote:
> On Tue, Sep 30, 2008 at 05:39:13PM -0400, Joey Boggs wrote:
>> Here's a sample that works, just want to verify it's alright. Is 64MB 
>> too much/too little to read at one time?
>>
>>
>> f = open("test.raw","r")
>> m = sha.new()
>> while 1:
>>    chunk = f.read(65536)
>>    if not chunk:
>>        break
>>    m.update(chunk)
>> print m.hexdigest()
> 
> Both md5 and sha1 are becoming obsolete, and indeed forbidden by some
> of the more paranoid organizations. I'd recommend we go straight
> to using at least sha256. Also the docs recommend using  hashlib module
> directly, eg
> 
>     import hashlib
> 
>     m = hashlib.sha256()
>     while 1:
>       chunk = f.read(65536)
>       if not chunk:
>         break
>       m.update(chunk)
>     print m.hexdigest()
>
(Continue reading)

Permalink | Reply | 10 comments |
headers
Cole Robinson | 1 Oct 16:02
Picon
Favicon

Re: [PATCH] virt-manager: show serial consoles as tabs in 'details' window

Daniel P. Berrange wrote:
> On Tue, Sep 30, 2008 at 12:04:13PM -0400, Cole Robinson wrote:
>> The attached patch combines the serial console window
>> with the VM details window. Opening the serial console
>> now appends a tab to the details view. In addition,
>> multiple serial consoles are now supported, not just
>> the primary/first defined console, though this still
>> only works for 'pty' devices.
>>
>> The patch does three things: 
>>
>> 1) Remove all the previous plumbing needed to keep track
>>    of the separate console window
>> 2) Fix the vmmSerialConsole class to extend gtk.HBox, so
>>    we can reuse most of the code in a notebook tab.
>> 3) Add all the plumbing in details.py to deal with adding
>>    and removing tabs on the fly.
>>
>> Screenshot of a couple tab examples:
>>
>> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab1.png
>>
>> Screenshot of selecting which serial console to open
>> (unsupported console types will have entries, they will
>>  just be disabled as shown):
>>
>> http://fedorapeople.org/~crobinso/virt-manager/vmm-serial-tab2.png
>>
>> Screenshot of terminal right click menu. Tabs can be
>> closed via this menu, or the 'View' menu shown in the
(Continue reading)

Permalink | Reply | 2 comments |
headers
Daniel P. Berrange | 1 Oct 16:06
Picon
Favicon

Re: [PATCH] virt-manager: show serial consoles as tabs in 'details' window

On Wed, Oct 01, 2008 at 10:02:36AM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> Remote and non-pty serial devices show up as an insensitive
> entry in the View->Serial Consoles list (see screenshot 2).
> I prefer the current method, rather than opening a tab
> indiscriminately. Some serial types will never make sense to
> open directly ('null', 'dev' if I understand it correctly).

Ah, yes i missed that first time around. That'll do for now unless
people complain in BZ.

Daniel
--

-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Permalink | Reply | 1 comment |
headers
Joey Boggs | 1 Oct 16:37
Picon
Favicon

Re: [patch] virt-convert add disk signature into virt-image format export

I'm done creating a sha256 hash setup should I offer more than just 
sha256for now? and checksum generation is off by default

Here's a preview.  Not sure how to catch the module import failure for 
hashlib though

Cole Robinson wrote:
> Daniel P. Berrange wrote:
>   
>> On Tue, Sep 30, 2008 at 05:39:13PM -0400, Joey Boggs wrote:
>>     
>>> Here's a sample that works, just want to verify it's alright. Is 64MB 
>>> too much/too little to read at one time?
>>>
>>>
>>> f = open("test.raw","r")
>>> m = sha.new()
>>> while 1:
>>>    chunk = f.read(65536)
>>>    if not chunk:
>>>        break
>>>    m.update(chunk)
>>> print m.hexdigest()
>>>       
>> Both md5 and sha1 are becoming obsolete, and indeed forbidden by some
>> of the more paranoid organizations. I'd recommend we go straight
>> to using at least sha256. Also the docs recommend using  hashlib module
>> directly, eg
>>
>>     import hashlib
(Continue reading)

Permalink | Reply | 8 comments |
headers
Daniel P. Berrange | 1 Oct 16:42
Picon
Favicon

Re: [patch] virt-convert add disk signature into virt-image format export

On Wed, Oct 01, 2008 at 09:43:54AM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Tue, Sep 30, 2008 at 05:39:13PM -0400, Joey Boggs wrote:
> >> Here's a sample that works, just want to verify it's alright. Is 64MB 
> >> too much/too little to read at one time?
> >>
> >>
> >> f = open("test.raw","r")
> >> m = sha.new()
> >> while 1:
> >>    chunk = f.read(65536)
> >>    if not chunk:
> >>        break
> >>    m.update(chunk)
> >> print m.hexdigest()
> > 
> > Both md5 and sha1 are becoming obsolete, and indeed forbidden by some
> > of the more paranoid organizations. I'd recommend we go straight
> > to using at least sha256. Also the docs recommend using  hashlib module
> > directly, eg
> > 
> >     import hashlib
> > 
> >     m = hashlib.sha256()
> >     while 1:
> >       chunk = f.read(65536)
> >       if not chunk:
> >         break
> >       m.update(chunk)
> >     print m.hexdigest()
(Continue reading)

Permalink | Reply | 0 comments |
headers
Daniel P. Berrange | 1 Oct 16:43
Picon
Favicon

Re: [patch] virt-convert add disk signature into virt-image format export

On Wed, Oct 01, 2008 at 10:37:17AM -0400, Joey Boggs wrote:
> I'm done creating a sha256 hash setup should I offer more than just 
> sha256for now? and checksum generation is off by default
> 
> Here's a preview.  Not sure how to catch the module import failure for 
> hashlib though

If we go for doing a compulsory md5 checksum, and optional
sha256 checksum with new enough python, then something
like....

    try:
       import hashlib
       m1 = hashlib.md5()
       m2 = hashlib.sha256()
    except:
       import md5
       m1 = md5.new()
       m2 = None

 
Daniel
--

-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Permalink | Reply | 7 comments |

Gmane