Masayuki Sunou | 1 Jun 03:08

[PATCH] Fix memory check in interactive mode

Hi

When memory is interactively input to virt-install, memory is not checked.

------------------------------------------------------------
# virt-install --name TEST --hvm
How much RAM should be allocated (in megabytes)? 1
 What would you like to use as the disk (path)?
------------------------------------------------------------

This patch fixes it.

Signed-off-by: Masayuki Sunou <fj1826dm@...>

Thanks,
Masayuki Sunou.

-------------------------------------------------------------------------------
diff -r 7fd35e3303c6 virt-install
--- a/virt-install	Fri May 25 10:49:47 2007 -0400
+++ b/virt-install	Thu May 31 10:49:20 2007 +0900
@@ -87,14 +87,14 @@ def get_name(name, guest):

 def get_memory(memory, guest):
     while 1:
-        memory = prompt_for_input("How much RAM should be allocated (in megabytes)?", memory)
-        if memory < MIN_RAM:
-            print "ERROR: Installs currently require %d megs of RAM." %(MIN_RAM,)
-            print ""
-            memory = None
(Continue reading)

Nobuhiro Itou | 1 Jun 04:05

Re: [PATCH] [RESEND] Fix continue to install Windows

Hi,

Would you give me a comment on this patch?
If not, please apply it.

> I can't continue to install Windows HVM domain after first restart.
> After the restarting, /dev/cdrom (or ISO path) has not been attached to the domain.
> The attached patch solves this problem.
> 
> Signed-off-by: Nobuhiro Itou <fj0873gn@...>

Thanks,
Nobuhiro Itou.

diff -r 797e92fd5e0d virtinst/FullVirtGuest.py
--- a/virtinst/FullVirtGuest.py Thu May 31 14:20:33 2007 -0400
+++ b/virtinst/FullVirtGuest.py Fri Jun 01 10:57:49 2007 +0900
@@ -227,8 +227,10 @@ class FullVirtGuest(Guest.XenGuest):
         ret = ""
         count = 0
         for d in self.disks:
+            backup_path = None
             if d.transient and not install:
                 if d.device == Guest.VirtualDisk.DEVICE_CDROM:
+                    backup_path = d.path
                     d.path = None
                 else:
                     continue
@@ -242,5 +244,7 @@ class FullVirtGuest(Guest.XenGuest):
                    count += 1
(Continue reading)

Gerd Hoffmann | 1 Jun 10:57
Picon
Favicon

Re: [PATCH] Add VNC-Port setting when virt-managercreates VM

   Hi,

>   b. The admin of the Dom0 only opens  specific ports for short periods of time. In this
>      case the admin will have to lookup what port corresponds to a VM, so it doesn't matter
>      whether we're using  fixed or dynamic ports, the admin still has same amount of work
>      to lookup a port.

Sorry for jumping in here, but the "lookup port" thingy rings a bell ;)

A IMHO useful feature would be mdns announcements via avahi for vnc 
screens and text consoles (assuming they are not bound to 127.0.0.1, so 
they are actually reachable from other machines).

I've hacked up a mdns announce utility.  Works using xenstore watches. 
Has the drawback of announcing everything (because xenstore doesn't tell 
you whenever it is bound to localhost or not) and is obviously limited 
to xen.  libvirt should be able to do that in a better way.  Or maybe 
qemu should do that directly?

cheers,
   Gerd
Hugh Brock | 1 Jun 15:16
Picon
Favicon
Gravatar

Re: [PATCH] [RESEND] Fix continue to install Windows

Nobuhiro Itou wrote:
> Hi,
> 
> Would you give me a comment on this patch?
> If not, please apply it.
> 
>> I can't continue to install Windows HVM domain after first restart.
>> After the restarting, /dev/cdrom (or ISO path) has not been attached to the domain.
>> The attached patch solves this problem.
>>
>> Signed-off-by: Nobuhiro Itou <fj0873gn@...>
> 
> 
> Thanks,
> Nobuhiro Itou.
> 
Oops, sorry, I did apply it but forgot to post. Thanks!

--Hugh

--

-- 
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock@...    | virtualization library http://libvirt.org
Hennessey Daniel | 1 Jun 16:28
Picon

RE: koan --virt error

Michael,

Thanks for your prompt reply, you were spot on. I set the selinux policy
to "permissive" in "system-config-security" and now all proceeds as
expected. No reboot required.

I can now install xen guests using koan.

One problem I have now is that the install fails if I include the
"xconfig" in the kickstart file as the xen instance doesn't have a
graphical display.

Does koan call virt-install to do the actual install? If it does then it
is just a matter of including the "--vnc" switch in the command line.

What do you suggest?

TIA and FYI I am really excited about the potential of using cobbler to
provision our real and virtual servers. I am also trying to work in
puppet for centralised configuration. This could be the answer to all my
(and my employers) prayers.

Exciting times indeed thanks to you and all the other OSS workers out
there

Cheers

Dan
-----Original Message-----
From: et-mgmt-tools-bounces@...
(Continue reading)

Michael DeHaan | 1 Jun 16:48
Picon
Favicon

Re: koan --virt error

Hennessey Daniel wrote:
> Michael,
>
> Thanks for your prompt reply, you were spot on. I set the selinux policy
> to "permissive" in "system-config-security" and now all proceeds as
> expected. No reboot required.
>
> I can now install xen guests using koan.
>   
Sure, this will be fixed and released shortly so you'll be able to leave 
SELinux on. I'll send an email to the list once that's done.
I obviously don't want to imply everyone should run with SELinux off 
just to get koan to work :)
> One problem I have now is that the install fails if I include the
> "xconfig" in the kickstart file as the xen instance doesn't have a
> graphical display.
>
> Does koan call virt-install to do the actual install? If it does then it
> is just a matter of including the "--vnc" switch in the command line.
>   
It's using virtinst, which is the library behind the virt-install app.

> What do you suggest?
>
>   
I'll see about adding a graphics option to koan.
As I was primarily targetting servers/datacenters, this was left out 
originally, but it's easy to add and ought to be there.
> TIA and FYI I am really excited about the potential of using cobbler to
> provision our real and virtual servers. I am also trying to work in
(Continue reading)

Hennessey Daniel | 1 Jun 17:03
Picon

RE: koan --virt error

Michael,

Maybe I should just tell you the symptoms and let you tell me what the
problem is.

>From virt-manager I can access the the two guests that I installed
through virt-install with a nice terminal that works perfectly. These
are both in run level 3 (no X). The ones that I created using koan I
have to use the serial console option from virt-manager which is painful
to use.

The line that I have to comment out in the kickstart file for koan is:

"xconfig --driver "fbdev" --resolution 800x600 --depth 24"

So I assume that for the non-koan installed guests, we are using the
frame buffer console (which is v nice). 

I know that I am not being unix hardcore by eschewing the serial option
and it is only a cosmetic thing but if it could be sorted I would be a
very happy hacker.

Cheers

Dan

-----Original Message-----
From: et-mgmt-tools-bounces@...
[mailto:et-mgmt-tools-bounces@...] On Behalf Of Michael DeHaan
Sent: 01 June 2007 3:48 PM
(Continue reading)

Michael DeHaan | 1 Jun 17:10
Picon
Favicon

Re: koan --virt error

Hennessey Daniel wrote:
> Michael,
>
> Maybe I should just tell you the symptoms and let you tell me what the
> problem is.
>
> >From virt-manager I can access the the two guests that I installed
> through virt-install with a nice terminal that works perfectly. These
> are both in run level 3 (no X). The ones that I created using koan I
> have to use the serial console option from virt-manager which is painful
> to use.
>
> The line that I have to comment out in the kickstart file for koan is:
>
> "xconfig --driver "fbdev" --resolution 800x600 --depth 24"
>
> So I assume that for the non-koan installed guests, we are using the
> frame buffer console (which is v nice). 
>
> I know that I am not being unix hardcore by eschewing the serial option
> and it is only a cosmetic thing but if it could be sorted I would be a
> very happy hacker.
>
> Cheers
>
> Dan

Basically virt-install allows creation of "graphics" settings for the 
virt guests, though koan
isn't creating any at the moment, assuming you'll only be using xm 
(Continue reading)

Hennessey Daniel | 1 Jun 17:31
Picon

RE: koan --virt error

Michael,

If I can be of any assistance with testing or anything, I would be happy
to help.

Cheers

Dan

-----Original Message-----
From: et-mgmt-tools-bounces@...
[mailto:et-mgmt-tools-bounces@...] On Behalf Of Michael DeHaan
Sent: 01 June 2007 4:10 PM
To: Fedora/Linux Management Tools
Subject: Re: [et-mgmt-tools] koan --virt error

Hennessey Daniel wrote:
> Michael,
>
> Maybe I should just tell you the symptoms and let you tell me what the

> problem is.
>
> >From virt-manager I can access the the two guests that I installed
> through virt-install with a nice terminal that works perfectly. These 
> are both in run level 3 (no X). The ones that I created using koan I 
> have to use the serial console option from virt-manager which is 
> painful to use.
>
> The line that I have to comment out in the kickstart file for koan is:
(Continue reading)

Michael DeHaan | 1 Jun 17:37
Picon
Favicon

Re: koan --virt error

Hennessey Daniel wrote:
> Michael,
>
> If I can be of any assistance with testing or anything, I would be happy
> to help.
>
> Cheers
>
> Dan
>   

Much appreciated. I'll let you know when the code for the above is 
available.

Gmane