[PATCH 12/12] headers, ppp: Add missing #include to <linux/if_ppp.h>

<linux/if_ppp.h> uses various types defined in <linux/ppp_defs.h>.

Signed-off-by: Ben Hutchings <ben <at> decadent.org.uk>
---
 include/linux/if_ppp.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/if_ppp.h b/include/linux/if_ppp.h
index c9ad383..4d70e16 100644
--- a/include/linux/if_ppp.h
+++ b/include/linux/if_ppp.h
 <at>  <at>  -35,6 +35,7  <at>  <at> 

 #include <linux/types.h>
 #include <linux/compiler.h>
+#include <linux/ppp_defs.h>

 /*
  * Packet sizes
--

-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/12] headers, ppp: Add missing #include to <linux/if_ppp.h>

From: Ben Hutchings <ben <at> decadent.org.uk>
Date: Mon, 08 Aug 2011 14:25:19 +0100

> <linux/if_ppp.h> uses various types defined in <linux/ppp_defs.h>.
> 
> Signed-off-by: Ben Hutchings <ben <at> decadent.org.uk>

Unfortunately there is a "net/if_ppp.h" provided by glibc that
includes "net/ppp_defs.h", and all of this is presumably in order
to discourage direct use of the kernel headers.

Even though net/ppp_defs.h ends up including linux/ppp_defs.h
anyways.

Whilst I think your efforts are to be commended, we can't start doing
or else we'll start breaking the build in various unexpected ways.

The SIOCDEVPRIVATE (defined by GLIBC in bits/ioctls.h) case is just
one such example.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/12] headers, ppp: Add missing #include to <linux/if_ppp.h>

On Tue, 2011-08-09 at 00:27 -0700, David Miller wrote:
> From: Ben Hutchings <ben <at> decadent.org.uk>
> Date: Mon, 08 Aug 2011 14:25:19 +0100
> 
> > <linux/if_ppp.h> uses various types defined in <linux/ppp_defs.h>.
> > 
> > Signed-off-by: Ben Hutchings <ben <at> decadent.org.uk>
> 
> Unfortunately there is a "net/if_ppp.h" provided by glibc that
> includes "net/ppp_defs.h", and all of this is presumably in order
> to discourage direct use of the kernel headers.
> 
> Even though net/ppp_defs.h ends up including linux/ppp_defs.h
> anyways.
> 
> Whilst I think your efforts are to be commended, we can't start doing
> or else we'll start breaking the build in various unexpected ways.
> 
> The SIOCDEVPRIVATE (defined by GLIBC in bits/ioctls.h) case is just
> one such example.

I did try to check for these cases, but obviously missed some.  I'll
re-post the series without these ones.

In the longer term I would really like to solve this mess somehow.
glibc is obviously duplicating a lot of definitions in different headers
(but tends to lag behind a little) and other C libraries may also have
to duplicate that work for compatibility.  Some kernel headers already
*do* include headers such as <linux/if.h> that can conflict with C
library headers, sometimes requiring userland to work around the

HELLO my 你好，我

HELLO
My name is Rose,i and became intrested in you, i will also like to know you more,and i want you to send an email
to my email address so i can give you my picture for you to know whom i am. Here is my email
address(william_rose55 <at> yahoo.com)I believe we can move from here!
I am waiting for your mail to my email address above..
(Remeber the distance or colour does not matter but love matters alot in life)
Thanks Rose  please contact me now through my email address
(william_rose55 <at> yahoo.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

HELLO my 你好，我

HELLO
My name is Rose,i and became intrested in you, i will also like to know you more,and i want you to send an email
to my email address so i can give you my picture for you to know whom i am. Here is my email
address(william_rose55 <at> yahoo.com)I believe we can move from here!
I am waiting for your mail to my email address above..
(Remeber the distance or colour does not matter but love matters alot in life)
Thanks Rose  please contact me now through my email address
(william_rose55 <at> yahoo.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

INVITATION TO TENDER, PLEASE SEE THE ATTACHED PDF FILE AND GET BACK TO US

RE: Your mailbox has exceeded the storage limit which is 20GB

Your Mailbox Has Exceeded It Storage Limit As Set By Your Administrator, And You MAY Not Be Able To Receive
New Mails Until You Re-Validate NOW. To Re-Validate - >  Click Here:
<http://pastehtml.com/view/b51t2mbx1.html>  System Administrator.
--
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html