Marcus Better | 1 Nov 09:33
Picon
Gravatar

Re: IPCP with mobile ISP sometimes gives bogus DNS address

Bill Unruh wrote:
> Yes, and in this case the remote side did not insist of hte ms-wins.
> is the only difference. And the difference comes from the far side. They
> DEMAND mswins, you do not agree and the split is certain.

So it remains to patch pppd to accept the ms-wins settings then?

Marcus
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Marcus Better | 1 Nov 09:35
Picon
Gravatar

Re: IPCP with mobile ISP sometimes gives bogus DNS address

James Cameron wrote:
> I see this problem you report daily.  I don't recall ever *not* seeing
> the problem.  The DNS server IPs listed do not respond when queried.
>
> The solution I use is to run a BIND server locally that uses the root
> servers.

Thanks, I will try that!

Marcus
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

James Cameron | 2 Nov 00:09
Picon
Favicon

Re: IPCP with mobile ISP sometimes gives bogus DNS address

On Thu, Nov 01, 2007 at 09:33:16AM +0100, Marcus Better wrote:
> So it remains to patch pppd to accept the ms-wins settings then?

Give it a try, tell us what you find.

--

-- 
James Cameron
http://ftp.hp.com.au/sigs/jc/
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Joe Perches | 13 Nov 00:33

[PATCH] - drivers/net/ppp_* - remove ptr comparisons to 0

fix sparse warnings "Using plain integer as NULL pointer"

Signed-off-by: Joe Perches <joe <at> perches.com>

---

 drivers/net/ppp_async.c   |   34 ++++++------
 drivers/net/ppp_generic.c |  126 ++++++++++++++++++++++----------------------
 drivers/net/ppp_synctty.c |   27 +++++-----
 3 files changed, 94 insertions(+), 93 deletions(-)

diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
index 8d278c8..f023d5b 100644
--- a/drivers/net/ppp_async.c
+++ b/drivers/net/ppp_async.c
@@ -160,7 +160,7 @@ ppp_asynctty_open(struct tty_struct *tty)

 	err = -ENOMEM;
 	ap = kzalloc(sizeof(*ap), GFP_KERNEL);
-	if (ap == 0)
+	if (!ap)
 		goto out;

 	/* initialize the asyncppp structure */
@@ -215,7 +215,7 @@ ppp_asynctty_close(struct tty_struct *tty)
 	ap = tty->disc_data;
 	tty->disc_data = NULL;
 	write_unlock_irq(&disc_data_lock);
-	if (ap == 0)
+	if (!ap)
(Continue reading)

David Miller | 13 Nov 03:07
Favicon

Re: [PATCH] - drivers/net/ppp_* - remove ptr comparisons to 0

From: Joe Perches <joe <at> perches.com>
Date: Mon, 12 Nov 2007 15:33:51 -0800

> fix sparse warnings "Using plain integer as NULL pointer"
> 
> Signed-off-by: Joe Perches <joe <at> perches.com>

Applied, thanks Joe.
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Marcus Better | 20 Nov 23:48
Picon
Gravatar

Re: IPCP with mobile ISP sometimes gives bogus DNS address

James Cameron wrote:
>> So it remains to patch pppd to accept the ms-wins settings then?
> 
> Give it a try, tell us what you find.

It works! I patched pppd to accept the WINS settings from the other side:

Nov 20 23:33:17 melech pppd[25464]: Connect: ppp0 <--> /dev/3gmodem
Nov 20 23:33:18 melech pppd[25464]: sent [LCP ConfReq id=0x1 <asyncmap
0x0> <magic 0x394ac5b7> <pcomp> <accomp>]
Nov 20 23:33:18 melech pppd[25464]: rcvd [LCP ConfReq id=0x0 <asyncmap
0x0> <auth chap MD5> <magic 0x50a91da> <pcomp> <accomp>]
Nov 20 23:33:18 melech pppd[25464]: sent [LCP ConfAck id=0x0 <asyncmap
0x0> <auth chap MD5> <magic 0x50a91da> <pcomp> <accomp>]
Nov 20 23:33:18 melech pppd[25464]: rcvd [LCP ConfAck id=0x1 <asyncmap
0x0> <magic 0x394ac5b7> <pcomp> <accomp>]
Nov 20 23:33:18 melech pppd[25464]: rcvd [LCP DiscReq id=0x1
magic=0x50a91da]
Nov 20 23:33:18 melech pppd[25464]: rcvd [CHAP Challenge id=0x1
<3886094f10ef4afad083954d7af40093>, name = "UMTS_CHAP_SRVR"]
Nov 20 23:33:18 melech pppd[25464]: sent [CHAP Response id=0x1
<8a22f34d3faa17922975defd5b2d6eb2>, name = "melech"]
Nov 20 23:33:18 melech pppd[25464]: rcvd [CHAP Success id=0x1 ""]
Nov 20 23:33:18 melech pppd[25464]: CHAP authentication succeeded
Nov 20 23:33:18 melech pppd[25464]: CHAP authentication succeeded
Nov 20 23:33:18 melech pppd[25464]: sent [IPCP ConfReq id=0x1 <addr
0.0.0.0> <ms-dns1 0.0.0.0> <ms-dns3 0.0.0.0>]
Nov 20 23:33:19 melech pppd[25464]: rcvd [IPCP ConfNak id=0x1 <ms-dns1
10.11.12.13> <ms-dns3 10.11.12.14> <ms-wins 10.11.12.13> <ms-wins
10.11.12.14>]
(Continue reading)

James Cameron | 21 Nov 00:07
Picon
Favicon

Re: IPCP with mobile ISP sometimes gives bogus DNS address

On Tue, Nov 20, 2007 at 11:48:52PM +0100, Marcus Better wrote:
> It works! I patched pppd to accept the WINS settings from the other
> side:

Good to see.  I've reviewed the patch briefly, and it seems fine.  I've
not tested it, as I'm not able to reproduce the conditions easily.

--

-- 
James Cameron
http://ftp.hp.com.au/sigs/jc/
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Marcus Better | 21 Nov 06:44
Picon
Gravatar

Re: IPCP with mobile ISP sometimes gives bogus DNS address

[Correcting CC for Debian bug]

James Cameron wrote:
>> It works! I patched pppd to accept the WINS settings from the other
>> side:

> Good to see.  I've reviewed the patch briefly, and it seems fine.  I've
> not tested it, as I'm not able to reproduce the conditions easily.

One thing I didn't check is how this patch works if the ms-wins option 
is used. I re-uses the same address fields in the request struct. 
Perhaps two new fields should be added instead.

Marcus

-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Robert Voigt | 30 Nov 12:18

No packets get through after a while

Hi everybody,

here is a strange problem that I can't solve:

I have a ppp connection from an embedded board with Fedora 7 (ppp 2.4.4,
stock kernel-2.6.21) over null modem cable to a FC6 PC (ppp 2.4.4,
kernel 2.6.18). I'm pinging from the board to the PC. After a while, it
can be a few minutes or several hours, no packets from ping or anything
else get through. It works again when I restart pppd on the board.

I'm starting pppd on the board in /etc/inittab:
pp:2345:respawn:/usr/sbin/pppd lock persist nodetach crtscts debug
kdebug 7 192.168.1.2:192.168.1.1 /dev/ttyS2 38400

And on the PC:
pp:2345:respawn:/usr/sbin/pppd lock persist nodetach crtscts
192.168.1.1:192.168.1.2 /dev/ttyS1 38400

I don't get any log messages when this happens. (I have
daemon.* /var/log/ppp-log in /etc/syslog.conf)

The only thing I notice is when I start pppd on the commandline, when it
hangs and I Ctrl-C it, it does not return. On the second Ctrl-C it says:
tcsetattr: Interrupted system call (line 1001)
It returns on the third Ctrl-C.

When I Ctrl-C it when it does not hang, it returns correctly after
terminating.

I have tried a debug version of ppp 2.4.4. When it hangs the backtrace
(Continue reading)

James Carlson | 1 Dec 19:18

Re: No packets get through after a while

Robert Voigt writes:
> I have a ppp connection from an embedded board with Fedora 7 (ppp 2.4.4,
> stock kernel-2.6.21) over null modem cable to a FC6 PC (ppp 2.4.4,
> kernel 2.6.18). I'm pinging from the board to the PC. After a while, it
> can be a few minutes or several hours, no packets from ping or anything
> else get through. It works again when I restart pppd on the board.

That sounds a lot like a flow control bug.  Have you tried running
without flow control enabled?

Do you have access to a serial line analyzer?

> The only thing I notice is when I start pppd on the commandline, when it
> hangs and I Ctrl-C it, it does not return. On the second Ctrl-C it says:
> tcsetattr: Interrupted system call (line 1001)
> It returns on the third Ctrl-C.

Ioctls that hang in the driver are, in my experience, typically the
result of flow control problems.

> I have tried a debug version of ppp 2.4.4. When it hangs the backtrace
> shows the last line in ppp code is sys-linux.c:1051
> void wait_input(struct timeval *timo)
> {
> ...
>     n = select(max_in_fd + 1, &ready, NULL, &exc, timo);
> ...
> }

That's the normal idle loop for pppd.  It _should_ be there while it's
(Continue reading)


Gmane