headers
Milind Arun Choudhary | 4 Apr 2007 19:49
Picon
Gravatar

[KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c

ROUND_UP macro cleanup use DIV_ROUND_UP

Signed-off-by: Milind Arun Choudhary <milindchoudhary <at> gmail.com>

---
 ppp_generic.c |    4 +---
 1 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c
index ef58e41..4b302f3 100644
--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
 <at>  <at>  -88,8 +88,6  <at>  <at>  struct ppp_file {
 #define PF_TO_PPP(pf)		PF_TO_X(pf, struct ppp)
 #define PF_TO_CHANNEL(pf)	PF_TO_X(pf, struct channel)

-#define ROUNDUP(n, x)		(((n) + (x) - 1) / (x))
-
 /*
  * Data structure describing one ppp unit.
  * A ppp unit corresponds to a ppp network interface device
 <at>  <at>  -1297,7 +1295,7  <at>  <at>  static int ppp_mp_explode(struct ppp *ppp, struct sk_buff *skb)
 	 */
 	fragsize = len;
 	if (nfree > 1)
-		fragsize = ROUNDUP(fragsize, nfree);
+		fragsize = DIV_ROUND_UP(fragsize, nfree);
 	/* nbigger channels get fragsize bytes, the rest get fragsize-1,
 	   except if nbigger==0, then they all get fragsize. */
 	nbigger = len % nfree;
(Continue reading)

Permalink | Reply | 0 comments |
headers
Paul Mackerras | 9 Apr 2007 20:28
Picon
Favicon

Re: [KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c

Milind Arun Choudhary writes:

> ROUND_UP macro cleanup use DIV_ROUND_UP
> 
> Signed-off-by: Milind Arun Choudhary <milindchoudhary <at> gmail.com>

Acked-by: Paul Mackerras <paulus <at> samba.org>
Permalink | Reply | 0 comments |
headers
Michael St. Laurent | 13 Apr 2007 00:55
Favicon

Not seeing "peer authentication succeeded" messages in syslog

Hello,

A little bit back I turned on authenticating with winbind as well as the
logwtmp option and ever since then I'm not getting the peer
authentication succeeded messages in syslog.

Since the perl script I am using for reporting is using those lines I
would like to find out if there is a way to make them appear again.
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply | 0 comments |
headers
maimam | 17 Apr 2007 06:17
Picon
Favicon

ppp interface


Hi 

I am having a hard time getting PPTP to work in a lab environemnt. I have
two linux systems connected directly. I have installed one of them as server
and the other one as client from the directions given at sourceforge.

My problem:

since i dont have a modem i dont have a ppp interface. pptp tries to use
ppp0 as a tunnel interface. so when i try to start a pptp connection it
gives me something like this. 

[root <at> localhost ppp]# pppd pty 'pptp 1.1.1.101 --nolaunchpppd' call pptp1
debug dump logfd 2 nodetach 
pppd options in effect:
debug           # (from command line)
nodetach                # (from command line)
logfd 2         # (from command line)
dump            # (from command line)
noauth          # (from /etc/ppp/options.pptp)
refuse-chap             # (from /etc/ppp/options.pptp)
refuse-mschap           # (from /etc/ppp/options.pptp)
refuse-eap              # (from /etc/ppp/options.pptp)
name netscreen          # (from /etc/ppp/peers/pptp1)
remotename PPTP         # (from /etc/ppp/peers/pptp1)
                # (from /etc/ppp/options.pptp)
pty pptp 1.1.1.101 --nolaunchpppd               # (from
/etc/ppp/peers/pptp1)
mru 1490                # (from /etc/ppp/peers/pptp1)
(Continue reading)

Permalink | Reply | 1 comment |
headers
James Cameron | 17 Apr 2007 06:21
Picon
Favicon

Re: ppp interface

On Mon, Apr 16, 2007 at 09:17:17PM -0700, maimam wrote:
> I am having a hard time getting PPTP to work in a lab environemnt.

Works for me every time.  I last checked it yesterday with the release
of pptpd 1.3.4.

> since i dont have a modem i dont have a ppp interface. pptp tries to use
> ppp0 as a tunnel interface. 

This is entirely normal.  If you did have a modem interface, pppd would
use ppp1 as the tunnel interface.

> [root <at> localhost ppp]# pppd pty 'pptp 1.1.1.101 --nolaunchpppd' call pptp1
> Connect: ppp0 <--> /dev/pts/3
> Child process pptp 1.1.1.101 --nolaunchpppd (pid 26619) terminated with
> signal 15

This suggests that pptp has failed with a SIGTERM.  There is no sign
there of any pppd problem.

> Although i have pppd in the processes i dont have any ppp interface. pppd
> version 2.4.2. What should i do?

Contact the PPTP Client mailing list.
http://pptpclient.sourceforge.net/contact.phtml

Have you tried OpenVPN yet?

--

-- 
James Cameron                         http://quozl.netrek.org/
(Continue reading)

Permalink | Reply | 0 comments |
headers
amyng | 19 Apr 2007 00:02

IPCP Negotiation Failure - Peer refuse to accept IP Address


I'm running 2.4.4 pppd on Solaris (I know it's not Linux, but there's no
sun-ppp forum) trying to connect to a device (which I can get to by window
rasppp btw).

After receiving "Could not determine local IP address" IPCP confReq (see
following ppp log)...

$ pppd options in effect:
debug           # (from /etc/ppp/options)
kdebug 31               # (from /etc/ppp/options)
-detach         # (from /etc/ppp/options)
dump            # (from /etc/ppp/options)
noauth          # (from /etc/ppp/options)
/dev/ttya               # (from command line)
38400           # (from command line)
lock            # (from /etc/ppp/options)
connect /etc/ppp/ppp-on-dialer          # (from command line)
crtscts         # (from /etc/ppp/options)
local           # (from /etc/ppp/options)
ipcp-accept-local               # (from /etc/ppp/options)
ipcp-accept-remote              # (from /etc/ppp/options)
noipdefault             # (from /etc/ppp/options)
defaultroute            # (from /etc/ppp/options)
ipcp-no-addresses               # (from /etc/ppp/options)
noccp           # (from /etc/ppp/options)
Serial connection established.
Using interface ppp0
Connect: ppp0 <--> /dev/ttya
sent [LCP ConfReq id=0x1 <asyncmap 0x0> <magic 0x2f497226> <pcomp> <accomp>]
(Continue reading)

Permalink | Reply | 1 comment |
headers
James Carlson | 20 Apr 2007 02:04

Re: IPCP Negotiation Failure - Peer refuse to accept IP Address

amyng writes:
> I'm running 2.4.4 pppd on Solaris (I know it's not Linux, but there's no
> sun-ppp forum) trying to connect to a device (which I can get to by window
> rasppp btw).

Actually, there are more appropriate lists for this.  The main PPP
list (for pppd) is ppp-bugs <at> samba.org.  If you're using something
other than Solaris Nevada, then you should contact Solaris support --
but do make sure you've reproduced the problem using Solaris PPP
(/usr/bin/pppd), and not the open source version.

If you're using Solaris Nevada, you could try one of the OpenSolaris
groups, like networking-discuss <at> opensolaris.org.

> kdebug 31               # (from /etc/ppp/options)

Unless you're designing and debugging kernel modules, I don't think
you want this.

> /dev/ttya               # (from command line)

If you're dialing out, you should use /dev/cua/a.  /dev/ttya is
equivalent to /dev/term/a, which is a dial-in port.

> local           # (from /etc/ppp/options)

That doesn't look right.  It disables modem signaling -- DTR/DCD --
and is probably here because the wrong serial port (ttya rather than
cua/a) is being used.
(Continue reading)

Permalink | Reply | 0 comments |

Gmane