2 Jun 2005 17:56
9 Jun 2005 10:23
Kernel 2.4.x with CONFIG_PPP_FILTER (warning remove)
magicfox <magicfox <at> magic.fr>
2005-06-09 08:23:58 GMT
2005-06-09 08:23:58 GMT
Dears,
uprog.len is defined in struct as unsigned short and can't be > 65535.
May be this legitime warning may be removed.
ppp_generic.c: In function `ppp_ioctl':
ppp_generic.c:662: warning: comparison is always true due to limited
range of data type
- if (uprog.len > 0 && uprog.len < 65536) {
+ if (uprog.len > 0) {
Best regards.
-
To unsubscribe from this list: send the line "unsubscribe linux-ppp" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
16 Jun 2005 09:09
Help - Auto PPPoA and PPPoE detection in ADSL line
Ranjeet Kumar - R&D <Ranjeet.Kumar <at> aztech.com>
2005-06-16 07:09:04 GMT
2005-06-16 07:09:04 GMT
Hi, I am new in this group, if anything is wrong, please excuse me in advance. We have ADSL modem running Linux Version - 2.4 and pppd version 2.4.1. We want to detect the protocol, whether it is PPPoE or PPPoA, of the connected ADSL line. Can anybody help me in providing information on how to achieve this task? We are using pppoe and pppoa plugin with pppd to connect to DSLAM (ISP). Really, appreciate the any help! Regards, Ranjeet - To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
16 Jun 2005 10:40
Re: Help - Auto PPPoA and PPPoE detection in ADSL line
Arvin Schnell <arvin <at> suse.de>
2005-06-16 08:40:30 GMT
2005-06-16 08:40:30 GMT
On Thu, Jun 16, 2005 at 03:09:04PM +0800, Ranjeet Kumar - R&D wrote: > Hi, > > I am new in this group, if anything is wrong, please excuse me in advance. > > We have ADSL modem running Linux Version - 2.4 and pppd version 2.4.1. We > want to detect the protocol, whether it is PPPoE or PPPoA, of the connected > ADSL line. Can anybody help me in providing information on how to achieve > this task? We are using pppoe and pppoa plugin with pppd to connect to DSLAM > (ISP). Detecting of PPPoE is easy: Send a PADI and see if you receive a PADO. This can be done with 'pppoe -A' included in the rp-pppoe source or you can also write your one code. I do not have experiences with PPPoA. ciao Arvin - To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
16 Jun 2005 14:56
Re: Help - Auto PPPoA and PPPoE detection in ADSL line
Marco d'Itri <md <at> Linux.IT>
2005-06-16 12:56:47 GMT
2005-06-16 12:56:47 GMT
On Jun 16, Ranjeet Kumar - R&D <Ranjeet.Kumar <at> aztech.com> wrote: > We have ADSL modem running Linux Version - 2.4 and pppd version 2.4.1. We > want to detect the protocol, whether it is PPPoE or PPPoA, of the connected > ADSL line. Can anybody help me in providing information on how to achieve > this task? We are using pppoe and pppoa plugin with pppd to connect to DSLAM > (ISP). The PPP book by James Carlson explains how to do it. OTOH it's probably better to implement this in a standalone application than in pppd. -- -- ciao, Marco - To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
16 Jun 2005 14:57
Re: Help - Auto PPPoA and PPPoE detection in ADSL line
Marco d'Itri <md <at> Linux.IT>
2005-06-16 12:57:40 GMT
2005-06-16 12:57:40 GMT
On Jun 16, Arvin Schnell <arvin <at> suse.de> wrote: > Detecting of PPPoE is easy: Send a PADI and see if you receive a > PADO. This is not enough, you also need to account for the presence (or not) of LLC/SNAP encapsulation. -- -- ciao, Marco
16 Jun 2005 15:34
Re: Help - Auto PPPoA and PPPoE detection in ADSL line
James Carlson <carlsonj <at> workingcode.com>
2005-06-16 13:34:08 GMT
2005-06-16 13:34:08 GMT
Marco d'Itri writes: > On Jun 16, Ranjeet Kumar - R&D <Ranjeet.Kumar <at> aztech.com> wrote: > > > We have ADSL modem running Linux Version - 2.4 and pppd version 2.4.1. We > > want to detect the protocol, whether it is PPPoE or PPPoA, of the connected > > ADSL line. Can anybody help me in providing information on how to achieve > > this task? We are using pppoe and pppoa plugin with pppd to connect to DSLAM > > (ISP). > The PPP book by James Carlson explains how to do it. Actually, I just discuss regular sync detection methods. Methods on ATM _should_ be similar in concept, but aren't described there. > OTOH it's probably better to implement this in a standalone application > than in pppd. I agree with that. -- -- James Carlson <carlsonj <at> workingcode.com> - To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
19 Jun 2005 13:16
(unknown)
<taentczusytw <at> yahoo.com>
2005-06-19 11:16:54 GMT
2005-06-19 11:16:54 GMT
- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
20 Jun 2005 08:18
(unknown)
<wybmohj <at> yahoo.com>
2005-06-20 06:18:09 GMT
2005-06-20 06:18:09 GMT
- To unsubscribe from this list: send the line "unsubscribe linux-ppp" in the body of a message to majordomo <at> vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
20 Jun 2005 23:53
[patch 1/1] list_for_each_entry: drivers-net-ppp_generic.c
<domen <at> coderock.org>
2005-06-20 21:53:56 GMT
2005-06-20 21:53:56 GMT
From: Domen Puncer <domen <at> coderock.org>
Make code more readable with list_for_each_entry.
Compile tested.
Signed-off-by: Domen Puncer <domen <at> coderock.org>
Signed-off-by: Maximilian Attems <janitor <at> sternwelten.at>
Signed-off-by: Domen Puncer <domen <at> coderock.org>
---
ppp_generic.c | 21 ++++++---------------
1 files changed, 6 insertions(+), 15 deletions(-)
Index: quilt/drivers/net/ppp_generic.c
===================================================================
--- quilt.orig/drivers/net/ppp_generic.c
+++ quilt/drivers/net/ppp_generic.c
<at> <at> -1228,8 +1228,7 <at> <at> static int ppp_mp_explode(struct ppp *pp
nch = 0;
hdrlen = (ppp->flags & SC_MP_XSHORTSEQ)? MPHDRLEN_SSN: MPHDRLEN;
- list = &ppp->channels;
- while ((list = list->next) != &ppp->channels) {
+ list_for_each(list, &ppp->channels) {
pch = list_entry(list, struct channel, clist);
nch += pch->avail = (skb_queue_len(&pch->file.xq) == 0);
/*
<at> <at> -1688,7 +1687,7 <at> <at> static void
ppp_receive_mp_frame(struct ppp *ppp, struct sk_buff *skb, struct channel *pch)
{
u32 mask, seq;
(Continue reading)
RSS Feed