Guennadi Liakhovetski | 1 Jul 01:12 2012
Picon
Picon

[PATCH] ARM: mach-shmobile: add SDHI2 to the 2.8V fixed regulator consumers on kzm9g

The recently added SDHI2 interface to kzm9g needs power supplies for the
upcoming transition away from OCR masks, provided in platform data.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski <at> gmx.de>
---

Rafael, please, take this one too for 3.6. SDHI2 has just been added, so, 
we need a power regulator for it as well.

 arch/arm/mach-shmobile/board-kzm9g.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index e72ff8d..53b7ea9 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
 <at>  <at>  -373,11 +373,13  <at>  <at>  static struct platform_device mmc_device = {
 	.resource	= sh_mmcif_resources,
 };

-/* Fixed 2.8V regulators to be used by SDHI0 */
+/* Fixed 2.8V regulators to be used by SDHI0 and SDHI2 */
 static struct regulator_consumer_supply fixed2v8_power_consumers[] =
 {
 	REGULATOR_SUPPLY("vmmc", "sh_mobile_sdhi.0"),
 	REGULATOR_SUPPLY("vqmmc", "sh_mobile_sdhi.0"),
+	REGULATOR_SUPPLY("vmmc", "sh_mobile_sdhi.2"),
+	REGULATOR_SUPPLY("vqmmc", "sh_mobile_sdhi.2"),
 };

(Continue reading)

Guennadi Liakhovetski | 1 Jul 01:12 2012
Picon
Picon

[PATCH/RFC] ARM: mach-shmobile: enable power switching on SDHI0 and SDHI2 on kzm9g

On the kzm9g board power for SDHI0 and SDHI2 interfaces is controlled by
GPIOs. Use a switchable fixed regulator for them.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski <at> gmx.de>
---

This is NOT for immediate application. It doesn't have to go to 3.6. If we 
manage to confirm my guess and test this - we _could_ take it to 3.6. If 
not - it can absolutely wait for 3.7. This patch is a _guess_ - in the 
kzm9g init function GPIOs 15 and 14 are configured as output fixed high in 
SDHI0 and SDHI2 sections respectively with a comment "power." So, my guess 
was, that these GPIOs can also actually switch card power on those slots. 
Since I have no datasheet or schematics for that board or the board 
itself, I cannot confirm that my guess. Since Morimoto-san has worked 
pretty intensively with this board, maybe he could verify that, but again 
- nothing urgent.

 arch/arm/mach-shmobile/board-kzm9g.c |   69 +++++++++++++++++++++++++++++-----
 1 files changed, 59 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index 53b7ea9..2230706 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
 <at>  <at>  -373,13 +373,35  <at>  <at>  static struct platform_device mmc_device = {
 	.resource	= sh_mmcif_resources,
 };

-/* Fixed 2.8V regulators to be used by SDHI0 and SDHI2 */
-static struct regulator_consumer_supply fixed2v8_power_consumers[] =
(Continue reading)

Guennadi Liakhovetski | 1 Jul 01:39 2012
Picon
Picon

Re: [PATCH/RFC] ARM: mach-shmobile: enable power switching on SDHI0 and SDHI2 on kzm9g

On Sun, 1 Jul 2012, Guennadi Liakhovetski wrote:

> On the kzm9g board power for SDHI0 and SDHI2 interfaces is controlled by
> GPIOs. Use a switchable fixed regulator for them.

Hm, no, this is not the whole truth: this will leave both SDHI0 and SDHI2 
slots unpowered is the fixed regulator is unavailable. This shall only be 
applied after we "select CONFIG_REGULATOR_FIXED_VOLTAGE" so, don't think 
we want this for 3.6. Still would be nice to know, whether those GPIOs can 
be used for power switching at all.

Thanks
Guennadi

> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski <at> gmx.de>
> ---
> 
> This is NOT for immediate application. It doesn't have to go to 3.6. If we 
> manage to confirm my guess and test this - we _could_ take it to 3.6. If 
> not - it can absolutely wait for 3.7. This patch is a _guess_ - in the 
> kzm9g init function GPIOs 15 and 14 are configured as output fixed high in 
> SDHI0 and SDHI2 sections respectively with a comment "power." So, my guess 
> was, that these GPIOs can also actually switch card power on those slots. 
> Since I have no datasheet or schematics for that board or the board 
> itself, I cannot confirm that my guess. Since Morimoto-san has worked 
> pretty intensively with this board, maybe he could verify that, but again 
> - nothing urgent.
> 
>  arch/arm/mach-shmobile/board-kzm9g.c |   69 +++++++++++++++++++++++++++++-----
(Continue reading)

Kuninori Morimoto | 2 Jul 02:47 2012

Re: [PATCH][rework] ARM: shmobile: patch set rework


Hi Rafael

> I've already merged your entire seres doing some manula adjustments
> wherever the changes depended on the new PM domain code.  Please
> check the 'next' branch of the renesas.git tree and let me know if
> anything is missing or wrong.

Thank you for accepting my patches.
Yes. Its are correctly included in my quick check.

> > ------- for rafael/soc ----------------------------------
> > Kuninori Morimoto (1):
> >       [PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
> > 
> >  arch/arm/mach-shmobile/board-ap4evb.c      |   19 +--------------
> >  arch/arm/mach-shmobile/board-g4evm.c       |   18 ---------------
> >  arch/arm/mach-shmobile/board-mackerel.c    |   30 +------------------------
> >  arch/arm/mach-shmobile/include/mach/gpio.h |   32 ++++++++++++++++++++++++++++
> >  4 files changed, 36 insertions(+), 63 deletions(-)
> 
> No, that should be split into 4 patches, such that patch 1 will change
> arch/arm/mach-shmobile/include/mach/gpio.h only and the other patches will
> change the respective board files.  You've done the split already, haven't you?
(snip)
> [PATCH 1/16] ARM: shmobile: add common DMAEngine definitions
> [PATCH 2/16] ARM: shmobile: add common extra gpio functions
> [PATCH 3/16] ARM: shmobile: r8a7740: add DMAEngine support for FSI
> [PATCH 4/16] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> [PATCH 5/16] ARM: shmobile: r8a7740: add DMAEngine support for USB
(Continue reading)

Tetsuyuki Kobayashi | 2 Jul 08:34 2012
Picon

Re: [PATCH/RFC] ARM: mach-shmobile: enable power switching on SDHI0 and SDHI2 on kzm9g

Hello, Guennadi

This is Tetsuyuki Kobayashi.  I have a KZM-A9-GT board (kzm9g).
According to the board specification (written in Japanese),
GPIOs 15 and 14 are connected to VDD of connector through PowerSW, 
resptctively.

I tried this patch with CONFIG_REGULATOR_FIXED_VOLTAGE=y, But
both SD card and micro SD card are not recognized (as if they are
not inserted).
I guess something missing. Please tell me how to test this patch
so that I will try again.

(2012/07/01 8:12), Guennadi Liakhovetski wrote:
> On the kzm9g board power for SDHI0 and SDHI2 interfaces is controlled by
> GPIOs. Use a switchable fixed regulator for them.
>
> Signed-off-by: Guennadi Liakhovetski<g.liakhovetski <at> gmx.de>
> ---
>
> This is NOT for immediate application. It doesn't have to go to 3.6. If we
> manage to confirm my guess and test this - we _could_ take it to 3.6. If
> not - it can absolutely wait for 3.7. This patch is a _guess_ - in the
> kzm9g init function GPIOs 15 and 14 are configured as output fixed high in
> SDHI0 and SDHI2 sections respectively with a comment "power." So, my guess
> was, that these GPIOs can also actually switch card power on those slots.
> Since I have no datasheet or schematics for that board or the board
> itself, I cannot confirm that my guess. Since Morimoto-san has worked
> pretty intensively with this board, maybe he could verify that, but again
> - nothing urgent.
(Continue reading)

Guennadi Liakhovetski | 2 Jul 09:07 2012
Picon
Picon

Re: [PATCH/RFC] ARM: mach-shmobile: enable power switching on SDHI0 and SDHI2 on kzm9g

Hello 

On Mon, 2 Jul 2012, Tetsuyuki Kobayashi wrote:

> Hello, Guennadi
> 
> This is Tetsuyuki Kobayashi.  I have a KZM-A9-GT board (kzm9g).
> According to the board specification (written in Japanese),
> GPIOs 15 and 14 are connected to VDD of connector through PowerSW,
> resptctively.

Great, thanks for confirming!

> I tried this patch with CONFIG_REGULATOR_FIXED_VOLTAGE=y, But
> both SD card and micro SD card are not recognized (as if they are
> not inserted).
> I guess something missing. Please tell me how to test this patch
> so that I will try again.

Thanks for testing. Yes, these ARM patches are preparatory, they cannot 
work without respective counterparts in the mmc driver subsystem. At the 
very least you also need these patches:

http://www.spinics.net/lists/linux-sh/msg12007.html
http://www.spinics.net/lists/linux-sh/msg12160.html

but at least the latter of them might not apply cleanly to your tree. It 
might be easier to test if you pull in the mmc-next branch of

git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
(Continue reading)

Tetsuyuki Kobayashi | 2 Jul 12:19 2012
Picon

Re: [PATCH/RFC] ARM: mach-shmobile: enable power switching on SDHI0 and SDHI2 on kzm9g

Hello, Guennadi

(2012/07/02 16:07), Guennadi Liakhovetski wrote:

>> I guess something missing. Please tell me how to test this patch
>> so that I will try again.
>
> Thanks for testing. Yes, these ARM patches are preparatory, they cannot
> work without respective counterparts in the mmc driver subsystem. At the
> very least you also need these patches:
>
> http://www.spinics.net/lists/linux-sh/msg12007.html
> http://www.spinics.net/lists/linux-sh/msg12160.html
>
> but at least the latter of them might not apply cleanly to your tree. It
> might be easier to test if you pull in the mmc-next branch of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
>

Thanks.
Hmm, I'm afraid it takes long time for me to prepare proper tree.
I will try again when these dependencies merged, as you said
this patch is not urgent.

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Rafael J. Wysocki | 2 Jul 21:53 2012
Picon

Re: [PATCH][rework] ARM: shmobile: patch set rework

On Monday, July 02, 2012, Kuninori Morimoto wrote:
> 
> Hi Rafael
> 
> > I've already merged your entire seres doing some manula adjustments
> > wherever the changes depended on the new PM domain code.  Please
> > check the 'next' branch of the renesas.git tree and let me know if
> > anything is missing or wrong.
> 
> Thank you for accepting my patches.
> Yes. Its are correctly included in my quick check.
> 
> > > ------- for rafael/soc ----------------------------------
> > > Kuninori Morimoto (1):
> > >       [PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
> > > 
> > >  arch/arm/mach-shmobile/board-ap4evb.c      |   19 +--------------
> > >  arch/arm/mach-shmobile/board-g4evm.c       |   18 ---------------
> > >  arch/arm/mach-shmobile/board-mackerel.c    |   30 +------------------------
> > >  arch/arm/mach-shmobile/include/mach/gpio.h |   32 ++++++++++++++++++++++++++++
> > >  4 files changed, 36 insertions(+), 63 deletions(-)
> > 
> > No, that should be split into 4 patches, such that patch 1 will change
> > arch/arm/mach-shmobile/include/mach/gpio.h only and the other patches will
> > change the respective board files.  You've done the split already, haven't you?
> (snip)
> > [PATCH 1/16] ARM: shmobile: add common DMAEngine definitions
> > [PATCH 2/16] ARM: shmobile: add common extra gpio functions
> > [PATCH 3/16] ARM: shmobile: r8a7740: add DMAEngine support for FSI
> > [PATCH 4/16] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
(Continue reading)

Guennadi Liakhovetski | 2 Jul 22:28 2012
Picon
Picon

Re: [PATCH 1/9 v3] dmaengine: add an shdma-base library

Hi Vinod

On Thu, 28 Jun 2012, Guennadi Liakhovetski wrote:

> Hi Vinod
> 
> On Fri, 25 May 2012, Guennadi Liakhovetski wrote:
> 
> > Hi Vinod
> > 
> > On Fri, 25 May 2012, Vinod Koul wrote:
> 
> [snip]
> 
> > > Let me know if you plan to fixing them or I will queue these up for 3.6
> > 
> > Please, queue these patches for the next merge window, we will work on 
> > improving the driver after this split.
> 
> It's been a month since this mail - do I see it right, that these patches 
> are still not in your slave-dma tree? Having them there would (1) get them 
> some exposure and testing and (2) eventually speed up building on top of 
> them and fixing existing driver's shortcomings. Any approximate idea when 
> you'd be able to pull them in?

An update to this patch series: unfortunately, I forgot to include the 
very first patch in this series. I'll send it as a reply to this mail.

Thanks
Guennadi
(Continue reading)

Guennadi Liakhovetski | 2 Jul 22:30 2012
Picon
Picon

[PATCH 0.5/9] dma: move shdma driver to an own directory

The shdma driver is going to be split into multiple files. To make this more
convenient move it to an own directory.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski <at> gmx.de>
---

Sorry for the "0.5," please, just apply this patch before the whole shdma 
splitting series.

Thanks
Guennadi

 drivers/dma/Makefile         |    2 +-
 drivers/dma/sh/Makefile      |    1 +
 drivers/dma/{ => sh}/shdma.c |    2 +-
 drivers/dma/{ => sh}/shdma.h |    0
 4 files changed, 3 insertions(+), 2 deletions(-)
 create mode 100644 drivers/dma/sh/Makefile
 rename drivers/dma/{ => sh}/shdma.c (99%)
 rename drivers/dma/{ => sh}/shdma.h (100%)

diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index 86b795b..59c10e5 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
 <at>  <at>  -14,7 +14,7  <at>  <at>  obj-$(CONFIG_DW_DMAC) += dw_dmac.o
 obj-$(CONFIG_AT_HDMAC) += at_hdmac.o
 obj-$(CONFIG_MX3_IPU) += ipu/
 obj-$(CONFIG_TXX9_DMAC) += txx9dmac.o
-obj-$(CONFIG_SH_DMAE) += shdma.o
(Continue reading)


Gmane