headers
Dan Williams | 1 Dec 2009 01:39
Picon
Favicon

Re: [PATCH v2] ppc440spe-adma: adds updated ppc440spe adma driver

Anatolij Gustschin wrote:
> This patch adds new version of the PPC440SPe ADMA driver.
> 
> Signed-off-by: Anatolij Gustschin <agust <at> denx.de>
> Signed-off-by: Yuri Tikhonov <yur <at> emcraft.com>

[minor] Sign-offs are typically in delivery path order, so yours would 
appear last.

[..]
>  drivers/dma/ppc440spe/ppc440spe-adma.c             | 5015 ++++++++++++++++++++
>  drivers/dma/ppc440spe/ppc440spe_adma.h             |  195 +
>  drivers/dma/ppc440spe/ppc440spe_dma.h              |  223 +
>  drivers/dma/ppc440spe/ppc440spe_xor.h              |  110 +

I belong to the school of thought that says something along the lines of 
"don't duplicate the directory path in the filename".  You seem to have 
copied the iop-adma driver's inconsistent use of '-' and '_' let's not 
carry that forward, i.e. looking for a changelog like:

   drivers/dma/ppc440spe/adma.c             | 5015 ++++++++++++++++++++
   drivers/dma/ppc440spe/adma.h             |  195 +
   drivers/dma/ppc440spe/dma.h              |  223 +
   drivers/dma/ppc440spe/xor.h              |  110 +

> +/**
> + * ppc440spe_adma_prep_dma_pqzero_sum - prepare CDB group for
> + * a PQ_ZERO_SUM operation
> + */
> +static struct dma_async_tx_descriptor *ppc440spe_adma_prep_dma_pqzero_sum(
(Continue reading)

Permalink | Reply | 0 comments |
headers
Richard Holden | 1 Dec 2009 02:25
Picon

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

Albert Herranz wrote:
> Add support for using the USB Gecko adapter as an early debugging
> console on the Nintendo GameCube and Wii video game consoles.
> The USB Gecko is a 3rd party memory card interface adapter that provides
> a EXI (External Interface) to USB serial converter.
> 
> Signed-off-by: Albert Herranz <albert_herranz <at> yahoo.es>
> ---
>  arch/powerpc/Kconfig.debug                         |    8 +++
>  arch/powerpc/include/asm/udbg.h                    |    1 +
>  arch/powerpc/kernel/head_32.S                      |   21 +++++++
>  arch/powerpc/kernel/udbg.c                         |    2 +
>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c |   59 ++++++++++++++++++++
>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.h |    2 +
>  6 files changed, 93 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
> index 3b10051..11e385b 100644
> --- a/arch/powerpc/Kconfig.debug
> +++ b/arch/powerpc/Kconfig.debug
>  <at>  <at>  -254,6 +254,14  <at>  <at>  config PPC_EARLY_DEBUG_CPM
>  	  using a CPM-based serial port.  This assumes that the bootwrapper
>  	  has run, and set up the CPM in a particular way.
>  
> +config PPC_EARLY_DEBUG_USBGECKO
> +	bool "Early debugging through the USB Gecko adapter"
> +	depends on GAMECUBE_COMMON
> +	select USBGECKO_UDBG
> +	help
> +	  Select this to enable early debugging for Nintendo GameCube/Wii
(Continue reading)

Permalink | Reply | 0 comments |
headers
Rusty Russell | 1 Dec 2009 03:58
Picon
Gravatar

Re: [PATCH] ppc64: re-enable kexec to allow module loads with CONFIG_MODVERSIONS and CONFIG_RELOCATABLE turned on

On Tue, 1 Dec 2009 04:46:00 am Neil Horman wrote:
> Paul, Ben, given that Rusty hasn't come back with any opinion on this patch, do you
> feel comfortable merging it via the ppc tree?  Currently the earlyinit routine
> is only compiled in and used for your arch, so I think its fairly benign.

Sorry, I *did* track down the archives for linuxppc-dev, then find your post,
then read your patch.  But I didn't actually reply.

Other than minor issues, there's one significant one: you shouldn't be trying
to change rodata.  It might work on PPC today, but it's poor form at least.

How's this?  Untested on ppc.

Other changes:
1) I also changed reloc_start to an array; this is a good idea for any
   linker-defined symbols so the compiler can't make assumptions about size.
2) local.h?  How about module.h?
3) I don't think the extra ". = 0" is necessary.
4) ARCH_USES_RELOC_ENTRIES isn't clear enough for me; I prefer
   ARCH_RELOCATE_KCRCTAB.

module: handle ppc64 relocating kcrctabs when CONFIG_RELOCATABLE=y

http://lists.ozlabs.org/pipermail/linuxppc-dev/2009-November/077972.html

Inspired-by: Neil Horman <nhorman <at> tuxdriver.com>
Signed-off-by: Rusty Russell <rusty <at> rustcorp.com.au>

diff --git a/arch/powerpc/include/asm/module.h b/arch/powerpc/include/asm/module.h
--- a/arch/powerpc/include/asm/module.h
(Continue reading)

Permalink | Reply | 0 comments |
headers
Albert Herranz | 1 Dec 2009 06:23
Picon
Picon
Favicon

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

Richard Holden wrote:
> Albert Herranz wrote:
>> Add support for using the USB Gecko adapter as an early debugging
>> console on the Nintendo GameCube and Wii video game consoles.
>> The USB Gecko is a 3rd party memory card interface adapter that provides
>> a EXI (External Interface) to USB serial converter.
>>
>> Signed-off-by: Albert Herranz <albert_herranz <at> yahoo.es>
>> ---
>>  arch/powerpc/Kconfig.debug                         |    8 +++
>>  arch/powerpc/include/asm/udbg.h                    |    1 +
>>  arch/powerpc/kernel/head_32.S                      |   21 +++++++
>>  arch/powerpc/kernel/udbg.c                         |    2 +
>>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c |   59 ++++++++++++++++++++
>>  arch/powerpc/platforms/embedded6xx/usbgecko_udbg.h |    2 +
>>  6 files changed, 93 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>> index 3b10051..11e385b 100644
>> --- a/arch/powerpc/Kconfig.debug
>> +++ b/arch/powerpc/Kconfig.debug
>>  <at>  <at>  -254,6 +254,14  <at>  <at>  config PPC_EARLY_DEBUG_CPM
>>  	  using a CPM-based serial port.  This assumes that the bootwrapper
>>  	  has run, and set up the CPM in a particular way.
>>  
>> +config PPC_EARLY_DEBUG_USBGECKO
>> +	bool "Early debugging through the USB Gecko adapter"
>> +	depends on GAMECUBE_COMMON
>> +	select USBGECKO_UDBG
>> +	help
(Continue reading)

Permalink | Reply | 0 comments |
headers
Allan Wang | 1 Dec 2009 06:35
Picon
Favicon

ep440xs board boot problem

Hello, All,

I am new to the list. I am still newbie to embedded linux. I have bought an ep440xs board which is similar to
sequoia board. u-boot is working. I am trying to make it run linux.  I have the following problems and need
your help. Thank you very much:

I am using linux kernel 2.6.30.4. I encounter 2 problems:
1. After console_init() is called inside start_kernel(), the console starts printing garbage like:
Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
serial8250.0: ttyS0 at MMIO 0x1ef600300 (irq = 16) is a 16550A
������������������������������
����������������������������
���������������������������������
������������������������������
�����������������.
2. It pakics when mounting the root file system(NFS):
(gdb) bt
#0  panic (fmt=0xc0290e94 "VFS: Unable to mount root fs on %s")
at kernel/panic.c:70
#1  0xc02d8ce0 in mount_block_root (name=0xc0290de4 "/dev/root", flags=0x8001)
at init/do_mounts.c:272
#2  0xc02d9084 in prepare_namespace () at init/do_mounts.c:415
#3  0xc02d81ec in kernel_init (unused=<value optimized out>) at init/main.c:885
#4  0xc000de60 in kernel_thread ()
There is a patch for Sequoia board to delete /chosen part in sequoia.dts, is /chosen required?

Allan

      
_______________________________________________
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mahajan Vivek-B08308 | 1 Dec 2009 06:36
Favicon

RE: [PATCH v3 3/3] powerpc/fsl: 85xx: add cache-sram support

> From: Wood Scott-B07421 
> Sent: Friday, November 20, 2009 11:09 PM
> > Cache-sram does not have any device tree entry since it is not a 
> > hardware as such. Putting it under chosen can be another option.
> > I think, Scott (cc'ed) was of the opinion that since 32b 
> base address 
> > support is missing; so there is no point in moving this 
> address to the 
> > command line and .config should be okay for now for it.
> 
> I don't know what you mean by "32b base address support is 
> missing".  I have no objection to putting it on the command line.

It was a typo, it should be missing 36b address support. Since the
kernel 
did not run under different environment (i.e 32b / 36b base address); so
it 
was decided that .config may be okay for this.

> 
> -Scott
> 

Thanks,
Vivek
Permalink | Reply | 0 comments |
headers
Michael Ellerman | 1 Dec 2009 06:40
Picon
Gravatar

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

On Tue, 2009-12-01 at 06:23 +0100, Albert Herranz wrote:
> Richard Holden wrote:
> >> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >> index ba4c7cc..3f125b6 100644
> >> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c
> >>  <at>  <at>  -17,6 +17,7  <at>  <at> 
> >>  #include <asm/io.h>
> >>  #include <asm/prom.h>
> >>  #include <asm/udbg.h>
> >> +#include <asm/fixmap.h>
> >>  
> >>  #include "usbgecko_udbg.h"
> >>  
> >>  <at>  <at>  -270,3 +271,61  <at>  <at>  done:
> >>  		of_node_put(np);
> >>  	return;
> >>  }
> >> +
> >> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO
> >> +
> >> +static void __init ug_early_remap(void)
> > 
> > you may want to rename the ug_ prefix, it took me a while looking back
> > and forth through the patch to convince myself it wasn't a typo.
> > 
> 
> What's wrong with ug_ ? (ug = (u)sb(g)ecko)

What's wrong with usb_gecko_early_remap() :)
(Continue reading)

Permalink | Reply | 0 comments |
headers
Albert Herranz | 1 Dec 2009 06:45
Picon
Picon
Favicon

Re: [RFC PATCH v3 3/3] powerpc: gamecube/wii: early debugging using usbgecko

Michael Ellerman wrote:
>>> you may want to rename the ug_ prefix, it took me a while looking back
>>> and forth through the patch to convince myself it wasn't a typo.
>>>
>> What's wrong with ug_ ? (ug = (u)sb(g)ecko)
> 
> What's wrong with usb_gecko_early_remap() :)
> 

Nothing, except that names end up been way long for my taste (like for example usb_gecko_early_grab_exi_io_base())
I prefer to use a shorter prefix consistently.

But that's my taste :)

Cheers,
Albert
Permalink | Reply | 0 comments |
headers
Yogesh Chaudhari | 1 Dec 2009 06:48
Picon
Gravatar

Re: Ethernet issues with lite5200 board from linux-2.6.31

Hello Grant,

2009/11/30 Grant Likely <grant.likely <at> secretlab.ca>:
> On Mon, Nov 30, 2009 at 2:50 AM, Yogesh Chaudhari <mr.yogesh <at> gmail.com> wrote:
>> Hello,
>>         I am running linux kernel with rt patch on embedded board
>> based on lite5200 eval board. From linux-2.6.31 release, in which the
>> mdio patch has gone inside,  the fec ethernet does not come up on this
>> board. I get the following message at startup:
>> mpc52xx MII bus: probed
>> mdio_bus f0003000: error probing PHY at address 1
>>
>>
>> After the bootup if I try to do a ifconfig I get the message:
>> net eth2: of_phy_connect failed
>>
>>
>> If I change the value of reg in dts file (lite5200.dts) to 0 then this
>> ethernet comes up. However upto this kernel version, this was not
>> required.
>>
>> Ethernet does not come up on board with original lite5200.dts file
>
> Is your board based on the Lite5200 or the Lite5200B?  The phys are at
> different addresses on those two revisions of the board.  There is a
> different .dts file for each board.
>
>> phy0: ethernet-phy <at> 1 {
>>                                 reg = <1>;
>>                         };
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tirumala Reddy Marri | 1 Dec 2009 06:49

RE: ep440xs board boot problem

It could be ramdisk size issue.  if it is bigger than 4MB you might have to pass ramidisk_size=100000 (100MB
or > your ramdisk size).

-----Original Message-----
From: linuxppc-dev-bounces+tmarri=amcc.com <at> lists.ozlabs.org
[mailto:linuxppc-dev-bounces+tmarri=amcc.com <at> lists.ozlabs.org] On Behalf Of Allan Wang
Sent: Monday, November 30, 2009 9:35 PM
To: linuxppc-dev <at> lists.ozlabs.org
Subject: ep440xs board boot problem

Hello, All,

I am new to the list. I am still newbie to embedded linux. I have bought an ep440xs board which is similar to
sequoia board. u-boot is working. I am trying to make it run linux.  I have the following problems and need
your help. Thank you very much:


I am using linux kernel 2.6.30.4. I encounter 2 problems:
1. After console_init() is called inside start_kernel(), the console starts printing garbage like:
Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
serial8250.0: ttyS0 at MMIO 0x1ef600300 (irq = 16) is a 16550A
������������������������������
����������������������������
���������������������������������
������������������������������
�����������������.
2. It pakics when mounting the root file system(NFS):
(gdb) bt
#0  panic (fmt=0xc0290e94 "VFS: Unable to mount root fs on %s")
at kernel/panic.c:70
(Continue reading)

Permalink | Reply | 0 comments |

Gmane