headers
Greg Ungerer | 1 May 2011 01:00

Re: [PATCH] m68knommu: Use generic show_interrupts()

Hi Geert,

On 01/05/11 07:15, Geert Uytterhoeven wrote:
> Apart from whitespace differences, /proc/interrupts doesn't change by
> enabling GENERIC_IRQ_SHOW.
>
> Signed-off-by: Geert Uytterhoeven<geert <at> linux-m68k.org>

Works fine on m68knommu, so:

Acked-by: Greg Ungerer <gerg <at> uclinux.org>

Do you want me to push this via the m68knommu git tree?

Regards
Greg

> ---
> _not_ tested on m68knommu.
> Observations done on work-in-progress Atari genirq.
>
>   arch/m68k/Kconfig      |    1 +
>   arch/m68k/kernel/irq.c |   28 ----------------------------
>   2 files changed, 1 insertions(+), 28 deletions(-)
>
> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
> index dee2796..c23af0a 100644
> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
>  <at>  <at>  -5,6 +5,7  <at>  <at>  config M68K
(Continue reading)

Permalink | Reply | 1 comment |
headers
Geert Uytterhoeven | 1 May 2011 10:08

Re: [PATCH] m68knommu: Use generic show_interrupts()

On Sun, May 1, 2011 at 01:00, Greg Ungerer <gerg <at> snapgear.com> wrote:
> On 01/05/11 07:15, Geert Uytterhoeven wrote:
>> Apart from whitespace differences, /proc/interrupts doesn't change by
>> enabling GENERIC_IRQ_SHOW.
>>
>> Signed-off-by: Geert Uytterhoeven<geert <at> linux-m68k.org>
>
> Works fine on m68knommu, so:
>
> Acked-by: Greg Ungerer <gerg <at> uclinux.org>
>
> Do you want me to push this via the m68knommu git tree?

Yes please. Thx!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert <at> linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Permalink | Reply | 0 comments |
headers
Sven Eckelmann | 3 May 2011 23:30
Favicon

[PATCH] atomic: add *_dec_not_zero

Introduce an *_dec_not_zero operation.  Make this a special case of
*_add_unless because batman-adv uses atomic_dec_not_zero in different
places like re-broadcast queue or aggregation queue management. There
are other non-final patches which may also want to use this macro.

Reported-by: David S. Miller <davem <at> davemloft.net>
Signed-off-by: Sven Eckelmann <sven <at> narfation.org>
Cc: David Howells <dhowells <at> redhat.com>
Cc: Chris Metcalf <cmetcalf <at> tilera.com>
Cc: x86 <at> kernel.org
Cc: linux-alpha <at> vger.kernel.org
Cc: linux-kernel <at> vger.kernel.org
Cc: linux-arm-kernel <at> lists.infradead.org
Cc: uclinux-dist-devel <at> blackfin.uclinux.org
Cc: linux-cris-kernel <at> axis.com
Cc: linux-ia64 <at> vger.kernel.org
Cc: linux-m32r <at> ml.linux-m32r.org
Cc: linux-m68k <at> lists.linux-m68k.org
Cc: linux-mips <at> linux-mips.org
Cc: linux-am33-list <at> redhat.com
Cc: linux-parisc <at> vger.kernel.org
Cc: linuxppc-dev <at> lists.ozlabs.org
Cc: linux-s390 <at> vger.kernel.org
Cc: linux-sh <at> vger.kernel.org
Cc: sparclinux <at> vger.kernel.org
Cc: linux-arch <at> vger.kernel.org
---
David S. Miller recommended this change in
 https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2011-May/004560.html
(Continue reading)

Permalink | Reply | 0 comments |
headers
Mike Frysinger | 4 May 2011 06:44
Picon

Re: [PATCH] atomic: add *_dec_not_zero

On Tue, May 3, 2011 at 17:30, Sven Eckelmann wrote:
> Introduce an *_dec_not_zero operation.  Make this a special case of
> *_add_unless because batman-adv uses atomic_dec_not_zero in different
> places like re-broadcast queue or aggregation queue management. There
> are other non-final patches which may also want to use this macro.
>
> Cc: uclinux-dist-devel <at> blackfin.uclinux.org
>
> --- a/arch/blackfin/include/asm/atomic.h
> +++ b/arch/blackfin/include/asm/atomic.h
>  <at>  <at>  -103,6 +103,7  <at>  <at>  static inline int atomic_test_mask(int mask, atomic_t *v)
>        c != (u);                                               \
>  })
>  #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
> +#define atomic_dec_not_zero(v) atomic_add_unless((v), -1, 0)
>
>  /*
>  * atomic_inc_and_test - increment and test

no opinion on the actual idea, but for the Blackfin pieces:
Acked-by: Mike Frysinger <vapier <at> gentoo.org>
-mike
Permalink | Reply | 0 comments |
headers
David Miller | 4 May 2011 08:12
Favicon

Re: [PATCH] atomic: add *_dec_not_zero

From: Sven Eckelmann <sven <at> narfation.org>
Date: Tue,  3 May 2011 23:30:35 +0200

> Introduce an *_dec_not_zero operation.  Make this a special case of
> *_add_unless because batman-adv uses atomic_dec_not_zero in different
> places like re-broadcast queue or aggregation queue management. There
> are other non-final patches which may also want to use this macro.
> 
> Reported-by: David S. Miller <davem <at> davemloft.net>
> Signed-off-by: Sven Eckelmann <sven <at> narfation.org>

Acked-by: David S. Miller <davem <at> davemloft.net>
Permalink | Reply | 0 comments |
headers
Ingo Molnar | 4 May 2011 09:03
Picon
Picon
Favicon

Re: [PATCH] atomic: add *_dec_not_zero


* Sven Eckelmann <sven <at> narfation.org> wrote:

> Introduce an *_dec_not_zero operation.  Make this a special case of
> *_add_unless because batman-adv uses atomic_dec_not_zero in different
> places like re-broadcast queue or aggregation queue management. There
> are other non-final patches which may also want to use this macro.

>  arch/x86/include/asm/atomic.h      |    1 +
>  arch/x86/include/asm/atomic64_64.h |    1 +

Acked-by: Ingo Molnar <mingo <at> elte.hu>

Thanks,

	Ingo
Permalink | Reply | 0 comments |
headers
David Laight | 4 May 2011 10:05

RE: [PATCH] atomic: add *_dec_not_zero


> Introduce an *_dec_not_zero operation.  Make this a special case of
> *_add_unless because batman-adv uses atomic_dec_not_zero in different
> places like re-broadcast queue or aggregation queue management. There
> are other non-final patches which may also want to use this macro.

Isn't there a place where a default definition of this can be
defined? Instead of adding it separately to every architecture.

	David
Permalink | Reply | 0 comments |
headers
Sven Eckelmann | 4 May 2011 10:21
Favicon

Re: [PATCH] atomic: add *_dec_not_zero

On Wednesday 04 May 2011 10:05:53 David Laight wrote:
> > Introduce an *_dec_not_zero operation.  Make this a special case of
> > *_add_unless because batman-adv uses atomic_dec_not_zero in different
> > places like re-broadcast queue or aggregation queue management. There
> > are other non-final patches which may also want to use this macro.
> 
> Isn't there a place where a default definition of this can be
> defined? Instead of adding it separately to every architecture.

Not that I would know about such a place - and all other atomic* macro 
definitions also suggest that there is no such place.

Kind regards,
	Sven
Permalink | Reply | 0 comments |
headers
Mike Frysinger | 4 May 2011 10:33
Picon

Re: [PATCH] atomic: add *_dec_not_zero

On Wed, May 4, 2011 at 04:05, David Laight wrote:
>> Introduce an *_dec_not_zero operation.  Make this a special case of
>> *_add_unless because batman-adv uses atomic_dec_not_zero in different
>> places like re-broadcast queue or aggregation queue management. There
>> are other non-final patches which may also want to use this macro.
>
> Isn't there a place where a default definition of this can be
> defined? Instead of adding it separately to every architecture.

that's what asm-generic is for.  if the arch isnt using it, it's
either because the arch needs to convert to it, or they're using SMP
and asm-generic doesnt yet support that for atomic.h.

for example, the Blackfin port only needed updating for the SMP case.
in the non-SMP case, we're getting the def from asm-generic/atomic.h.
-mike
Permalink | Reply | 0 comments |
headers
Geert Uytterhoeven | 4 May 2011 11:33

atarimouse (was: Re: [git pull] m68k SLUB fix for 2.6.39)

Hi Michael,

On Sat, Apr 30, 2011 at 01:35, Michael Schmitz
<schmitzmic <at> googlemail.com> wrote:
> Falcon CT60, 14MB/512MB no swap:
>
> Out of memory: Kill process 8644 (malloctest) score 967 or sacrifice child
> Killed process 8644 (malloctest) total-vm:512244kB, anon-rss:510088kB,
> file-rss:284kB

Ah, real hardware ;-)

Any chance you can try the mouse (e.g. with gpm), and check if
http://permalink.gmane.org/gmane.linux.ports.m68k/1867 is needed, so we know
if this is an ARAnyM issue or not?

Thx!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert <at> linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Permalink | Reply | 6 comments |

Gmane