Michael Schmitz | 2 Jan 2009 01:12
Picon
Favicon

Re: [PATCH] m68k: Fix atarimouse init

Hi Geert,

> > I still get no mouse events in either /dev/input/mice or .../mouse0, though. I 
> > suspect the mouse open hook never gets called. Same bug might affect amimouse 
> > (though the open function does do the full hardware setup there).
> 
> Thanks, we're making progress :-)

Sort of ... 

> I get events from /dev/input/mouse0 and /dev/input/mice (atari_defconfig).
> 
> The kernel says (ARAnyM, windowed mode):
> | input: Atari mouse as /devices/virtual/input/input1
> | Reseting weird mouse packet: 942, 379, 0
> | Reseting weird mouse packet: 943, 379, 0
> | Reseting weird mouse packet: 945, 378, 0
> | Reseting weird mouse packet: 948, 378, 0
> | Reseting weird mouse packet: 956, 376, 0

That's the broken packets - the real ones shoule be fine (small x and y 
increments in byte 1 and 2, 0x8 in byte 0 unless button pressed).

> 
> When running X under ARAnyM (depth 16), some shortcomings show up:
>   - up and down are interchanged (works fine when rolling the mouse over the
>     bottom surface of the table --- old arabic map style ;-)

Weird - the inversion of the y direction increment is taken from the old 
busmouse driver code where it used to work OK. The point of reference is set to 
(Continue reading)

Michael Schmitz | 2 Jan 2009 01:27
Picon
Favicon

Re: [PATCH] m68k: Fix atarimouse init

Hi Petr,

> > I get events from /dev/input/mouse0 and /dev/input/mice (atari_defconfig).
> > 
> > When running X under ARAnyM (depth 16), some shortcomings show up:
> >   - the middle mouse button is dead
> 
> BTW, ARAnyM implements a mouse extension for the wheels that is
> compatible with an existing hardware modification (or an add-on).
> Sometime later we could implement its support in linux to get true
> middle mouse button and its wheels.

So what would the middle button and wheel events be reported at? 

	Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andreas Schwab | 2 Jan 2009 10:42
Picon

Re: [PATCH] m68k: Fix atarimouse init

Michael Schmitz <schmitz <at> biophys.uni-duesseldorf.de> writes:

> Hi Geert,
>
>> The kernel says (ARAnyM, windowed mode):
>> | Reseting weird mouse packet: 942, 379, 0
>> | Reseting weird mouse packet: 943, 379, 0
>> | Reseting weird mouse packet: 945, 378, 0
>> | Reseting weird mouse packet: 948, 378, 0
>> | Reseting weird mouse packet: 956, 376, 0

These messages come from ARAnyM.

>> 
>> When running X under ARAnyM (depth 16), some shortcomings show up:
>>   - up and down are interchanged (works fine when rolling the mouse over the
>>     bottom surface of the table --- old arabic map style ;-)
>
> Weird - the inversion of the y direction increment is taken from the old 
> busmouse driver code where it used to work OK. The point of reference is set to 
> be at the top of the 'screen' so moving the mouse down ought to generate 
> positive increments.

ARAnyM's emulation of the IKBD does not support changing the y origin.

>>   - the left and right mouse button are interchanged
>
> The busmouse driver had no annotation as to the semantics of the buttons so O 
> guessed bit 0 was for the left button. Guessed wrong, it seems.

(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:11

[PATCH] fbdev: Kill Atari vblank cursor blinking

Kill the last remaining vblank cursor blinking user

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
---
 drivers/video/console/fbcon.c |   38 --------------------------------------
 1 files changed, 0 insertions(+), 38 deletions(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 4bcff81..1657b96 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
 <at>  <at>  -78,13 +78,6  <at>  <at> 
 #include <asm/fb.h>
 #include <asm/irq.h>
 #include <asm/system.h>
-#ifdef CONFIG_ATARI
-#include <asm/atariints.h>
-#endif
-#if defined(__mc68000__)
-#include <asm/machdep.h>
-#include <asm/setup.h>
-#endif

 #include "fbcon.h"

 <at>  <at>  -155,9 +148,6  <at>  <at>  static int fbcon_set_origin(struct vc_data *);

 #define CURSOR_DRAW_DELAY		(1)

-/* # VBL ints between cursor state changes */
(Continue reading)

Petr Stehlik | 2 Jan 2009 11:20
Picon
Favicon

Re: [PATCH] m68k: Fix atarimouse init

Andreas Schwab píše v Pá 02. 01. 2009 v 10:42 +0100:
> > Hi Geert,
> >
> >> The kernel says (ARAnyM, windowed mode):
> >> | Reseting weird mouse packet: 942, 379, 0
> >> | Reseting weird mouse packet: 943, 379, 0
> >> | Reseting weird mouse packet: 945, 378, 0
> >> | Reseting weird mouse packet: 948, 378, 0
> >> | Reseting weird mouse packet: 956, 376, 0
> 
> These messages come from ARAnyM.

..and indicates that something wrong is going on. Normally there is only
one such message when entering the ARAnyM window.

> ARAnyM's emulation of the IKBD does not support changing the y origin.

will add it there.

> >>   - the middle mouse button is dead
> >
> > As is expexcted - the original code was for a two-button mouse only. If Petr 
> > knows what the ikbd format for the third button is (on real hardware) it's easy 
> > to add that in.
> 
> The IKBD does not support more than two buttons.  For a three button
> mouse the middle button was apparently wired to the joystick port.

Yes, that was an old Linux-m68k extension.

(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:41

[PATCH] m68k: amiga core - kill warn_unused_result warnings

warning: ignoring return value of 'request_irq', declared with attribute
warn_unused_result

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
---
 arch/m68k/amiga/amiints.c |   12 ++++++++----
 arch/m68k/amiga/cia.c     |    4 +++-
 arch/m68k/amiga/config.c  |    3 ++-
 3 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/arch/m68k/amiga/amiints.c b/arch/m68k/amiga/amiints.c
index 907a553..c5b5212 100644
--- a/arch/m68k/amiga/amiints.c
+++ b/arch/m68k/amiga/amiints.c
 <at>  <at>  -72,10 +72,14  <at>  <at>  static struct irq_controller amiga_irq_controller = {

 void __init amiga_init_IRQ(void)
 {
-	request_irq(IRQ_AUTO_1, ami_int1, 0, "int1", NULL);
-	request_irq(IRQ_AUTO_3, ami_int3, 0, "int3", NULL);
-	request_irq(IRQ_AUTO_4, ami_int4, 0, "int4", NULL);
-	request_irq(IRQ_AUTO_5, ami_int5, 0, "int5", NULL);
+	if (request_irq(IRQ_AUTO_1, ami_int1, 0, "int1", NULL))
+		pr_err("Couldn't register int%d\n", 1);
+	if (request_irq(IRQ_AUTO_3, ami_int3, 0, "int3", NULL))
+		pr_err("Couldn't register int%d\n", 3);
+	if (request_irq(IRQ_AUTO_4, ami_int4, 0, "int4", NULL))
+		pr_err("Couldn't register int%d\n", 4);
+	if (request_irq(IRQ_AUTO_5, ami_int5, 0, "int5", NULL))
+		pr_err("Couldn't register int%d\n", 5);
(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:41

[PATCH] m68k: Atari SCC support for ST

Enable support for Atari ST, and fix 2 obvious typos in the ST support code.

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
Cc: Michael Schmitz <schmitz <at> biophys.uni-duesseldorf.de>
---
 drivers/char/atari_scc.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/char/atari_scc.c b/drivers/char/atari_scc.c
index 800193c..e407aa8 100644
--- a/drivers/char/atari_scc.c
+++ b/drivers/char/atari_scc.c
 <at>  <at>  -51,6 +51,7  <at>  <at> 

 #define CONFIG_TT_SCC     1
 #define CONFIG_FALCON_SCC 1
+#define CONFIG_ST_SCC     1

 #define CHANNEL_A	0
 #define CHANNEL_B	1
 <at>  <at>  -475,7 +476,7  <at>  <at>  static int atari_st_scc_init(void)
 	request_irq(IRQ_SCCA_STAT, scc_stat_int, IRQ_TYPE_PRIO,
 		    "SCC-A status", port);
 	request_irq(IRQ_SCCA_RX, scc_rx_int, IRQ_TYPE_PRIO, "SCC-A RX", port);
-	request_irq(SCCA_SPCOND, scc_spcond_int, IRQ_TYPE_PRIO,
+	request_irq(IRQ_SCCA_SPCOND, scc_spcond_int, IRQ_TYPE_PRIO,
 		    "SCC-A special cond", port);
 	{
 		SCC_ACCESS_INIT(port);
 <at>  <at>  -493,7 +494,7  <at>  <at>  static int atari_st_scc_init(void)
(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:41

[PATCH] m68k: apollo core - kill warn_unused_result warnings

warning: ignoring return value of 'request_irq', declared with attribute
warn_unused_result

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
---
 arch/m68k/apollo/config.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c
index cf215a0..8d3eafa 100644
--- a/arch/m68k/apollo/config.c
+++ b/arch/m68k/apollo/config.c
 <at>  <at>  -200,7 +200,8  <at>  <at>  void dn_sched_init(irq_handler_t timer_routine)
 	printk("*(0x10803) %02x\n",*(volatile unsigned char *)(timer+0x3));
 #endif

-	request_irq(IRQ_APOLLO, dn_timer_int, 0, "time", timer_routine);
+	if (request_irq(IRQ_APOLLO, dn_timer_int, 0, "time", timer_routine))
+		pr_err("Couldn't register timer interrupt\n");
 }

 unsigned long dn_gettimeoffset(void) {
--

-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:41

[PATCH] m68k: sun3 core - kill warn_unused_result warnings

warning: ignoring return value of 'request_irq', declared with attribute
warn_unused_result

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
---
 arch/m68k/sun3/sun3ints.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/sun3/sun3ints.c b/arch/m68k/sun3/sun3ints.c
index 7364cd6..ad90393 100644
--- a/arch/m68k/sun3/sun3ints.c
+++ b/arch/m68k/sun3/sun3ints.c
 <at>  <at>  -105,7 +105,10  <at>  <at>  void __init sun3_init_IRQ(void)
 	m68k_setup_irq_controller(&sun3_irq_controller, IRQ_AUTO_1, 7);
 	m68k_setup_user_interrupt(VEC_USER, 128, NULL);

-	request_irq(IRQ_AUTO_5, sun3_int5, 0, "int5", NULL);
-	request_irq(IRQ_AUTO_7, sun3_int7, 0, "int7", NULL);
-	request_irq(IRQ_USER+127, sun3_vec255, 0, "vec255", NULL);
+	if (request_irq(IRQ_AUTO_5, sun3_int5, 0, "int5", NULL))
+		pr_err("Couldn't register %s interrupt\n", "int5");
+	if (request_irq(IRQ_AUTO_7, sun3_int7, 0, "int7", NULL))
+		pr_err("Couldn't register %s interrupt\n", "int7");
+	if (request_irq(IRQ_USER+127, sun3_vec255, 0, "vec255", NULL))
+		pr_err("Couldn't register %s interrupt\n", "vec255");
 }
--

-- 
1.5.6.5

--
(Continue reading)

Geert Uytterhoeven | 2 Jan 2009 11:41

[PATCH] m68k: mac core - kill warn_unused_result warnings

warning: ignoring return value of 'request_irq', declared with attribute
warn_unused_result

Signed-off-by: Geert Uytterhoeven <geert <at> linux-m68k.org>
---
 arch/m68k/mac/baboon.c  |    3 ++-
 arch/m68k/mac/iop.c     |   10 ++++++----
 arch/m68k/mac/macints.c |    5 +++--
 arch/m68k/mac/oss.c     |   25 +++++++++++++++----------
 arch/m68k/mac/psc.c     |   12 ++++++++----
 arch/m68k/mac/via.c     |   33 ++++++++++++++++++++-------------
 6 files changed, 54 insertions(+), 34 deletions(-)

diff --git a/arch/m68k/mac/baboon.c b/arch/m68k/mac/baboon.c
index 245d16d..2a96beb 100644
--- a/arch/m68k/mac/baboon.c
+++ b/arch/m68k/mac/baboon.c
 <at>  <at>  -92,7 +92,8  <at>  <at>  static irqreturn_t baboon_irq(int irq, void *dev_id)
 void __init baboon_register_interrupts(void)
 {
 	baboon_disabled = 0;
-	request_irq(IRQ_NUBUS_C, baboon_irq, 0, "baboon", (void *)baboon);
+	if (request_irq(IRQ_NUBUS_C, baboon_irq, 0, "baboon", (void *)baboon))
+		pr_err("Couldn't register baboon interrupt\n");
 }

 /*
diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c
index 326fb99..1ad4e9d 100644
--- a/arch/m68k/mac/iop.c
(Continue reading)


Gmane