headers
Adrian Bunk | 4 Sep 13:41
Picon
Favicon

2.6.18-rc5-mm1: is_init() parisc compile error

pidspace-is_init.patch causes the following compile error on parisc:

<--  snip  -->

...
  CC      arch/parisc/kernel/module.o
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/parisc/kernel/module.c:76: error:
conflicting types for 'is_init'
/home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/include/linux/sched.h:1090: error: previous
definition of 'is_init' was here
make[2]: *** [arch/parisc/kernel/module.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

-- 
VGER BF report: H 2.76804e-05
Permalink | Reply | 0 comments |
headers
Matthew Wilcox | 4 Sep 15:48

Re: [parisc-linux] 2.6.18-rc5-mm1: is_init() parisc compile error

On Mon, Sep 04, 2006 at 01:41:30PM +0200, Adrian Bunk wrote:
> pidspace-is_init.patch causes the following compile error on parisc:
> 
> <--  snip  -->
> 
> ...
>   CC      arch/parisc/kernel/module.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/parisc/kernel/module.c:76: error:
conflicting types for 'is_init'
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/include/linux/sched.h:1090: error:
previous definition of 'is_init' was here
> make[2]: *** [arch/parisc/kernel/module.o] Error 1
> 
> <--  snip  -->

Looks like ia64 calls the same function in_init().  I'm tempted to
change parisc to have the same name.
Permalink | Reply | 0 comments |
headers
Eric W. Biederman | 4 Sep 20:24
Favicon

[PATCH] Fix conflict with the is_init identifier on parisc

Matthew Wilcox <matthew <at> wil.cx> writes:

> On Mon, Sep 04, 2006 at 01:41:30PM +0200, Adrian Bunk wrote:
>> pidspace-is_init.patch causes the following compile error on parisc:
>> 
>> <--  snip  -->
>> 
>> ...
>>   CC      arch/parisc/kernel/module.o
>>
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/parisc/kernel/module.c:76:
> error: conflicting types for 'is_init'
>> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/include/linux/sched.h:1090:
> error: previous definition of 'is_init' was here
>> make[2]: *** [arch/parisc/kernel/module.o] Error 1
>> 
>> <--  snip  -->
>
> Looks like ia64 calls the same function in_init().  I'm tempted to
> change parisc to have the same name.

How does the following patch look?
Since I don't have a parisc compiler so I haven't compile tested it.
But it is a simple substitute and replace and I can't see any problems
by inspection so it should work.

----

This appears to be the only usage of is_init in the kernel
besides the usage in sched.h.   On ia64 the same function is
(Continue reading)

Permalink | Reply | 0 comments |
headers
Adrian Bunk | 4 Sep 20:41
Picon
Favicon

Re: [PATCH] Fix conflict with the is_init identifier on parisc

On Mon, Sep 04, 2006 at 12:24:27PM -0600, Eric W. Biederman wrote:
> Matthew Wilcox <matthew <at> wil.cx> writes:
> 
> > On Mon, Sep 04, 2006 at 01:41:30PM +0200, Adrian Bunk wrote:
> >> pidspace-is_init.patch causes the following compile error on parisc:
> >> 
> >> <--  snip  -->
> >> 
> >> ...
> >>   CC      arch/parisc/kernel/module.o
> >>
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/parisc/kernel/module.c:76:
> > error: conflicting types for 'is_init'
> >> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/include/linux/sched.h:1090:
> > error: previous definition of 'is_init' was here
> >> make[2]: *** [arch/parisc/kernel/module.o] Error 1
> >> 
> >> <--  snip  -->
> >
> > Looks like ia64 calls the same function in_init().  I'm tempted to
> > change parisc to have the same name.
> 
> How does the following patch look?
> Since I don't have a parisc compiler so I haven't compile tested it.
> But it is a simple substitute and replace and I can't see any problems
> by inspection so it should work.
>...

Thanks, I can confirm it fixes the compilation.
(Continue reading)

Permalink | Reply | 0 comments |
headers
Andrew Morton | 4 Sep 21:18

Re: [PATCH] Fix conflict with the is_init identifier on parisc

On Mon, 04 Sep 2006 12:24:27 -0600
ebiederm <at> xmission.com (Eric W. Biederman) wrote:

> Singed-off-by: Eric Biederman <ebiederm <at> xmission.com>

ouch!  One for the hot-fixes directory, I assume.
Permalink | Reply | 0 comments |
headers
Amol Lad | 28 Sep 07:53
Favicon

[KJ] [PATCH] ioremap balanced with iounmap for drivers/parisc

ioremap must be balanced by an iounmap and failing to do so can result
in a memory leak.

Tested (compilation only) to make sure the files are compiling without
any warning/error due to new changes

Signed-off-by: Amol Lad <amol <at> verismonetworks.com>
---
 dino.c    |    4 +++-
 eisa.c    |    1 +
 iosapic.c |    1 +
 lba_pci.c |    7 ++++++-
 4 files changed, 11 insertions(+), 2 deletions(-)
---
diff -uprN -X linux-2.6.18-orig/Documentation/dontdiff linux-2.6.18-orig/drivers/parisc/dino.c linux-2.6.18/drivers/parisc/dino.c
--- linux-2.6.18-orig/drivers/parisc/dino.c	2006-09-21 10:15:38.000000000 +0530
+++ linux-2.6.18/drivers/parisc/dino.c	2006-09-28 10:14:07.000000000 +0530
@@ -1007,8 +1007,10 @@ static int __init dino_probe(struct pari
 		dino_bridge_init(dino_dev, name);
 	}

-	if (dino_common_init(dev, dino_dev, name))
+	if (dino_common_init(dev, dino_dev, name)) {
+		iounmap(dino_dev->hba.base_addr);
 		return 1;
+	}

 	dev->dev.platform_data = dino_dev;

diff -uprN -X linux-2.6.18-orig/Documentation/dontdiff linux-2.6.18-orig/drivers/parisc/eisa.c linux-2.6.18/drivers/parisc/eisa.c
(Continue reading)

Permalink | Reply | 0 comments |
headers
Kyle McMartin | 28 Sep 14:58

Re: [KJ] [parisc-linux] [PATCH] ioremap balanced with iounmap for drivers/parisc

On Thu, Sep 28, 2006 at 11:23:34AM +0530, Amol Lad wrote:
> ioremap must be balanced by an iounmap and failing to do so can result
> in a memory leak.
> 

Looks ok. Will merge.
Permalink | Reply | 0 comments |
headers
Matthew Wilcox | 28 Sep 15:14

Re: [KJ] [parisc-linux] [PATCH] ioremap balanced with iounmap for drivers/parisc

On Thu, Sep 28, 2006 at 08:58:15AM -0400, Kyle McMartin wrote:
> On Thu, Sep 28, 2006 at 11:23:34AM +0530, Amol Lad wrote:
> > ioremap must be balanced by an iounmap and failing to do so can result
> > in a memory leak.
> > 
> 
> Looks ok. Will merge.

Actually, it shows some areas we need to do better.  It's an
improvement, but look at, eg, the error returns from elroy.
Permalink | Reply | 0 comments |

Gmane