Re: [PATCH] Support for AD1889 PCI Soundchip

At Fri, 29 Jul 2005 21:16:34 +0200,
Thibaut VARENE wrote:
> 
> Hi,
> 
> Attached is a patch against 2.6.13-rc4 providing support for Analog
> Devices AD1889 PCI Sound chip, which is especially found on some HP
> PA-RISC machines.
> 
> The driver has been successfully tested on parisc and ppc architectures,
> and offers support for full duplex playback (variable rates, mono/stereo
> 8/16bit) and capture (fixed 48kHz, mono/stereo 8/16bit).
> 
> It's developed and maintained in the parisc-linux.org CVS kernel tree
> (http://cvs.parisc-linux.org/), and has a status webpage on
> http://wiki.parisc-linux.org/AD1889
> 
> This patch doesn't yet feature OPL3 code, because it's still work in
> progress in our development tree.

Thanks for the patch.

I put your code to alsa-driver for the time being.
Will be moved to alsa-kernel to push to linux-kernel tree later.

Takashi

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,

Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip

Thibaut VARENE wrote:
> Attached is a patch against 2.6.13-rc4 providing support for Analog
> Devices AD1889 PCI Sound chip, which is especially found on some HP
> PA-RISC machines.

I don't actually have this hardware , but the docs don't mention
any dependency between the count registers (BC, CC) and the interrupt
count registers (IC, IB).

So wouldn't it be possible to put the ALSA buffer size into the count
registers and the ALSA period size into the interrupt count registers?

This would make the interrupt handler much simpler, as it wouldn't
have to reprogram any registers.  And it would solve the problem that
the DMA accesses for one period go beyond the buffer when the number
of periods per buffer is not an integer.

Regards,
Clemens

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Why toggle_bounce only for disks?

Ahoi,

The following patch fixes a crash caused by attempting to bounce buffer
when an IDE CD-ROM is used on a machine with an IO-MMU. [At least, this
patch fixes things so I can use my IDE CD-ROM behind an ns87415 on a 
HP PA-RISC workstation.]

Why was this only allowed for disks?

--- a/drivers/ide/ide-lib.c   18 Jul 2005 18:46:30 -0000
+++ b/drivers/ide/ide-lib.c   6 Aug 2005 20:28:04 -0000
@@ -410,7 +410,7 @@ void ide_toggle_bounce(ide_drive_t *driv
 {
        u64 addr = BLK_BOUNCE_HIGH;     /* dma64_addr_t */

-       if (on && drive->media == ide_disk) {
+       if (on) {
                if (!PCI_DMA_BUS_IS_PHYS)
                        addr = BLK_BOUNCE_ANY;
                else if (HWIF(drive)->pci_dev)

Cheers,
--

-- 
Kyle McMartin
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] schedule obsolete OSS drivers for removal (version 2)

On Fri, 2005-07-29 at 17:32 +0200, Adrian Bunk wrote:
> This patch schedules obsolete OSS drivers (with ALSA drivers that 
> support the same hardware) for removal.
> 
> Scheduling the via82cxxx driver for removal was ACK'ed by Jeff Garzik.
> 

Someone on linux-audio-user just pointed out that the OSS USB audio and
midi modules were never deprecated, much less scheduled to be removed.

Maybe the best way to deprecate them is to move them to Sound -> OSS,
that's where they belong anyway.

Lee

On Tue, 2005-08-09 at 18:42 +0200, Christoph Eckert wrote: 
> > Recompile the kernel with USB audio support.
> 
> Please ensure that you *disable* => Devioce drivers => USB => 
> USB audio and USB Midi.
> 
> Both are OSS modules and caused a lot of trouble here when 
> used in conjunction with the ALSA module
> 
> => Sound => ALSA => USB devices => USB Audio/MIDI driver
> 
> 
> BTW: OSS is marked as deprecated, but not the two OSS modules 
> mentioned above. Couldn't this get set or at least some info 
> that these modules belong to OSS?

Re: [2.6 patch] schedule obsolete OSS drivers for removal (version 2)

On Tue, Aug 09, 2005 at 01:13:51PM -0400, Lee Revell wrote:
> On Fri, 2005-07-29 at 17:32 +0200, Adrian Bunk wrote:
> > This patch schedules obsolete OSS drivers (with ALSA drivers that 
> > support the same hardware) for removal.
> > 
> > Scheduling the via82cxxx driver for removal was ACK'ed by Jeff Garzik.
> > 
> 
> Someone on linux-audio-user just pointed out that the OSS USB audio and
> midi modules were never deprecated, much less scheduled to be removed.
> 
> Maybe the best way to deprecate them is to move them to Sound -> OSS,
> that's where they belong anyway.

I'd deprecate them without moving them.

I'll send a patch unless someone tells that any functionality of these 
drivers is lacking in ALSA.

> Lee

cu
Adrian

--

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] schedule obsolete OSS drivers for removal (version 2)

On Tue, 2005-08-09 at 19:49 +0200, Adrian Bunk wrote:
> I'd deprecate them without moving them.
> 

OK, I think that will still be slightly confusing becuase it comes
before Sound in the kernel config, but maybe the deprecated part will
make people think twice.

I think we should at least label these clearly as part of OSS.  Users at
least seem to know that mixing OSS and ALSA modules is bad.

> I'll send a patch unless someone tells that any functionality of these
> drivers is lacking in ALSA. 

OK.  I'm almost positive there is no functionality missing, there have
not been any reports of people needing to use the OSS driver on any of
the ALSA lists.

Lee 

-
To unsubscribe from this list: send the line "unsubscribe linux-sound" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip

I wrote:
> Thibaut VARENE wrote:
> > Attached is a patch against 2.6.13-rc4 providing support for Analog
> > Devices AD1889 PCI Sound chip, which is especially found on some HP
> > PA-RISC machines.
>
> I don't actually have this hardware , but the docs don't mention
> any dependency between the count registers (BC, CC) and the interrupt
> count registers (IC, IB).
>
> So wouldn't it be possible to put the ALSA buffer size into the count
> registers and the ALSA period size into the interrupt count registers?
>
> This would make the interrupt handler much simpler, as it wouldn't
> have to reprogram any registers.  And it would solve the problem that
> the DMA accesses for one period go beyond the buffer when the number
> of periods per buffer is not an integer.

... something like this (please test):

Index: alsa/alsa-driver/pci/ad1889.h
===================================================================
--- alsa.orig/alsa-driver/pci/ad1889.h	2005-08-04 17:56:50.000000000 +0200
+++ alsa/alsa-driver/pci/ad1889.h	2005-08-11 11:54:38.000000000 +0200
@@ -172,13 +172,6 @@
 #define AD_ADC_STATE	1
 #define AD_MAX_STATES	2

-/* "<ggg> T-Bone: parisc IOMMU can start DMA at any address.
-   But the IOMMU can only map at page size granularity."

Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip

On Thu, Aug 11, 2005 at 05:18:31PM +0200, Clemens Ladisch wrote:
> > This would make the interrupt handler much simpler, as it wouldn't
> > have to reprogram any registers.  And it would solve the problem that
> > the DMA accesses for one period go beyond the buffer when the number
> > of periods per buffer is not an integer.
> 
> ... something like this (please test):
> 

This doesn't apply against PA-RISC Linux CVS head (should have
no changes since submission) nor against ALSA CVS head... care to try
again? I don't have time to clean up the patch right now, it would
have to wait a week or so.

Cheers,
--

-- 
Kyle McMartin

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

Re: [parisc-linux] [PATCH] Support for AD1889 PCI Soundchip

Kyle McMartin wrote:
> On Thu, Aug 11, 2005 at 05:18:31PM +0200, Clemens Ladisch wrote:
> > ... something like this (please test):
>
> This doesn't apply against PA-RISC Linux CVS head (should have
> no changes since submission) nor against ALSA CVS head...

It should apply against both, but it seems somewhere some whitespaces
got lost ...

Here you go again.

Regards,
Clemens

Index: alsa/alsa-driver/pci/ad1889.h
===================================================================
--- alsa.orig/alsa-driver/pci/ad1889.h	2005-08-04 17:56:50.000000000 +0200
+++ alsa/alsa-driver/pci/ad1889.h	2005-08-11 11:54:38.000000000 +0200
@@ -172,13 +172,6 @@
 #define AD_ADC_STATE	1
 #define AD_MAX_STATES	2
 
-/* "<ggg> T-Bone: parisc IOMMU can start DMA at any address.
-   But the IOMMU can only map at page size granularity."
-   This affects in particular .period_bytes_min */
-#define BUF_SIZE        PAGE_SIZE
-#define MAX_BUFS        32
-#define DMA_SIZE	(MAX_BUFS*BUF_SIZE)

Re: [2.6 patch] schedule obsolete OSS drivers for removal (version 2)

On Tue, 2005-08-09 at 19:49 +0200, Adrian Bunk wrote:
> On Tue, Aug 09, 2005 at 01:13:51PM -0400, Lee Revell wrote:
> > On Fri, 2005-07-29 at 17:32 +0200, Adrian Bunk wrote:
> > > This patch schedules obsolete OSS drivers (with ALSA drivers that 
> > > support the same hardware) for removal.
> > > 
> > > Scheduling the via82cxxx driver for removal was ACK'ed by Jeff Garzik.
> > > 
> > 
> > Someone on linux-audio-user just pointed out that the OSS USB audio and
> > midi modules were never deprecated, much less scheduled to be removed.
> > 
> > Maybe the best way to deprecate them is to move them to Sound -> OSS,
> > that's where they belong anyway.
> 
> I'd deprecate them without moving them.
> 

Here's the patch.  The bug was that CONFIG_USB_AUDIO and CONFIG_USB_MIDI
need to depend on CONFIG_SOUND_PRIME.

It also fixes some typos and clarifies the help text.

Signed-Off-By: Lee Revell <rlrevell <at> joe-job.com>

--- linux-2.6.13-rc4/drivers/usb/class/Kconfig~	2005-08-12 15:54:36.000000000 -0400
+++ linux-2.6.13-rc4/drivers/usb/class/Kconfig	2005-08-12 15:57:38.000000000 -0400
@@ -5,12 +5,12 @@
 	depends on USB