Texas Instrument's Omap Processor's Linux development mailing list

Seth Forshee | 1 Apr 2008 02:51

Picon

Re: [RFC/PATH] OMAP: HSMMC: Fixes for 1.8V MMC2 interface

On Mon, Mar 31, 2008 at 11:45:21PM +0300, Francisco Alecrim wrote:
> Hello Seth,
>    It's fine and work for 3430! Maybe you should resend changing the 
> commit message. It's too big.
> 
> Remove "RFC" from subject.
> 
> What do you think?
> 
> if(changes)
>    Acked-by: Francisco Alecrim <francisco.alecrim <at> indt.org.br>

Thank you for reviewing/testing.  I wanted to get verification for OMAP3430
before I officially submitted the patch, and since you have done that I will
submit it now.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Seth Forshee | 1 Apr 2008 03:34

Picon

[PATCH] OMAP: HSMMC: Fix 1.8V MMC2 host on OMAP2430/3430

OMAP2430/3430 contain an 1.8V-only MMC2 host that is not properly
supported by the current driver.  This patch contains changes to
correctly set up this host.

Signed-off-by: Seth Forshee <seth.forshee <at> gmail.com>
Acked-by: Francisco Alecrim <francisco.alecrim <at> indt.org.br>
---
 drivers/mmc/host/omap_hsmmc.c |   32 ++++++++++++++++++++++++++------
 1 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 248257f..d5d82a8 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
 <at>  <at>  -388,8 +388,12  <at>  <at>  static int omap_mmc_switch_opcond(struct mmc_omap_host *host, int vdd)
 	 * If a MMC dual voltage card is detected, the set_ios fn calls
 	 * this fn with VDD bit set for 1.8V. Upon card removal from the
 	 * slot, mmc_omap_detect fn sets the VDD back to 3V.
+	 *
+	 * Only MMC1 supports 3.0V.  MMC2 will not function if SDVS30 is
+	 * set in HCTL.
 	 */
-	if (((1 << vdd) == MMC_VDD_32_33) || ((1 << vdd) == MMC_VDD_33_34))
+	if (host->id == OMAP_MMC1_DEVID && (((1 << vdd) == MMC_VDD_32_33) ||
+				((1 << vdd) == MMC_VDD_33_34)))
 		reg_val |= SDVS30;
 	if ((1 << vdd) == MMC_VDD_165_195)
 		reg_val |= SDVS18;
 <at>  <at>  -517,10 +521,16  <at>  <at>  mmc_omap_start_dma_transfer(struct mmc_omap_host *host, struct mmc_request *req)

(Continue reading)

Francisco Alecrim | 1 Apr 2008 04:28

Picon

Re: [PATCH] OMAP: HSMMC: Fix 1.8V MMC2 host on OMAP2430/3430

Acked-by : Francisco Alecrim <francisco.alecrim <at> indt.org.br>

ext Seth Forshee wrote:
> OMAP2430/3430 contain an 1.8V-only MMC2 host that is not properly
> supported by the current driver.  This patch contains changes to
> correctly set up this host.
>
> Signed-off-by: Seth Forshee <seth.forshee <at> gmail.com>
> Acked-by: Francisco Alecrim <francisco.alecrim <at> indt.org.br>
> ---
>  drivers/mmc/host/omap_hsmmc.c |   32 ++++++++++++++++++++++++++------
>  1 files changed, 26 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 248257f..d5d82a8 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
>  <at>  <at>  -388,8 +388,12  <at>  <at>  static int omap_mmc_switch_opcond(struct mmc_omap_host *host, int vdd)
>  	 * If a MMC dual voltage card is detected, the set_ios fn calls
>  	 * this fn with VDD bit set for 1.8V. Upon card removal from the
>  	 * slot, mmc_omap_detect fn sets the VDD back to 3V.
> +	 *
> +	 * Only MMC1 supports 3.0V.  MMC2 will not function if SDVS30 is
> +	 * set in HCTL.
>  	 */
> -	if (((1 << vdd) == MMC_VDD_32_33) || ((1 << vdd) == MMC_VDD_33_34))
> +	if (host->id == OMAP_MMC1_DEVID && (((1 << vdd) == MMC_VDD_32_33) ||
> +				((1 << vdd) == MMC_VDD_33_34)))
>  		reg_val |= SDVS30;
>  	if ((1 << vdd) == MMC_VDD_165_195)

(Continue reading)

Francisco Alecrim | 1 Apr 2008 04:29

Picon

Re: [PATCH] OMAP: HSMMC: Fix 1.8V MMC2 host on OMAP2430/3430

Acked-by : Francisco Alecrim <francisco.alecrim <at> indt.org.br>

ext Seth Forshee wrote:
> OMAP2430/3430 contain an 1.8V-only MMC2 host that is not properly
> supported by the current driver.  This patch contains changes to
> correctly set up this host.
>
> Signed-off-by: Seth Forshee <seth.forshee <at> gmail.com>
> Acked-by: Francisco Alecrim <francisco.alecrim <at> indt.org.br>
> ---
>  drivers/mmc/host/omap_hsmmc.c |   32 ++++++++++++++++++++++++++------
>  1 files changed, 26 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 248257f..d5d82a8 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
>  <at>  <at>  -388,8 +388,12  <at>  <at>  static int omap_mmc_switch_opcond(struct mmc_omap_host *host, int vdd)
>  	 * If a MMC dual voltage card is detected, the set_ios fn calls
>  	 * this fn with VDD bit set for 1.8V. Upon card removal from the
>  	 * slot, mmc_omap_detect fn sets the VDD back to 3V.
> +	 *
> +	 * Only MMC1 supports 3.0V.  MMC2 will not function if SDVS30 is
> +	 * set in HCTL.
>  	 */
> -	if (((1 << vdd) == MMC_VDD_32_33) || ((1 << vdd) == MMC_VDD_33_34))
> +	if (host->id == OMAP_MMC1_DEVID && (((1 << vdd) == MMC_VDD_32_33) ||
> +				((1 << vdd) == MMC_VDD_33_34)))
>  		reg_val |= SDVS30;
>  	if ((1 << vdd) == MMC_VDD_165_195)

(Continue reading)

Hiroshi DOYU | 1 Apr 2008 09:11

Picon

[PATCH 1/2] ARM: OMAP: Add fuctional clock enabler for iva2

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU <at> nokia.com>
---
 arch/arm/mach-omap2/clock34xx.h       |    5 +++--
 arch/arm/mach-omap2/cm-regbits-34xx.h |    1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/clock34xx.h b/arch/arm/mach-omap2/clock34xx.h
index d00ef1e..4d9a67b 100644
--- a/arch/arm/mach-omap2/clock34xx.h
+++ b/arch/arm/mach-omap2/clock34xx.h
 <at>  <at>  -1046,12 +1046,13  <at>  <at>  static struct clk iva2_ck = {
 	.name		= "iva2_ck",
 	.parent		= &dpll2_m2_ck,
 	.init		= &omap2_init_clksel_parent,
+	.enable_reg	= OMAP_CM_REGADDR(OMAP3430_IVA2_MOD, CM_FCLKEN),
+	.enable_bit	= OMAP3430_CM_FCLKEN_IVA2_EN_IVA2_SHIFT,
 	.clksel_reg	= OMAP_CM_REGADDR(OMAP3430_IVA2_MOD,
 					  OMAP3430_CM_IDLEST_PLL),
 	.clksel_mask	= OMAP3430_ST_IVA2_CLK_MASK,
 	.clksel		= iva2_clksel,
-	.flags		= CLOCK_IN_OMAP343X | RATE_PROPAGATES |
-				PARENT_CONTROLS_CLOCK,
+	.flags		= CLOCK_IN_OMAP343X | RATE_PROPAGATES,
 	.recalc		= &omap2_clksel_recalc,
 };

diff --git a/arch/arm/mach-omap2/cm-regbits-34xx.h b/arch/arm/mach-omap2/cm-regbits-34xx.h
index 9249129..3c38395 100644
--- a/arch/arm/mach-omap2/cm-regbits-34xx.h
+++ b/arch/arm/mach-omap2/cm-regbits-34xx.h

(Continue reading)

Roman Tereshonkov | 1 Apr 2008 13:54

Picon

[PATCH] Tiny fix. No comma after KERN_INFO.


Signed-off-by: Roman Tereshonkov <roman.tereshonkov <at> nokia.com>
---
 drivers/misc/sti/sdti.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/sti/sdti.c b/drivers/misc/sti/sdti.c
index 9b20ccd..adfbcbc 100644
--- a/drivers/misc/sti/sdti.c
+++ b/drivers/misc/sti/sdti.c
 <at>  <at>  -120,7 +120,7  <at>  <at>  static int __init omap_sdti_init(void)
 	i = sti_readl(SDTI_REVISION);
 	snprintf(buf, sizeof(buf), "OMAP SDTI support loaded (HW v%u.%u)\n",
 		(i >> 4) & 0x0f, i & 0x0f);
-	printk(KERN_INFO, "%s", buf);
+	printk(KERN_INFO "%s", buf);
 	omap_sti_channel_write_trace(strlen(buf), 0xc3, buf, 239);

 	return 0;
--

-- 
1.5.3.7

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Tony Lindgren | 1 Apr 2008 14:43

Re: [PATCH] I2C: Fix twl4030 timeouts on omap3430

* Tony Lindgren <tony <at> atomide.com> [080331 17:30]:
> * Tony Lindgren <tony <at> atomide.com> [080331 13:43]:
> > * Tony Lindgren <tony <at> atomide.com> [080328 10:41]:
> > > Hi all,
> > > 
> > > This helps with the annoying I2C timeouts. Does anybody have an idea
> > > why the twl4030 chip does not like doing multiple transfers in a row?
> > > 
> > > To me the only difference seems to be that clocks are idled between
> > > writing the twl4030 register and reading the register value.
> > 
> > I'll push this today with a REVISIT comment added.
> 
> Looks like this kills twl4030 interrupts, so I've reverted it.

After looking into this problem a bit more, looks like twl4030 reads
to anything in "POWER ID" (modules 0x10 and higher) will hang twl4030
eventually and I2C controller gets stuck in mode where STP never clears.

Repeated reads to "USB ID", "AUD ID" or "AUX ID" will not hang twl4030.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Peter 'p2' De Schrijver | 1 Apr 2008 15:00

Picon

Re: [PATCH] I2C: Fix twl4030 timeouts on omap3430

On Tue, Apr 01, 2008 at 03:43:56PM +0300, ext Tony Lindgren wrote:
> * Tony Lindgren <tony <at> atomide.com> [080331 17:30]:
> > * Tony Lindgren <tony <at> atomide.com> [080331 13:43]:
> > > * Tony Lindgren <tony <at> atomide.com> [080328 10:41]:
> > > > Hi all,
> > > > 
> > > > This helps with the annoying I2C timeouts. Does anybody have an idea
> > > > why the twl4030 chip does not like doing multiple transfers in a row?
> > > > 
> > > > To me the only difference seems to be that clocks are idled between
> > > > writing the twl4030 register and reading the register value.
> > > 
> > > I'll push this today with a REVISIT comment added.
> > 
> > Looks like this kills twl4030 interrupts, so I've reverted it.
> 
> After looking into this problem a bit more, looks like twl4030 reads
> to anything in "POWER ID" (modules 0x10 and higher) will hang twl4030
> eventually and I2C controller gets stuck in mode where STP never clears.
> 
> Repeated reads to "USB ID", "AUD ID" or "AUX ID" will not hang twl4030.
> 

I remember seeing something similar when doing the powerbutton code. 
Klaus Pedersen found out that leaving CFG_BOOT to its reset value solved
the problem. Unfortunately this breaks MADC and USB afaics, so it's not
a real solution. CFG_BOOT is programmed in power_companion_init().

Cheers,

(Continue reading)

Tony Lindgren | 1 Apr 2008 15:38

Re: [PATCH] I2C: Fix twl4030 timeouts on omap3430

* Peter 'p2' De Schrijver <peter.de-schrijver <at> nokia.com> [080401 16:01]:
> On Tue, Apr 01, 2008 at 03:43:56PM +0300, ext Tony Lindgren wrote:
> > * Tony Lindgren <tony <at> atomide.com> [080331 17:30]:
> > > * Tony Lindgren <tony <at> atomide.com> [080331 13:43]:
> > > > * Tony Lindgren <tony <at> atomide.com> [080328 10:41]:
> > > > > Hi all,
> > > > > 
> > > > > This helps with the annoying I2C timeouts. Does anybody have an idea
> > > > > why the twl4030 chip does not like doing multiple transfers in a row?
> > > > > 
> > > > > To me the only difference seems to be that clocks are idled between
> > > > > writing the twl4030 register and reading the register value.
> > > > 
> > > > I'll push this today with a REVISIT comment added.
> > > 
> > > Looks like this kills twl4030 interrupts, so I've reverted it.
> > 
> > After looking into this problem a bit more, looks like twl4030 reads
> > to anything in "POWER ID" (modules 0x10 and higher) will hang twl4030
> > eventually and I2C controller gets stuck in mode where STP never clears.
> > 
> > Repeated reads to "USB ID", "AUD ID" or "AUX ID" will not hang twl4030.
> > 
> 
> I remember seeing something similar when doing the powerbutton code. 
> Klaus Pedersen found out that leaving CFG_BOOT to its reset value solved
> the problem. Unfortunately this breaks MADC and USB afaics, so it's not
> a real solution. CFG_BOOT is programmed in power_companion_init().

Great, this helped a lot! Looks like power_companion_init() tries to get

(Continue reading)

Paul Walmsley | 1 Apr 2008 15:58

Re: [PATCH 1/2] ARM: OMAP: Add fuctional clock enabler for iva2

On Tue, 1 Apr 2008, Hiroshi DOYU wrote:

> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU <at> nokia.com>
> ---
>  arch/arm/mach-omap2/clock34xx.h       |    5 +++--
>  arch/arm/mach-omap2/cm-regbits-34xx.h |    1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)

Thanks Hiroshi,

Acked-by: Paul Walmsley <paul <at> pwsan.com>

- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Group

gmane.linux.ports.arm.omap.

Project Web Page

Texas Instrument's Omap Processor's Linux development mailing list

Search Archive

Page

1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 74

Articles in period: 735

April 2008

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane

Recent entries

[PATCH v2] ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin an (25 May 2013)
[PATCH] ARM: DTS: OMAP4: Panda/SDP: twl6030: fix mux for IRQ pin and m (24 May 2013)
[PATCH 1/1] ARM : omap3 : fix wrong container_of in clock36xx.c (24 May 2013)
[PATCH 0/1] ARM: omap3: Fix regression in dpll4 child clock frequency (24 May 2013)
[PATCH] ARM: dts: OMAP4. fix missing omap4-sdp-es23plus.dtb in dtbs ta (23 May 2013)
[PATCH v2 0/5] ARM: dts: OMAP2+: use preprocessor for device trees (23 May 2013)
[PATCH] OMAPDSS: Fix crash with DT boot (23 May 2013)
[PATCH] ARM: dts: omap3-devkit8000: fix NAND memory binding (23 May 2013)
[PATCH 0/2] ARM: dts: updates for omap3-overo (23 May 2013)
[RFC/RFT] ARM: dts: add minimal DT support for Nokia N950 & N9 (22 May 2013)
[PATCH 0/5] ARM: dts: OMAP2+: use preprocessor for device trees (22 May 2013)
[pandaboard] device tree booting fails (21 May 2013)
[PATCH] arm: omap: board-overo: reset GPIO for SMSC911x (21 May 2013)
the Usage of ROM and RAM of Cortex-M3 on OMAP4 (21 May 2013)
подарок создан удивлять (20 May 2013)
обратить действительность ощутимо бо� (20 May 2013)
[PATCH-V2] ARM: OMAP2+: AM33xx: Fix missing reset status data to GFX h (20 May 2013)
[PATCH-V2 0/2] ARM: OMAP AM33XX: clock data: Enable clkout2 output on (20 May 2013)
Технологии в поддержку (20 May 2013)
[GIT PULL] ARM: OMAP2+: hwmod/serial: fix DT case (20 May 2013)
OMAP baseline test results for v3.10-rc1 (20 May 2013)

Archives

362	May 2013
681	April 2013
1133	March 2013
873	February 2013
879	January 2013
648	December 2012
1469	November 2012
1566	October 2012
1512	September 2012
1132	August 2012
1237	July 2012
1701	June 2012
1611	May 2012
1235	April 2012
1487	March 2012
1389	February 2012
948	January 2012
1161	December 2011
862	November 2011
658	October 2011
1478	September 2011
1216	August 2011
1121	July 2011
1213	June 2011
1196	May 2011
785	April 2011
1839	March 2011
2005	February 2011
1656	January 2011
1592	December 2010
1452	November 2010
1440	October 2010
1616	September 2010
1229	August 2010
881	July 2010
1131	June 2010
1893	May 2010
1222	April 2010
1151	March 2010
1407	February 2010
1419	January 2010
1361	December 2009
1371	November 2009
1286	October 2009
744	September 2009
1478	August 2009
722	July 2009
1007	June 2009
1026	May 2009
690	April 2009
1253	March 2009
967	February 2009
1185	January 2009
665	December 2008
1117	November 2008
1208	October 2008
1589	September 2008
992	August 2008
437	July 2008
592	June 2008
572	May 2008
732	April 2008
350	March 2008
11	February 2008
22	January 2008
261	December 2007
468	November 2007
316	October 2007
247	September 2007
562	August 2007
175	July 2007
321	June 2007
564	May 2007
208	April 2007
294	March 2007
181	February 2007
248	January 2007
194	December 2006
316	November 2006
218	October 2006
151	September 2006
263	August 2006
113	July 2006
152	June 2006
356	May 2006
158	April 2006
297	March 2006
205	February 2006
276	January 2006
263	December 2005
133	November 2005

Design

Zawodny | Right Menu | Left Menu

Your Own Design

Paste the URL of your CSS below. Download CSS template