headers
Tony Lindgren | 1 Oct 2007 19:35
Gravatar

Re: [PATCH 0/14] [TAKE 2] Update OMAP defconfigs

* Felipe Balbi <felipe.lima <at> indt.org.br> [070918 10:57]:
> Previous patch series was a little messy due to make oldconfig
> mis-behavior.
> 
> This series looks a lot cleaner.
> 
> Dirk, Tony, any comments?

Pushing this series today.

Tony
Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Oct 2007 19:37
Gravatar

Re: [RFC] [PATCH] MMC OMAP: add OMAP_GPIO_SWITCH dependency for N800

* Anderson Briglia <anderson.briglia <at> indt.org.br> [070918 10:12]:
> OMAP_GPIO_SWITCH is needed by MMC host on N800. If this option is
> not selected, compilation fails.
> 
> Signed-off-by: Anderson Briglia <anderson.briglia <at> indt.org.br>
> ---
>  drivers/mmc/host/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index e23082f..671b9a4 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
>  <at>  <at>  -39,6 +39,7  <at>  <at>  config MMC_OMAP
>  	tristate "TI OMAP Multimedia Card Interface support"
>  	depends on ARCH_OMAP
>  	select TPS65010 if MACH_OMAP_H2
> +	select OMAP_GPIO_SWITCH if MACH_NOKIA_N800
>  	help
>  	  This selects the TI OMAP Multimedia card Interface.
>  	  If you have an OMAP board with a Multimedia Card slot,

Pushing today.

Tony
Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Oct 2007 19:43
Gravatar

Re: [PATCH] ARM: OMAP: DMA fix bug in omap_get_dma_dst_pos

* Gadiyar, Anand <gadiyar <at> ti.com> [070918 22:53]:
> From: Anand Gadiyar <gadiyar <at> ti.com>
> 
> omap_get_dma_dst_pos() should return the current destination address.
> The CDSA register contains the destination start address.
> CDAC register should be used instead.
> 
> Signed-off-by: Anand Gadiyar <gadiyar <at> ti.com>
> ---
> 
>  linux-omap/arch/arm/plat-omap/dma.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> ===================================================================
> --- linux-omap.orig/arch/arm/plat-omap/dma.c	2007-09-18
> 16:17:21.000000000 +0530
> +++ linux-omap/arch/arm/plat-omap/dma.c	2007-09-18 16:21:59.000000000
> +0530
>  <at>  <at>  -776,7 +776,7  <at>  <at> 
>  				       (OMAP1_DMA_CDSA_U_REG(lch) <<
> 16));
>  
>  	if (cpu_is_omap24xx())
> -		offset = OMAP2_DMA_CDSA_REG(lch);
> +		offset = OMAP2_DMA_CDAC_REG(lch);
>  
>  	return offset;
>  }

Thanks, pushing today. Can you please check your mail program settings
to avoid wrapped patches next time?
(Continue reading)

Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Oct 2007 19:44
Gravatar

Re: [PATCH] OMAP: lcd_mipid: Fix OOM error reporting

* Timo Savola <tsavola <at> movial.fi> [070920 04:32]:
> Do not try access a memory region when its allocation failed.
> 
> Signed-off-by: Timo Savola <tsavola <at> movial.fi>
> ---
>  drivers/video/omap/lcd_mipid.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
> index 922e322..ef071a6 100644
> --- a/drivers/video/omap/lcd_mipid.c
> +++ b/drivers/video/omap/lcd_mipid.c
>  <at>  <at>  -561,7 +561,7  <at>  <at>  static int mipid_spi_probe(struct spi_device *spi)
>  
>  	md = kzalloc(sizeof(*md), GFP_KERNEL);
>  	if (md == NULL) {
> -		dev_err(&md->spi->dev, "out of memory\n");
> +		dev_err(&spi->dev, "out of memory\n");
>  		return -ENOMEM;
>  	}
>  

Thanks, pushing today.

Tony
Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Oct 2007 20:05
Gravatar

Re: [PATCH] ARM: OMAP: Set default OMAP2_CTRL_BASE for OMAP1

* Dirk Behme <dirk.behme <at> googlemail.com> [070918 10:33]:
>
> In case no OMAP2_CTRL_BASE is set, set default one to fix compilation
> errors e.g. for OMAP1.
>
> Signed-off-by: Dirk Behme <dirk.behme <at> gmail.com>

> Index: linux-osk/include/asm-arm/arch-omap/omap24xx.h
> ===================================================================
> --- linux-osk.orig/include/asm-arm/arch-omap/omap24xx.h
> +++ linux-osk/include/asm-arm/arch-omap/omap24xx.h
>  <at>  <at>  -103,6 +103,11  <at>  <at> 
>  
>  #endif
>  
> +#if !defined(OMAP2_CTRL_BASE)
> +/* If no one of the above configs is selected, use default */
> +#define OMAP2_CTRL_BASE		L4_24XX_BASE
> +#endif
> +
>  /* Control module */
>  #define OMAP2_CONTROL_DEVCONF0	(OMAP2_CTRL_BASE + 0x274)
>  #define OMAP2_CONTROL_DEVCONF1	(OMAP2_CTRL_BASE + 0x2e8)

Just for reference, this should not be needed any longer AFAIK.

Tony
Permalink | Reply | 0 comments |
headers
Tony Lindgren | 1 Oct 2007 20:06
Gravatar

Re: [PATCH RFC] arch/arm/plat-omap/devices.c

* Dirk Behme <dirk.behme <at> googlemail.com> [070919 08:50]:
> Luís Cargnini wrote:
>> --- linux-omap-2.6/arch/arm/plat-omap/devices.c 2007-08-28 01:01:
>> 50.502065325 -0300
>> +++ linux-omap-2.6.23-instramed/arch/arm/plat-omap/devices.c    2007-09-18
>> 15:05:44.748685528 -0300
> ...
>
> Should this be a fix for your issues [1]?
>
> If yes, why do you think [2] isn't sufficent? Did you try [2]?
>
> [3] introduced usage of OMAP2_CTRL_BASE undefined on OMAP1. So anything 
> like [2] to fix compilation issues like [1] should be sufficent to fix [1]. 
> [2] works at least for me selecting MMC on OSK.

Luis, please repost your patch if something still needs to be patched.

Tony

> [1] 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-September/011373.html
>
> [2] 
> http://linux.omap.com/pipermail/linux-omap-open-source/2007-September/011393.html
>
> [3] 
> http://source.mvista.com/git/?p=linux-omap-2.6.git;a=commitdiff;h=ad1794683d378d08467ea9b340628994ff3e7edd
> _______________________________________________
> Linux-omap-open-source mailing list
(Continue reading)

Permalink | Reply | 2 comments |
headers
Tony Lindgren | 1 Oct 2007 20:53
Gravatar

Re: [PATCH 01/01] ARM: OMAP: Makes DSP compiles again for 1510 boards

* Carlos Aguiar <carlos.aguiar <at> indt.org.br> [070924 08:51]:
> From: Carlos Eduardo Aguiar <carlos.aguiar <at> indt.org.br>
> 
> This simple patch makes DSP compiles again for 1510 boards.
> 
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar <at> indt.org.br>
> Signed-off-by: Eduardo Valentin <eduardo.valentin <at> indt.org.br>
> ---
>  include/asm-arm/arch-omap/omap1510.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/asm-arm/arch-omap/omap1510.h b/include/asm-arm/arch-omap/omap1510.h
> index c575d35..7b5114b 100644
> --- a/include/asm-arm/arch-omap/omap1510.h
> +++ b/include/asm-arm/arch-omap/omap1510.h
>  <at>  <at>  -44,5 +44,7  <at>  <at> 
>  #define OMAP1510_DSPREG_SIZE	SZ_128K
>  #define OMAP1510_DSPREG_START	0xE1000000
>  
> +#define OMAP1510_DSP_MMU_BASE	(0xfffed200)
> +
>  #endif /*  __ASM_ARCH_OMAP15XX_H */
>  

Pushing today.

Tony
Permalink | Reply | 0 comments |
headers
Filipe Braz | 2 Oct 2007 00:06
Picon

ALSA and TWL4030 in full duplex mode

Hi,

I have been having trouble running the ALSA driver for the TWL4030 audio
codec in Full duplex mode, using the OMAP 2430SDP. The driver used is the
ALSA OMAP2430SDP driver (or the TWL4030 driver in 2.6.14 v3).

It works fine in half-duplex mode but not in full duplex mode. I tried this
with the following ti kernels:

 - linux-2.6.14-omap2-v3.tgz
 - linux-2.6.14-omap2-v4.tgz

When opening the device for capture (after successfully opening for
playback), the driver prints the following kernel error message:

"Request for MCBSP Failed[-22]"

This error occurs in omap2-audio-twl4030.c and is caused by attempting to
request the McBSP interface when it is already reserved.

I also notice that the there is an additional driver: the OMAP2430DASF. This
driver seems to use a message queue but its unclear on how it is supposed to
work and if it supports full duplex mode. When attempting to play sound
using it, it blocks the application and eventually fails with write error.

Any information on these would be appreciated

Thanks,
Filipe
(Continue reading)

Permalink | Reply | 1 comment |
headers
Luís Cargnini | 2 Oct 2007 01:20
Picon
Gravatar

Re: [PATCH RFC] arch/arm/plat-omap/devices.c

Tony please I submitted a patch for mcbsp.{c,h}, modifying it to support
shared IRQ on McBSP ports, it are working for me, and for my device driver,
I'm testing it yet it take me sometime. But the device diver isn't a major
question, only the interruption modification on mcbsp file as I said.

On 10/1/07, Tony Lindgren <tony <at> atomide.com> wrote:
>
> * Dirk Behme <dirk.behme <at> googlemail.com> [070919 08:50]:
> > Luís Cargnini wrote:
> >> --- linux-omap-2.6/arch/arm/plat-omap/devices.c 2007-08-28 01:01:
> >> 50.502065325 -0300
> >> +++ linux-omap-2.6.23-instramed
> /arch/arm/plat-omap/devices.c    2007-09-18
> >> 15:05:44.748685528 -0300
> > ...
> >
> > Should this be a fix for your issues [1]?
> >
> > If yes, why do you think [2] isn't sufficent? Did you try [2]?
> >
> > [3] introduced usage of OMAP2_CTRL_BASE undefined on OMAP1. So anything
> > like [2] to fix compilation issues like [1] should be sufficent to fix
> [1].
> > [2] works at least for me selecting MMC on OSK.
>
> Luis, please repost your patch if something still needs to be patched.
>
> Tony
>
>
(Continue reading)

Permalink | Reply | 1 comment |
headers
Tony Lindgren | 2 Oct 2007 02:01
Gravatar

Re: [PATCH RFC] arch/arm/plat-omap/devices.c

* Luís Cargnini <lvcargnini <at> gmail.com> [071001 16:20]:
> Tony please I submitted a patch for mcbsp.{c,h}, modifying it to support
> shared IRQ on McBSP ports, it are working for me, and for my device driver,
> I'm testing it yet it take me sometime. But the device diver isn't a major
> question, only the interruption modification on mcbsp file as I said.

Yeah at least the header patch looks OK.

Regards,

Tony
Permalink | Reply | 0 comments |

Gmane